Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-06-07 Thread Tejun Heo
On Tue, Jun 07, 2022 at 01:39:01PM -0400, Alex Deucher wrote: > On Tue, Jun 7, 2022 at 1:14 PM Tejun Heo wrote: > > > > On Sat, May 21, 2022 at 12:04:00AM -0400, Andrey Grodzovsky wrote: > > > From 78df30cc97f10c885f5159a293e6afe2348aa60c Mon Sep 17 00:00:00 2001 > > > From: Andrey Grodzovsky > >

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-06-07 Thread Alex Deucher
On Tue, Jun 7, 2022 at 1:14 PM Tejun Heo wrote: > > On Sat, May 21, 2022 at 12:04:00AM -0400, Andrey Grodzovsky wrote: > > From 78df30cc97f10c885f5159a293e6afe2348aa60c Mon Sep 17 00:00:00 2001 > > From: Andrey Grodzovsky > > Date: Thu, 19 May 2022 09:47:28 -0400 > > Subject: Revert "workqueue: r

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-06-07 Thread Tejun Heo
On Sat, May 21, 2022 at 12:04:00AM -0400, Andrey Grodzovsky wrote: > From 78df30cc97f10c885f5159a293e6afe2348aa60c Mon Sep 17 00:00:00 2001 > From: Andrey Grodzovsky > Date: Thu, 19 May 2022 09:47:28 -0400 > Subject: Revert "workqueue: remove unused cancel_work()" > > This reverts commit 6417250d

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-20 Thread Andrey Grodzovsky
On 2022-05-20 03:52, Tejun Heo wrote: On Fri, May 20, 2022 at 08:22:39AM +0200, Christian König wrote: Am 20.05.22 um 02:47 schrieb Lai Jiangshan: On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky wrote: See this patch-set https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2F

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-20 Thread Tejun Heo
On Fri, May 20, 2022 at 08:22:39AM +0200, Christian König wrote: > Am 20.05.22 um 02:47 schrieb Lai Jiangshan: > > On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky > > wrote: > > > See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, > > > specifically patch > > > 'drm/amdgpu

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Christian König
Am 20.05.22 um 02:47 schrieb Lai Jiangshan: On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky wrote: See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, specifically patch 'drm/amdgpu: Switch to delayed work from work_struct. I will just reiterate here - We need to be ab

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Lai Jiangshan
On Thu, May 19, 2022 at 11:04 PM Andrey Grodzovsky wrote: > > See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, > specifically patch > 'drm/amdgpu: Switch to delayed work from work_struct. > > I will just reiterate here - > > We need to be able to do non blocking cancel pend

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Andrey Grodzovsky
See this patch-set https://www.spinics.net/lists/amd-gfx/msg78514.html, specifically patch 'drm/amdgpu: Switch to delayed work from work_struct. I will just reiterate here - We need to be able to do non blocking cancel pending reset works from within GPU reset. Currently kernel API allows this

Re: [PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Lai Jiangshan
On Thu, May 19, 2022 at 9:57 PM Andrey Grodzovsky wrote: > > This reverts commit 6417250d3f894e66a68ba1cd93676143f2376a6f > and exports the function. > > We need this funtion in amdgpu driver to fix a bug. Hello, Could you specify the reason why it is needed in amdgpu driver rather than "fix a b

[PATCH] Revert "workqueue: remove unused cancel_work()"

2022-05-19 Thread Andrey Grodzovsky
This reverts commit 6417250d3f894e66a68ba1cd93676143f2376a6f and exports the function. We need this funtion in amdgpu driver to fix a bug. Signed-off-by: Andrey Grodzovsky --- include/linux/workqueue.h | 1 + kernel/workqueue.c| 9 + 2 files changed, 10 insertions(+) diff --gi