RE: [PATCH 4/9] drm/amdgpu: Add a bitmask in amdgpu_ctx_mgr

König > Sent: Thursday, December 6, 2018 8:34 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 4/9] drm/amdgpu: Add a bitmask in amdgpu_ctx_mgr > > Am 06.12.18 um 13:14 schrieb Rex Zhu: > > used to manager the reserverd vm space. > > Wh

RE: [PATCH 3/9] drm/amdgpu: Use dynamical reserved vm size

> -Original Message- > From: Christian König > Sent: Thursday, December 6, 2018 8:33 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/9] drm/amdgpu: Use dynamical reserved vm size > > Am 06.12.18 um 13:14 schrieb Rex Zhu: > > Use

Re: [PATCH] drm/amd/powerplay: rv dal-pplib interface refactor powerplay part

: Thursday, December 6, 2018 2:03 AM To: amd-gfx@lists.freedesktop.org; Zhu, Rex; Deucher, Alexander Subject: RE: [PATCH] drm/amd/powerplay: rv dal-pplib interface refactor powerplay part Hello, Alex, Rex, Would you please help review the change? Thanks, Hersen [WHY] clarify dal input

Re: [PATCH] drm/amd/powerplay: improve OD code robustness

Please add Signed-off-by in the patch commit. Except that, Patch is Reviewed-by: Rex Zhu Best Regards Rex From: Yin, Tianci (Rico) Sent: Tuesday, December 4, 2018 5:01 PM To: Zhu, Rex; Zhang, Jerry; Li, Pauline; Teng, Rui; Liang, Prike; Zhu, Changfeng

Re: [PATCH -next] drm/amdgpu: Fix return value check in amdgpu_allocate_static_csa()

y: Alex Deucher From: Wei Yongjun Sent: Tuesday, December 4, 2018 2:39 PM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); airl...@linux.ie; Zhu, Rex; Liu, Monk Cc: Wei Yongjun; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop

Re: [PATCH] drm: should break if already get the best size

Tested-by: Rex Zhu Without this patch, if we search node via rb tree. For example: we insert different node with rand size, size range in (1-). the key in root node is 5587. if we try to find the node with key equal to 5587 or 7381, Loop: node->key is 5587 node->key is 2273 nod

RE: [PATCH] drm/amdgpu: refactor smu8_send_msg_to_smc and WARN_ON time out

Patch is Reviewed-by: Rex Zhu Best Regards Rex > -Original Message- > From: amd-gfx On Behalf Of S, > Shirish > Sent: Monday, November 12, 2018 10:48 PM > To: Zhu, Rex ; Deucher, Alexander > > Cc: Daniel Kurtz ; amd-gfx@lists.freedesktop.org; S, > Shirish

RE: [PATCH] drm/amdgpu: log smu version

Patch is Reviewed-by: Rex Zhu Best Regards Rex > -Original Message- > From: amd-gfx On Behalf Of S, > Shirish > Sent: Monday, November 12, 2018 2:50 PM > To: Zhu, Rex ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PA

Re: [PATCH] drm/amdgpu: Fix CSA buffer alloc failed on Vega

Got it . Thanks. Best Regards Rex From: Christian König Sent: Monday, November 12, 2018 6:42 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix CSA buffer alloc failed on Vega Am 12.11.18 um 11:33 schrieb Rex Zhu

Re: [PATCH] drm/amdgpu: fix VM leaf walking

That sounds reasonable. Thanks. Best Regards Rex From: Christian König Sent: Friday, October 26, 2018 3:34 PM To: Zhu, Rex; Deucher, Alexander; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM leaf walking Yeah, that came to my mind as

RE: [PATCH] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

Patch is Acked-by: Rex Zhu Regards Rex > -Original Message- > From: S, Shirish > Sent: Friday, October 26, 2018 12:28 AM > To: Zhu, Rex ; Agrawal, Akshu > ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PATCH] Revert &q

RE: [PATCH] drm/amdgpu: fix reporting of failed msg sent to SMU

Patch is Reviewed-by: Rex Zhu Rex > -Original Message- > From: amd-gfx On Behalf Of S, > Shirish > Sent: Friday, October 26, 2018 6:37 AM > To: Deucher, Alexander ; Zhu, Rex > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish > Subject: [PATCH] drm/amdgpu: fix

RE: [PATCH] drm/amdgpu: fix VM leaf walking

-gfx On Behalf Of Zhu, Rex Sent: Thursday, October 25, 2018 11:34 PM To: Deucher, Alexander ; Christian König ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: fix VM leaf walking Patch is Tested-by: Rex Zhu rex@amd.com<mailto:rex@amd.com> Regards Rex From: a

RE: [PATCH] drm/amdgpu: fix VM leaf walking

Patch is Tested-by: Rex Zhu rex@amd.com<mailto:rex@amd.com> Regards Rex From: amd-gfx On Behalf Of Deucher, Alexander Sent: Thursday, October 25, 2018 11:08 PM To: Christian König ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix VM leaf walking Acked-by

Re: [PATCH 2/3] drm/amd/powerplay: added hwmon interfaces for setting max/min fan speed

From: Quan, Evan Sent: Wednesday, October 24, 2018 4:47 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/3] drm/amd/powerplay: added hwmon interfaces for setting max/min fan speed This can be performed under auto mode. The settings are always effective unless user

Re: [PATCH 2/2] drm/amd/powerplay: commonize the API for retrieving current clocks

Series is: Reviewed-by: Rex Zhu Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Wednesday, October 24, 2018 4:09 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/2] drm/amd/powerplay: commonize the API for retrieving curren

Re: [PATCH 3/3] drm/amd/powerplay: support hwmon max/min fan speed setting on Vega20

- percent = current_rpm * 100 / pp_table->FanMaximumRpm; + percent = (current_rpm * 100) / + hwmgr->thermal_controller.fanInfo.ulMaxRPM; Better check hwmgr->thermal_controller.fanInfo.ulMaxRPM not equal to 0. Best Regards Rex From: am

Re: [PATCH 2/3] drm/amd/powerplay: added hwmon interfaces for setting max/min fan speed

One question: how to exit the max/min fan speed and return to auto mode? Best Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Wednesday, October 24, 2018 4:11 PM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan Subject: [PATCH 2/3] drm/amd/powerplay:

Re: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet

Thanks David. I think we can use ring->idx. Best Regards Rex From: Zhou, David(ChunMing) Sent: Wednesday, October 24, 2018 2:55 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH v2] drm/amdgpu: Patch csa mc address in IB pac

Re: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet

Sorry, Please ignore this patch. Best Regards Rex From: Zhou, David(ChunMing) Sent: Wednesday, October 24, 2018 2:55 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet

Re: [PATCH] drm/amdgpu: Modify the argument of emit_ib interface

Ok, I will refine the patch as you suggested. Thanks. Best Regards Rex From: amd-gfx on behalf of Koenig, Christian Sent: Tuesday, October 23, 2018 9:05 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Modify the argument

Re: [PATCH] drm/amdgpu: Modify the argument of emit_ib interface

rds Rex From: amd-gfx on behalf of Koenig, Christian Sent: Tuesday, October 23, 2018 8:47 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Modify the argument of emit_ib interface Am 23.10.18 um 14:43 schrieb Zhu, Rex: >Maybe indeed provide the CSA address a

Re: [PATCH] drm/amdgpu: Modify the argument of emit_ib interface

CSA address as parameter, we need to check which ring it is. The csa address is different between sdma/gfx/compute. Best Regards Rex From: Christian König Sent: Tuesday, October 23, 2018 8:09 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PAT

Re: [PATCH] drm/amdgpu: Fix amdgpu_vm_alloc_pts failed

Hi Christian, You can reproduce this issue by allocate CSA buffer in baremetal and map them to reserved VM address. Please see the attached patch. Best Regards Rex From: Christian König Sent: Tuesday, October 23, 2018 5:01 PM To: Zhu, Rex; Zhang, Jerry

Re: [PATCH] drm/amdgpu: Fix amdgpu_vm_alloc_pts failed

gpu: add amdgpu_vm_entries_mask v2 We can't get the mask for the root directory from the number of entries. So add a new function to avoid that problem. Best Regards Rex From: amd-gfx on behalf of Zhang, Jerry(Junwei) Sent: Tuesday, October 23, 2018 1:12 PM To:

Re: [PATCH] drm/amdgpu: Fix amdgpu_vm_alloc_pts failed

Thanks Jerry. Good suggestion. Use the right mask for PD instand of hardcode. so don't need to revert the whole patch. Best Regards Rex From: Zhang, Jerry Sent: Tuesday, October 23, 2018 10:02 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org; K

RE: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

> -Original Message- > From: Christian König > Sent: Wednesday, October 17, 2018 3:11 AM > To: Zhu, Rex ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if > they were disabled by user >

RE: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

> -Original Message- > From: Koenig, Christian > Sent: Wednesday, October 17, 2018 2:59 AM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if > they were disabled by user > > Am 16.10.2018 u

RE: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

> -Original Message- > From: Christian König > Sent: Wednesday, October 17, 2018 2:31 AM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH v2] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if > they were disabled by user > > Am 16.10.2018

RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

The code base is different. And do you set ip_block_mask = 0xeff to diable vce? Best Regards Rex From: S, Shirish Sent: Wednesday, October 17, 2018 1:25 AM To: Zhu, Rex ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they

RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user

Do you test based on drm-next branch? Best Regards Rex From: S, Shirish Sent: Wednesday, October 17, 2018 1:12 AM To: Deucher, Alexander ; Zhu, Rex ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Poweroff uvd/vce/vcn/acp block if they were disabled by user This patch fails on

RE: [PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov vf

> -Original Message- > From: amd-gfx On Behalf Of > Koenig, Christian > Sent: Friday, October 12, 2018 3:25 PM > To: Huang, Ray ; Kuehling, Felix > ; Min, Frank ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amdgpu: skip vm entries checking while in sriov > vf > > Am

Re: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg

Ok. BTW, Maybe we can remove the module parameter amdgpu_fw_load_type suppor . It is only used for bring up/debug. Best Regards Rex From: Deucher, Alexander Sent: Wednesday, October 10, 2018 3:31 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re

RE: [PATCH 3/5] drm/amdgpu: Extract the function of fw loading out of powerplay

> -Original Message- > From: Alex Deucher > Sent: Wednesday, October 10, 2018 3:28 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 3/5] drm/amdgpu: Extract the function of fw loading out > of powerplay > > On Tue, Oct 9, 2018 at 8:45 AM Rex Zhu

RE: [PATCH 4/5] drm/amdgpu: Fix unnecessary warning in dmesg

> -Original Message- > From: Michel Dänzer > Sent: Tuesday, October 9, 2018 9:19 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 4/5] drm/amdgpu: Fix unnecessary warning in dmesg > > On 2018-10-09 2:43 p.m., Rex Zhu wrote: >

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

- > From: Christian König > Sent: Tuesday, October 9, 2018 2:22 AM > To: Zhu, Rex ; Koenig, Christian > ; Deucher, Alexander > ; Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > Am 08.10.2018 um

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

> -Original Message- > From: Koenig, Christian > Sent: Tuesday, October 9, 2018 2:03 AM > To: Zhu, Rex ; Deucher, Alexander > ; Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > Am 0

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

> -Original Message- > From: Christian König > Sent: Tuesday, October 9, 2018 1:32 AM > To: Zhu, Rex ; Deucher, Alexander > ; Alex Deucher > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > Am 0

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

> -Original Message- > From: Deucher, Alexander > Sent: Tuesday, October 9, 2018 12:21 AM > To: Zhu, Rex ; Alex Deucher > Cc: amd-gfx list > Subject: RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > > -Original Message--

RE: [PATCH 4/5] drm/amdgpu: Add fw load in gfx_v8 and sdma_v3

Thanks. I will fix this error in a following patch. Best Regards Rex > -Original Message- > From: Alex Deucher > Sent: Thursday, October 4, 2018 11:33 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 4/5] drm/amdgpu: Add fw load in gfx_v8 and sdma_v3 >

RE: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when suspend

> -Original Message- > From: Alex Deucher > Sent: Thursday, October 4, 2018 11:35 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 1/5] drm/amdgpu: Don't reallocate ucode bo when > suspend > > On Wed, Oct 3, 2018 at 7:11 AM Rex Zhu wrote:

RE: [PATCH 4/5] drm/amdgpu: Add fan RPM setting via sysfs

I may misunderstood. If for read, we should not change the mode to manual. I will revert the change for fan1_input. Best Regards Rex > -Original Message- > From: Russell, Kent > Sent: Friday, October 5, 2018 11:55 PM > To: Zhu, Rex ; Deucher, Alexander > ; amd-gfx@lists.

RE: [PATCH 4/5] drm/amdgpu: Add fan RPM setting via sysfs

control mode to Manual. Disable, we set the fan control mode to Auto. Regards Rex > -Original Message- > From: Russell, Kent > Sent: Friday, October 5, 2018 10:40 PM > To: Zhu, Rex ; Deucher, Alexander > ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 4/5] drm/amdgpu: A

RE: [PATCH 1/6] drm/amdgpu: Remove FW_LOAD_DIRECT type support on VI

I will add some warnings in dmesg. Thanks Best Regards Rex > -Original Message- > From: Quan, Evan > Sent: Sunday, September 30, 2018 10:30 AM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: RE: [PATCH 1/6] drm/amdgpu: Remove FW_LOAD_DIRECT

RE: [PATCH 3/4] drm/amdgpu: Add fw load in gfx_v8 and sdma_v3.

Yes. So the hw ip smu/gfx/sdma have no dependence. We can initialize gfx/sdma/smu or sdma/gfx/smu. In powerplay, if the fw has been loaded successfully, we will skip the fw loading. Rex > -Original Message- > From: Quan, Evan > Sent: Sunday, September 30, 2018 12:19 PM >

RE: [PATCH 3/6] drm/amdgpu: Fix cg/pg unexpected disabled when hw init failed

> -Original Message- > From: Quan, Evan > Sent: Sunday, September 30, 2018 11:03 AM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: RE: [PATCH 3/6] drm/amdgpu: Fix cg/pg unexpected disabled when > hw init failed > > Comment inline &

RE: [PATCH 4/5] drm/amdgpu: Add fan RPM setting via sysfs

> -Original Message- > From: Deucher, Alexander > Sent: Monday, October 1, 2018 9:16 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex > Subject: RE: [PATCH 4/5] drm/amdgpu: Add fan RPM setting via sysfs > > > -Original Message- >

Re: [PATCH v2] drm/amd/pp: Export load_firmware interface

Sorry, Please ignore this patch. Best Regards Rex From: amd-gfx on behalf of Rex Zhu Sent: Thursday, September 27, 2018 9:55 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH v2] drm/amd/pp: Export load_firmware interface Export this

RE: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

> -Original Message- > From: Alex Deucher > Sent: Wednesday, September 26, 2018 11:39 PM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface > > On Wed, Sep 26, 2018 at 11:21 AM Zhu, Rex wrote: > &g

RE: [PATCH 6/7] drm/amd/pp: Export load_firmware interface

> -Original Message- > From: Alex Deucher > Sent: Wednesday, September 26, 2018 10:15 PM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 6/7] drm/amd/pp: Export load_firmware interface > > On Wed, Sep 26, 2018 at 8:53 AM Rex Zhu wrote: > > >

Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c

Ok. I will remove the code. Best Regards Rex From: Christian König Sent: Wednesday, September 26, 2018 8:45 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c Am 26.09.2018 um 14:41 schrieb Rex Zhu

RE: [PATCH v2] drm/amdgpu:No action when VCN PG state is unchanged

> -Original Message- > From: amd-gfx On Behalf Of > James Zhu > Sent: Friday, September 21, 2018 10:22 PM > To: Zhu, Rex ; Koenig, Christian > ; Zhu, James ; Alex > Deucher > Cc: James Zhu ; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: [PATCH

RE: [PATCH 4/4] drm/amdgpu: Change the gfx/sdma init/fini sequence

> -Original Message- > From: Vishwakarma, Pratik > Sent: Friday, September 21, 2018 12:34 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org; Zhou, > Hang > Subject: Re: [PATCH 4/4] drm/amdgpu: Change the gfx/sdma init/fini > sequence > > On 9/20/

RE: [PATCH 9/9] drm/amdgpu: print smc feature mask in debugfs amdgpu_pm_info

Series is: Reviewed-by: Rex Zhu Regards Rex > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, September 21, 2018 11:55 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 9/9] drm/amdgpu: print smc feature mask in debugfs >

RE: [PATCH v2] drm/amdgpu:No action when VCN PG state is unchanged

In my understand, when dpg mode enabled, we don't need to power up/down VCN via SMU and Also don't need to set vcn power gate/ungate state. Just need to enable the dpg mode. If not true, please correct me. Best Regards Rex > -Original Message- > From: amd-gfx On Behalf Of > Chr

RE: [PATCH 1/3] drm/amd/pp: Avoid divide-by-zero in smu7_fan_ctrl_set_fan_speed_rpm

if user want to change back to auto fan control mode, they need to echo 2 to pwm_enable. Best Regards Rex From: Deucher, Alexander Sent: Thursday, September 20, 2018 9:52 PM To: Zhu, Rex ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/3] drm/amd/pp: Avoid divide-by-zero in smu7_fan_ctrl_se

Re: [PATCH] drm/amd/powerplay: enable fan RPM and pwm settings

Please see in line. Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Thursday, September 20, 2018 10:26 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; Quan, Evan Subject: [PATCH] drm/amd/powerplay: enable fan RPM and pwm settings Manual

Re: [PATCH] drm/amdgpu: add new polaris pci id

Reviewed-by: Rex Zhu Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, September 20, 2018 11:05 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander; sta...@vger.kernel.org Subject: [PATCH] drm/amdgpu: add new polaris pci id Add new

RE: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer

Thanks. So we still need to check the bo valid before use for the case that if we don't know the size when allocate. Best Regards Rex > -Original Message- > From: Koenig, Christian > Sent: Tuesday, September 18, 2018 5:34 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.

RE: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer

> -Original Message- > From: Koenig, Christian > Sent: Tuesday, September 18, 2018 4:41 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer > > Am 18.09.2018 um 10:16 schrieb Zhu, Rex: >

RE: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer

> -Original Message- > From: Christian König > Sent: Tuesday, September 18, 2018 3:14 PM > To: Zhu, Rex ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer > > Am 18.09.2018 um 08:16 schrieb Zhu, Rex: >

RE: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer

> -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Tuesday, September 18, 2018 2:07 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: don't try to unreserve NULL pointer > > Don't try to unreserve a BO we doesn't allocated. > > Fixes: 07012f

RE: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes

018 9:31 PM To: Zhu, Rex ; Deucher, Alexander ; Wentland, Harry Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes On Linux, the clocks are already set by the time that function call is reached. amdgpu_pm_co

RE: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes

+Harry and David. Best Regards Rex From: Deucher, Alexander Sent: Friday, September 14, 2018 9:40 PM To: Zhu, Rex ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes Acked-by: Alex Deucher mailto:alexander.deuc

RE: [PATCH] drm/amd/powerplay: expose vega20 OD features

For mclk, Smu just let us change the max clock in dpm3(high level). And the mclk in other dpm levels can not be changed. Any concerns? Best Regards Rex From: Deucher, Alexander Sent: Wednesday, August 29, 2018 12:03 AM To: Quan, Evan ; Alex Deucher Cc: Zhu, Rex ; amd-gfx list ; Xu, Fe

RE: [PATCH] drm/amd/powerplay: expose vega20 OD features

> -Original Message- > From: Alex Deucher > Sent: Friday, August 24, 2018 11:48 PM > To: Quan, Evan > Cc: amd-gfx list ; Xu, Feifei > ; Kuehling, Felix ; Deucher, > Alexander ; Zhu, Rex ; > Zhang, Hawking > Subject: Re: [PATCH] drm/amd/powerplay: expose veg

RE: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini

> -Original Message- > From: Michel Dänzer > Sent: Friday, August 24, 2018 5:31 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 3/3] drm/amdgpu: Power on uvd block when hw_fini > > On 2018-08-24 10:50 a.m., Rex Zhu wrote: > >

RE: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3

> -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Thursday, August 23, 2018 7:24 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/4] drm/amdgpu: add ring soft recovery v3 > > Instead of hammering hard on the GPU try a soft recovery first. > > v2: reo

RE: [PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini

> -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Thursday, August 23, 2018 6:58 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/3] drm/amdgpu: Power up uvd block when hw_fini > > On 2018-08-23 11:24 a.

RE: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on Kaveri/Mullins

> -Original Message- > From: Michel Dänzer > Sent: Thursday, August 23, 2018 6:59 PM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix > > Subject: Re: [PATCH 1/3] drm/amdgpu: Fix vce initialize failed on > Kaveri/Mullins > > On 2018-0

RE: [PATCH] drm/amdgpu: Remove duplicated power source update

Hi Alex, We get initial state in amdgpu_device_init. Best Regards Rex > -Original Message- > From: Alex Deucher > Sent: Thursday, August 23, 2018 8:37 PM > To: Zhu, Rex > Cc: amd-gfx list ; Wu, Hersen > > Subject: Re: [PATCH] drm/amdgpu: Remove duplicate

RE: Regression: Kaveri VCE ring test fails

Hi Michel, Thanks. I know the root cause, and will fix this issue today. Best Regards Rex > -Original Message- > From: Michel Dänzer > Sent: Thursday, August 23, 2018 12:31 AM > To: Zhu, Rex > Cc: amd-gfx@lists.freedesktop.org > Subject: Regression: Kaveri V

RE: [PATCH 2/2] drm/amdgpu: Refine gfx_v9_0_kcq_disable function

> -Original Message- > From: Alex Deucher > Sent: Saturday, August 18, 2018 1:26 AM > To: Zhu, Rex > Cc: amd-gfx list > Subject: Re: [PATCH 2/2] drm/amdgpu: Refine gfx_v9_0_kcq_disable function > > On Fri, Aug 17, 2018 at 5:35 AM Rex Zhu wrote: > >

RE: [PATCH v2 1/2] drm/amdgpu: Remove the sriov checking and add firmware checking

I have tested the patches on Rv/Vega10/Vega12. Series is: Reviewed-and-Tested-by: Rex Zhu Best Regards Rex > -Original Message- > From: amd-gfx On Behalf Of > Christian König > Sent: Friday, August 17, 2018 3:23 PM > To: Deng, Emily ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

> -Original Message- > From: Zhu, Rex > Sent: Thursday, August 16, 2018 1:41 PM > To: 'Alex Deucher' > Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org> > Subject: RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalid

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

> -Original Message- > From: Alex Deucher > Sent: Wednesday, August 15, 2018 10:14 PM > To: Zhu, Rex > Cc: Deng, Emily ; amd-gfx list g...@lists.freedesktop.org> > Subject: Re: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalidate tlb >

RE: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

> -Original Message- > From: amd-gfx On Behalf Of Emily > Deng > Sent: Wednesday, August 15, 2018 5:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deng, Emily > Subject: [PATCH 1/2] drm/amdgpu/sriov: For sriov runtime, use kiq to do > invalidate tlb > > To avoid the tlb flush not inte

Re: [PATCH v2] drm/amdgpu/sriov: For sriov runtime, use kiq to do invalidate tlb

Remove the sriov check, The patch can work on both vega10 and Raven under bare metal with tip firmware. Best Regards Rex From: amd-gfx on behalf of Christian König Sent: Wednesday, August 15, 2018 3:07 PM To: Deng, Emily; amd-gfx@lists.freedesktop.org Sub

Re: [PATCH 3/3] drm/amdgpu/powerplay/vega10: enable AVFS control via ppfeaturemask

Series is: Reviewed-by: Rex Zhu Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Saturday, August 11, 2018 2:24 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 3/3] drm/amdgpu/powerplay/vega10: enable AVFS control via pp

Re: [PATCH] drm/amdpu/vce_v3: skip suspend and resume if powergated

, Alexander; Zhu, Rex; Liu, Leo Cc: amd-gfx@lists.freedesktop.org; S, Shirish Subject: [PATCH] drm/amdpu/vce_v3: skip suspend and resume if powergated This patch adds a mechanism by which the VCE 3.0 block shall check if it was enabled or in use before suspending, if it was powergated while entering

Re: [PATCH] drm/amdgpu/powerplay: check vrefresh when when changing displays

Patch is Reviewed-by: Rex Zhu Thanks. Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Friday, August 10, 2018 4:16:23 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: check vrefresh when whe

RE: [PATCH 2/2] drm/amdgpu/pp: endian fixes for processpptables.c

Series is: Reviewed-by: Rex Zhu Regards Rex -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, August 8, 2018 5:32 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH 2/2] drm/amdgpu/pp: endian fixes for processpptables.c Properly swap

Re: [PATCH 3/3] drm/amd/pp: Add gfx power status check support on Rv/Vega12

Currently, there is no use case except for debug. So I will keep the patches in my local. Thanks. Best Regards Rex From: Alex Deucher Sent: Wednesday, August 1, 2018 11:13 PM To: Zhu, Rex Cc: Deucher, Alexander; Quan, Evan; amd-gfx@lists.freedesktop.org

Re: [PATCH 3/3] drm/amd/pp: Add gfx power status check support on Rv/Vega12

Hi Alex, Is it necessary to export an interface as "is_gfx_on" in powerplay to amdgpu? It can show the current power state of gfx ip. Best Regards Rex From: amd-gfx on behalf of Zhu, Rex Sent: Monday, July 30, 2018 11:39 AM To: Quan, Eva

Re: [PATCH v2 2/4] drm/amdgpu: Put enable gfx off feature to a delay thread

One problem, I delay 500ms to enable gfx off feature. Any concern about the delay time? Best Regards Rex From: amd-gfx on behalf of Rex Zhu Sent: Monday, July 30, 2018 5:23 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH v2 2/4] drm

Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function

, July 30, 2018 12:32 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function >This flag should only be set by gfx ip after gfx cg/pg feature enabled. >Other clients can't enable gfx off feature before this flag is set.

Re: [PATCH 2/4] drm/amdgpu: Put enable gfx off feature to a delay thread

t value. if Other clients have new disable requests before the delay work ran, the count will be added by 1. so in the delay thread, gfx off will not be enabled. Best Regards Rex From: Quan, Evan Sent: Monday, July 30, 2018 10:26 AM To: Zhu, Rex; amd-gfx@lis

Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function

;t need to care this flag. Best Regards Rex From: Quan, Evan Sent: Monday, July 30, 2018 11:12 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 1/4] drm/amdgpu: Add amdgpu_gfx_off_ctrl function + if (adev

Re: [PATCH 3/3] drm/amd/pp: Add gfx power status check support on Rv/Vega12

mean it is safe to visit the registers through mmio. Best Regards Rex From: Quan, Evan Sent: Monday, July 30, 2018 9:31 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/amd/pp: Add gfx power status check support on Rv/Vega12 Since th

Re: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch

Series is: Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex From: Quan, Evan Sent: Monday, July 23, 2018 2:38 PM To: Quan, Evan; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH 2/3] drm/amd/powerplay: correct the argume

Re: [PATCH 2/2] drm/amdgpu: Power down acp if board uses AZ

_ From: Alex Deucher Sent: Friday, July 20, 2018 12:53:37 AM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2/2] drm/amdgpu: Power down acp if board uses AZ On Thu, Jul 19, 2018 at 11:14 AM, Zhu, Rex mailto:rex@amd.com>> wrote: >We also need to power it back up in hw_fini and s

Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled

Hi Evan， Changing the title to "Only allow slow switch if NB pstate switch is enabled" can make patch more understandable. Best Regards Rex From: amd-gfx on behalf of Zhu, Rex Sent: Friday, July 20, 2018 4:43 PM To: Quan, Eva

Re: [PATCH 1/3] drm/amd/powerplay: slow UCLK switch when multiple displays not in sync

Reviewed-by: Rex Zhumailto:re...@amd.com>> Regards Rex From: amd-gfx on behalf of Evan Quan Sent: Friday, July 20, 2018 10:35 AM To: amd-gfx@lists.freedesktop.org Cc: Quan, Evan; Zhu, Rex Subject: [PATCH 1/3] drm/amd/powerplay: slow UCLK switch when mu

Re: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled

rg Cc: Quan, Evan; Zhu, Rex Subject: [PATCH 3/3] drm/amd/powerplay: disallow slow switch if NBPState is disabled Otherwise there may be potential SMU performance issues. Change-Id: I05a09bb05407f7b3705d79a1d2c6628385c80461 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_

Re: [PATCH 2/2] drm/amdgpu: Power down acp if board uses AZ

: Alex Deucher Sent: Thursday, July 19, 2018 9:56 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 2/2] drm/amdgpu: Power down acp if board uses AZ On Thu, Jul 19, 2018 at 4:46 AM, Rex Zhu wrote: > if board uses AZ rather than ACP, we power down acp > through smu to save power. > We also n

Re: [PATCH] drm/amdgpu/powerplay: use irq source defines for smu7 sources

Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex From: amd-gfx on behalf of Alex Deucher Sent: Thursday, July 19, 2018 5:08 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay: use irq source defines f

Re: [PATCH] drm/amdgpu/pm: Remove VLA usage

Patch has been applied to our internal amd-staging-drm-next tree. Thanks. Best Regards Rex From: Christian K?nig Sent: Tuesday, July 17, 2018 2:58:21 PM To: Zhu, Rex; Kees Cook; Deucher, Alexander Cc: Zhou, David(ChunMing); David Airlie; Kuehling, Felix

Re: [PATCH 1/2] drm/amd/pp: Set Max clock level to display by default

>shouldn't we still assign simple_clocks.level to clocks->max_clocks_state if >it's non-zero? Yes, Thanks for your reminding. Best Regards Rex From: Wentland, Harry Sent: Wednesday, July 18, 2018 2:29 AM To: Zhu, Rex; amd-gfx@lists.free

Re: [PATCH] drm/amdgpu/pm: Remove VLA usage

Patch is: Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex From: keesc...@google.com on behalf of Kees Cook Sent: Tuesday, July 17, 2018 11:59 AM To: Deucher, Alexander Cc: LKML; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zh

Re: [PATCH 1/4] drm/amdgpu/pp/smu7: use a local variable for toc indexing

Series is: Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex ?? Outlook for Android From: amd-gfx on behalf of Alex Deucher Sent: Thursday, July 12, 2018 10:39:38 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

  1   2   3   >