RE: [PATCH] drm/amdgpu: : Fix the null pointer dereference for amdgpu_device_switch_gang

[AMD Official Use Only - AMD Internal Distribution Only] Hi Christian Thanks for your comments. I miss the before logic has limited the generated pointer. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年7月3日 17:26 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Huang

RE: [PATCH] drm/amdgpu: add missing error handling for amdgpu_ring_alloc()

skip and wait the next action. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年6月21日 17:28 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Huang, Tim ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: add missing error handling for amdgpu_ring_alloc() Am 21.06.24

RE: [PATCH] drm/amdgpu: add missing error handling for amdgpu_ring_alloc()

: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Huang, Tim ; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: add missing error handling for amdgpu_ring_alloc() Am 21.06.24 um 11:24 schrieb Bob Zhou: > Fix the unchecked return value warning reported by Coverity, so add > error handling. That

RE: [PATCH] drm/amdgpu: add missing error handling in function amdgpu_gmc_flush_gpu_tlb_pasid

[AMD Official Use Only - AMD Internal Distribution Only] Hi Alex, Thanks for your review, I will push other patch to fix those issues. Regards, Bob -Original Message- From: Alex Deucher Sent: 2024年6月20日 22:59 To: Zhou, Bob Cc: amd-gfx@lists.freedesktop.org; Huang, Tim ; Zhang, Jesse

RE: [PATCH] drm/amdgpu: replace int with unsigned int for imu_v12_0.c

, Bob -Original Message- From: Koenig, Christian Sent: 2024年6月3日 19:11 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Huang, Tim ; Zhang, Jesse(Jie) Cc: Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu: replace int with unsigned int for imu_v12_0.c Am 03.06.24 um 10:53 schrieb Zhou

RE: [PATCH] drm/amdgpu: replace int with unsigned int for imu_v12_0.c

[AMD Official Use Only - AMD Internal Distribution Only] Hi Christian, It fixes a potential Overflowed constant (INTEGER_OVERFLOW) warning reported by Coverity. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年6月3日 15:56 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amd/pm: add missing error handling in function smu_v13_0_6_allocate_dpm_context

[AMD Official Use Only - AMD Internal Distribution Only] Good catch! Thanks for your comments. I will fix this on next patch. Regards, Bob -Original Message- From: Wang, Yang(Kevin) Sent: 2024年5月31日 15:43 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Huang, Tim ; Zhang, Jesse(Jie

RE: [PATCH] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

[Public] Thanks for your suggestion, I will send the next version patch. Regards, Bob -Original Message- From: Huang, Tim Sent: 2024年5月31日 13:15 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Zhang, Jesse(Jie) Cc: Deucher, Alexander ; Koenig, Christian ; Zhou, Bob Subject: RE

RE: [PATCH] drm/amdgpu: Fix signedness bug in sdma_v4_0_process_trap_irq()

[Public] Reviewed-by: Bob Zhou Regards, Bob -Original Message- From: Dan Carpenter Sent: 2024年4月28日 20:57 To: Zhou, Bob Cc: Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; David Airlie ; Daniel Vetter ; Kuehling, Felix ; Zhang, Hawking ; Guchun Chen ; Ma, Le ; Lazar, Lijo

RE: [PATCH 1/2] drm/amdgpu: fix double free err_addr pointer warnings

[Public] Ping Regards, Bob -Original Message- From: Bob Zhou Sent: 2024年4月23日 13:33 To: amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Koenig, Christian Cc: Zhou, Bob Subject: [PATCH 1/2] drm/amdgpu: fix double free err_addr pointer warnings In

RE: [PATCH 2/2] drm/amdgpu: fix uninitialized variable warning

[AMD Official Use Only - General] Hi Christian Agree with you, returning an error is surely a better modification. I will send v2 patch to fix this. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年4月23日 15:41 To: Zhou, Bob ; Koenig, Christian ; amd-gfx

RE: [PATCH 2/2] drm/amdgpu: fix uninitialized variable warning

unexpected issue. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年4月23日 14:05 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH 2/2] drm/amdgpu: fix uninitialized variable warning Am 23.04.24 um 07:33 schrieb

RE: [PATCH 2/2] drm/amdgpu: fix uninitialized variable warning

om value and it will cause unexpected issue. Regards, Bob -Original Message- From: Koenig, Christian Sent: 2024年4月23日 14:05 To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH 2/2] drm/amdgpu: fix uninitialized variable warning Am 23

RE: [PATCH] drm/amdgpu: fix miss to create mca debugfs node issue

[AMD Official Use Only - General] Reviewed-by: Bob Zhou Regards, Bob -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Thursday, November 30, 2023 1:09 PM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Wang, Yang(Kevin) ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: f

RE: [PATCH] drm/amdgpu: Fix infinite loop in gfxhub_v1_2_xcc_gart_enable

[AMD Official Use Only - General] The variable tmp_mask also could be removed. Regards, Bob -Original Message- From: amd-gfx On Behalf Of Victor Lu Sent: Wednesday, July 19, 2023 3:02 AM To: amd-gfx@lists.freedesktop.org Cc: Lazar, Lijo ; Skvortsov, Victor ; Lu, Victor Cheng Chi (Victo

RE: [PATCH] drm/amdgpu: skip force complete fences when ring is uninitialized

[AMD Official Use Only - General] Hi Christian, Thanks for your suggestion. I will apply it and send out the v2 patch for review. Regards, Bob -Original Message- From: Koenig, Christian Sent: Wednesday, May 31, 2023 4:33 PM To: Zhou, Bob ; amd-gfx@lists.freedesktop.org; Min, Frank