n of adding yet another bool flag parameter to the
> function.
>
> Cc: Christian König
> Cc: amd-gfx@lists.freedesktop.org
> Cc: intel-...@lists.freedesktop.org
> Cc: nouv...@lists.freedesktop.org
> Cc: spice-de...@lists.freedesktop.org
> Cc: dri-de...@lists.freedesktop.org
>
On Mon, Sep 9, 2024 at 7:37 AM Thomas Zimmermann wrote:
>
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
1f4a62d64
> prerequisite-patch-id: f5d4bf16dc45334254527c2e31ee21ba4582761c
> prerequisite-patch-id: 734c87e610747779aa41be12eb9e4c984bdfa743
> prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
> prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
> prerequisite-patch-id: cbc453ee02fae02af22fbfdce56ab732c7a88c36
> --
> 2.43.2
>
That's a really nice cleanup! I already gave a r-b for 9/13. For the rest:
Acked-by: Zack Rusin
z
m_gem_object *obj)
> {
> - vmw_gem_pin_private(obj, false);
> + struct vmw_bo *vbo = to_vmw_bo(obj);
> +
> + vmw_bo_pin_reserved(vbo, false);
> }
>
> static struct sg_table *vmw_gem_object_get_sg_table(struct drm_gem_object
> *obj)
> diff --git a/include/drm/drm_gem_shmem_helper.h
> b/include/drm/drm_gem_shmem_helper.h
> index eb12aa9a8c556..efbc9f27312b5 100644
> --- a/include/drm/drm_gem_shmem_helper.h
> +++ b/include/drm/drm_gem_shmem_helper.h
> @@ -175,15 +175,8 @@ static inline void
> drm_gem_shmem_object_print_info(struct drm_printer *p, unsign
> static inline int drm_gem_shmem_object_pin(struct drm_gem_object *obj)
> {
> struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj);
> - int ret;
>
> - ret = dma_resv_lock_interruptible(shmem->base.resv, NULL);
> - if (ret)
> - return ret;
> - ret = drm_gem_shmem_pin_locked(shmem);
> - dma_resv_unlock(shmem->base.resv);
> -
> - return ret;
> + return drm_gem_shmem_pin_locked(shmem);
> }
>
> /**
> @@ -197,9 +190,7 @@ static inline void drm_gem_shmem_object_unpin(struct
> drm_gem_object *obj)
> {
> struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj);
>
> - dma_resv_lock(shmem->base.resv, NULL);
> drm_gem_shmem_unpin_locked(shmem);
> - dma_resv_unlock(shmem->base.resv);
> }
>
>
Ah, I see. Looks great.
Reviewed-by: Zack Rusin
On Tue, Feb 27, 2024 at 6:39 AM Thomas Zimmermann wrote:
>
> Acquire the reservation lock directly in GEM pin callback. Same for
> unpin. Prepares for further changes.
>
> Dma-buf locking semantics require callers to hold the buffer's
> reservation lock when invoking the pin and unpin callbacks. P
; (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct vmw_surface_dirty.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc: Zack Ru
On Wed, 2023-03-08 at 10:10 +0100, Christian König wrote:
>
> Am 08.03.23 um 06:14 schrieb Zack Rusin:
> > On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote:
> > > VMWGFX is the only remaining user of this and should probably moved over
> > > to drm_exec wh
On Tue, 2023-02-28 at 09:34 +0100, Christian König wrote:
> VMWGFX is the only remaining user of this and should probably moved over
> to drm_exec when it starts using GEM as well.
Is this because vmwgfx piggybacks buffer-id relocations on top of ttm
validations or
did you just find it too hard t
On Thu, 2022-04-21 at 12:17 +0200, Christian König wrote:
> ⚠ External Email
>
> Am 20.04.22 um 21:28 schrieb Zack Rusin:
> > [SNIP]
> > > To figure out what it is could you try the following code
> > > fragment:
> > >
> > > diff --git a/drivers
On Wed, 2022-04-20 at 20:56 +0200, Christian König wrote:
> ⚠ External Email
>
> Am 20.04.22 um 20:49 schrieb Christian König:
> > Am 20.04.22 um 20:41 schrieb Zack Rusin:
> > > On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
> > > > Am 20.04.22 um 19
On Wed, 2022-04-20 at 19:40 +0200, Christian König wrote:
>
> Am 20.04.22 um 19:38 schrieb Zack Rusin:
> > On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
> > > ⚠ External Email
> > >
> > > Hi Zack,
> > >
> > > Am 20.04.22 um 0
On Wed, 2022-04-20 at 09:37 +0200, Christian König wrote:
> ⚠ External Email
>
> Hi Zack,
>
> Am 20.04.22 um 05:56 schrieb Zack Rusin:
> > On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote:
> > > Rework the internals of the dma_resv object to allow ad
On Thu, 2022-04-07 at 10:59 +0200, Christian König wrote:
> Rework the internals of the dma_resv object to allow adding more than
> one
> write fence and remember for each fence what purpose it had.
>
> This allows removing the workaround from amdgpu which used a container
> for
> this instead.
>
From: Zack Rusin
Switch to using the TTM resource manager debugfs helpers. The
functionality is largely the same.
The TTM resource managers need to stay valid for as long as the
drm debugfs_root is valid.
Signed-off-by: Zack Rusin
Cc: Alex Deucher
Cc: "Christian König"
Cc: "P
From: Zack Rusin
Switch to using the TTM resource manager debugfs helpers. It's
exactly the same functionality but the debugfs code is shared with
other drivers.
The TTM resource managers need to stay valid for as long as the
drm debugfs_root is valid.
Signed-off-by: Zack Rusin
Cc:
From: Zack Rusin
Switch to using the TTM resource manager debugfs helpers. The
functionality is largely the same, except that the entries live under
/sys/kernel/debug/ttm/ and their lifetimes are managed by TTM.
Signed-off-by: Zack Rusin
Cc: Alex Deucher
Cc: "Christian König"
From: Zack Rusin
Switch to using the TTM resource manager debugfs helpers. It's
exactly the same functionality, except that the entries live under
/sys/kernel/debug/ttm/.
Signed-off-by: Zack Rusin
Cc: Alex Deucher
Cc: "Christian König"
Cc: "Pan, Xinhui"
Cc: David
Zimmermann
> Reviewed-by: Laurent Pinchart
> Acked-by: Daniel Vetter
Looks good.
Reviewed-by: Zack Rusin
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
et = -EPERM;
- goto out_unref;
- }
- ret = bo->bdev->funcs->verify_access(bo, filp);
+ ret = vmw_user_bo_verify_access(bo, tfile);
if (unlikely(ret != 0))
goto out_unref;
Looks great.
Reviewed-by: Zack Rusin
z
ot a big deal and I know it's been in the original, but since
you're already in there if you could change this to DRM_ERR that'd be
great. Either way:
Reviewed-by: Zack Rusin
z
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
h
> On Dec 3, 2020, at 10:12, Daniel Vetter wrote:
>
> On Thu, Dec 03, 2020 at 03:06:20AM +0000, Zack Rusin wrote:
>>
>>
>>> On Dec 2, 2020, at 11:03, Daniel Vetter wrote:
>>>
>>> On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote:
>>
> On Dec 2, 2020, at 11:03, Daniel Vetter wrote:
>
> On Wed, Dec 2, 2020 at 4:37 PM Zack Rusin wrote:
>>
>>
>>
>>> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote:
>>>
>>> Hi
>>>
>>> Am 02.12.20 um 09:01 schrieb
> On Dec 2, 2020, at 09:27, Thomas Zimmermann wrote:
>
> Hi
>
> Am 02.12.20 um 09:01 schrieb Thomas Zimmermann:
>> Hi
>> Am 30.11.20 um 21:59 schrieb Zack Rusin:
>>>
>>>
>>>> On Nov 24, 2020, at 06:38, Thomas Zimmermann wrote:
>&
vmwgfx/vmwgfx_cmdbuf.c | 8
> drivers/gpu/drm/vmwgfx/vmwgfx_drv.c| 27 +-
> drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 2 +-
Reviewed-by: Zack Rusin
z
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists
24 matches
Mail list logo
