RE: [PATCH v2] drm/amdgpu: fix the memleak caused by fence not released

2025-02-14 Thread YuanShang Mao (River)
[AMD Official Use Only - AMD Internal Distribution Only] Better to put the fence outside amdgpu_gem_va_update_vm. Since it is passed to the caller, and the caller must keep one reference at least until this fence is no longer needed. Thanks River -Original Message- From: amd-gfx On Be

[PATCH] drm/amdgpu - Put the fence returned by amdgpu_gem_va_update_vm

2025-02-09 Thread YuanShang
The fence in amdgpu_gem_va_update_vm is not used after amdgpu_gem_update_bo_mapping. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c

[PATCH v2] drm/amdgpu: Flush tlb by VM_INVALIDATION packet in sdma_v5_2

2024-09-09 Thread YuanShang
In order for SDMA not to be switched between VM_INVALIDATION request and ack, use an single VM_INVALIDATION packet in function sdma_v5_2_ring_emit_vm_flush. Signed-off-by: YuanShang --- .../gpu/drm/amd/amdgpu/navi10_sdma_pkt_open.h | 64 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_2

[PATCH] drm/amdgpu: Flush tlb by VM_INVALIDATION packet in sdma_v5_2

2024-09-09 Thread YuanShang
To flush tlb by one single packet, Use VM_INVALIDATION packet in function sdma_v5_2_ring_emit_vm_flush. Signed-off-by: YuanShang --- .../gpu/drm/amd/amdgpu/navi10_sdma_pkt_open.h | 64 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c| 24 ++- 2 files changed, 87 insertions

RE: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-19 Thread YuanShang Mao (River)
[AMD Official Use Only - AMD Internal Distribution Only] Same issue on CPU page table update. -Original Message- From: Kuehling, Felix Sent: Thursday, July 18, 2024 12:28 AM To: Christian König ; YuanShang Mao (River) ; Huang, Trigger ; amd-gfx@lists.freedesktop.org; cao, lin Subject

RE: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-12 Thread YuanShang Mao (River)
er is still accessing the "invalidated" BO. I am not familiar with amdgpu_vm_bo state machine, so I don’t know if it is an code error or an design error. Thanks River -Original Message- From: YuanShang Mao (River) Sent: Friday, July 12, 2024 10:55 AM To: Christian

RE: [PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-11 Thread YuanShang Mao (River)
invalidated BO. Agree with Trigger. Seems kfd eviction should been synced to move notify, not the move action. Thanks River -Original Message- From: Christian König Sent: Thursday, July 11, 2024 8:39 PM To: Huang, Trigger ; YuanShang Mao (River) ; amd-gfx@lists.freedesktop.org Subject: Re

[PATCH] drm/amdgpu: Mark amdgpu_bo as invalid after moved

2024-07-11 Thread YuanShang
It leads to race condition if amdgpu_bo is marked as invalid before it is really moved. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm

RE: [PATCH v3] drm/amd/amdgpu: Update RLC_SPM_MC_CNT by ring wreg

2024-01-15 Thread YuanShang Mao (River)
[AMD Official Use Only - General] Ping... -Original Message- From: YuanShang Mao (River) Sent: Saturday, January 13, 2024 2:58 PM To: amd-gfx@lists.freedesktop.org Cc: YuanShang Mao (River) ; YuanShang Mao (River) Subject: [PATCH v3] drm/amd/amdgpu: Update RLC_SPM_MC_CNT by ring wreg

[PATCH v3] drm/amd/amdgpu: Update RLC_SPM_MC_CNT by ring wreg

2024-01-12 Thread YuanShang
[Why] RLC_SPM_MC_CNTL can not updated by MMIO since MMIO protection is enabled during runtime in guest machine. [How] Submit command of wreg in amdgpu ring to update RLC_SPM_MC_CNT. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 2 +- drivers/gpu/drm/amd/amdgpu

[PATCH v2] drm/amd/amdgpu: Update RLC_SPM_MC_CNT by ring wreg

2024-01-11 Thread YuanShang
[Why] RLC_SPM_MC_CNTL can not updated by MMIO since MMIO protection is enabled during runtime in guest machine. [How] Submit command of wreg in amdgpu ring to update RLC_SPM_MC_CNT. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 2 +- drivers/gpu/drm/amd/amdgpu

[PATCH] SWDEV-439292 - Update RLC_SPM_MC_CNT by ring wreg

2024-01-11 Thread YuanShang
Why: RLC_SPM_MC_CNTL can not updated by MMIO since MMIO protection is enabled during runtime. How: submit command of wreg in amdgpu ring to update RLC_SPM_MC_CNT. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_rlc.h | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2

[PATCH] /drm/amdgpu: correct chunk_ptr to a pointer to chunk.

2023-10-30 Thread YuanShang
The variable "chunk_ptr" should be a pointer pointing to a struct drm_amdgpu_cs_chunk instead of to a pointer of that. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

[PATCH v3] drm/amdgpu: load sdma ucode in the guest machine

2023-07-18 Thread YuanShang
] Load the sdma ucode for CHIP_NAVI12 and CHIP_SIENNA_CICHLID in the guest machine. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 11 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 8 +++- 3 files changed, 14

[PATCH v2] drm/amdgpu: load sdma ucode in the guest machine

2023-07-17 Thread YuanShang
] Load the sdma ucode for CHIP_NAVI12 and CHIP_SIENNA_CICHLID in the guest machine. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 11 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 8 +++- 3 files changed, 14

[PATCH] drm/amdgpu: load sdma ucode in the guest machine

2023-07-13 Thread YuanShang
Value Packet). Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 11 +++ drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 6 ++ 3 files changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: Remove IMU ucode in vf2pf

2023-05-09 Thread YuanShang
The IMU firmware is loaded on the host side, not the guest. Remove IMU in vf2pf ucode id enum. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c| 1 - drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amdgpu: Remove IMU ucode in vf2pf

2023-05-09 Thread YuanShang
The IMU firmware is loaded on the host side, not the guest. Remove IMU in vf2pf ucode id enum. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c| 1 - drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH] drm/amd: Remove IMU ucode in vf2pf

2023-05-09 Thread YuanShang
Remove IMU in vf2pf ucode id enum to align with host's definition. Signed-off-by: YuanShang --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c| 1 - drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/dr