Re: [PATCH 4/4] drm/amdgpu: rework synchronization of VM updates v3

Was the change to true from the only use of intr in amdgpu_bo_sync_wait_resv intentional?  If so, would it not make sense to remove the argument from the function signature while the API is changing? On 1/23/20 8:21 AM, Christian König wrote: > If provided we only sync to the BOs reservation > o

Re: [PATCH] drm/amdgpu: fix doc by clarifying sched_list definition

If we're worrying about spelling and grammar, see one more nitpick inline. On 1/20/20 10:35 AM, Nirmoy Das wrote: > expand sched_list definition for better understanding. > Also fix a typo atleast -> at least > > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/scheduler/sched_entity.c | 2 +-

Re: [PATCH v2 2/5] drm: Add Reusable task barrier.

Some typographical error nitpicks inline. On 12/13/19 10:54 AM, Andrey Grodzovsky wrote: > It is used to synchronize N threads at a rendevouz point before execution rendezvous > of critical code that has to be started by all the threads at approximatly approximately > the same time. > > v2: Remove

Re: [PATCH 6/8] drm/amdgpu: add psp memory training callbacks and macro

On 10/8/19 2:29 PM, Alex Deucher wrote: > From: "Tianci.Yin" > > add interface for memory training. > > Change-Id: Ibb6d1d24eb651df796bc2bb3419a44937af60242 > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 18 > drivers/gpu/dr

Re: [PATCH 4/8] drm/amdgpu: update atomfirmware header with memory training related members

On 10/8/19 2:29 PM, Alex Deucher wrote: > From: "Tianci.Yin" > > add new vram_reserve_block structure and atomfirmware_internal_constants > enumeration > > Change-Id: I6ba642ecd7ad94250162ae5c322ed8d85de9c35a > Reviewed-by: Alex Deucher > Signed-off-by: Tianci.Yin > --- > drivers/gpu/drm/amd

Re: [PATCH] drm/amd/powerplay: detect version of smu backend

On 6/14/19 2:01 AM, Prike Liang wrote: > Change-Id: Ib050c8cf0c2c5af4c1f747cf596860f9be01a2d3 > Signed-off-by: Prike Liang > --- > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 1 + > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 1 + > drivers/gpu/drm/amd/powerplay/sm

Re: [PATCH v3] drm/amdgpu: add badpages sysfs interafce

Typo in the patch description.  s/interafce/interface/ On 5/9/19 10:24 AM, Alex Deucher wrote: > On Thu, May 9, 2019 at 6:31 AM Pan, Xinhui wrote: >> add badpages node. >> it will output badpages list in format >> gpu pfn : gpu page size : flags >> >> example >> 0x : 0x1000 : R >> 0x0

Re: [PATCH] drm/amdkfd: fix a compiling error when CONFIG_HSA_AMD disalbed

Typo in patch description: s/disalbed/disabled/ On 3/6/19 10:11 AM, Deucher, Alexander wrote: Add a line like: Fixes: 9032ea09e2d2ef ("drm/amdkfd: add RAS ECC event support") With that added: Reviewed-by: Alex Deucher From:

Re: [PATCH] drm/amd/powerplay: revise Vega20 pptable version check

On 10/29/18 8:41 PM, Alex Deucher wrote: > On Mon, Oct 29, 2018 at 9:39 PM Evan Quan wrote: >> Tell the version numbers when the pptable versions do not match. >> >> Change-Id: I3ea8aac7493927281b14d28866fa87690621f0f0 >> Signed-off-by: Evan Quan >> --- >> .../drm/amd/powerplay/hwmgr/vega20_pr

Re: [PATCH libdrm 3/6] amdgpu: add handle table implementation

Applies to patch #1 and patch #3, should lockup not be lookup? On 08/02/2018 09:04 AM, Christian König wrote: > The kernel handles are dense and the kernel always tries to use the > lowest free id. Use this to implement a more efficient handle table > by using a resizeable array instead of a hash

Re: [PATCH] drm/amdgpu: Partially revert commit 2dc80b006

On 06/13/2018 08:30 AM, Jan Vesely wrote: Hi, can you please improve the commit message? seeing "Revert $HASH" conveys zero information about the code change. I'm sorry for bringing this up again, but following AMDGPU/Radeon driver development is an exercise in frustration for anyone who is not

Re: [PATCH] drm/amdgpu: Fix amdgpu_sync_add_later to preserve explicit flag.

On 12/05/2017 08:41 AM, Andrey Grodzovsky wrote: > Signed-off-by: Andrey Grodzovsky > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c > b/drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH 2/6] drm/amd/display: Use new DRM API where possible

On 10/12/2017 04:15 PM, sunpeng...@amd.com wrote: > From: "Leo (Sunpeng) Li" > > To conform to DRM's new API, we should not be accessing a DRM object's > internal state directly. Rather, the DRM for_each_old/new_* iterators, > and drm_atomic_get_old/new_* interface should be used. > > This is an

Re: [PATCH libdrm] amdgpu: update headers

On 09/18/2017 06:16 PM, Andres Rodriguez wrote: > For testing the kernel commit > --- > include/drm/amdgpu_drm.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h > index da2ade6..c01abaa 100644 > --- a/include/drm/amdgpu_drm.h > +

Re: [PATCH] drm/amdgpu: discard commands of killed processes

On 08/21/2017 07:58 AM, Christian König wrote: > From: Christian König > > When a process is killed we shouldn't submit all waiting jobs, but instead > clean up as fast as possible. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 23 +

Re: [PATCH 1/6] drm: Add helper to cast DMA-buf to GEM object v2

On 07/18/2017 09:22 PM, Felix Kuehling wrote: > v2: Use the new helper in drm_gem_prime_import > > Signed-off-by: Felix Kuehling > Reviewed-by: Christian König > Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_prime.c | 43 +-- > include/drm/dr

Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.

On 06/08/2017 02:50 AM, Rex Zhu wrote: > should disable led dpm feature when stop dpm. > > Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0 > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >

Re: [PATCH] drm/amdgpu: fix errors in comments.

On 05/08/2017 10:32 AM, Alex Xie wrote: > Signed-off-by: Alex Xie > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > ind

Re: [PATCH] drm/amdgpu: set vm size and block size by individual gmc by default

On 04/05/2017 01:43 AM, Junwei Zhang wrote: > By default, the value is set by individual gmc. > if a specific value is input, it overrides the global value for all > > Signed-off-by: Junwei Zhang > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++ > drivers/gpu/drm/amd/amdgpu/amdgpu_d

Re: [PATCH 03/15] drm/amdgpu: add num_level to the VM manager

On 03/27/2017 12:53 AM, Chunming Zhou wrote: > From: Christian König > > Needs to be filled with handling. > > Change-Id: I04881a2b304a020c259ce85e94b12900a77f1c02 > Signed-off-by: Christian König > Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 1 + > drivers/gp

Re: [PATCH 3/6] drm/amdgpu: add get_clockgating callback for soc15

On 03/24/17 00:47, Huang Rui wrote: > Signed-off-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 +++ > drivers/gpu/drm/amd/amdgpu/soc15.c | 34 > ++ > 2 files changed, 37 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

Re: [PATCH 16/21] drm/amdgpu: implement lru amdgpu_queue_mgr policy for compute v3

Minor spelling nitpick. >> +/** >> + * amdgpu_ring_lru_get - get the least recently used ring for a HW >> IP block >> + * >> + * @adev: amdgpu_device pointer >> + * @type: amdgpu_ring_type enum >> + * @ring: output ring >> + * >> + * Retreive the amdgpu_ring structure for the least recently used

Re: [PART1 PATCH 2/8] drm/amdgpu: add parse clock gating state

Minor nit. s/Grain/Grained/ Also, amdgpu_clockgating_state as a function name does not seem explicit enough as to what it's doing, maybe amdgpu_get_clockgating_state? On 01/05/17 07:49, Huang Rui wrote: > Signed-off-by: Huang Rui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 95 > +++

Re: [PATCH 1/2] drm/amdgpu/si/dpm: make a bunch of things static

Two minor possible changes inline for further simplification... On 09/12/16 23:11, Alex Deucher wrote: > remnants of the port from radeon. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/si_dpm.c | 34 -- > 1 file changed, 16 insertions(+), 1

Re: [PATCH 5/5] drm/amdgpu: add VRAM manager

s/Destory/Destroy/. On 08/29/16 04:20, Christian König wrote: > From: Christian König > > Split VRAM allocations into 4MB blocks. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + > drive

Re: [PATCH 1/5] drm/amdgpu: add AMDGPU_GEM_CREATE_VRAM_LINEAR flag v2

Question inline, probably my lack of understanding of the code. On 08/29/16 04:20, Christian König wrote: > From: Christian König > > Add a flag noting that a BO must be created using linear VRAM > and set this flag on all in kernel users where appropriate. > > Hopefully I haven't missed anythin