[PATCH 2/2] drm/radeon: Do not hold console lock during resume

. The console lock is only required by DRM's fbdev emulation, which acquires it as necessary. Also fixes a possible circular dependency between the console lock and the client-list mutex, where the mutex is supposed to be taken first. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/r

[PATCH 0/2] drm/radeon: Do not acquire console lock during suspend/resume

drivers. Fixes the cyclic locking. Tested by repeatedly suspeding/resuming on Radeon HD 6570. Thomas Zimmermann (2): drm/radeon: Do not hold console lock while suspending clients drm/radeon: Do not hold console lock during resume drivers/gpu/drm/radeon/radeon_device.c | 23

[PATCH 1/2] drm/radeon: Do not hold console lock while suspending clients

let the fbdev DRM client acquire the lock when needed. This is what all other DRM drivers so. Signed-off-by: Thomas Zimmermann Reported-by: Jeff Johnson Closes: https://lore.kernel.org/dri-devel/0a087cfd-bd4c-48f1-aa2f-4a3b12593...@oss.qualcomm.com/ Suggested-by: Ville Syrjälä --- drivers/gpu

[PATCH] Revert "drm/amdgpu: Use dma_buf from GEM object instance"

t a DRM framebuffer associated. Hence, this revert to going back to using .import_attach->dmabuf. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 3

Re: [PATCH v5 RESEND 1/3] drm/shmem-helper: Import dmabuf without mapping its sg_table

(cc:ing more AMD devs) Hi Am 14.07.25 um 12:16 schrieb Shixiong Ou: 在 2025/7/11 22:16, Thomas Zimmermann 写道: Hi this patch regresses buffer sharing between udl and amdgpu. The latter uses TTM. When udl imports a dma_buf from amdgpu, vmap returns a kernel address, but pagefaults on the

Re: WARNING: possible circular locking dependency detected: drm_client_dev_suspend() & radeon_suspend_kms()

HP-ZBook-14-G2 kernel: This doesn't seem to be the cause of the ath12k issue I'm debugging, but thought it worth mentioning since I only see one similar report on lore, and that didn't have any apparent follow-up: https://lore.kernel.org/all/20250202161048.373f89c0@yea/ /jeff -

Re: [PATCH v2 0/2] drm/amd: Avoid using import_attach directly

Hi Am 25.06.25 um 16:40 schrieb Alex Deucher: On Wed, Jun 25, 2025 at 7:25 AM Christian König wrote: On 25.06.25 10:42, Thomas Zimmermann wrote: The field import_attach of struct drm_gem_object is often only required by PRIME code. In other places, replace its use with clearer alternatives

[PATCH v2 1/2] drm/amdgpu: Test for imported buffers with drm_gem_is_imported()

Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. v2: - keep amdgpu_bo_print_info() as-is (Christian) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2

[PATCH v2 0/2] drm/amd: Avoid using import_attach directly

The field import_attach of struct drm_gem_object is often only required by PRIME code. In other places, replace its use with clearer alternatives. v2: - keep amdgpu_bo_print_info() as-is (Christian) Thomas Zimmermann (2): drm/amdgpu: Test for imported buffers with drm_gem_is_imported() drm

[PATCH v2 2/2] drm/amdgpu: Use dma_buf from GEM object instance

Avoid dereferencing struct drm_gem_object.import_attach for the imported dma-buf. The dma_buf field in the GEM object instance refers to the same buffer. Prepares to make import_attach an implementation detail of PRIME. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu

Re: [PATCH 1/2] drm/amdgpu: Test for imported buffers with drm_gem_is_imported()

Hi Am 24.06.25 um 15:17 schrieb Christian König: On 19.06.25 14:15, Thomas Zimmermann wrote: Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2

[PATCH 2/2] drm/amdgpu: Use dma_buf from GEM object instance

Avoid dereferencing struct drm_gem_object.import_attach for the imported dma-buf. The dma_buf field in the GEM object instance refers to the same buffer. Prepares to make import_attach an implementation detail of PRIME. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] drm/amdgpu: Test for imported buffers with drm_gem_is_imported()

Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4

[PATCH 0/2] drm/amd: Avoid using import_attach directly

The field import_attach of struct drm_gem_object is often only required by PRIME code. In other places, replace its use with clearer alternatives. Thomas Zimmermann (2): drm/amdgpu: Test for imported buffers with drm_gem_is_imported() drm/amdgpu: Use dma_buf from GEM object instance drivers

[PATCH 1/2] drm/amdgpu: Test for imported buffers with drm_gem_is_imported()

Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd

[PATCH 2/2] drm/amdgpu: Use dma_buf from GEM object instance

Avoid dereferencing struct drm_gem_object.import_attach for the imported dma-buf. The dma_buf field in the GEM object instance refers to the same buffer. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/amd/amdgpu/amdgpu_dma_buf.c | 2 +- drivers/gpu

[PATCH 09/11] drm/radeon: Test for imported buffers with drm_gem_is_imported()

Instead of testing import_attach for imported GEM buffers, invoke drm_gem_is_imported() to do the test. The helper tests the dma_buf itself while import_attach is just an artifact of the import. Prepares to make import_attach optional. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc

[PATCH 0/2] drm/amdgpu: Avoid struct drm_gem_object.import_attach

7;s buffer has been imported into the driver. The corresponding dma-buf is referenced by the object itself. Both cases avoid import_attach. Thomas Zimmermann (2): drm/amdgpu: Test for imported buffers with drm_gem_is_imported() drm/amdgpu: Use dma_buf from GEM object instance drivers/gpu/drm/

Re: [PATCH 02/19] drm: Pass pixel_format+modifier directly to drm_get_format_info()

st struct drm_format_info * drm_get_format_info(struct drm_device *dev, - const struct drm_mode_fb_cmd2 *mode_cmd); + u32 pixel_format, u64 modifier); uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth); uint32_t drm_driver_legacy_fb_format

Re: [RFC] PCI: add CONFIG_MMU dependency

i/Kconfig index 0cc06c2ce0b8..75ace2302fed 100644 --- a/drivers/scsi/bnx2i/Kconfig +++ b/drivers/scsi/bnx2i/Kconfig @@ -4,7 +4,6 @@ config SCSI_BNX2_ISCSI depends on NET depends on PCI depends on (IPV6 || IPV6=n) - depends on MMU select SCSI_ISCSI_ATTRS select NETDEVICES select ETHERNET diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig index c3bcb6911c53..2b0172f54665 100644 --- a/drivers/vfio/pci/Kconfig +++ b/drivers/vfio/pci/Kconfig @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only menu "VFIO support for PCI devices" - depends on PCI && MMU + depends on PCI config VFIO_PCI_CORE tristate -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

*(#$ u64 next to the u32. Yeah probably. Otoh I know inertia, so I am tempted to go with the oddball LINEAR_VEDNOR_A_VENDOR_B_INTEROP thing and stretch the runway for a bit. And we just assign those as we go as a very special thing, and the drivers that support it would prefer it above just LINEAR if there's no other common format left. Also makes it really obvious what all userspace/kernel driver enabling would be needed to justify such a modifier. -Sima > > Cheers, > Daniel -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

Hi Am 14.01.25 um 14:46 schrieb Thomas Zimmermann: Hi Am 15.12.24 um 21:53 schrieb Marek Olšák: The comment explains the problem with DRM_FORMAT_MOD_LINEAR. Signed-off-by: Marek Olšák diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index 78abd819fd62e

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

e also has alignment requirements for framebuffer width (usually 8 pixels). Best regards Thomas [1] https://elixir.bootlin.com/linux/v6.12.6/source/drivers/gpu/drm/renesas/rcar-du/rcar_du_kms.c#L410 -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frank

Re: [PATCH v2 0/5] drm/connector: make mode_valid() callback accept const mode pointer

uld I rework it adding something like .mode_valid_new() callback which takes const argument? Please merge as-is. No need to complicate things. For the whole series: Reviewed-by: Thomas Zimmermann Thanks for doing this. Best regards Thomas Signed-off-by: Dmitry Baryshkov --- Changes in v

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

ruct drm_driver, its initialization from drivers, along with the common DRIVER_DATE macros. v2: Also update drivers/accel (kernel test robot) Reviewed-by: Javier Martinez Canillas Acked-by: Alex Deucher Acked-by: Simon Ser Acked-by: Jeffrey Hugo Signed-off-by: Jani Nikula Reviewed-b

[PATCH v4 11/12] drm/client: Make client support optional

it has to select DRM_CLIENT by itself unconditionally. v3: - provide empty drm_client_debugfs_init() if DRM_CLIENT=n (kernel test robot) Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan Reviewed-by: Jonathan Cavitt --- drivers/gpu/d

[PATCH v4 12/12] drm/client: Add client-lib module

B - remove duplicate line from Makefile (Jocelyn) Signed-off-by: Thomas Zimmermann Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/Kconfig | 26 - drivers/gpu/drm/Makefile| 14 + drivers/gpu/drm/drm_client_setup.c | 3 +++ drive

[PATCH v4 07/12] drm/client: Move suspend/resume into DRM client callbacks

(Jonathan) Signed-off-by: Thomas Zimmermann Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/drm_client_event.c | 60 drivers/gpu/drm/drm_fbdev_client.c | 30 +- drivers/gpu/drm/drm_modeset_helper.c | 14 --- include/drm/drm_client.h

[PATCH v4 10/12] drm/radeon: Suspend and resume clients with client helpers

-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/radeon/radeon_device.c | 19 ++- drivers/gpu/drm/radeon/radeon_fbdev.c | 6 -- drivers/gpu/drm/radeon/radeon_mode.h | 3 --- 3 files c

[PATCH v4 09/12] drm/nouveau: Suspend and resume clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo

[PATCH v4 06/12] drm/client: Move client event handlers to drm_client_event.c

: - rename new files to drm_client_event.{c,h} Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich Reviewed-by: Jonathan Cavitt --- Documentation/gpu/drm-client.rst | 3

[PATCH v4 08/12] drm/amdgpu: Suspend and resume internal clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König

[PATCH v4 05/12] drm/fbdev: Store fbdev module parameters in separate file

rs to drm_kms_helper_common.c, so that the actual fbdev implementaton can later go into a separate module. Signed-off-by: Thomas Zimmermann Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/drm_fb_helper.c | 31 -- drivers/gpu/drm/drm_internal.h | 7 + drivers/gp

[PATCH v4 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them

Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH v4 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

;fbdefio; | ^~ drivers/gpu/drm/drm_fbdev_dma.c:221:43: error: 'struct drm_fb_helper' has no member named 'fbdefio' 221 | info->fbdefio = &fb_helper->fbdefio; | ^~ Signed-of

[PATCH v4 02/12] drm/xe: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1

[PATCH v4 00/12] drm: Introduce DRM client library

robot) v2: - rework of the overall design - keep base client code in DRM core Thomas Zimmermann (12): drm/i915: Select DRM_CLIENT_SELECTION drm/xe: Select DRM_CLIENT_SELECTION drm/fbdev-dma: Select FB_DEFERRED_IO drm/fbdev: Select fbdev I/O helpers from modules that require them drm/fbdev: S

[PATCH v4 01/12] drm/i915: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Reviewed-by: Jonathan Cavitt --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file

Re: [PATCH v3 07/12] drm/client: Move suspend/resume into DRM client callbacks

Hi Am 08.10.24 um 23:21 schrieb Cavitt, Jonathan: -Original Message- From: Intel-xe On Behalf Of Thomas Zimmermann Sent: Tuesday, October 8, 2024 4:59 AM To: sim...@ffwll.ch; airl...@gmail.com; javi...@redhat.com; jfale...@redhat.com Cc: dri-de...@lists.freedesktop.org; amd-gfx

[PATCH v3 11/12] drm/client: Make client support optional

it has to select DRM_CLIENT by itself unconditionally. v3: - provide empty drm_client_debugfs_init() if DRM_CLIENT=n (kernel test robot) Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu/drm/Kconfig| 10 ++ d

[PATCH v3 04/12] drm/fbdev: Select fbdev I/O helpers from modules that require them

Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH v3 12/12] drm/client: Add client-lib module

B - remove duplicate line from Makefile (Jocelyn) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 26 - drivers/gpu/drm/Makefile| 14 + drivers/gpu/drm/drm_client_setup.c | 3 +++ drivers/gpu/drm/drm_kms_helper_com

[PATCH v3 09/12] drm/nouveau: Suspend and resume clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo

[PATCH v3 10/12] drm/radeon: Suspend and resume clients with client helpers

Replace calls to drm_fb_helper_set_suspend() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König"

[PATCH v3 05/12] drm/fbdev: Store fbdev module parameters in separate file

rs to drm_kms_helper_common.c, so that the actual fbdev implementaton can later go into a separate module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 31 -- drivers/gpu/drm/drm_internal.h | 7 + drivers/gpu/drm/drm_kms_helper_common.c

[PATCH v3 08/12] drm/amdgpu: Suspend and resume internal clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König

[PATCH v3 07/12] drm/client: Move suspend/resume into DRM client callbacks

them for fbdev emulation with the existing drm_fb_helper_set_suspend_unlocked(). Then update DRM's modeset helpers to call the new interface. Clients that are not fbdev can now implement suspend/resume to their requirements. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client_ev

[PATCH v3 06/12] drm/client: Move client event handlers to drm_client_event.c

: - rename new files to drm_client_event.{c,h} Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Makefile

[PATCH v3 03/12] drm/fbdev-dma: Select FB_DEFERRED_IO

;fbdefio; | ^~ drivers/gpu/drm/drm_fbdev_dma.c:221:43: error: 'struct drm_fb_helper' has no member named 'fbdefio' 221 | info->fbdefio = &fb_helper->fbdefio; | ^~ Signed-of

[PATCH v3 01/12] drm/i915: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v3 02/12] drm/xe: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH v3 00/12] drm: Introduce DRM client library

ase client code in DRM core Thomas Zimmermann (12): drm/i915: Select DRM_CLIENT_SELECTION drm/xe: Select DRM_CLIENT_SELECTION drm/fbdev-dma: Select FB_DEFERRED_IO drm/fbdev: Select fbdev I/O helpers from modules that require them drm/fbdev: Store fbdev module parameters in separate file

Re: NULL pointer dereference with kernel 6.12.0-rc1 and ARUBA GPU

ehci_hcd mdio_devres scsi_mod scsi_common libphy usbcore usb_common [   15.672773] CR2: 0050 [   15.672776] ---[ end trace ]--- -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo

[PATCH v2 04/11] drm/fbdev: Store fbdev module parameters in separate file

rs to drm_kms_helper_common.c, so that the actual fbdev implementaton can later go into a separate module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_fb_helper.c | 31 -- drivers/gpu/drm/drm_internal.h | 7 + drivers/gpu/drm/drm_kms_helper_common.c

[PATCH v2 10/11] drm/client: Make client support optional

it has to select DRM_CLIENT by itself unconditionally. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu/drm/Kconfig| 10 ++ drivers/gpu/drm/Makefile | 7 --- drivers/gpu/drm/amd/amdgpu/Kc

[PATCH v2 11/11] drm/client: Add client-lib module

m Makefile (Jocelyn) Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 26 - drivers/gpu/drm/Makefile| 14 + drivers/gpu/drm/drm_client_setup.c | 3 +++ drivers/gpu/drm/drm_kms_helper_common.c | 3 +++ 4 files c

[PATCH v2 07/11] drm/amdgpu: Suspend and resume internal clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König

[PATCH v2 06/11] drm/client: Move suspend/resume into DRM client callbacks

them for fbdev emulation with the existing drm_fb_helper_set_suspend_unlocked(). Then update DRM's modeset helpers to call the new interface. Clients that are not fbdev can now implement suspend/resume to their requirements. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_client_ev

[PATCH v2 03/11] drm/fbdev: Select fbdev I/O helpers from modules that require them

Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH v2 08/11] drm/nouveau: Suspend and resume clients with client helpers

Replace calls to drm_fb_helper_set_suspend_unlocked() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo

[PATCH v2 09/11] drm/radeon: Suspend and resume clients with client helpers

Replace calls to drm_fb_helper_set_suspend() with calls to the client functions drm_client_dev_suspend() and drm_client_dev_resume(). Any registered in-kernel client will now receive suspend and resume events. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König"

[PATCH v2 05/11] drm/client: Move client event handlers to drm_client_event.c

: - rename new files to drm_client_event.{c,h} Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- Documentation/gpu/drm-client.rst | 3 + drivers/gpu/drm/Makefile

[PATCH v2 01/11] drm/i915: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula i Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 00/11] drm: Introduce DRM client library

- rework of the overall design - keep base client code in DRM core. Thomas Zimmermann (11): drm/i915: Select DRM_CLIENT_SELECTION drm/xe: Select DRM_CLIENT_SELECTION drm/fbdev: Select fbdev I/O helpers from modules that require them drm/fbdev: Store fbdev module parameters in separate file d

[PATCH v2 02/11] drm/xe: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH 24/28] drm/vc4: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Dave Stevenson Cc: Raspberry Pi Kernel Maintenance --- driver

[PATCH 03/28] drm/armada: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Russell King --- drivers/gpu/drm/armada/armada_drv.c | 4 ++-- 1 file chang

[PATCH 21/28] drm/bochs: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/bochs.c | 4 ++-- 1 file changed, 2 inser

[PATCH 04/28] drm/ast: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.c | 4 ++-- 1

[PATCH 28/28] drm: Remove DRM aperture helpers

The DRM aperture helpers are wrappers around video helpers from . There are no callers of these functions. Remove them entirely. Signed-off-by: Thomas Zimmermann Cc: Jonathan Corbet --- Documentation/gpu/drm-internals.rst | 12 -- MAINTAINERS | 2 - drivers/gpu/drm

[PATCH 05/28] drm/hisilicon/hibmc: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Xinliang Liu Cc: Tian Tao Cc: Xinwei Kong Cc: Sumit Semwal Cc: Yongqin Liu Cc:

[PATCH 27/28] drm/xe: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Lucas De Marchi Cc: "Thomas Hellström" Cc: Rodrigo Vivi --- dri

[PATCH 26/28] drm/vmwgfx: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Zack Rusin Cc: Broadcom internal kernel review list --- drivers/gpu/drm/v

[PATCH 25/28] drm/virtgpu: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: David Airlie Cc: Gerd Hoffmann Cc: Gurchetan Singh Cc: Chia-I Wu --- drivers/gp

[PATCH 22/28] drm/cirrus: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file ch

[PATCH 12/28] drm/nouveau: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Karol Herbst Cc: Lyude Paul Cc: Danilo Krummrich --- drivers/gpu/drm/no

[PATCH 10/28] drm/mgag200: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Jocelyn Falempe --- drivers/gpu/drm/mgag200/mgag200_drv.c | 4 ++

[PATCH 23/28] drm/vboxvideo: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_drv.c | 5 +++-- 1 file chang

[PATCH 02/28] drm/arm/hdlcd: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Liviu Dudau --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- 1 file changed, 2 inser

[PATCH 20/28] drm/tegra: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Thierry Reding Cc: Mikko Perttunen Cc: Jonathan Hunter --- drivers/gpu/drm/tegra/

[PATCH 18/28] drm/stm: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Yannick Fertre Cc: Raphael Gallais-Pou Cc: Philippe Cornu Cc: Maxime Coqueli

[PATCH 16/28] drm/rockchip: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Sandy Huang Cc: "Heiko Stübner" Cc: Andy Yan --- drivers/g

[PATCH 19/28] drm/sun4i: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: Jernej Skrabec Cc: Samuel Holland --- driver

[PATCH 08/28] drm/loongson: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_drv.c | 8 1 file chang

[PATCH 15/28] drm/radeon: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers

[PATCH 17/28] drm/simpledrm: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/simpledrm.c | 8 +--- 1

[PATCH 13/28] drm/ofdrm: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Javier Martinez Canillas --- drivers/gpu/drm/tiny/ofdrm.c | 4 ++-- 1 file chang

[PATCH 11/28] drm/msm: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Su

[PATCH 14/28] drm/qxl: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Dave Airlie Cc: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_drv.c | 4 ++-- 1 file ch

[PATCH 06/28] drm/hyperv-drm: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Deepak Rawat --- drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 4 ++-- 1 file chang

[PATCH 09/28] drm/meson: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl --- dr

[PATCH 07/28] drm/i915: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Tvrtko Ursulin --- driver

[PATCH 01/28] drm/amdgpu: Use video aperture helpers

DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Alex Deucher Cc: "Christian König" Cc: Xinhui Pan --- drivers/gpu

[PATCH 00/28] drm: Remove DRM aperture helpers

ectly. No functional changes intended. This series should replace one interface with another. Individual patches could go into the various trees and the DRM wrappers can be removed when all driver changes have been merged. Thomas Zimmermann (28): drm/amdgpu: Use video aperture helpers drm/arm/

Re: [PATCH 0/5] drm: Introduce DRM client library

Hi Am 30.09.24 um 13:46 schrieb Jocelyn Falempe: On 27/09/2024 16:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_cli

Re: [PATCH 0/5] drm: Introduce DRM client library

Hi Am 27.09.24 um 21:27 schrieb Felix Kuehling: On 2024-09-27 10:37, Thomas Zimmermann wrote: With the next DRM client coming soon (drm_log) and most of DRM's fbdev emulation consolidated in a few places, it's time to provide a single place for the clients. The new module drm_cli

[PATCH 0/5] drm: Introduce DRM client library

client support, but the presence of the client module depends on the user's kernel configuration. Without selected clients, no client module will be build. Thomas Zimmermann (5): drm/i915: Select DRM_CLIENT_SELECTION drm/xe: Select DRM_CLIENT_SELECTION drm: Move client-device functions in

[PATCH 4/5] drm: Select fbdev helpers for modules that require them

Fbdev emulation for SHMEM and TTM requires helpers from the fbdev subsystem. Select them from the modules that use them instead of the core DRM module. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 1/5] drm/i915: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from i915. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/i915/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig index

[PATCH 2/5] drm/xe: Select DRM_CLIENT_SELECTION

The Kconfig token DRM_CLIENT_SELECTION will make DRM clients available to drivers. Select it from xe. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/xe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig index ebd0879e04d4

  1   2   3   4   5   6   7   8   9   10   >