Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Takashi Iwai
.org/ > > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > Cc: Linus Torvalds > Cc: Julia Lawall > Signed-off-by: Steven Rostedt (Google) For the sound part Acked-by: Takashi Iwai thanks, Takashi

Re: [PATCH 2/5] ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code

2023-08-25 Thread Takashi Iwai
On Fri, 25 Aug 2023 08:27:11 +0200, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Should be no functional change > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Fred Oh > Cc: Pierre-Louis Bossart > Cc: Kai Vehmanen > Cc: Bjorn Helgaas > Signed-off-

Re: Missing AMDGPU drm-fixes-6.4 merges

2023-07-05 Thread Takashi Iwai
On Wed, 05 Jul 2023 14:17:20 +0200, Alex Deucher wrote: > > On Wed, Jul 5, 2023 at 2:26 AM Takashi Iwai wrote: > > > > Hi Dave, Alex, > > > > it seems that the last PR for AMDGPU 6.4 fixes wasn't taken by Linus > > due to the missing signed tag: >

Missing AMDGPU drm-fixes-6.4 merges

2023-07-04 Thread Takashi Iwai
Hi Dave, Alex, it seems that the last PR for AMDGPU 6.4 fixes wasn't taken by Linus due to the missing signed tag: https://lore.kernel.org/lkml/CAHk-=wiOCgiwzVPOwORHPML9eBphnbtM2DhRcv+v=-tnrrg...@mail.gmail.com/ And more importantly, this series isn't seen on linux-next, either; so the whole f

Re: [PATCH] ALSA: hda/hdmi: Use only dynamic PCM device allocation

2022-12-25 Thread Takashi Iwai
On Sun, 25 Dec 2022 13:14:28 +0100, Michael Laß wrote: > > CC'ing amd-gfx as this might be an issue in the amd driver. > > This change causes a regression in Linux 6.1 at least on some AMD APUs. > There are reports from users with Ryzen 4750U, 5800U and 5850U chips > where the HDMI sound devices

[PATCH] drm: radeon: Fix audio get_eld callback

2022-11-10 Thread Takashi Iwai
/-/issues/2236 Signed-off-by: Takashi Iwai --- Note: this is the additional fix on top of the previously submitted audio component support for radeon. drivers/gpu/drm/radeon/radeon_audio.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon

Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for more AMD display audio

2022-11-08 Thread Takashi Iwai
On Tue, 08 Nov 2022 09:47:46 +0100, Evan Quan wrote: > > We are able to power down the GPU and audio via the GPU driver > so flag these asics as supporting runtime pm. > > Signed-off-by: Evan Quan > Change-Id: Ib7ea9bfe7b62b98afd63f96a2d98795504e7ae04 Applied now. I dropped the useless change-

[5.12 regression] ttm->pages NULL dereference with radeon driver

2021-05-07 Thread Takashi Iwai
Hi, we've received a regression report showing NULL dereference Oops with radeon driver on 5.12 kernel: https://bugzilla.opensuse.org/show_bug.cgi?id=1185516 It turned out that the recent TTM cleanup / refactoring via commit 0575ff3d33cd ("drm/radeon: stop using pages with drm_prime_sg_to_page_

Re: [PATCH 1/2] drm/amd/display: Fix the brightness read via aux

2021-02-06 Thread Takashi Iwai
On Fri, 05 Feb 2021 17:36:44 +0100, Alex Deucher wrote: > > On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > > > The current code tries to read the brightness value via > > dc_link_get_backlight_level() no matter whether it's controlled via > > aux or not

Re: [PATCH 2/2] drm/amd/display: Add aux_backlight module option

2021-02-06 Thread Takashi Iwai
On Fri, 05 Feb 2021 17:34:36 +0100, Alex Deucher wrote: > > On Wed, Feb 3, 2021 at 7:42 AM Takashi Iwai wrote: > > > > There seem devices that don't work with the aux channel backlight > > control. For allowing such users to test with the other backlight > > c

[PATCH 2/2] drm/amd/display: Add aux_backlight module option

2021-02-03 Thread Takashi Iwai
rt is detected by the hardware capability. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 0/2] drm/amd/display: some backlight fixes

2021-02-03 Thread Takashi Iwai
control. It's no direct solution for the bug we've hit, but it gives at least a workaround. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 thanks, Takashi === Takashi Iwai (2): drm/amd/display: Fix the

[PATCH 1/2] drm/amd/display: Fix the brightness read via aux

2021-02-03 Thread Takashi Iwai
https://bugzilla.opensuse.org/show_bug.cgi?id=1180749 BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1438 Signed-off-by: Takashi Iwai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdg

Re: [PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE

2021-01-26 Thread Takashi Iwai
bios.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_bios.c | 4 ++-- > drivers/hwmon/acpi_power_meter.c | 4 ++-- > drivers/platform/x86/asus-laptop.c | 6 +++--- > drivers/spi/spi.c | 2 +- > sound/pci/hda/hda_intel.c| 4 ++-- For the sound/*

Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio

2021-01-12 Thread Takashi Iwai
On Tue, 12 Jan 2021 16:03:41 +0100, Alex Deucher wrote: > > On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai wrote: > > > > On Tue, 05 Jan 2021 18:52:45 +0100, > > Alex Deucher wrote: > > > > > > We are able to power down the GPU and audio via the GPU driv

Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio

2021-01-12 Thread Takashi Iwai
On Tue, 05 Jan 2021 18:52:45 +0100, Alex Deucher wrote: > > We are able to power down the GPU and audio via the GPU driver > so flag these asics as supporting runtime pm. > > Reviewed-by: Evan Quan > Signed-off-by: Alex Deucher I wanted to apply this one now, but noticed that the author addres

[PATCH 2/3] drm/amd/display: Don't invoke kgdb_breakpoint() unconditionally

2020-10-23 Thread Takashi Iwai
tfall, make the kgdb_breakpoint() call only when CONFIG_DEBUG_KERNEL_DC is set. https://bugzilla.opensuse.org/show_bug.cgi?id=1177973 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/dc/os_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH 1/3] drm/amd/display: Fix kernel panic by dal_gpio_open() error

2020-10-23 Thread Takashi Iwai
(), for allowing the debugging, instead. BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1177973 Cc: Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/dc/gpio/gpio_base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio

[PATCH 0/3] drm/amd/display: Fix kernel panic by breakpoint

2020-10-23 Thread Takashi Iwai
Hi, the amdgpu driver's ASSERT_CRITICAL() macro calls the kgdb_breakpoing() even if no debug option is set, and this leads to a kernel panic on distro kernels. The first two patches are the oneliner fixes for those, while the last one is the cleanup of those debug macros. Takashi === Ta

[PATCH 3/3] drm/amd/display: Clean up debug macros

2020-10-23 Thread Takashi Iwai
. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/Kconfig | 1 + drivers/gpu/drm/amd/display/dc/os_types.h | 33 +++ 2 files changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display

Re: kgdb_breakpoint() usage leads to kernel panic

2020-10-23 Thread Takashi Iwai
On Thu, 22 Oct 2020 11:03:43 +0200, Takashi Iwai wrote: > > Hi, > > we recently stumbled on a kernel crash in amdgpu [*], and the kernel > messages indicated that it's from kgdb_breakpoint() call in > ASSERT_CRITICAL() macro. > > Since CONFIG_KGDB=y is set on the

kgdb_breakpoint() usage leads to kernel panic

2020-10-22 Thread Takashi Iwai
Hi, we recently stumbled on a kernel crash in amdgpu [*], and the kernel messages indicated that it's from kgdb_breakpoint() call in ASSERT_CRITICAL() macro. Since CONFIG_KGDB=y is set on the openSUSE distro kernels, the breakpoint is enabled even though CONFIG_DEBUG_KERNEL_DC=n, and this leads t

Re: [PATCH] sound/pci/hda: add sienna_cichlid audio asic id for sienna_cichlid up

2020-06-03 Thread Takashi Iwai
On Wed, 03 Jun 2020 03:31:37 +0200, Alex Deucher wrote: > > From: Hersen Wu > > dp/hdmi ati hda is not shown in audio settings > > Signed-off-by: Hersen Wu > Reviewed-by: Alex Deucher > Signed-off-by: Alex Deucher Applied now with a slight rearrangement with the sorted order and Cc to stabl

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-05-02 Thread Takashi Iwai
On Sat, 02 May 2020 09:27:31 +0200, Takashi Iwai wrote: > > On Sat, 02 May 2020 09:17:28 +0200, > Lukas Wunner wrote: > > > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > >

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-05-02 Thread Takashi Iwai
On Sat, 02 May 2020 09:17:28 +0200, Lukas Wunner wrote: > > On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote: > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -673

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-05-02 Thread Takashi Iwai
On Thu, 30 Apr 2020 19:49:03 +0200, Takashi Iwai wrote: > > On Thu, 30 Apr 2020 19:38:16 +0200, > Nicholas Johnson wrote: > > > > On Thu, Apr 30, 2020 at 07:01:08PM +0200, Takashi Iwai wrote: > > > On Thu, 30 Apr 2020 18:52:20 +0200, > > > Nicholas Johnson

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-30 Thread Takashi Iwai
On Thu, 30 Apr 2020 19:38:16 +0200, Nicholas Johnson wrote: > > On Thu, Apr 30, 2020 at 07:01:08PM +0200, Takashi Iwai wrote: > > On Thu, 30 Apr 2020 18:52:20 +0200, > > Nicholas Johnson wrote: > > > > > > On Thu, Apr 30, 2020 at 05:14:56PM +0200, Takashi Iwa

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-30 Thread Takashi Iwai
On Thu, 30 Apr 2020 18:52:20 +0200, Nicholas Johnson wrote: > > On Thu, Apr 30, 2020 at 05:14:56PM +0200, Takashi Iwai wrote: > > On Wed, 29 Apr 2020 18:19:57 +0200, > > Alex Deucher wrote: > > > > > > On Wed, Apr 29, 2020 at 12:05 PM Takashi Iwai wrote: >

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-30 Thread Takashi Iwai
On Wed, 29 Apr 2020 18:19:57 +0200, Alex Deucher wrote: > > On Wed, Apr 29, 2020 at 12:05 PM Takashi Iwai wrote: > > Well, but the code path there is the runtime PM resume of the audio > > device and it means that GPU must have been runtime-resumed again > > beforehand

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-29 Thread Takashi Iwai
On Wed, 29 Apr 2020 17:47:47 +0200, Alex Deucher wrote: > > On Wed, Apr 29, 2020 at 11:27 AM Nicholas Johnson > wrote: > > > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > > On Tue, 28 Apr 2020 16:48:45 +0200

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-29 Thread Takashi Iwai
On Wed, 29 Apr 2020 17:27:17 +0200, Nicholas Johnson wrote: > > On Wed, Apr 29, 2020 at 09:37:41AM +0200, Takashi Iwai wrote: > > On Tue, 28 Apr 2020 16:48:45 +0200, > > Nicholas Johnson wrote: > > > > > > > > > > > > > > > >

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-29 Thread Takashi Iwai
On Tue, 28 Apr 2020 16:48:45 +0200, Nicholas Johnson wrote: > > > > > > > > > > > FWIW, I have a fiji board in a desktop system and it worked fine when > > > > > this code was enabled. > > > > > > > > Is the new DC code used for Fiji boards? IIRC, the audio component > > > > binding from amdgpu i

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-28 Thread Takashi Iwai
On Mon, 27 Apr 2020 20:43:54 +0200, Alex Deucher wrote: > > On Mon, Apr 27, 2020 at 2:39 PM Takashi Iwai wrote: > > > > On Mon, 27 Apr 2020 20:28:12 +0200, > > Alex Deucher wrote: > > > > > > On Mon, Apr 27, 2020 at 2:07 PM Nicholas Johnson > > &

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-27 Thread Takashi Iwai
On Mon, 27 Apr 2020 20:28:12 +0200, Alex Deucher wrote: > > On Mon, Apr 27, 2020 at 2:07 PM Nicholas Johnson > wrote: > > > > On Mon, Apr 27, 2020 at 05:15:55PM +0200, Takashi Iwai wrote: > > > On Mon, 27 Apr 2020 16:22:21 +0200, > > > Deucher, Alexander

Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

2020-04-27 Thread Takashi Iwai
On Mon, 27 Apr 2020 16:22:21 +0200, Deucher, Alexander wrote: > > [AMD Public Use] > > > -Original Message- > > From: Nicholas Johnson > > Sent: Sunday, April 26, 2020 12:02 PM > > To: linux-ker...@vger.kernel.org > > Cc: Deucher, Alexander ; Koenig, Christian > > ; Zhou, David(ChunMing)

Re: [PATCH 1/5] drm/amdgpu/pm: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
BTW, please ignore the subject prefix '[1/5]', which was added mistakenly while extracting a patch from the commit list. This is a single patch. thanks, Takashi On Wed, 11 Mar 2020 08:29:04 +0100, Takashi Iwai wrote: > > Since snprintf() returns the would-be-output siz

[PATCH 1/5] drm/amdgpu/pm: Use scnprintf() for avoiding potential buffer overflow

2020-03-11 Thread Takashi Iwai
length. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index bc3cf04a1a94..4a737d074f4b 100644 --- a/drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amd/display: Fix wrongly passed static prefix

2020-02-05 Thread Takashi Iwai
On Thu, 28 Nov 2019 15:35:23 +0100, Harry Wentland wrote: > > On 2019-11-28 3:27 a.m., Takashi Iwai wrote: > > Currently, gcc spews a warning as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hubbub.c: In > > function ‘hubbub1_verify_allow_pstate_change_hi

Re: [PATCH] ALSA: hda/hdmi - fix atpx_present when CLASS is not VGA

2019-12-21 Thread Takashi Iwai
On Sat, 21 Dec 2019 01:17:02 +0100, Alex Deucher wrote: > > You can't use PCI_BASE_CLASS with pci_get_class(). This > happens to work by luck on devices with PCI_CLASS_DISPLAY_VGA, but > misses PCI_CLASS_DISPLAY_OTHER. Add a check for those as well. > > Signed-off-by: Alex Deucher Applied, th

[PATCH] drm/amd/display: Fix wrongly passed static prefix

2019-11-28 Thread Takashi Iwai
create new files for hubbub functions") Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10

Re: [PATCH 0/4] add runtime pm support for AMD display audio

2019-11-26 Thread Takashi Iwai
On Tue, 26 Nov 2019 16:31:37 +0100, Alex Deucher wrote: > > On Tue, Nov 26, 2019 at 9:53 AM Takashi Iwai wrote: > > > > On Mon, 25 Nov 2019 15:40:43 +0100, > > Alex Deucher wrote: > > > > > > On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai wrote: > >

Re: [PATCH 0/4] add runtime pm support for AMD display audio

2019-11-26 Thread Takashi Iwai
On Mon, 25 Nov 2019 15:40:43 +0100, Alex Deucher wrote: > > On Sat, Nov 23, 2019 at 3:57 AM Takashi Iwai wrote: > > > > On Fri, 22 Nov 2019 22:43:49 +0100, > > Alex Deucher wrote: > > > > > > These patches were originally part of a larger set of patches

Re: [PATCH 0/4] add runtime pm support for AMD display audio

2019-11-23 Thread Takashi Iwai
On Fri, 22 Nov 2019 22:43:49 +0100, Alex Deucher wrote: > > These patches were originally part of a larger set of patches > to enabled runtime pm support on the GPU side[1]. However, the > patches are useful on their own there are really no dependencies, > other than the fact that you need both f

Re: [PATCH 21/21] ALSA: hda/hdmi - enable automatic runtime pm for AMD HDMI codecs by default

2019-10-28 Thread Takashi Iwai
On Mon, 28 Oct 2019 22:42:16 +0100, Alex Deucher wrote: > > So that we can power down the GPU and audio to save power. > > Acked-by: Evan Quan > Signed-off-by: Alex Deucher Reviewed-by: Takashi Iwai thanks, Takashi ___ amd-gfx m

Re: [PATCH 20/21] ALSA: hda/hdmi - enable runtime pm for newer AMD display audio

2019-10-28 Thread Takashi Iwai
g the new pci ids Reviewed-by: Takashi Iwai thanks, Takashi ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 19/21] ALSA: hda/hdmi - Add new pci ids for AMD GPU display audio

2019-10-28 Thread Takashi Iwai
On Mon, 28 Oct 2019 22:42:14 +0100, Alex Deucher wrote: > > These are needed so we can enable runtime pm in a subsequent > patch. > > Signed-off-by: Alex Deucher Reviewed-by: Takashi Iwai thanks, Takashi ___ amd-gfx maili

Re: [PATCH 18/21] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD

2019-10-28 Thread Takashi Iwai
On Mon, 28 Oct 2019 22:42:13 +0100, Alex Deucher wrote: > > @@ -35,6 +35,11 @@ > #include > #include > #include > +#ifdef SUPPORT_VGA_SWITCHEROO > +#ifdef CONFIG_ACPI > +#include > +#endif > +#endif I don't think we need ifdefs here. Other than that,

Re: [PATCH 17/19] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD

2019-10-17 Thread Takashi Iwai
On Fri, 11 Oct 2019 03:45:34 +0200, Alex Deucher wrote: > > Only enable the vga_switcheroo logic on systems with the > ATPX ACPI method. This logic is not needed for asics > that are not part of a PX (PowerXpress)/HG (Hybrid Graphics) > platform. > > Signed-off-by: Alex Deucher > --- > sound/p

Re: [PATCH 18/19] ALSA: hda/hdmi - enable runtime pm for newer AMD display audio

2019-10-17 Thread Takashi Iwai
On Fri, 11 Oct 2019 03:45:35 +0200, Alex Deucher wrote: > > We are able to power down the GPU and audio via the GPU driver > so flag these asics as supporting runtime pm. > > Signed-off-by: Alex Deucher Sorry for the late reply, as I've been off for the last few weeks. The change itself looks

Re: [PATCH 2/2] drm/amd/display: Add drm_audio_component support to amdgpu_dm

2019-07-19 Thread Takashi Iwai
On Wed, 17 Jul 2019 15:32:55 +0200, Takashi Iwai wrote: > > On Wed, 10 Jul 2019 16:36:19 +0200, > Takashi Iwai wrote: > > > > On Wed, 10 Jul 2019 16:31:40 +0200, > > Kazlauskas, Nicholas wrote: > > > > > > On 7/10/19 9:48 AM, Takashi Iwai wrot

Re: [PATCH 2/2] drm/amd/display: Add drm_audio_component support to amdgpu_dm

2019-07-17 Thread Takashi Iwai
On Wed, 10 Jul 2019 16:36:19 +0200, Takashi Iwai wrote: > > On Wed, 10 Jul 2019 16:31:40 +0200, > Kazlauskas, Nicholas wrote: > > > > On 7/10/19 9:48 AM, Takashi Iwai wrote: > > > On Tue, 09 Jul 2019 18:30:19 +0200, > > > Nicholas Kazlauska

Re: [PATCH 2/2] drm/amd/display: Add drm_audio_component support to amdgpu_dm

2019-07-10 Thread Takashi Iwai
On Wed, 10 Jul 2019 16:31:40 +0200, Kazlauskas, Nicholas wrote: > > On 7/10/19 9:48 AM, Takashi Iwai wrote: > > On Tue, 09 Jul 2019 18:30:19 +0200, > > Nicholas Kazlauskas wrote: > >> > >> [Why] > >> The drm_audio_component can be used to give pin

Re: [PATCH 2/2] drm/amd/display: Add drm_audio_component support to amdgpu_dm

2019-07-10 Thread Takashi Iwai
ually occurs, however. > We wait until after all the programming is complete rather than sending > the notification mid sequence. > > Particular care is needed for the get ELD callback since it can happen > outside the locking and fencing DRM does for atomic commits. > > Cc:

[PATCH] drm/amdgpu: Add missing firmware entry for HAINAN

2018-11-19 Thread Takashi Iwai
Due to lack of MODULE_FIRMWARE() with hainan_mc.bin, the driver doesn't work properly in initrd. Let's add it. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1116239 Fixes: 8eaf2b1faaf4 ("drm/amdgpu: switch firmware path for SI parts") Cc: Signed-off-by: Takashi Iwai

Re: y4T�TCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread Takashi Iwai
On Wed, 25 Jul 2018 10:02:34 +0200, jimqu wrote: > > > > On 2018年07月25日 13:46, Takashi Iwai wrote: > > On Wed, 25 Jul 2018 07:38:37 +0200, > > Qu, Jim wrote: > >> Jim: Just like Alex said, we want driver can get eld info when hotplug in > >> new

Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: > > Jim: Just like Alex said, we want driver can get eld info when hotplug in new > device. amdgpu driver is a bit difference from radeon driver, it is not a > suitable place to call notify() function in *_audio_enable() , since they are > not

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread Takashi Iwai
On Wed, 25 Jul 2018 05:32:52 +0200, Qu, Jim wrote: > @@ -269,6 +271,10 @@ static void radeon_audio_enable(struct radeon_device > *rdev, > > if (rdev->audio.funcs->enable) > rdev->audio.funcs->enable(rdev, pin, enable_mask); > + > + if (acomp && acomp->audio_ops && ac

Re: [PATCH 0/4] drm_audio_component support for AMD/ATI HDMI codecs

2018-07-23 Thread Takashi Iwai
On Mon, 23 Jul 2018 22:53:08 +0200, Alex Deucher wrote: > > On Mon, Jul 23, 2018 at 10:50 AM, Takashi Iwai wrote: > > Hi, > > > > this is a patch set to add the support of drm_audio_component for > > AMD/ATI HDMI codecs. With the drm_audio_component, the HDMI/DP

[PATCH 2/4] ALSA: hda/hdmi: Allow audio component for AMD/ATI HDMI

2018-07-23 Thread Takashi Iwai
patch, the DRM component in radeon and amdgpu DRM driver sides isn't implemented yet, so this change won't give any benefit alone. By the following changes in DRM sides, the mission will be completed. Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_hdmi.c | 142

[PATCH 0/4] drm_audio_component support for AMD/ATI HDMI codecs

2018-07-23 Thread Takashi Iwai
yet. Takashi === Takashi Iwai (4): ALSA: hda/hdmi: Use single mutex unlock in error paths ALSA: hda/hdmi: Allow audio component for AMD/ATI HDMI drm/radeon: Add audio component support drm/amdgpu: Add audio component support drivers/gpu/drm/Kconfig | 2 + drivers/gpu

[PATCH 1/4] ALSA: hda/hdmi: Use single mutex unlock in error paths

2018-07-23 Thread Takashi Iwai
further changes. Signed-off-by: Takashi Iwai --- sound/pci/hda/patch_hdmi.c | 67 +++--- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 1de5491fb9bf..6750318d1c82 100644 --- a/sound/pci/hda

[PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-23 Thread Takashi Iwai
connector->eld contents. This patch currently doesn't contain the component support for the new DC codes yet. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/amd/amdgpu/Makefile | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 +

[PATCH 3/4] drm/radeon: Add audio component support

2018-07-23 Thread Takashi Iwai
->eld contents. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/Kconfig | 1 + drivers/gpu/drm/radeon/radeon.h | 3 + drivers/gpu/drm/radeon/radeon_audio.c | 79 +++ 3 files changed, 83 insertions(+) diff --git a/drivers/gpu/drm/Kconfig b/drivers/

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread Takashi Iwai
On Tue, 17 Jul 2018 10:56:37 +0200, jimqu wrote: > > > > On 2018年07月17日 16:52, Takashi Iwai wrote: > > On Tue, 17 Jul 2018 10:38:58 +0200, > > Lukas Wunner wrote: > >> On Tue, Jul 17, 2018 at 04:20:50PM +0800, Jim Qu wrote: > >>> On modern laptop,

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread Takashi Iwai
On Tue, 17 Jul 2018 10:38:58 +0200, Lukas Wunner wrote: > > On Tue, Jul 17, 2018 at 04:20:50PM +0800, Jim Qu wrote: > > On modern laptop, there are more and more platforms > > have two GPUs, and each of them maybe have audio codec > > for HDMP/DP output. For some dGPU which is no output, > > audio

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-16 Thread Takashi Iwai
On Mon, 16 Jul 2018 17:10:43 +0200, Harry Wentland wrote: > > > > On 2018-07-15 10:36 AM, Alex Deucher wrote: > > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: > >> On Sat, 14 Jul 2018 14:03:26 +0200, > >> jimqu wrote: > >>> >

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Takashi Iwai
On Mon, 16 Jul 2018 16:43:42 +0200, Lukas Wunner wrote: > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > + > > + list_for_each_entry(client, &vgasr_priv.clients, list) { > > + if (!client_is_audio(client) || client_id(client) != > > + VGA_SWITCHEROO_UNK

Re: [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread Takashi Iwai
ne wants this through another tree inevitably, let me know. In that case, fell free to take my reviewed-by tag: Reviewed-by: Takashi Iwai thanks, Takashi > --- > drivers/gpu/vga/vga_switcheroo.c | 39 +-- > include/linux/vga_switche

Re: [V2 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to replace PCI_CLASS_DISPLAY_VGA

2018-07-16 Thread Takashi Iwai
On Mon, 16 Jul 2018 08:06:34 +0200, Jim Qu wrote: > > Except PCI_CLASS_DISPLAY_VGA, some PCI class is sometimes > PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER. > > Signed-off-by: Jim Qu Applied this one now, as it's basically an individual fix. thanks, Takashi

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-14 Thread Takashi Iwai
On Sat, 14 Jul 2018 14:03:26 +0200, jimqu wrote: > > > > 在 2018/7/13 23:07, Takashi Iwai 写道: > > On Wed, 11 Jul 2018 13:12:01 +0200, > > Takashi Iwai wrote: > >> And the forced runtime PM is still an issue, and this would need the > >> other notificati

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Takashi Iwai
On Fri, 13 Jul 2018 17:25:39 +0200, jimqu wrote: > > > > 在 2018/7/13 16:46, Takashi Iwai 写道: > > On Fri, 13 Jul 2018 10:06:02 +0200, > > Jim Qu wrote: > >> On modern laptop, there are more and more platforms > >> have two GPUs, and each of them mayb

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-13 Thread Takashi Iwai
On Wed, 11 Jul 2018 13:12:01 +0200, Takashi Iwai wrote: > > And the forced runtime PM is still an issue, and this would need the > other notification mechanism than the HD-audio unsolicited event as > AMD HDMI controller doesn't honor the HD-audio WAKEEN bit. Since we had a ni

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread Takashi Iwai
On Fri, 13 Jul 2018 10:06:02 +0200, Jim Qu wrote: > > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it will se

Re: [alsa-devel] [PATCH 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to cover more display adapters

2018-07-13 Thread Takashi Iwai
On Fri, 13 Jul 2018 10:06:01 +0200, Jim Qu wrote: > > Signed-off-by: Jim Qu More explanations please. e.g. why is this needed? The code change itself looks good, but ... > @@ -31,7 +31,7 @@ > * CHANGES: > * > * 2004.12.01 Major rewrite by tiwai, merged the work of pshou > - * >

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Wed, 11 Jul 2018 12:21:03 +0200, jimqu wrote: > > > > On 2018年07月11日 17:53, Takashi Iwai wrote: > > On Wed, 11 Jul 2018 11:26:11 +0200, > > jimqu wrote: > >> > >> > >> On 2018年07月11日 17:04, Takashi Iwai wrote: > >>> On Wed, 11 Ju

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Wed, 11 Jul 2018 11:26:11 +0200, jimqu wrote: > > > > On 2018年07月11日 17:04, Takashi Iwai wrote: > > On Wed, 11 Jul 2018 10:41:38 +0200, > > jimqu wrote: > >> > >> > >> On 2018年07月11日 15:19, Takashi Iwai wrote: > >>> On Tue, 10 Ju

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: > > > > On 2018年07月11日 15:19, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 13:21:00 +0200, > > Takashi Iwai wrote: > >>> revert the fix of amdgpu suspend issue, audio issue also can be observed. > >> D

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread Takashi Iwai
On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: > > > revert the fix of amdgpu suspend issue, audio issue also can be observed. > > Did you check the behavior with the single AMD GPU hardware? > If confirmed, we can forget about vga_switcheroo. ... and taking a look

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
On Tue, 10 Jul 2018 13:11:20 +0200, jimqu wrote: > > > > On 2018年07月10日 17:50, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 11:13:27 +0200, > > jimqu wrote: > >> > >> > >> On 2018年07月10日 16:01, Takashi Iwai wrote: > >>> On Tue, 10

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: > > > > On 2018年07月10日 16:01, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 09:44:42 +0200, > > Qu, Jim wrote: > >> Hi Takashi, > >> > >> I am not expert in audio driver, so I just update s

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread Takashi Iwai
ction and ELD query is performed at the end of codec resume, hence it'll be covered there. So in theory, ELD information should be passed from the GPU to HD-audio no matter whether runtime PM is enabled or not. BTW, please stop top-posting. It makes the thread readability awfully worse. t

Re: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
he given device? Does the driver give the proper ELD bytes as well as the jack state? Takashi > > Thanks > JimQu > > -邮件原件- > 发件人: Takashi Iwai > 发送时间: 2018年7月9日 23:58 > 收件人: Daniel Vetter > 抄送: Alex Deucher ; alsa-de...@alsa-project.org; > amd-gfx@lists

Re: 答复: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 18:03:48 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 11:57 AM, Takashi Iwai wrote: > > On Mon, 09 Jul 2018 17:53:19 +0200, > > Qu, Jim wrote: > >> > >> Hi All, > >> > >> Here, I want to clarify the audio devi

Re: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 18:15:32 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 12:06 PM, Lukas Wunner wrote: > > On Mon, Jul 09, 2018 at 05:52:49PM +0200, Takashi Iwai wrote: > >> On Mon, 09 Jul 2018 17:47:34 +0200, Lukas Wunner wrote: > >> > Since v4.17,

Re: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 17:59:00 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 11:52 AM, Takashi Iwai wrote: > > On Mon, 09 Jul 2018 17:47:34 +0200, > > Lukas Wunner wrote: > >> > >> On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote: > >&g

Re: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 17:56:43 +0200, Daniel Vetter wrote: > > On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote: > > On Mon, 09 Jul 2018 15:58:51 +0200, > > Alex Deucher wrote: > > > > > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote: > > &g

Re: 答复: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
o audio codec on discrete GPU...? Why do we need vga_switcheroo at all, then? Takashi > > Thanks > JimQu > > -邮件原件- > 发件人: Lukas Wunner > 发送时间: 2018年7月9日 23:48 > 收件人: Takashi Iwai > 抄送: Alex Deucher ; alsa-de...@alsa-project.org;

Re: [alsa-devel] ??????: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 17:47:34 +0200, Lukas Wunner wrote: > > On Mon, Jul 09, 2018 at 05:04:22PM +0200, Takashi Iwai wrote: > > On Mon, 09 Jul 2018 15:58:51 +0200, Alex Deucher wrote: > > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote: > > > > > You're s

Re: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 16:02:48 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote: > > Hi Lukas, > > > > Thanks to your explanation, and see comments in line. > > > > > > Do you need to runtime resume the HDA controller even if user space isn't > > streaming audio? Why, a

Re: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-09 Thread Takashi Iwai
On Mon, 09 Jul 2018 15:58:51 +0200, Alex Deucher wrote: > > On Mon, Jul 9, 2018 at 6:16 AM, Qu, Jim wrote: > > Hi Lukas, > > > > Thanks to your explanation, and see comments in line. > > > > > > Do you need to runtime resume the HDA controller even if user space isn't > > streaming audio? Why, a

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Takashi Iwai
On Tue, 03 Apr 2018 11:18:34 +0200, Michel D4nzer wrote: > > On 2018-04-03 11:02 AM, Takashi Iwai wrote: > > On Tue, 03 Apr 2018 10:57:56 +0200, > > Christian K6nig wrote: > >> > >> Am 03.04.2018 um 10:36 schrieb Michel Dänzer: > >>> On 2018-04-01 0

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-03 Thread Takashi Iwai
On Tue, 03 Apr 2018 10:57:56 +0200, Christian K6nig wrote: > > Am 03.04.2018 um 10:36 schrieb Michel Dänzer: > > On 2018-04-01 07:45 PM, Ilia Mirkin wrote: > >> On Sun, Apr 1, 2018 at 1:39 PM, Christian König > >> wrote: > >>> Am 30.03.2018 um 22:45

Re: [PATCH 2/2] drm/amdgpu: Add modeset module option

2018-04-01 Thread Takashi Iwai
On Sun, 01 Apr 2018 19:58:11 +0200, Christian K6nig wrote: > > Am 01.04.2018 um 19:45 schrieb Ilia Mirkin: > > On Sun, Apr 1, 2018 at 1:39 PM, Christian König > > wrote: > >> Am 30.03.2018 um 22:45 schrieb Takashi Iwai: > >>> amdgpu driver lacks of modeset

[PATCH 1/2] drm/amdgpu: Fix memory leaks at amdgpu_init() error path

2018-03-30 Thread Takashi Iwai
amdgpu driver checks vgacon_text_force() after some initializations but without cleaning up. This will result in leaks. Move the check of vgacon_text_force() to the beginning of amdgpu_init() for fixing it and also for optimization. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/amdgpu

[PATCH 2/2] drm/amdgpu: Add modeset module option

2018-03-30 Thread Takashi Iwai
piece. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index e55792d3cd12..029d95ecd26b 100644 --- a/drivers/gpu/drm

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Takashi Iwai
| 6 +++--- > kernel/trace/trace_printk.c | 4 ++-- > lib/raid6/sse2.c | 14 +++--- > sound/soc/fsl/fsl_dma.c | 2 +- For sound bits, Acked-by: Takashi Iwai thanks, T

Re: [PATCH] drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp

2017-07-19 Thread Takashi Iwai
On Tue, 18 Jul 2017 22:53:48 +0200, Michel D4nzer wrote: > > On 18/07/17 11:20 AM, Takashi Iwai wrote: > > From: Egbert Eich > > > > The radeon driver reduces the framebuffer resolution to 8bpp if a > > device with less than 32MB VRAM is found. This causes the f

[PATCH] drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp

2017-07-18 Thread Takashi Iwai
Signed-off-by: Takashi Iwai --- This has been included in SUSE kernel for quite some time, and I'm trying to upstream this. The 16bpp looks more reasonable nowadays, but I know this is a matter of taste, too. It'd be great if you guys can comment on this, at least, whether it's