[PATCH] drm/amdgpu: fix the logic to validate fpriv and root bo

2025-07-09 Thread Sunil Khatri
which makes an NULL dereference in case fpriv is NULL. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202507090525.9rdwghz3-...@intel.com/ Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH] drm/amdgpu: fix MQD debugfs undefined symbol when DEBUG_FS=n

2025-07-08 Thread Sunil Khatri
Fix undefined reference to amdgpu_mqd_info_fops during debugfs_create_file if DEBUG_FS=n Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm

[PATCH v10 2/4] drm: add debugfs support on per client-id basis

2025-07-04 Thread Sunil Khatri
the client and create a symlink back to the parent drm device from each client. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/drm_debugfs.c | 81 +++ drivers/gpu/drm/drm_file.c| 11 + include/drm/drm_debugfs.h | 11

[PATCH v10 4/4] drm/amdgpu: add support of debugfs for mqd information

2025-07-04 Thread Sunil Khatri
Add debugfs support for mqd for each queue of the client. The address exposed to debugfs could be used to dump the mqd. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu

[PATCH v10 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-04 Thread Sunil Khatri
_root, hence to handle drm bridge debugfs add a new function which call drm_bridge_debugfs_params where drm_debugfs_root is accessible. Suggested-by: Christian König Signed-off-by: Sunil Khatri --- drivers/accel/drm_accel.c | 16 --- drivers/gpu/drm/drm_debugfs.c

[PATCH v10 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-07-04 Thread Sunil Khatri
Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 52

[PATCH v10 0/4] Enable debugfs information based on client-id

2025-07-04 Thread Sunil Khatri
the amdgpu_vm_init Sunil Khatri (4): drm: move drm based debugfs funcs to drm_debugfs.c drm: add debugfs support on per client-id basis drm/amdgpu: add debugfs support for VM pagetable per client drm/amdgpu: add support of debugfs for mqd information drivers/accel/drm_accel.c

[PATCH v9 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-07-01 Thread Sunil Khatri
Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 52 + drivers/gpu

[PATCH v9 4/4] drm/amdgpu: add support of debugfs for mqd information

2025-07-01 Thread Sunil Khatri
Add debugfs support for mqd for each queue of the client. The address exposed to debugfs could be used to dump the mqd. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu

[PATCH v9 2/4] drm: add debugfs support on per client-id basis

2025-07-01 Thread Sunil Khatri
the client and create a symlink back to the parent drm device from each client. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/drm_debugfs.c | 81 +++ drivers/gpu/drm/drm_file.c| 9 include/drm/drm_debugfs.h | 11

[PATCH v9 0/4] Enable debugfs information based on client-id

2025-07-01 Thread Sunil Khatri
moving the debugfs related information to drm_debugfs.c Sunil Khatri (4): drm: move drm based debugfs funcs to drm_debugfs.c drm: add debugfs support on per client-id basis drm/amdgpu: add debugfs support for VM pagetable per client drm/amdgpu: add support of debugfs for mqd information

[PATCH v9 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-01 Thread Sunil Khatri
igned-off-by: Sunil Khatri --- drivers/accel/drm_accel.c | 16 drivers/gpu/drm/drm_debugfs.c | 32 ++-- drivers/gpu/drm/drm_drv.c | 14 -- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_accel.h| 5 - includ

[PATCH v8 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-06-30 Thread Sunil Khatri
igned-off-by: Sunil Khatri --- drivers/accel/drm_accel.c | 16 drivers/gpu/drm/drm_debugfs.c | 32 ++-- drivers/gpu/drm/drm_drv.c | 14 -- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_accel.h| 5 - includ

[PATCH v8 2/4] drm: add debugfs support on per client-id basis

2025-06-30 Thread Sunil Khatri
the client and create a symlink back to the parent drm device from each client. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/drm_debugfs.c | 81 +++ drivers/gpu/drm/drm_file.c| 9 include/drm/drm_debugfs.h | 11

[PATCH v8 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-30 Thread Sunil Khatri
Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 52 + drivers/gpu

[PATCH v8 4/4] drm/amdgpu: add support of debugfs for mqd information

2025-06-30 Thread Sunil Khatri
Add debugfs support for mqd for each queue of the client. The address exposed to debugfs could be used to dump the mqd. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu

[PATCH v7 5/5] drm/amdgpu: add support of debugfs for mqd information

2025-06-30 Thread Sunil Khatri
Add debugfs support for mqd for each queue of the client. The address exposed to debugfs could be used to dump the mqd. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu

[PATCH v7 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-30 Thread Sunil Khatri
Move the debugfs accel driver code to the drm layer and it is an intermediate step to move all debugfs related handling into drm_debugfs.c Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/accel/drm_accel.c | 16 drivers/gpu/drm/drm_drv.c | 6

[PATCH v7 2/5] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-30 Thread Sunil Khatri
: Christian König Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 28 ++-- drivers/gpu/drm/drm_drv.c | 18 -- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_drv.h | 14 -- 4 files changed, 40 insertions

[PATCH v7 4/5] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-30 Thread Sunil Khatri
Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 52 + drivers/gpu

[PATCH v7 3/5] drm: add debugfs support on per client-id basis

2025-06-30 Thread Sunil Khatri
the client and create a symlink back to the parent drm device from each client. Signed-off-by: Sunil Khatri Reviewed-by: Christian König --- drivers/gpu/drm/drm_debugfs.c | 81 +++ drivers/gpu/drm/drm_file.c| 9 include/drm/drm_debugfs.h | 11

[PATCH v6 4/5] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-27 Thread Sunil Khatri
Add a debugfs file under the client directory which shares the root page table base address of the VM. This address could be used to dump the pagetable for debug memory issues. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu

[PATCH v6 2/5] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-27 Thread Sunil Khatri
: Christian König Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 33 +++-- drivers/gpu/drm/drm_drv.c | 19 +-- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_drv.h | 19 +-- 4 files changed, 51

[PATCH v6 3/5] drm: add debugfs support on per client-id basis

2025-06-27 Thread Sunil Khatri
the client and create a symlink back to the parent drm device from each client. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 80 +++ drivers/gpu/drm/drm_file.c| 9 include/drm/drm_debugfs.h | 11 + include/drm/drm_file.h

[PATCH v6 5/5] drm/amdgpu: add support of debugfs for mqd information

2025-06-27 Thread Sunil Khatri
Add debugfs support for mqd for each queue of the client. The address exposed to debugfs could be used to dump the mqd. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h | 1 + 2 files changed, 53

[PATCH v6 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-27 Thread Sunil Khatri
Move the debugfs accel driver code to the drm layer and it is an intermediate step to move all debugfs related handling into drm_debugfs.c Signed-off-by: Sunil Khatri --- drivers/accel/drm_accel.c | 16 drivers/gpu/drm/drm_drv.c | 6 +- include/drm/drm_accel.h | 5

[PATCH v5 4/5] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-25 Thread Sunil Khatri
base address of the VM under the client-id node along with the process information in debugfs. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 58 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +- 3

[PATCH v5 1/5] drm: move the debugfs accel driver code to drm layer

2025-06-25 Thread Sunil Khatri
move the debugfs accel driver code to the drm layer. This is first inline change to move the debugfs related changes for drm to drm_debugfs.c Signed-off-by: Sunil Khatri --- drivers/accel/drm_accel.c | 16 drivers/gpu/drm/drm_drv.c | 6 +- include/drm/drm_accel.h | 5

[PATCH v5 5/5] drm/amdgpu: add support of debugfs for mqd information

2025-06-24 Thread Sunil Khatri
add mqd support based on queue of for each client-id so the gpu address could be used to dump the mqd. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 52 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h | 1 + 2 files changed, 53 insertions

[PATCH v5 3/5] drm: add debugfs support on per client-id basis

2025-06-24 Thread Sunil Khatri
. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 26 ++ drivers/gpu/drm/drm_file.c| 6 ++ include/drm/drm_debugfs.h | 11 +++ include/drm/drm_file.h| 7 +++ 4 files changed, 50 insertions(+) diff --git a/drivers/gpu/drm

[PATCH v5 2/5] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-24 Thread Sunil Khatri
: Christian König Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 37 -- drivers/gpu/drm/drm_drv.c | 19 ++--- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_drv.h | 24 -- 4 files changed

[PATCH v4 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-18 Thread Sunil Khatri
base address of the VM under the client-id node along with the process information in debugfs. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 58 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +- 3

[PATCH v4 4/4] drm/amdgpu: add support of debugfs for mqd information

2025-06-18 Thread Sunil Khatri
add mqd support based on queue of for each client-id so the gpu address could be used to dump the mqd. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

[PATCH v4 2/4] drm: add debugfs support on per client-id basis

2025-06-18 Thread Sunil Khatri
. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 32 drivers/gpu/drm/drm_file.c| 10 ++ include/drm/drm_debugfs.h | 12 include/drm/drm_file.h| 7 +++ 4 files changed, 61 insertions(+) diff --git a

[PATCH v4 1/4] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-18 Thread Sunil Khatri
client in the root directory which is dri. Suggested-by: Christian König Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 22 ++ drivers/gpu/drm/drm_drv.c | 11 --- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_drv.h | 10

[PATCH v3 2/4] drm: add debugfs support on per client-id basis

2025-06-17 Thread Sunil Khatri
. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 37 +++ drivers/gpu/drm/drm_file.c| 10 ++ include/drm/drm_debugfs.h | 12 include/drm/drm_device.h | 4 include/drm/drm_file.h| 7 +++ 5 files

[PATCH v3 4/4] drm/amdgpu: add support of debugfs for mqd information

2025-06-17 Thread Sunil Khatri
add mqd support based on queue of for each client-id so the gpu address could be used to dump the mqd. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c

[PATCH v3 3/4] drm/amdgpu: add debugfs support for VM pagetable per client

2025-06-17 Thread Sunil Khatri
base address of the VM under the client-id node along with the process information in debugfs. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 58 - drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 4 +- 3

[PATCH v3 0/4] Add support of VM PT and MQD per client-id

2025-06-17 Thread Sunil Khatri
ing support is added based on per client-id as that is a unique no across devices and unlike PID it is more reliable. Sunil Khatri (4): drm: move debugfs functionality from drm_drv.c to drm_debugfs.c drm: add debugfs support on per client-id basis drm/amdgpu: add debugfs support for VM pageta

[PATCH v3 1/4] drm: move debugfs functionality from drm_drv.c to drm_debugfs.c

2025-06-17 Thread Sunil Khatri
client in the root directory which is dri. Suggested-by: Christian König Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 22 ++ drivers/gpu/drm/drm_drv.c | 11 --- drivers/gpu/drm/drm_internal.h | 6 ++ include/drm/drm_drv.h | 10

[PATCH v2 0/2] Support for debugfs directory for each client-id in /dri directory

2025-06-16 Thread Sunil Khatri
- Sunil Khatri (2): drm/debugfs: add client-id to the debugfs entry drm: add debugfs support on per client-id basis drivers/gpu/drm/drm_debugfs.c | 10 ++ drivers/gpu/drm/drm_file.c| 26 ++ include/drm/drm_device.h | 4 include/drm

[PATCH v2 2/2] drm: add debugfs support on per client-id basis

2025-06-16 Thread Sunil Khatri
. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_debugfs.c | 1 + drivers/gpu/drm/drm_file.c| 26 ++ include/drm/drm_device.h | 4 include/drm/drm_file.h| 7 +++ 4 files changed, 38 insertions(+) diff --git a/drivers/gpu/drm/drm_debugfs.c

[PATCH v2 1/2] drm/debugfs: add client-id to the debugfs entry

2025-06-16 Thread Sunil Khatri
pid is not always the right choice for fd to track the caller and hence adding drm client-id to the print which is unique for a drm client and can be used by driver in debugging One of the use is to further enhance debugging for amdgpu driver based on client-id. Signed-off-by: Sunil Khatri

[PATCH v1 1/2] drm: add debugfs support per client-id

2025-06-13 Thread Sunil Khatri
add support to add a directory for each client-id per drm node based on drm-file. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 11 +++ include/drm/drm_file.h | 7 +++ 2 files changed, 18 insertions(+) diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm

[PATCH v1 2/2] amdgpu: add debugfs file for pt-base per client-id

2025-06-13 Thread Sunil Khatri
Each drm node is associated with a unique client-id. Adding root page table base address of the VM under the client-id node in debugfs. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 14 +- drivers/gpu/drm

[PATCH v1 0/2] debugfs support for pt base for each vm

2025-06-13 Thread Sunil Khatri
:~# cat /sys/kernel/debug/dri/0/client-8/pt_base 81febdc000 root@amd-X570-AORUS-ELITE:~# cat /sys/kernel/debug/dri/0/client-9/pt_base 81febb2000 root@amd-X570-AORUS-ELITE:~# cat /sys/kernel/debug/dri/0/client-10/pt_base 81febaf000 Sunil Khatri (2): drm: add debugfs support per client-id amdgpu

[PATCH 2/3] drm/amdgpu/userq: add client id for each userq_mgr

2025-05-28 Thread Sunil Khatri
Add client id the for each userq_mgr which is created per fd to track which fd is for which client that could be used in debugfs entry to derive information like vm and mqd. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 1 + drivers/gpu/drm/amd/amdgpu

[PATCH] Revert "drm/amdgpu: promote the implicit sync to the dependent read fences"

2025-05-27 Thread Sunil Khatri
. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index d6ae9974c952..5576ed0b508f 100644 --- a/drivers/gpu/drm/amd

[PATCH v2] drm/amdgpu: fix the indentation

2025-05-07 Thread Sunil Khatri
fix the indentation drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:6992 gfx_v11_ip_dump compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505071619.7shtlpng-...@intel.com/ Signed-off-by: Sunil Khatri

[PATCH v1] drm/amdgpu: fix the indentation

2025-05-07 Thread Sunil Khatri
fix the indentation drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c:6992 gfx_v11_ip_dump compiler: gcc-11 (Debian 11.3.0-12) 11.3.0 | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202505071619.7shtlpng-...@intel.com/ Signed-off-by: Sunil Khatri

[PATCH v1] drm/amdgpu: update fence ptr with context:seqno

2025-04-21 Thread Sunil Khatri
log context:seqno of the fence during timeout rather than logging fence pointer. Cc: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b

[PATCH] drm/amdgpu: update fence ptr with context:seqno

2025-04-21 Thread Sunil Khatri
log context:seqno of the fence during timeout rather than logging fence pointer. Cc: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b

[PATCH V8 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-18 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu

[PATCH V8 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm

[PATCH V6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to add process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH V6 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
[amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 21 --- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH V8 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions

[PATCH V6 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
) remove drm_print.h v7: Use va_format and %pV to concatenate fmt and vargs (Jani Nikula) Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 34 ++ include/drm/drm_file.h | 3 +++ 2 files changed, 37 insertions(+) diff --git a/drivers/gpu/drm/drm_file.c

[PATCH V8 3/5] drm/amdgpu: use drm_file_err in fence timeouts

2025-04-17 Thread Sunil Khatri
ent: Unset ... Failed to evict userqueue Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 21 --- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers/gpu/drm/

[PATCH V8 1/5] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
) remove drm_print.h v7: Use va_format and %pV to concatenate fmt and vargs (Jani Nikula) v8: Code formatting and typos (Ursulin tvrtko) Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 34 ++ include/drm/drm_file.h | 3

[PATCH v6 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-17 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to ad process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH V8] drm: add drm_file_err function to add process info

2025-04-17 Thread Sunil Khatri
) remove drm_print.h v7: Use va_format and %pV to concatenate fmt and vargs (Jani Nikula) v8: Code formatting and typos (Ursulin tvrtko) Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/drm_file.c | 34 ++ include/drm/drm_file.h | 3

[PATCH V6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH V6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH V1] drm/amdgpu/userq: add context and seqno of the fence

2025-04-17 Thread Sunil Khatri
Add context and seqno of the fence in error logging rather than printing fence ptr. Suggested-by: Pierre-Eric Pelloux-Prayer Suggested-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH v2] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insert

[PATCH] drm/amdgpu/userq: add context and seqno of the fence

2025-04-17 Thread Sunil Khatri
Add context and seqno of the fence in error logging rather than printing fence ptr. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c b/drivers

[PATCH 2/2] drm/radeon: fix the warning for radeon_cs_parser_fini

2025-04-17 Thread Sunil Khatri
Fix the below warning message. radeon/radeon_cs.c:418: warning: Excess function parameter 'backoff' description in 'radeon_cs_parser_fini' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/radeon/radeon_cs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/r

[PATCH v6 3/5] drm/amdgpu: use drm_file_err to add process info

2025-04-17 Thread Sunil Khatri
-logind pid:1058 [ 42.825082] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

[PATCH v1] drm/sched: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Reviewed-by: Tvrtko Ursulin Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insert

[PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-17 Thread Sunil Khatri
fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'evict_low' not described in 'ttm_bo_swapout

[PATCH] drm/schedular: fix the warning in drm_sched_job_done

2025-04-17 Thread Sunil Khatri
Fix the below warning. scheduler/sched_main.c:397: warning: Function parameter or struct member 'result' not described in 'drm_sched_job_done' Signed-off-by: Sunil Khatri --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH v6 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-17 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-17 Thread Sunil Khatri
Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 37 + 1 file changed, 37 insertions(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 94d365b22505..856b38e996c7 100644 --- a/include/drm/drm_file.h +++ b/include/drm/drm_file.h @@ -446,6

[PATCH v6 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-17 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v5 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-16 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v5 3/5] drm/amdgpu: use drm_file_err to add process info

2025-04-16 Thread Sunil Khatri
-logind pid:1058 [ 42.825082] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

[PATCH v5 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-16 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v5 1/5] drm: add macro drm_file_err to print process info

2025-04-16 Thread Sunil Khatri
Add a drm helper macro which append the process information for the drm_file over drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index

[PATCH v5 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-16 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to ad process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v4 4/5] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-16 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err to ad process name and pid to the logging. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 52 +++ 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c

[PATCH v4 5/5] drm/amdgpu: change DRM_DBG_DRIVER to drm_dbg_driver

2025-04-16 Thread Sunil Khatri
update the functions in amdgpu_userqueues.c from DRM_DBG_DRIVER to drm_dbg_driver so multi gpu instance can be logged in. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH v4 3/5] drm/amdgpu: use drm_file_err to add process info

2025-04-16 Thread Sunil Khatri
-logind pid:1058 [ 42.825082] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

[PATCH v4 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-16 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v4 1/5] drm: add macro drm_file_err to print process info

2025-04-16 Thread Sunil Khatri
Add a drm helper macro which append the process information for the drm_file over drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 41 + 1 file changed, 41 insertions(+) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index

[PATCH v3 3/4] drm/amdgpu: use drm_file_err in logging to also dump process information

2025-04-15 Thread Sunil Khatri
] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 2/4] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-15 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v3 4/4] drm/amdgpu: change DRM_ERROR to drm_file_err in amdgpu_userqueue.c

2025-04-15 Thread Sunil Khatri
change the DRM_ERROR to drm_file_err which gives the drm device information too which is useful in case of multiple GPU's and also add process information. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 59 +++ 1 file changed, 33 inser

[PATCH v3 1/4] drm: add function drm_file_err to print proc information too

2025-04-15 Thread Sunil Khatri
Add a drm helper function which get the process information for the drm_file and append the process information using the existing drm_err. Signed-off-by: Sunil Khatri --- include/drm/drm_file.h | 40 1 file changed, 40 insertions(+) diff --git a

[PATCH v2 4/4] drm/amdgpu: change DRM_ERROR to drm_err in amdgpu_userqueue.c

2025-04-15 Thread Sunil Khatri
change the DRM_ERROR to drm_err which gives the drm device information too which is useful in case of multiple GPU's. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 75 ++- 1 file changed, 41 insertions(+), 34 deletions(-) diff --git a/dr

[PATCH v2 2/4] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-15 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v2 1/4] drm: function to get process name and pid

2025-04-15 Thread Sunil Khatri
Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 34 ++ include/drm

[PATCH v2 3/4] drm/amdgpu: update the error logging for more information

2025-04-15 Thread Sunil Khatri
] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 47 +++ 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v1 2/3] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-11 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH v1 3/3] drm/amdgpu: update the error logging for more information

2025-04-11 Thread Sunil Khatri
] [drm:amdgpu_userqueue_suspend [amdgpu]] *ERROR* Not suspending userqueue, timeout waiting for comm:systemd-logind pid:1058 Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 45 +++ 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v1 1/3] drm: function to get process name and pid

2025-04-11 Thread Sunil Khatri
Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 30 ++ include/drm/drm_file.h

[PATCH] drm: function to get process name and pid

2025-04-11 Thread Sunil Khatri
Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 30 ++ include/drm/drm_file.h

[PATCH v1 1/2] drm/amdgpu: add pid and name of the process with userq manager

2025-04-08 Thread Sunil Khatri
Add the pid and the process name of the process with the userq manager which could be used in debugging and understanding error messages better. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.h | 2 ++ 2

[PATCH v1 2/2] drm/amdgpu: update the error logging for more information

2025-04-08 Thread Sunil Khatri
add process and pid information in the userqueue error logging to make it more useful in resolving the error by logs. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/gpu

[PATCH v1] drm/amdgpu: no need to set queue_active in mes_userq_resume

2025-04-05 Thread Sunil Khatri
In mes_userq_resume calls mes_userq_map which set the queue_active state to true if it succeed and from the resume we dont need to explicitly set the queue state. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 1 - 1 file changed, 1 deletion(-) diff --git a

  1   2   3   4   5   6   >