RE: [PATCH] drm/amd/amdgpu: Add missing kdoc 'inst' parameter in 'amdgpu_device_ip_set_powergating_state'

2024-11-13 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - AMD Internal Distribution Only] Ping!? -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Monday, November 11, 2024 8:15 AM To: Koenig, Christian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN Subject: [PATCH] drm/amd/amdgpu

RE: [PATCH] drm/amd/amdgpu: Add missing kdoc 'gpu_addr' parameter in amdgpu_seq64_alloc()

2024-11-13 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - AMD Internal Distribution Only] Ping!? -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Monday, November 11, 2024 8:14 AM To: Koenig, Christian ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN Subject: [PATCH] drm/amd/amdgpu

RE: [PATCH v2 1/2] drm/amdgpu/gfx9: Add cleaner shader for GFX9.4.2

2024-10-17 Thread SHANMUGAM, SRINIVASAN
=] 29 | static const u32 gfx_9_4_2_cleaner_shader_hex[] = { Or it should be made unused here in patch1 and remove in patch2 As suggested will send merged one's. Thank you so much! -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Thursday, October 17, 2024 10:14 PM To: K

RE: [PATCH] drm/amdgpu/atomfirmware: silence UBSAN warning

2024-07-03 Thread SHANMUGAM, SRINIVASAN
[Public] Acked-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, July 1, 2024 10:25 PM To: amd-gfx@lists.freedesktop.org; jlay...@kernel.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/atomfirmware: silence UBSAN warning This is a

Re: [PATCH 2/2] Revert "drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update"

2024-06-07 Thread SHANMUGAM, SRINIVASAN
To: amd-gfx@lists.freedesktop.org Cc: SHANMUGAM, SRINIVASAN ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Choi, Nicholas ; Zhang, George ; alex.deuc...@amd.com ; LIPSKI, IVAN Subject: [PATCH 2/2] Revert "drm/amd/display: Add NULL check for 'afb

Re: [PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor"

2024-06-07 Thread SHANMUGAM, SRINIVASAN
To: amd-gfx@lists.freedesktop.org Cc: SHANMUGAM, SRINIVASAN ; Li, Sun peng (Leo) ; Wentland, Harry ; Siqueira, Rodrigo ; Choi, Nicholas ; Zhang, George ; alex.deuc...@amd.com ; LIPSKI, IVAN Subject: [PATCH 1/2] Revert "drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor

RE: [PATCH] drm/amd/display: Fix buffer overflow in 'get_host_router_total_dp_tunnel_bw()'

2024-01-30 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] From: SHANMUGAM, SRINIVASAN Sent: Tuesday, January 30, 2024 3:18 PM To: Siqueira, Rodrigo ; Pillai, Aurabindo Cc: Cyr, Aric ; amd-gfx@lists.freedesktop.org; Somasundaram, Meenakshikumar ; Huang, PeiChen (Pei-Chen) Subject: Re: [PATCH] drm/amd/display: Fix

Re: [bug report] drm/amdgpu/vpe: enable vpe dpm

2024-01-07 Thread SHANMUGAM, SRINIVASAN
[Public] + Srinath, Tim Get Outlook for Android<https://aka.ms/AAb9ysg> From: SHANMUGAM, SRINIVASAN Sent: Saturday, January 6, 2024 10:06:33 AM To: Dan Carpenter ; Lee, Peyton Cc: dri-de...@lists.freedesktop.org ; amd-gfx@lists.freedesktop.org Subje

RE: [bug report] drm/amdgpu/vpe: enable vpe dpm

2024-01-05 Thread SHANMUGAM, SRINIVASAN
[Public] Hi Dan Carpenter, This was fixed in https://patchwork.freedesktop.org/patch/573477/?series=128249&rev=1 Thank you! Regards, Srini -Original Message- From: amd-gfx On Behalf Of Dan Carpenter Sent: Friday, January 5, 2024 7:04 PM To: Lee, Peyton Cc: dri-de...@lists.freedeskto

RE: [PATCH] drm/amd/pm: fix error flow in sensor fetching

2023-08-21 Thread SHANMUGAM, SRINIVASAN
[Public] -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, August 18, 2023 9:55 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Jiapeng Chong Subject: [PATCH] drm/amd/pm: fix error flow in sensor fetching Sensor fetching functions should return an s

Re: [PATCH] drm/amd/pm: Fixes incorrect type in 'amdgpu_hwmon_show_power_avg() & _input()'

2023-08-20 Thread SHANMUGAM, SRINIVASAN
On 8/21/2023 11:59 AM, Kamal, Asad wrote: [AMD Official Use Only - General] -Original Message- From: amd-gfx On Behalf Of Srinivasan Shanmugam Sent: Monday, August 21, 2023 11:36 AM To: Koenig, Christian ; Deucher, Alexander ; Chen, Guchun Cc: Pan, Xinhui ; SHANMUGAM, SRINIVASAN

RE: [PATCH -next] drm/amd/display: Simplify bool conversion

2023-08-16 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks Li, for the fix, the fix is already in process of merging into amd-staging-drm-next. https://patchwork.freedesktop.org/patch/552568/ -Original Message- From: amd-gfx On Behalf Of Yang Li Sent: Wednesday, August 16, 2023 6:16 AM To: airl...@gmail

Re: [PATCH] drm/amdgpu: Replace ternary operator with min() in 'amdgpu_iomem_read'

2023-08-14 Thread SHANMUGAM, SRINIVASAN
On 8/14/2023 2:45 PM, Christian König wrote: Am 12.08.23 um 16:47 schrieb Srinivasan Shanmugam: Fixes the following coccicheck: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:2427:16-17: WARNING opportunity for min() min() macro is defined in include/linux/minmax.h. It avoids multiple evaluations

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-08-04 Thread SHANMUGAM, SRINIVASAN
On 8/3/2023 2:12 PM, Christian König wrote: Am 03.08.23 um 07:23 schrieb SHANMUGAM, SRINIVASAN: On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see

Re: [PATCH] drm/amdgpu: Remove volatile from 'wb' & from 'ptr' in amdgpu.h

2023-08-02 Thread SHANMUGAM, SRINIVASAN
On 7/24/2023 10:43 PM, Alex Deucher wrote: On Mon, Jul 24, 2023 at 11:54 AM Srinivasan Shanmugam wrote: Fixes the following from checkpatch.pl: WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst + volatile uint32_t *wb; WARNING:

RE: [PATCH] drm/amdgpu: Fix style issues in amdgpu_psp.c

2023-07-28 Thread SHANMUGAM, SRINIVASAN
[Public] Reviewed-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Praful Swarnakar Sent: Thursday, July 27, 2023 9:17 AM To: Koenig, Christian ; Deucher, Alexander ; Chen, Guchun Cc: Swarnakar, Praful ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu:

RE: [PATCH] drm/amdgpu: Fix style issues in amdgpu_debugfs.c

2023-07-26 Thread SHANMUGAM, SRINIVASAN
[Public] Reviewed-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, July 26, 2023 11:59 PM To: Swarnakar, Praful Cc: Deucher, Alexander ; amd-gfx@lists.freedesktop.org; Koenig, Christian ; Chen, Guchun Subject: Re: [PATCH] drm/amdgp

RE: [PATCH V2] drm/amdgpu: remove redundant variable declaration

2023-07-24 Thread SHANMUGAM, SRINIVASAN
[Public] Reviewed-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Bob Zhou Sent: Monday, July 24, 2023 2:06 PM To: amd-gfx@lists.freedesktop.org; Pelloux-Prayer, Pierre-Eric Cc: Zhou, Bob ; Chen, Guchun Subject: [PATCH V2] drm/amdgpu: remove redundant variable

RE: [PATCH] drm/radeon: ERROR: "foo* bar" should be "foo *bar"

2023-07-14 Thread SHANMUGAM, SRINIVASAN
[Public] Reviewed-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of shijie...@208suo.com Sent: Friday, July 14, 2023 1:36 PM To: Deucher, Alexander ; Pan, Xinhui ; airl...@gmail.com; dan...@ffwll.ch Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.or

RE: [PATCH] drm/amd/display: Fix guarding of 'if (dc->debug.visual_confirm)'

2023-06-06 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] -Original Message- From: Mahfooz, Hamza Sent: Tuesday, June 6, 2023 8:30 PM To: SHANMUGAM, SRINIVASAN ; Deucher, Alexander ; Pillai, Aurabindo ; Siqueira, Rodrigo ; Wang, Chao-kai (Stylon) ; Lee, Alvin ; Lei, Jun Cc: amd-gfx@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: remove unused definition

2023-05-18 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Acked-by: Srinivasan Shanmugam -Original Message- From: Zhou1, Tao Sent: Friday, May 19, 2023 11:24 AM To: amd-gfx@lists.freedesktop.org; Zhang, Hawking Cc: SHANMUGAM, SRINIVASAN ; Zhou1, Tao ; kernel test robot Subject: [PATCH] drm/amdgpu: remove

RE: [PATCH v2] drm/amd/amdgpu: Remove redundant else branch in amdgpu_encoders.c

2023-05-17 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] -Original Message- From: Deucher, Alexander Sent: Wednesday, May 17, 2023 6:25 PM To: SHANMUGAM, SRINIVASAN ; Koenig, Christian Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH v2] drm/amd/amdgpu: Remove redundant else branch in amdgpu_encoders.c

RE: [PATCH] drm/amd/amdgpu: Remove redundant else branch in amdgpu_encoders.c

2023-05-17 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] -Original Message- From: Alex Deucher Sent: Thursday, May 11, 2023 7:55 AM To: SHANMUGAM, SRINIVASAN Cc: Koenig, Christian ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Remove redundant else branch in

RE: [PATCH] drm/amd/amdgpu: Remove redundant else branch in amdgpu_encoders.c

2023-05-08 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] -Original Message- From: Alex Deucher Sent: Monday, May 8, 2023 9:27 PM To: SHANMUGAM, SRINIVASAN Cc: Koenig, Christian ; Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: Remove redundant else branch in

RE: [PATCH] drm/amd/display: DSC passthrough is for DP-HDMI pcon (SST pcon).

2023-04-24 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Jerry! and Aurabindo!, much appreciate for your help in reviewing this patch. -Original Message- From: Zuo, Jerry Sent: Monday, April 24, 2023 10:52 PM To: SHANMUGAM, SRINIVASAN ; Pillai, Aurabindo Cc: amd-gfx@lists.freedesktop.org

RE: [PATCH v2] drm/amd/display: Add logging for DP link traning Test Pattern Seqeunces

2023-04-10 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] -Original Message- From: SHANMUGAM, SRINIVASAN Sent: Monday, April 10, 2023 11:02 PM To: Wentland, Harry ; Zuo, Jerry ; Li, Sun peng (Leo) ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org; SHANMUGAM, SRINIVASAN Subject: [PATCH v2] drm/amd

RE: [PATCH] drm/amd/display : Log DP link training downspread info

2023-04-10 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Aurabindo! much appreciate for your help in reviewing this patch. Best regards, Srini -Original Message- From: Pillai, Aurabindo Sent: Monday, April 10, 2023 6:39 PM To: SHANMUGAM, SRINIVASAN ; Wentland, Harry ; Limonciello, Mario ; Li

RE: [PATCH v2] drm/amd/amdgpu: Fix trivial style errors

2023-04-05 Thread SHANMUGAM, SRINIVASAN
ario ; Russell, Kent ; SHANMUGAM, SRINIVASAN ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v2] drm/amd/amdgpu: Fix trivial style errors Removing the global job_hang_limit variable and replacing the only place where its used with 0 would probably be a good idea also. Chris

RE: [PATCH] drm/amd/amdgpu: Remove initialisation of globals to 0 or NULL

2023-03-27 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Alex for reviewing the patch. Best Regards, Srini -Original Message- From: Alex Deucher Sent: Tuesday, March 28, 2023 12:12 AM To: SHANMUGAM, SRINIVASAN Cc: Koenig, Christian ; Deucher, Alexander ; Limonciello, Mario ; Mahfooz, Hamza

RE: [PATCH] drm/amd/amdgpu: Fix error do not initialise globals to 0

2023-03-27 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot! Hamza Mahfooz for reviewing! Best Wishes, Srini -Original Message- From: Mahfooz, Hamza Sent: Monday, March 27, 2023 11:00 PM To: SHANMUGAM, SRINIVASAN ; Koenig, Christian ; Deucher, Alexander ; Limonciello, Mario Cc: amd-gfx

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Luben!, much appreciate for your help! -Original Message- From: Tuikov, Luben Sent: Thursday, March 23, 2023 7:24 PM To: Koenig, Christian ; SHANMUGAM, SRINIVASAN ; Deucher, Alexander ; Limonciello, Mario ; Zhang, Hawking Cc: amd-gfx

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
[Public] Thanks a lot Mario!, much appreciate for your help in reviewing! Best Regards, Srini -Original Message- From: Limonciello, Mario Sent: Thursday, March 23, 2023 6:09 PM To: SHANMUGAM, SRINIVASAN ; Koenig, Christian ; Deucher, Alexander ; Li, Candice ; Zhang, Hawking Cc: amd

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Hawking!, much appreciate for your help in reviewing! Best Regards, Srini -Original Message- From: Zhang, Hawking Sent: Thursday, March 23, 2023 7:15 PM To: Koenig, Christian ; SHANMUGAM, SRINIVASAN ; Deucher, Alexander ; Limonciello

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
[AMD Official Use Only - General] Thanks a lot Christian!, much appreciate for your help! Best Regards, Srini -Original Message- From: Koenig, Christian Sent: Thursday, March 23, 2023 6:59 PM To: SHANMUGAM, SRINIVASAN ; Deucher, Alexander ; Limonciello, Mario ; Zhang, Hawking

RE: [PATCH] drm/amd/amdgpu: Fix logic bug in fatal error handling

2023-03-23 Thread SHANMUGAM, SRINIVASAN
[Public] Hi Mario, Thanks for your comments, it was on " origin/amd-staging-drm-next" Best Regards, Srini -Original Message- From: Limonciello, Mario Sent: Thursday, March 23, 2023 6:03 PM To: SHANMUGAM, SRINIVASAN ; Koenig, Christian ; Deucher, Alexander ; Li, Candi