[PATCH v3 10/10] drm/amdgpu: Enable devcoredump for JPEG5_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu

[PATCH v3 09/10] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 08/10] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 07/10] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 06/10] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 05/10] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 04/10] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 03/10] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu

[PATCH v3 02/10] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-30 Thread Sathishkumar S
: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 84 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 9 +++ 2 files changed, 93 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 01/10] drm/amdgpu: Add a func for core specific reg offset

2025-01-30 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24

[PATCH v3 00/10] drm/amdgpu: Add jpeg devcoredump support

2025-01-30 Thread Sathishkumar S
) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() Sathishkumar S (10): drm/amdgpu: Add a func for core specific reg offset drm/amdgpu: Add helper funcs for jpeg devcoredump drm/amdgpu: Enable devcoredump for JPEG4_0_3 drm/amdgpu: Enable devcoredump for JPEG5_0_1 drm/amdgpu: Enable devcoredump

[PATCH v2 8/9] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 24 1 file changed, 24 insertions(+) diff --git a

[PATCH v2 9/9] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a

[PATCH v2 7/9] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 24 1 file changed, 24 insertions(+) diff --git a

[PATCH v2 5/9] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion

[PATCH v2 6/9] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 27 +++- 1 file changed, 26 insertions(+), 1 deletion

[PATCH v2 4/9] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 51 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 61

[PATCH v2 3/9] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 44 1 file changed, 44 insertions(+) diff --git a

[PATCH v2 1/9] drm/amdgpu: Add a func for core specific reg offset

2025-01-29 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH v2 2/9] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-29 Thread Sathishkumar S
-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 80 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 10 +++ 2 files changed, 90 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c index

[PATCH v2 0/9] drm/amdgpu: Add jpeg devcoredump support

2025-01-29 Thread Sathishkumar S
This patch-series enables jpeg devcoredump support V2: (Lijo) - add amdgpu_jpeg_reg_dump_init() for memory allocation and reg_list ref - use reg_list and reg_count from init() to dump and print registers - add amdgpu_jpeg_reg_dump_fini() to free memory and clear reg_list ref Sathishkumar S (9

[PATCH 4/9] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 65 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 61 ++ 2 files changed, 124 insertions(+), 2 deletions(-) diff --git a

[PATCH 9/9] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c index

[PATCH 8/9] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c index

[PATCH 7/9] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c index

[PATCH 6/9] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 41 +++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 5/9] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 3/9] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 58 1 file changed, 58 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c

[PATCH 2/9] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-28 Thread Sathishkumar S
Add devcoredump helper functions that can be reused for all jpeg versions. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 59 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 7 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/9] drm/amdgpu: Add a func for core specific reg offset

2025-01-28 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH 0/9] drm/amdgpu: Add jpeg devcoredump support

2025-01-28 Thread Sathishkumar S
This patch-series enables jpeg devcoredump support Sathishkumar S (9): drm/amdgpu: Add a func for core specific reg offset drm/amdgpu: Add helper funcs for jpeg devcoredump drm/amdgpu: Enable devcoredump for JPEG4_0_3 drm/amdgpu: Enable devcoredump for JPEG5_0_1 drm/amdgpu: Enable

[PATCH] drm/amdgpu: increase amdgpu max rings limit

2025-01-12 Thread Sathishkumar S
increase max rings to 132 to support all JPEG5_0_1 cores, else ring_init fails due to ring count exceeding maximum limit. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] drm/amdgpu: increase amdgpu max rings limit

2025-01-10 Thread Sathishkumar S
increase max rings to 132 to support all JPEG5_0_1 cores, else ring_init fails due to ring count exceeding maximum limit. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/2] drm/amdgpu: Add amdgpu_vcn_sched_mask debugfs

2024-11-11 Thread Sathishkumar S
Add debugfs entry to enable or disable job submission to specific vcn instances. The entry is created only when there is more than an instance and is unified queue type. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH 1/2] drm/amdgpu: Add a func for core specific reg offset

2024-11-11 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH] drm/amdgpu: Normalize reg offsets on VCN v4.0.3

2024-11-04 Thread Sathishkumar S
Remote access to external AIDs isn't possible with VCN RRMT disabled and it is disabled on SoCs with GC 9.4.4, so use only local offsets. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH] drm/amdgpu: Normalize reg offsets on VCN v4.0.3

2024-11-04 Thread Sathishkumar S
Remote access to external AIDs isn't possible with VCN RRMT disabled and it is disabled on SoCs with GC 9.4.4, so use only local offsets. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[PATCH] drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs

2024-09-10 Thread Sathishkumar S
more cores in the jpeg ip. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c| 71 + drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h| 1 + 3 files changed, 74 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/amdgpu: update jpeg max decode resolution

2024-04-22 Thread Sathishkumar S
jpeg ip version v2.1 and higher supports 16kx16k resolution decode Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/nv.c| 6 +++--- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/soc21.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-11-17 Thread Shyam Sundar S K
Hi Hans, Apologies for the long delay. On 10/19/2023 12:38 AM, Hans de Goede wrote: > Hi, > > I was not following this at first, so my apologies for > jumping in in the middle of the thread: > > > > >> +static int amd_pmf_gpu_get_cur_state(struct thermal_cooling_device >> *cooling_d

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-11-17 Thread Shyam Sundar S K
On 10/19/2023 2:31 PM, Christian König wrote: > Am 18.10.23 um 19:05 schrieb Shyam Sundar S K: >> >> On 10/18/2023 9:37 PM, Christian König wrote: >>> Am 18.10.23 um 17:47 schrieb Mario Limonciello: >>>> On 10/18/2023 08:40, Christian König wrote: >>&g

Re: [PATCH v4 10/17] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-11-16 Thread Shyam Sundar S K
Hi Ilpo, Apologies for the long delay. On 10/18/2023 2:30 PM, Ilpo Järvinen wrote: > On Wed, 18 Oct 2023, Shyam Sundar S K wrote: > >> PMF driver sends constant inputs to TA which its gets via the other >> subsystems in the kernel. To debug certain TA issues knowing what input

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-18 Thread Shyam Sundar S K
On 10/18/2023 9:37 PM, Christian König wrote: > Am 18.10.23 um 17:47 schrieb Mario Limonciello: >> On 10/18/2023 08:40, Christian König wrote: >>> >>> >>> Am 18.10.23 um 11:28 schrieb Shyam Sundar S K: >>>> >>>> On 10/18/2023 2:50 PM,

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-18 Thread Shyam Sundar S K
On 10/18/2023 2:50 PM, Ilpo Järvinen wrote: > On Wed, 18 Oct 2023, Shyam Sundar S K wrote: > >> In order to provide GPU inputs to TA for the Smart PC solution to work, we >> need to have interface between the PMF driver and the AMDGPU driver. >> >> Add the initi

[PATCH v4 17/17] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-18 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the Ambient light via the Ambient Light Sensor (ALS) which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Reviewed-by: Mario Limonciello Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam

[PATCH v4 16/17] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-10-18 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

[PATCH v4 15/17] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()

2023-10-18 Thread Shyam Sundar S K
on will be called by multiple callers in the next patch. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +-- .../amd-sfh-hid/sfh1_1/amd_sfh_interface.h| 1 + 2 files c

[PATCH v4 14/17] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-10-18 Thread Shyam Sundar S K
Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++ drivers/platform/x86/amd/pmf/pmf.h | 2 ++ drivers/platform/x86/amd/pmf/tee-if.c | 21 +++-- 3 files changed, 39 insertions

[PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-18 Thread Shyam Sundar S K
Sundar S K --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 138 drivers/platform/x86/amd/pmf/Kconfig| 1 + drivers/platform/x86/amd/pmf/core.c | 1 + drivers/platform

[PATCH v4 12/17] platform/x86/amd/pmf: dump policy binary data

2023-10-18 Thread Shyam Sundar S K
Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/tee-if.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 6c4ce22ba518..2f5fb8623c20 100644 --- a/drivers/platform/x86/amd

[PATCH v4 11/17] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-10-18 Thread Shyam Sundar S K
: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 1 + drivers/platform/x86/amd/pmf/tee-if.c | 67 +++ 2 files changed, 68 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h index

[PATCH v4 10/17] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-10-18 Thread Shyam Sundar S K
-static function as this helper is required outside of sps.c file. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers/platform/x86/amd/pmf/spc.c| 37 +++ drivers/platform/x86/amd/pmf/tee-if.c | 1 + 3

[PATCH v4 09/17] platform/x86/amd/pmf: Make source_as_str() as non-static

2023-10-18 Thread Shyam Sundar S K
Add amd_pmf prefix to source_as_str() function, so that the function name does not look generic. As this is a helper function make it as non-static so that it can be reused across multiple PMF features. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h | 1 + drivers

[PATCH v4 08/17] platform/x86/amd/pmf: Add support to update system state

2023-10-18 Thread Shyam Sundar S K
rules under Documentation/admin-guide/pmf.rst. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/pmf.rst | 24 +++ drivers/platform/x86/amd/pmf/pmf.h| 9 +++ drivers/platform/x86

[PATCH v4 07/17] platform/x86/amd/pmf: Add support update p3t limit

2023-10-18 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers

[PATCH v4 06/17] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-18 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf

[PATCH v4 04/17] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-18 Thread Shyam Sundar S K
t in the kernel which can load the amdtee driver. Without amdtee driver loading onto the system the "tee" calls shall fail from the PMF driver. Hence an explicit MODULE_SOFTDEP has been added to address this. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/Kconfig | 2

[PATCH v4 05/17] platform/x86/amd/pmf: change amd_pmf_init_features() call sequence

2023-10-18 Thread Shyam Sundar S K
es() so that when the Smart PC init happens, it has the parent debugfs directory to get itself hooked. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform

[PATCH v4 03/17] platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()

2023-10-18 Thread Shyam Sundar S K
function to set the DRAM address. Add a suspend handler that can free up the allocated memory for getting the metrics table information. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 42 ++--- drivers/platform/x86

[PATCH v4 02/17] platform/x86/amd/pmf: Add support for PMF-TA interaction

2023-10-18 Thread Shyam Sundar S K
getting the information from the other kernel subsystems or from userland) 2) Enact: Enact the output actions from the TA. The action could be applying a new thermal limit to boost/throttle the power limits or change system behavior. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K

[PATCH v4 01/17] platform/x86/amd/pmf: Add PMF TEE interface

2023-10-18 Thread Shyam Sundar S K
code path to build these pipes. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/Kconfig | 1 + drivers/platform/x86/amd/pmf/Makefile | 3 +- drivers/platform/x86/amd/pmf/core.c | 10 ++- drivers/platform/x86/amd/pmf/pmf.h| 16 dr

[PATCH v4 00/17] Introduce PMF Smart PC Solution Builder Feature

2023-10-18 Thread Shyam Sundar S K
or interaction with SFH - other cosmetic remarks Basavaraj Natikar (3): HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int() platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS Shyam Sundar S K (14): platform/x86/a

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-12 Thread Shyam Sundar S K
On 10/11/2023 8:47 AM, Shyam Sundar S K wrote: > > > On 10/10/2023 9:56 PM, Mario Limonciello wrote: >> On 10/10/2023 07:59, Shyam Sundar S K wrote: >>> PMF Policy binary is a encrypted and signed binary that will be part >>> of the BIOS. PMF driver via the AC

Re: [PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 9:56 PM, Mario Limonciello wrote: > On 10/10/2023 07:59, Shyam Sundar S K wrote: >> PMF Policy binary is a encrypted and signed binary that will be part >> of the BIOS. PMF driver via the ACPI interface checks the existence >> of Smart PC bit. If the adverti

Re: [PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 9:33 PM, Mario Limonciello wrote: > On 10/10/2023 07:59, Shyam Sundar S K wrote: >> PMF driver based on the output actions from the TA can request to >> update >> the system states like entering s0i3, lock screen etc. by generating >> an uevent. Based o

Re: [PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Shyam Sundar S K
On 10/10/2023 6:38 PM, Ilpo Järvinen wrote: > On Tue, 10 Oct 2023, Shyam Sundar S K wrote: > >> Sometimes policy binary retrieved from the BIOS maybe incorrect that can >> end up in failing to enable the Smart PC solution feature. >> >> Use print_hex_dump_debug(

[PATCH v3 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-10-10 Thread Shyam Sundar S K
the current file. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 + drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 2 +- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 6 ++ .../amd

[PATCH v3 15/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-10-10 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

[PATCH v3 14/16] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()

2023-10-10 Thread Shyam Sundar S K
on will be called by multiple callers in the next patch. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/d

[PATCH v3 13/16] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-10-10 Thread Shyam Sundar S K
Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++ drivers/platform/x86/amd/pmf/pmf.h | 2 ++ drivers/platform/x86/amd/pmf/tee-if.c | 21 +++-- 3 files changed, 39 insertions

[PATCH v3 10/16] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-10-10 Thread Shyam Sundar S K
: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 1 + drivers/platform/x86/amd/pmf/tee-if.c | 67 +++ 2 files changed, 68 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/pmf.h b/drivers/platform/x86/amd/pmf/pmf.h index

[PATCH v3 12/16] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-10 Thread Shyam Sundar S K
Sundar S K --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 136 drivers/platform/x86/amd/pmf/Kconfig| 1 + drivers/platform/x86/amd/pmf/core.c | 1 + drivers/platform

[PATCH v3 11/16] platform/x86/amd/pmf: dump policy binary data

2023-10-10 Thread Shyam Sundar S K
Sundar S K --- drivers/platform/x86/amd/pmf/tee-if.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 994daf945795..e4386f503ad0 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers

[PATCH v3 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-10 Thread Shyam Sundar S K
rules under Documentation/admin-guide/pmf.rst. Signed-off-by: Shyam Sundar S K --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/pmf.rst | 25 +++ drivers/platform/x86/amd/pmf/pmf.h| 9 +++ drivers/platform/x86/amd/pmf/tee-if.c | 36

[PATCH v3 09/16] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-10-10 Thread Shyam Sundar S K
-static function as this helper is required outside of sps.c file. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers/platform/x86/amd/pmf/spc.c| 37 +++ drivers/platform/x86/amd/pmf/sps.c| 2

[PATCH v3 07/16] platform/x86/amd/pmf: Add support update p3t limit

2023-10-10 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers

[PATCH v3 06/16] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-10 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf

[PATCH v3 05/16] platform/x86/amd/pmf: change amd_pmf_init_features() call sequence

2023-10-10 Thread Shyam Sundar S K
es() so that when the Smart PC init happens, it has the parent debugfs directory to get itself hooked. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform

[PATCH v3 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-10 Thread Shyam Sundar S K
t in the kernel which can load the amdtee driver. Without amdtee driver loading onto the system the "tee" calls shall fail from the PMF driver. Hence an explicit "request_module" has been added to address this. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/

[PATCH v3 03/16] platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()

2023-10-10 Thread Shyam Sundar S K
function to set the DRAM address. Add a suspend handler that can free up the allocated memory for getting the metrics table information. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/core.c | 42 ++--- drivers/platform/x86

[PATCH v3 02/16] platform/x86/amd/pmf: Add support PMF-TA interaction

2023-10-10 Thread Shyam Sundar S K
getting the information from the other kernel subsystems or from userland) 2) Enact: Enact the output actions from the TA. The action could be applying a new thermal limit to boost/throttle the power limits or change system behavior. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K

[PATCH v3 01/16] platform/x86/amd/pmf: Add PMF TEE interface

2023-10-10 Thread Shyam Sundar S K
code path to build these pipes. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/Kconfig | 1 + drivers/platform/x86/amd/pmf/Makefile | 3 +- drivers/platform/x86/amd/pmf/core.c | 10 ++- drivers/platform/x86/amd/pmf/pmf.h| 16 dr

[PATCH v3 00/16] Introduce PMF Smart PC Solution Builder Feature

2023-10-10 Thread Shyam Sundar S K
raction with SFH - other cosmetic remarks Basavaraj Natikar (3): HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int() platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS Shyam Sundar S K (13): platform/x86/amd/pmf: Add P

Re: [PATCH v2 12/16] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 6:19 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> In order to provide GPU inputs to TA for the Smart PC solution to work, we >> need to have interface between the PMF driver and the AMDGPU driver. >> >> Add the initi

Re: [PATCH v2 08/16] platform/x86/amd/pmf: Add support to update system state

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:53 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF driver based on the output actions from the TA can request to update >> the system states like entering s0i3, lock screen etc. by generating >> an uevent. Based on t

Re: [PATCH v2 06/16] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:44 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF driver sends changing inputs from each subystem to TA for evaluating >> the conditions in the policy binary. >> >> Add initial support of plumbing in the

Re: [PATCH v2 04/16] platform/x86/amd/pmf: Add support for PMF Policy Binary

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 5:30 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> PMF Policy binary is a encrypted and signed binary that will be part >> of the BIOS. PMF driver via the ACPI interface checks the existence >> of Smart PC bit. If the adve

Re: [PATCH v2 01/16] platform/x86/amd/pmf: Add PMF TEE interface

2023-10-08 Thread Shyam Sundar S K
On 10/4/2023 4:20 PM, Ilpo Järvinen wrote: > On Sat, 30 Sep 2023, Shyam Sundar S K wrote: > >> AMD PMF driver loads the PMF TA (Trusted Application) into the AMD >> ASP's (AMD Security Processor) TEE (Trusted Execution Environment). >> >> PMF Trusted Appli

Re: [PATCH 06/15] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-09-30 Thread Shyam Sundar S K
On 9/26/2023 10:38 PM, Ilpo Järvinen wrote: > On Fri, 22 Sep 2023, Shyam Sundar S K wrote: > >> PMF driver sends changing inputs from each subystem to TA for evaluating >> the conditions in the policy binary. >> >> Add initial support of plumbing in the

[PATCH v2 16/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for ALS

2023-09-30 Thread Shyam Sundar S K
the current file. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/amd_sfh_common.h | 1 + drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 2 +- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 6 ++ .../amd

[PATCH v2 14/16] HID: amd_sfh: rename float_to_int() to amd_sfh_float_to_int()

2023-09-30 Thread Shyam Sundar S K
on will be called by multiple callers in the next patch. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K Signed-off-by: Basavaraj Natikar --- drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c | 22 +-- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/d

[PATCH v2 15/16] platform/x86/amd/pmf: Add PMF-AMDSFH interface for HPD

2023-09-30 Thread Shyam Sundar S K
From: Basavaraj Natikar AMDSFH has information about the User presence information via the Human Presence Detection (HPD) sensor which is part of the AMD sensor fusion hub. Add PMF and AMDSFH interface to get this information. Co-developed-by: Shyam Sundar S K Signed-off-by: Shyam Sundar S K

[PATCH v2 13/16] platform/x86/amd/pmf: Add PMF-AMDGPU set interface

2023-09-30 Thread Shyam Sundar S K
Limonciello Signed-off-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 18 ++ drivers/platform/x86/amd/pmf/pmf.h | 2 ++ drivers/platform/x86/amd/pmf/tee-if.c | 21 +++-- 3 files changed, 39 insertions

[PATCH v2 12/16] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-09-30 Thread Shyam Sundar S K
Sundar S K --- drivers/gpu/drm/amd/amdgpu/Makefile | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_pmf.c | 136 drivers/platform/x86/amd/pmf/Kconfig| 1 + drivers/platform/x86/amd/pmf/core.c | 1 + drivers/platform

[PATCH v2 11/16] platform/x86/amd/pmf: dump policy binary data

2023-09-30 Thread Shyam Sundar S K
Sundar S K --- drivers/platform/x86/amd/pmf/tee-if.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/amd/pmf/tee-if.c b/drivers/platform/x86/amd/pmf/tee-if.c index 01f974b55a6a..d16bdecfd43a 100644 --- a/drivers/platform/x86/amd/pmf/tee-if.c +++ b/drivers/platform

[PATCH v2 10/16] platform/x86/amd/pmf: Add capability to sideload of policy binary

2023-09-30 Thread Shyam Sundar S K
: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309251031.awddkrgs-...@intel.com/ Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 1 + drivers/platform/x86/amd/pmf/tee-if.c | 68 +++ 2 files

[PATCH v2 09/16] platform/x86/amd/pmf: Add facility to dump TA inputs

2023-09-30 Thread Shyam Sundar S K
-static function as this helper is required outside of sps.c file. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers/platform/x86/amd/pmf/spc.c| 37 +++ drivers/platform/x86/amd/pmf/sps.c| 2

[PATCH v2 08/16] platform/x86/amd/pmf: Add support to update system state

2023-09-30 Thread Shyam Sundar S K
rules under Documentation/admin-guide/pmf.rst. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202309260515.5xbr6n0g-...@intel.com/ Signed-off-by: Shyam Sundar S K --- Documentation/admin-guide/index.rst | 1 + Documentation/admin-guide/pmf.rst | 25

[PATCH v2 07/16] platform/x86/amd/pmf: Add support update p3t limit

2023-09-30 Thread Shyam Sundar S K
P3T (Peak Package Power Limit) is a metric within the SMU controller that can influence the power limits. Add support from the driver to update P3T limits accordingly. Reviewed-by: Mario Limonciello Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf/pmf.h| 3 +++ drivers

[PATCH v2 06/16] platform/x86/amd/pmf: Add support to get inputs from other subsystems

2023-09-30 Thread Shyam Sundar S K
PMF driver sends changing inputs from each subystem to TA for evaluating the conditions in the policy binary. Add initial support of plumbing in the PMF driver for Smart PC to get information from other subsystems in the kernel. Signed-off-by: Shyam Sundar S K --- drivers/platform/x86/amd/pmf

  1   2   3   4   >