[PATCH] drm/amdgpu/jpeg: Move parse_cs to amdgpu_jpeg.c

2025-09-04 Thread Sathishkumar S
Rename jpeg_v2_dec_ring_parse_cs to amdgpu_jpeg_dec_parse_cs and move it to amdgpu_jpeg.c as it is shared among jpeg versions. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 65 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 10 drivers

[PATCH v3] drm/amdgpu/vcn: Fix video_profile switch race condition

2025-08-14 Thread Sathishkumar S
amdgpu/vcn: adjust workload profile handling") Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 37 +++-- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 6 +++- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 14 ++ 3 files changed, 23 insertions(+

[PATCH] drm/amdgpu/vcn: Fix video_profile switch race condition

2025-08-14 Thread Sathishkumar S
lobal workload_profile_mutex. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 24 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 2 files changed, 19 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/driver

[PATCH] drm/amdgpu/vcn: Fix race condition during dpm off

2025-08-13 Thread Sathishkumar S
lock (David Wu) Fixes: 3b669df92c85 ("drm/amdgpu/vcn: adjust workload profile handling") Signed-off-by: Sathishkumar S Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c| 31 +- drivers/g

[PATCH] drm/amdgpu/vcn: Fix video_profile switch race condition

2025-08-12 Thread Sathishkumar S
instance is powered OFF. VCN workload_profile_mutex can be removed after similar clean up is done for vcn2_5. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 24 +--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 4 2 files changed, 13 insertions(+), 15

[PATCH 2/2] drm/amdgpu/vcn: Hold pg_lock before vcn power off

2025-08-06 Thread Sathishkumar S
Acquire vcn_pg_lock before changes to vcn power state and release it after power off in idle work handler. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/drivers/gpu/drm

[PATCH 1/2] drm/amdgpu/jpeg: Hold pg_lock before jpeg poweroff

2025-08-06 Thread Sathishkumar S
Acquire jpeg_pg_lock before changes to jpeg power state and release it after power off from idle work handler. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH] drm/amdgpu: Fix unintended error log in VCN5_0_0

2025-07-29 Thread Sathishkumar S
The error log is supposed to be gaurded under if failure condition. Fixes: 29ef09ead572 ("drm/amdgpu: Check vcn sram load return value") Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 8/8] drm/amdgpu/vcn: Register dump cleanup in VCN2_5

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN2_5 and VCN2_6 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 82 +++ 1 file changed, 7 insertions(+), 75 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm

[PATCH 7/8] drm/amdgpu/vcn: Register dump cleanup in VCN2_0_0

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN2_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 78 ++- 1 file changed, 5 insertions(+), 73 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 6/8] drm/amdgpu/vcn: Register dump cleanup in VCN3_0

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN3_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 77 ++- 1 file changed, 5 insertions(+), 72 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 5/8] drm/amdgpu/vcn: Register dump cleanup in VCN4_0_3

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN4_0_3 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 78 ++--- 1 file changed, 5 insertions(+), 73 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c b/drivers/gpu/drm/amd

[PATCH 4/8] drm/amdgpu/vcn: Register dump cleanup in VCN4_0_5

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN4_0_5 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 78 ++--- 1 file changed, 5 insertions(+), 73 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c b/drivers/gpu/drm/amd

[PATCH 3/8] drm/amdgpu/vcn: Register dump cleanup in VCN4_0_0

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN4_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 79 ++- 1 file changed, 5 insertions(+), 74 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 2/8] drm/amdgpu/vcn: Register dump cleanup in VCN5

2025-07-18 Thread Sathishkumar S
Use generic vcn devcoredump helper functions for VCN5 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 86 ++--- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.h | 5 -- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 44 +++-- 3 files changed, 44

[PATCH 1/8] drm/amdgpu/vcn: Add regdump helper functions

2025-07-18 Thread Sathishkumar S
Add generic helper functions for vcn devcoredump support which can be re-used for all vcn versions. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 86 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 8 +++ 2 files changed, 94 insertions(+) diff

[PATCH 0/8] Generic register dump helper functions for VCN

2025-07-18 Thread Sathishkumar S
This patch series adds generic vcn register dump helper functions and reuses it in all vcn versions instead of redefining the same in every vcn version. Sathishkumar S (8): drm/amdgpu/vcn: Add regdump helper functions drm/amdgpu/vcn: Register dump cleanup in VCN5 drm/amdgpu/vcn: Register

[PATCH] drm/amdgpu: Check vcn sram load return value

2025-07-13 Thread Sathishkumar S
Log an error when vcn sram load fails in indirect mode and return the same error value. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 10 -- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 10 -- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 10

[PATCH 1/2] drm/amdgpu: Update vcn doorbell range in NBIO 7.9

2025-04-10 Thread Sathishkumar S
From: Shiwu Zhang Increase vcn doorbell range for gfx950 to 11. Signed-off-by: Shiwu Zhang --- drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c ind

[PATCH 2/2] drm/amdgpu: Enable doorbell for JPEG5_0_1

2025-04-10 Thread Sathishkumar S
Enable doorbell for JPEG5_0_1 and adjust index for VCN5_0_1. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 2/2] drm/amdgpu: Wait for pte updates before uq_resume

2025-03-16 Thread Sathishkumar S
fault (src_id:0 ring:40 vmid:10 pasid:32771) amdgpu: in process pid 0 thread pid 0) amdgpu: in page starting at address 0x800105404000 from client 10 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 13 + 1 file changed, 13 insertions(+) diff

[PATCH 1/2] drm/amdgpu: update eviction fence driver name

2025-03-16 Thread Sathishkumar S
update the eviction fence driver name to amdgpu_eviction_fence Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.c b/drivers/gpu/drm/amd

[PATCH 2/2] drm/amdgpu: Wait for pte updates before uq_resume

2025-03-16 Thread Sathishkumar S
fault (src_id:0 ring:40 vmid:10 pasid:32771) amdgpu: in process pid 0 thread pid 0) amdgpu: in page starting at address 0x800105404000 from client 10 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 13 + 1 file changed, 13 insertions(+) diff

[PATCH 1/2] drm/amdgpu: update eviction fence driver name

2025-03-16 Thread Sathishkumar S
update the eviction fence driver name to amdgpu_eviction_fence Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_eviction_fence.c b/drivers/gpu/drm/amd

[PATCH 2/2] drm/amdgpu: Fix core reset sequence for JPEG5_0_1

2025-02-26 Thread Sathishkumar S
For cores 1 through 9 repair the core reset sequence by adjusting offsets to access the expected registers. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/2] drm/amdgpu: Fix core reset sequence for JPEG4_0_3

2025-02-26 Thread Sathishkumar S
For cores 1 through 7 repair the core reset sequence by adjusting offsets to access the expected registers. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/3] drm/amdgpu: Per-instance init func for JPEG5_0_1

2025-02-20 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG5_0_1. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 150 +++ 1 file changed, 69 insertions(+), 81 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 3/3] drm/amdgpu: Add ring reset callback for JPEG5_0_1

2025-02-20 Thread Sathishkumar S
Add ring reset function callback for JPEG5_0_1 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 50 1 file changed, 50 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c

[PATCH 2/3] drm/amdgpu: Add core reset registers for JPEG5_0_1

2025-02-20 Thread Sathishkumar S
Add core reset control register definitions and align all prior register definitions to end at 100 column length for uniformity. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 128 --- 1 file changed, 68 insertions(+), 60 deletions(-) diff

[PATCH] drm/amdgpu: Do not poweroff UVDJ in JPEG4_0_3

2025-02-20 Thread Sathishkumar S
Update power gate setting to not poweroff UVDJ in JPEG4_0_3. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c index

[PATCH v4 2/2] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-02-17 Thread Sathishkumar S
ence V4: - Dont create reset_mask sysfs and return -EOPNOTSUPP on VFs (Lijo) Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 56 +--- 1 file changed, 49 insertions(+), 7 deletions(-) diff --git a/dri

[PATCH v4 1/2] drm/amdgpu: Add JPEG4_0_3 core reset control reg

2025-02-17 Thread Sathishkumar S
Add core reset control registers for JPEG4_0_3 Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- .../include/asic_reg/vcn/vcn_4_0_3_offset.h | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn

[PATCH v3 2/2] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-02-17 Thread Sathishkumar S
Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 49 +--- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_

[PATCH v3 1/2] drm/amdgpu: Add JPEG4_0_3 core reset control reg

2025-02-17 Thread Sathishkumar S
Add core reset control registers for JPEG4_0_3 Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- .../include/asic_reg/vcn/vcn_4_0_3_offset.h | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn

Re: [PATCH] amdgpu/pm/legacy: fix suspend/resume issues

2025-02-17 Thread Maciej S. Szmigiero
12e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c") Signed-off-by: chr[] Signed-off-by: Alex Deucher --- Tested-by: Maciej S. Szmigiero # on Oland PRO Thanks, Maciej

[PATCH v3 1/6] drm/amdgpu: Per-instance init func for JPEG4_0_3

2025-02-12 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG4_0_3. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 190 --- 1 file changed, 98 insertions

[PATCH v3 5/6] drm/amdgpu: Add ring reset callback for JPEG2_5_0

2025-02-12 Thread Sathishkumar S
Add ring reset function callback for JPEG2_5_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion

[PATCH v3 4/6] drm/amdgpu: Per-instance init func for JPEG2_5_0

2025-02-12 Thread Sathishkumar S
Add helper functions to handle per-instance initialization and deinitialization in JPEG2_5_0. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 102 + 1 file changed, 55 insertions(+), 47 deletions

[PATCH v3 6/6] drm/amdgpu: Add ring reset callback for JPEG2_0_0

2025-02-12 Thread Sathishkumar S
Add ring reset function callback for JPEG2_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion

[PATCH v3 4/6] drm/amdgpu: Per-instance init func for JPEG2_5_0

2025-02-12 Thread Sathishkumar S
Add helper functions to handle per-instance initialization and deinitialization in JPEG2_5_0. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 102 + 1 file changed, 55 insertions(+), 47 deletions

[PATCH v3 3/6] drm/amdgpu: Add ring reset callback for JPEG3_0_0

2025-02-12 Thread Sathishkumar S
Add ring reset function callback for JPEG3_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion

[PATCH v3 2/6] drm/amdgpu: Add ring reset callback for JPEG4_0_0

2025-02-12 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions

[PATCH v3 1/6] drm/amdgpu: Per-instance init func for JPEG4_0_3

2025-02-12 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG4_0_3. Signed-off-by: Sathishkumar S Acked-by: Christian König Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 190 --- 1 file changed, 98 insertions

[PATCH v3 0/6] drm/amdgpu: jpeg ring reset callback

2025-02-12 Thread Sathishkumar S
This patch series enables jpeg ring reset callback to recover from job timeouts without having to do a full gpu reset. V2: - sched->ready flag shouldn't be modified by HW backend (Christian) V3: - Dont modifying sched/job-submission state from HW backend (Christian) Sathishkumar S (6

[PATCH v2 7/7] drm/amdgpu: Add ring reset callback for JPEG2_0_0

2025-02-10 Thread Sathishkumar S
Add ring reset function callback for JPEG2_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 6/7] drm/amdgpu: Add ring reset callback for JPEG2_5_0

2025-02-10 Thread Sathishkumar S
Add ring reset function callback for JPEG2_5_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 5/7] drm/amdgpu: Per-instance init func for JPEG2_5_0

2025-02-10 Thread Sathishkumar S
Add helper functions to handle per-instance initialization and deinitialization in JPEG2_5_0. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 102 + 1 file changed, 55 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 4/7] drm/amdgpu: Add ring reset callback for JPEG3_0_0

2025-02-10 Thread Sathishkumar S
Add ring reset function callback for JPEG3_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 3/7] drm/amdgpu: Add ring reset callback for JPEG4_0_0

2025-02-10 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v2 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-02-10 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. V2: - sched->ready flag shouldn't be modified by back-ends (Christian) - use drm_sched_wqueue_stop()/drm_sched_wqueue_start() instead (Alex) Signed-off-by: Sathishkumar S --- drivers

[PATCH v2 1/7] drm/amdgpu: Per-instance init func for JPEG4_0_3

2025-02-10 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG4_0_3. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 190 --- 1 file changed, 98 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 0/7] drm/amdgpu: jpeg ring reset callback

2025-02-10 Thread Sathishkumar S
This patch series enables jpeg ring reset callback to recover from job timeouts without having to do a full gpu reset. V2: - sched->ready flag shouldn't be modified by backends (Christian) - use drm_sched_wqueue_stop()/drm_sched_wqueue_start() instead (Alex) Sathishkumar S (7): dr

[PATCH 7/7] drm/amdgpu: Add ring reset callback for JPEG2_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG2_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c b

[PATCH 6/7] drm/amdgpu: Add ring reset callback for JPEG2_5_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG2_5_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c b

[PATCH 4/7] drm/amdgpu: Add ring reset callback for JPEG3_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG3_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c b

[PATCH 5/7] drm/amdgpu: Per-instance init func for JPEG2_5_0

2025-01-31 Thread Sathishkumar S
Add helper functions to handle per-instance initialization and deinitialization in JPEG2_5_0. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 102 + 1 file changed, 55 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 3/7] drm/amdgpu: Add ring reset callback for JPEG4_0_0

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_0 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 2/7] drm/amdgpu: Add ring reset callback for JPEG4_0_3

2025-01-31 Thread Sathishkumar S
Add ring reset function callback for JPEG4_0_3 to recover from job timeouts without a full gpu reset. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 60 ++-- 1 file changed, 57 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 1/7] drm/amdgpu: Per-instance init func for JPEG4_0_3

2025-01-31 Thread Sathishkumar S
Add helper functions to handle per-instance and per-core initialization and deinitialization in JPEG4_0_3. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 190 --- 1 file changed, 98 insertions(+), 92 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/7] Add jpeg ring reset callback

2025-01-31 Thread Sathishkumar S
This patch-series adds jpeg ring reset callback function to recover from job timeouts without a full gpu reset. How is it tested:- A bad job on jpeg causes timeout and recovers alongside an unaffected mpv vaapi-decode(vcn) in playback loop. Sathishkumar S (7): drm/amdgpu: Per-instance init

[PATCH v3 10/10] drm/amdgpu: Enable devcoredump for JPEG5_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu

[PATCH v3 09/10] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 08/10] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 07/10] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 06/10] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 05/10] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 04/10] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm

[PATCH v3 03/10] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-30 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 V2: (Lijo) - remove version specific callbacks and use simplified helper functions V3: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() and avoid the call here Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu

[PATCH v3 02/10] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-30 Thread Sathishkumar S
: (Lijo) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 84 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 9 +++ 2 files changed, 93 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH v3 01/10] drm/amdgpu: Add a func for core specific reg offset

2025-01-30 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24

[PATCH v3 00/10] drm/amdgpu: Add jpeg devcoredump support

2025-01-30 Thread Sathishkumar S
) - move amdgpu_jpeg_reg_dump_fini() to sw_fini() Sathishkumar S (10): drm/amdgpu: Add a func for core specific reg offset drm/amdgpu: Add helper funcs for jpeg devcoredump drm/amdgpu: Enable devcoredump for JPEG4_0_3 drm/amdgpu: Enable devcoredump for JPEG5_0_1 drm/amdgpu: Enable devcoredump

[PATCH v2 8/9] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 24 1 file changed, 24 insertions(+) diff --git a

[PATCH v2 9/9] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a

[PATCH v2 7/9] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 24 1 file changed, 24 insertions(+) diff --git a

[PATCH v2 5/9] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion

[PATCH v2 6/9] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 27 +++- 1 file changed, 26 insertions(+), 1 deletion

[PATCH v2 4/9] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 51 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 61

[PATCH v2 3/9] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-29 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 V2: (Lijo) - remove version specific callbacks and use simplified helper functions Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 44 1 file changed, 44 insertions(+) diff --git a

[PATCH v2 1/9] drm/amdgpu: Add a func for core specific reg offset

2025-01-29 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH v2 2/9] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-29 Thread Sathishkumar S
-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 80 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 10 +++ 2 files changed, 90 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c index

[PATCH v2 0/9] drm/amdgpu: Add jpeg devcoredump support

2025-01-29 Thread Sathishkumar S
This patch-series enables jpeg devcoredump support V2: (Lijo) - add amdgpu_jpeg_reg_dump_init() for memory allocation and reg_list ref - use reg_list and reg_count from init() to dump and print registers - add amdgpu_jpeg_reg_dump_fini() to free memory and clear reg_list ref Sathishkumar S (9

[PATCH 4/9] drm/amdgpu: Enable devcoredump for JPEG5_0_1

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG5_0_1 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 65 +++- drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.h | 61 ++ 2 files changed, 124 insertions(+), 2 deletions(-) diff --git a

[PATCH 9/9] drm/amdgpu: Enable devcoredump for JPEG2_5_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_5_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c | 41 ++ 1 file changed, 41 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v2_5.c index

[PATCH 8/9] drm/amdgpu: Enable devcoredump for JPEG2_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG2_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c index

[PATCH 7/9] drm/amdgpu: Enable devcoredump for JPEG3_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG3_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c index

[PATCH 6/9] drm/amdgpu: Enable devcoredump for JPEG4_0_5

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_5 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 41 +++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 5/9] drm/amdgpu: Enable devcoredump for JPEG4_0_0

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_0 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 3/9] drm/amdgpu: Enable devcoredump for JPEG4_0_3

2025-01-28 Thread Sathishkumar S
Add register list and enable devcoredump for JPEG4_0_3 Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 58 1 file changed, 58 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c

[PATCH 2/9] drm/amdgpu: Add helper funcs for jpeg devcoredump

2025-01-28 Thread Sathishkumar S
Add devcoredump helper functions that can be reused for all jpeg versions. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c | 59 drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 7 +++ 2 files changed, 66 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 1/9] drm/amdgpu: Add a func for core specific reg offset

2025-01-28 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH 0/9] drm/amdgpu: Add jpeg devcoredump support

2025-01-28 Thread Sathishkumar S
This patch-series enables jpeg devcoredump support Sathishkumar S (9): drm/amdgpu: Add a func for core specific reg offset drm/amdgpu: Add helper funcs for jpeg devcoredump drm/amdgpu: Enable devcoredump for JPEG4_0_3 drm/amdgpu: Enable devcoredump for JPEG5_0_1 drm/amdgpu: Enable

[PATCH] drm/amdgpu: increase amdgpu max rings limit

2025-01-12 Thread Sathishkumar S
increase max rings to 132 to support all JPEG5_0_1 cores, else ring_init fails due to ring count exceeding maximum limit. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] drm/amdgpu: increase amdgpu max rings limit

2025-01-10 Thread Sathishkumar S
increase max rings to 132 to support all JPEG5_0_1 cores, else ring_init fails due to ring count exceeding maximum limit. Signed-off-by: Sathishkumar S Reviewed-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/2] drm/amdgpu: Add amdgpu_vcn_sched_mask debugfs

2024-11-11 Thread Sathishkumar S
Add debugfs entry to enable or disable job submission to specific vcn instances. The entry is created only when there is more than an instance and is unified queue type. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c

[PATCH 1/2] drm/amdgpu: Add a func for core specific reg offset

2024-11-11 Thread Sathishkumar S
Add an inline function to calculate core specific register offsets for JPEG v4.0.3 and reuse it, makes code more readable and easier to align. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 54 +++- 1 file changed, 24 insertions(+), 30 deletions

[PATCH] drm/amdgpu: Normalize reg offsets on VCN v4.0.3

2024-11-04 Thread Sathishkumar S
Remote access to external AIDs isn't possible with VCN RRMT disabled and it is disabled on SoCs with GC 9.4.4, so use only local offsets. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff

[PATCH] drm/amdgpu: Normalize reg offsets on VCN v4.0.3

2024-11-04 Thread Sathishkumar S
Remote access to external AIDs isn't possible with VCN RRMT disabled and it is disabled on SoCs with GC 9.4.4, so use only local offsets. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff

[PATCH] drm/amdgpu: add amdgpu_jpeg_sched_mask debugfs

2024-09-10 Thread Sathishkumar S
more cores in the jpeg ip. Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 + drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.c| 71 + drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h| 1 + 3 files changed, 74 insertions(+) diff --git a/drivers/gpu

[PATCH] drm/amdgpu: update jpeg max decode resolution

2024-04-22 Thread Sathishkumar S
jpeg ip version v2.1 and higher supports 16kx16k resolution decode Signed-off-by: Sathishkumar S --- drivers/gpu/drm/amd/amdgpu/nv.c| 6 +++--- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/soc21.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH v4 13/17] platform/x86/amd/pmf: Add PMF-AMDGPU get interface

2023-11-17 Thread Shyam Sundar S K
Hi Hans, Apologies for the long delay. On 10/19/2023 12:38 AM, Hans de Goede wrote: > Hi, > > I was not following this at first, so my apologies for > jumping in in the middle of the thread: > > > > >> +static int amd_pmf_gpu_get_cur_state(struct thermal_cooling_device >> *cooling_d

  1   2   3   4   5   >