Re: [PATCH 09/28] drm/meson: Use video aperture helpers

2024-09-30 Thread Neil Armstrong
On 30/09/2024 15:03, Thomas Zimmermann wrote: DRM's aperture functions have long been implemented as helpers under drivers/video/ for use with fbdev. Avoid the DRM wrappers by calling the video functions directly. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilma

Re: [PATCH v2 27/86] drm/meson: Run DRM default client setup

2024-08-21 Thread Neil Armstrong
s the default if no format has been given, leave it out entirely. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl --- drivers/gpu/drm/meson/meson_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gp

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica

Re: [PATCH 31/86] drm/panel/ili9341: Run DRM default client setup

2024-08-19 Thread Neil Armstrong
On 16/08/2024 14:22, Thomas Zimmermann wrote: Call drm_client_setup() to run the kernel's default client setup for DRM. Set fbdev_probe in struct drm_driver, so that the client setup can start the common fbdev client. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica

Re: [PATCH v3 2/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-22 Thread Neil Armstrong
select DRM_DISPLAY_HELPER help Say Y here if you want to enable support for LG sw43408 panel. The panel has a 1080x2160@60Hz resolution and uses 24 bit RGB per Reviewed-by: Neil Armstrong

Re: [PATCH v3 3/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-22 Thread Neil Armstrong
On 22/05/2024 08:25, Dmitry Baryshkov wrote: Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being declared. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ Reviewed-by: Neil Armstrong Fixes: 069a6c0e

Re: [PATCH] MAINTAINERS: drm/ci: add entries for xfail files

2023-10-02 Thread neil . armstrong
-foundation.org S:Maintained T:git git://anongit.freedesktop.org/drm/drm-misc +F: drivers/gpu/drm/ci/xfails/virtio* F:drivers/gpu/drm/virtio/ F:include/uapi/linux/virtio_gpu.h Reviewed-by: Neil Armstrong

Re: [PATCH 2/4] drm/bridge-connector: handle subconnector types

2023-08-02 Thread Neil Armstrong
On 29/07/2023 02:49, Dmitry Baryshkov wrote: If the created connector type supports subconnector type property, create and attach corresponding it. The default subtype value is 0, which maps to the DRM_MODE_SUBCONNECTOR_Unknown type. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_bri

Re: [PATCH 1/2] drm/amdgpu: Fix no-procfs build

2023-05-26 Thread Neil Armstrong
Hi, On Thu, 25 May 2023 08:52:24 -0700, Rob Clark wrote: > Fixes undefined symbol when PROC_FS is not enabled. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/2] drm/amdgpu: Fix no-procfs build https://cgit.freedesktop.org/drm/drm-misc/com

Re: [PATCH 2/2] drm/amdgpu: Remove duplicate fdinfo fields

2023-05-26 Thread Neil Armstrong
Hi Rob, On 25/05/2023 17:52, Rob Clark wrote: From: Rob Clark Some of the fields that are handled by drm_show_fdinfo() crept back in when rebasing the patch. Remove them again. Fixes: 376c25f8ca47 ("drm/amdgpu: Switch to fdinfo helper") Signed-off-by: Rob Clark --- drivers/gpu/drm/amd/amd

Re: (subset) [PATCH v4 0/9] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
On 24/05/2023 18:10, Neil Armstrong wrote: Hi, On Mon, 15 May 2023 07:30:07 -0700, Rob Clark wrote: Similar motivation to other similar recent attempt[1]. But with an attempt to have some shared code for this. As well as documentation. It is probably a bit UMA-centric, I guess devices with

Re: [PATCH v5 0/7] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
Hi, On Wed, 24 May 2023 08:59:30 -0700, Rob Clark wrote: > From: Rob Clark > > Similar motivation to other similar recent attempt[1]. But with an > attempt to have some shared code for this. As well as documentation. > > It is probably a bit UMA-centric, I guess devices with VRAM might want >

Re: (subset) [PATCH v4 0/9] drm: fdinfo memory stats

2023-05-24 Thread Neil Armstrong
Hi, On Mon, 15 May 2023 07:30:07 -0700, Rob Clark wrote: > Similar motivation to other similar recent attempt[1]. But with an > attempt to have some shared code for this. As well as documentation. > > It is probably a bit UMA-centric, I guess devices with VRAM might want > some placement stats

Re: [PATCH 01/13] drm/connector: Add define for HDMI 1.4 Maximum Pixel Rate

2021-11-03 Thread Neil Armstrong
Karlman > Cc: Jonathan Hunter > Cc: Joonas Lahtinen > Cc: Kevin Hilman > Cc: Laurent Pinchart > Cc: linux-amlo...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-te...@vger.kernel.org > Cc: Martin Blumenstingl > Cc: Neil Armstrong >

Re: [PATCH] drm/aperture: Pass DRM driver structure instead of driver name

2021-06-29 Thread Neil Armstrong
; > Signed-off-by: Thomas Zimmermann > --- ... > drivers/gpu/drm/meson/meson_drv.c | 2 +- Acked-by: Neil Armstrong ... > > diff --git a/drivers/gpu/drm/meson/meson_drv.c > b/drivers/gpu/drm/meson/meson_drv.c > index a7388bf7c838..3d0ccc7eef1b

Re: [PATCH 2/2] drm/edid: Add alternate clock for SMPTE 4K

2019-11-12 Thread Neil Armstrong
On 12/11/2019 08:53, Wayne Lin wrote: > [Why] > In hdmi_mode_alternate_clock(), it adds an exception for VIC 4 > mode (4096x2160@24) due to there is no alternate clock defined for > that mode in HDMI1.4b. But HDMI2.0 adds 23.98Hz for that mode. > > [How] > Remove the exception Shouldn't it be onl

Re: [PATCH v7 0/9] drm: cec: convert DRM drivers to the new notifier API

2019-08-19 Thread Neil Armstrong
Hi Dariusz, Hans, I can apply the dw-hdmi patches if necessary. Neil On 19/08/2019 11:38, Hans Verkuil wrote: > Hi all, > > The patches in this series can be applied independently from each other. > > If you maintain one of these drivers and you want to merge it for v5.4 > yourself, then pleas

Re: [PATCH 02/13] drm/radeon: Eliminate possible use of an uninitialized variable

2019-08-01 Thread Neil Armstrong
Hi Andrzej, I had to revert the previous patch, so you should re-spin it entirely : After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/gpu/drm/radeon/radeon_connectors.c: In function 'radeon_add_legacy_conne

Re: [PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

2019-08-01 Thread Neil Armstrong
On 01/08/2019 14:01, Daniel Vetter wrote: > On Thu, Aug 1, 2019 at 1:53 PM Neil Armstrong wrote: >> >> This reverts commit bed7a2182de6833f5d0f990a656bffb1c6000c70. >> >> It causes the following build error: >> ../drm/radeon/radeon_connectors.c: In func

[PATCH] Revert "drm/radeon: Provide ddc symlink in connector sysfs directory"

2019-08-01 Thread Neil Armstrong
s function) ddc = &radeon_connector->ddc_bus->adapter; ^~~ Suggested-by: Daniel Vetter Signed-off-by: Neil Armstrong --- drivers/gpu/drm/radeon/radeon_connectors.c | 142 ++--- 1 file changed, 36 insertions(+), 106 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_c

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
Hi Andrzej, On 31/07/2019 16:22, Neil Armstrong wrote: > On 31/07/2019 15:10, Andrzej Pietrasiewicz wrote: >> W dniu 31.07.2019 o 12:40, Sam Ravnborg pisze: >>> Hi Neil. >>> >>> On Wed, Jul 31, 2019 at 10:00:14AM +0200, Neil Armstrong wrote: >>>

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
On 31/07/2019 15:10, Andrzej Pietrasiewicz wrote: > W dniu 31.07.2019 o 12:40, Sam Ravnborg pisze: >> Hi Neil. >> >> On Wed, Jul 31, 2019 at 10:00:14AM +0200, Neil Armstrong wrote: >>> Hi Sam, >>> >>> On 26/07/2019 20:55, Sam Ravnborg wrote: >

Re: Review required [Was: Associate ddc adapters with connectors]

2019-07-31 Thread Neil Armstrong
Hi Sam, On 26/07/2019 20:55, Sam Ravnborg wrote: > Hi all. > > Andrzej have done a good job following up on feedback and this series is > now ready. > > We need ack on the patches touching the individual drivers before we can > proceed. > Please check your drivers and get back. I can apply all

Re: [PATCH v4 19/23] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-31 Thread Neil Armstrong
Hi, On 30/07/2019 19:30, Sam Ravnborg wrote: > Hi Neil. > >>> Signed-off-by: Andrzej Pietrasiewicz >>> --- >>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 40 +++ >>> 1 file changed, 20 insertions(+), 20 deletions(-) >>>

Re: [PATCH v6 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
ctor_type); > + ret = drm_connector_init_with_ddc(bridge->dev, &dvi->connector, > + &tfp410_con_funcs, > + dvi->connector_type, > + dvi->ddc); > if (ret) { >

Re: [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
> if (ret) { > DRM_ERROR("Failed to initialize connector\n"); > return ret; > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v4 20/23] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
return ret; > @@ -382,8 +381,8 @@ static int tfp410_fini(struct device *dev) > > drm_bridge_remove(&dvi->bridge); > > - if (dvi->ddc) > - i2c_put_adapter(dvi->ddc); > + if (dvi->connector.ddc) > + i2c_put_adapter(dvi->connector.ddc); > if (dvi->hpd) > gpiod_put(dvi->hpd); > > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v4 19/23] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
>adap); > - hdmi->ddc = NULL; > + hdmi->connector.ddc = NULL; > } > > if (hdmi->cec_notifier) > @@ -2788,7 +2788,7 @@ __dw_hdmi_probe(struct platform_device *pdev, > err_isfr: > clk_disable_unprepare(hdmi->isfr_clk); >

Re: [PATCH v4 18/23] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-30 Thread Neil Armstrong
->ddc); > + return PTR_ERR(vga->connector.ddc); > } > } > > @@ -216,8 +215,8 @@ static int dumb_vga_remove(struct platform_device *pdev) > > drm_bridge_remove(&vga->bridge); > > - if (!IS_ERR(vga->ddc)) > - i2c_put_adapter(vga->ddc); > + if (!IS_ERR(vga->connector.ddc)) > + i2c_put_adapter(vga->connector.ddc); > > return 0; > } > Reviewed-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm: Split out drm_probe_helper.h

2019-01-15 Thread Neil Armstrong
drivers/gpu/drm/mediatek/mtk_dpi.c| 2 +- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c| 2 +- > drivers/gpu/drm/mediatek/mtk_drm_fb.c | 2 +- > drivers/gpu/drm/mediatek/mtk_dsi.c| 2 +- > d

Re: [PATCH 7/7] drm: Split out drm_probe_helper.h

2018-12-10 Thread Neil Armstrong
S) BE LIABLE FOR ANY CLAIM, DAMAGES OR > + * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, > + * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef __DRM_PROBE_HELPER_H__ > +#define __DRM_PROBE_HELPER_H__ > + > +#include > + > +struct drm_connector; > +struct drm_device; > +struct drm_modeset_acquire_ctx; > + > +int drm_helper_probe_single_connector_modes(struct drm_connector > + *connector, uint32_t maxX, > + uint32_t maxY); > +int drm_helper_probe_detect(struct drm_connector *connector, > + struct drm_modeset_acquire_ctx *ctx, > + bool force); > +void drm_kms_helper_poll_init(struct drm_device *dev); > +void drm_kms_helper_poll_fini(struct drm_device *dev); > +bool drm_helper_hpd_irq_event(struct drm_device *dev); > +void drm_kms_helper_hotplug_event(struct drm_device *dev); > + > +void drm_kms_helper_poll_disable(struct drm_device *dev); > +void drm_kms_helper_poll_enable(struct drm_device *dev); > +bool drm_kms_helper_is_poll_worker(void); > + > +#endif > Acked-by: Neil Armstrong ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx