[PATCH 33/33] drm/amd/display: Enable mem low power control for DCN3.1 sub-IP blocks

From: Michael Strauss [WHY] Sequences to handle powering down these sub-IP blocks are now ready for use Reviewed-by: Eric Yang Acked-by: Mikita Lipski Signed-off-by: Michael Strauss --- .../drm/amd/display/dc/dcn31/dcn31_resource.c| 16 1 file changed, 8 insertions

[PATCH 32/33] drm/amd/display: remove force_enable_edp_fec param.

From: Ian Chen Reviewed-by: Wenjing Liu Acked-by: Mikita Lipski Signed-off-by: Ian Chen --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dc.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display

[PATCH 31/33] drm/amd/display: Add VPG and AFMT low power support for DCN3.1

From: Michael Strauss [WHY] Power down VPG and AFMT blocks when not in use [HOW] Create afmt31 and vpg31 structs and add necessary fields to reg list Reviewed-by: Eric Yang Acked-by: Mikita Lipski Signed-off-by: Michael Strauss --- drivers/gpu/drm/amd/display/dc/core/dc.c | 10

[PATCH 30/33] drm/amd/display: Revert adding degamma coefficients

From: Jaehyun Chung [Why] Degamma coefficients are calculated in our degamma formula using the regamma coefficients. We do not need to add separate degamma coefficients. [How] Remove the change to add separate degamma coefficients. Reviewed-by: Krunoslav Kovac Acked-by: Mikita Lipski Signed

[PATCH 25/33] drm/amd/display: [FW Promotion] Release 0.0.82

From: Anthony Koo * PSR SMU optimizations * MST dock fixes Reviewed-by: Anthony Koo Acked-by: Mikita Lipski Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dmub

[PATCH 28/33] drm/amd/display: Fix unstable HPCP compliance on Chrome Barcelo

-by: Bhawanpreet Lakha Acked-by: Mikita Lipski Signed-off-by: Qingqing Zhuo --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 +-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display

[PATCH 29/33] drm/amd/display: Link training retry fix for abort case

aborted. Reviewed-by: Jimmy Kizito Acked-by: Mikita Lipski Signed-off-by: Meenakshikumar Somasundaram --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu

[PATCH 27/33] drm/amd/display: 3.2.152

From: Aric Cyr * Correct degamma coefficients * Optimize bandwidth on following fast update * Fix multiple memory leaks reported by coverity * Get backlight from PWM if DMCU is not initialized Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd

[PATCH 22/33] drm/amd/display: dsc mst 2 4K displays go dark with 2 lane HBR3

n from compute_mst_dsc_configs_for_state to dm_update_mst_vcpi_slots_for_dsc Cc: sta...@vger.kernel.org Reviewed-by: Scott Foster Acked-by: Mikita Lipski Signed-off-by: Hersen Wu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 22 ++- .../display/amdgpu_dm/amdgpu_dm_mst_types.c

[PATCH 26/33] drm/amd/display: Correct degamma coefficients

From: Jaehyun Chung [Why] Some incorrect coefficients were being used Reviewed-by: Michael Strauss Acked-by: Mikita Lipski Signed-off-by: Jaehyun Chung --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu

[PATCH 24/33] drm/amd/display: Add helper for blanking all dp displays

From: "Leo (Hanghong) Ma" [Why & How] The codes to blank all dp display have been called many times, so add a helper in dc_link to make it more concise. Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/display/dc/core/

[PATCH 23/33] drm/amd/display: Add periodic detection when zstate is enabled

From: Eric Yang [Why] When system is in Z10 HPD interrupts cannot fire, we may miss display configuration changes. [How] When Zstate is enabled, if DMUB indicate DCN has lost power, do a complete detection periodically. Reviewed-by: Nicholas Kazlauskas Acked-by: Mikita Lipski Signed-off-by

[PATCH 21/33] drm/amd/display: Refine condition of cursor visibility for pipe-split

plane covers current half/whole pipe plane, disable cursor. Reviewed-by: Krunoslav Kovac Acked-by: Mikita Lipski Signed-off-by: Dale Zhao --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 43 +++ 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 19/33] drm/amd/display: Apply w/a for hard hang on HPD

access an irresponsive PHY and thus a hard hang on the system. [How] Disable 48mhz refclk off when there is any HPD status in connected state. Reviewed-by: Hersen Wu Acked-by: Mikita Lipski Signed-off-by: Qingqing Zhuo --- .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 12 - .../display

[PATCH 20/33] drm/amd/display: Optimize bandwidth on following fast update

hawanpreet Lakha Acked-by: Mikita Lipski Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/dc/core/dc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/

[PATCH 17/33] drm/amd/display: Revert "Directly retrain link from debugfs"

From: Anson Jacob This reverts commit f5b6a20c7ef40599095c796b0500d842ffdbc639. This patch broke new settings from taking effect. Hotplug is required for new settings to take effect. Reviewed-by: Mikita Lipski Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd

[PATCH 15/33] drm/amd/display: Fix multiple memory leaks reported by coverity

: 1466017: ("Resource leaks") Reviewed-by: Aurabindo Jayamohanan Pillai Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- .../gpu/drm/amd/display/dc/dcn30/dcn30_resource.c| 6 +- .../gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 6 +- .../gpu/drm/amd/display

[PATCH 18/33] drm/amd/display: Add regamma/degamma coefficients and set sRGB when TF is BT709

formula, causing the cutoff point of the linear section of the curve to be incorrect. [How] Set pixel format in the surface update sequence. Add separate coefficient arrays for regamma and degamma. Reviewed-by: Krunoslav Kovac Acked-by: Mikita Lipski Signed-off-by: Jaehyun Chung --- .../amd

[PATCH 16/33] drm/amd/display: Get backlight from PWM if DMCU is not initialized

...@vger.kernel.org Reviewed-by: Josip Pavic Acked-by: Mikita Lipski Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c| 16 .../gpu/drm/amd/display/dc/dce/dce_panel_cntl.c | 10 -- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a

[PATCH 11/33] drm/amd/display: Fix for null pointer access for ddc pin and aux engine.

From: Meenakshikumar Somasundaram [Why] Need a check for NULL pointer access for ddc pin and aux engine. [How] Adding a check for ddc pin and aux engine accesses. Reviewed-by: Jimmy Kizito Acked-by: Mikita Lipski Signed-off-by: Meenakshikumar Somasundaram --- .../gpu/drm/amd/display

[PATCH 13/33] drm/amd/display: Revert "dc: w/a for hard hang on HPD on native DP"

From: Qingqing Zhuo This reverts commit "drm/amd/display: w/a for hard hang on HPD on native DP". [How & Why] Revert change as it does not fix the hard hang in all cases. An alternative w/a will be submitted separately. Acked-by: Mikita Lipski Signed-off-by: Qingqing Zhu

[PATCH 12/33] drm/amd/display: [FW Promotion] Release 0.0.81

From: Anthony Koo * PSR optimizations * add support for ABM when ODM is enabled * Z10 with PSR fixes * Increase trace buffer Reviewed-by: Anthony Koo Acked-by: Mikita Lipski Signed-off-by: Anthony Koo --- drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 ++-- 1 file changed, 2 insertions

[PATCH 14/33] drm/amd/display: 3.2.151

From: Aric Cyr * coverity kernel memory leak fixes * NULL pointer dereference fixes * Add periodic detection when zstate is enabled * Fork thread to offload work of hpd_rx_irq Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Signed-off-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/dc.h | 2

[PATCH 10/33] drm/amd/display: Fix false BAD_FREE warning from Coverity

From: Anson Jacob This is an attempt to fix false warning raised by Coverity via multiple CID's. Addresses-Coverity-ID: 1487412 ("Free of address-of expression") Cc: Wesley Chalmers Reviewed-by: Wesley Chalmers Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- driv

[PATCH 09/33] drm/amd/display: Fix dynamic link encoder access.

function 'link_encs_assign' defined) and a link supports flexible mapping to DIGs, use the link_enc_cfg API to access the DIG assigned to a link or stream. Reviewed-by: Meenakshikumar Somasundaram Acked-by: Mikita Lipski Signed-off-by: Jimmy Kizito --- .../display/dc/clk

[PATCH 08/33] drm/amd/display: Add flag to detect dpms force off during HPD

ed-by: Mikita Lipski Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 19 +-- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 ++ .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 18 ++ 3 files changed, 29 insertions(+), 10 dele

[PATCH 06/33] drm/amd/display: Fork thread to offload work of hpd_rx_irq

l be handled by the order that dc_link_handle_hpd_rx_irq() used to be. * Change function name dm_handle_hpd_rx_irq() to dm_handle_mst_sideband_msg() to be more specific Reviewed-by: Nicholas Kazlauskas Acked-by: Mikita Lipski Signed-off-by: Wayne Lin --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 203 +

[PATCH 07/33] drm/amd/display: unblock abm when odm is enabled only on configs that support it

that combination unblocked can lead to one side of the screen appearing brighter than the other. [How] When ODM is enabled, unblock abm on dcn31 and block it on dcn30 Reviewed-by: Anthony Koo Acked-by: Mikita Lipski Signed-off-by: Josip Pavic --- drivers/gpu/drm/amd/display/dc/dcn30

[PATCH 05/33] drm/amd/display: Add option to defer works of hpd_rx_irq

lost handling flow out from dc_link_handle_hpd_rx_irq() and put those into a new function dc_link_dp_handle_link_loss() * Add one option parameter to decide whether defer works within dc_link_handle_hpd_rx_irq() Acked-by: Mikita Lipski Signed-off-by: Wayne Lin Reviewed-by: Nicholas Kazlau

[PATCH 04/33] drm/amd/display: update conditions to do dfp cap ext validation

evcie supporting 8b/10b channel coding only and it has no DSC passthrough capability. Acked-by: Mikita Lipski Signed-off-by: Wenjing Liu Reviewed-by: George Shen --- drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH 03/33] drm/amd/display: move bpp range decision in decide dsc bw range function

. Acked-by: Mikita Lipski Signed-off-by: Wenjing Liu Reviewed-by: George Shen --- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 6 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 126 ++-- 2 files changed, 69 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 02/33] drm/amd/display: Fix system hang at boot

From: "Leo (Hanghong) Ma" [Why] During DQE's promotion test, system hang issue is found on linux system; [How] 1. Add NULL pointor check for the link in the sequence trace function; 2. Get the right link for the stream encoder before blank DP stream; Acked-by: Mikita Lip

[PATCH 00/33] DC Patches September 08, 2021

This DC patchset brings improvements in multiple areas. In summary, we highlight: * bandwidth optimizations on following fast updates * fixes and code improvements of DP connector blanking * add thread to offload work of MST HPD IRQ function * fix gamma coefficients * provide backlight support fo

[PATCH 01/33] drm/amd/display: Add DPCD writes at key points

From: "Leo (Hanghong) Ma" This reverts commit "Revert "Add DPCD writes at key points" ". The following patch will fix the system hang issue. Signed-off-by: Leo (Hanghong) Ma Acked-by: Mikita Lipski Reviewed-by: Aric Cyr --- drivers/gpu/drm/amd/display/dc/core/

[PATCH 06/19] drm/amd/display: expose dsc overhead bw in dc dsc header

From: Wenjing Liu [why] DM needs to know how much overhead is added to DSC as result of AMD internal DSC limitation. Reviewed-by: George Shen Acked-by: Mikita Lipski Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 5 ++ drivers/gpu/drm/amd/display/dc/dsc

[PATCH 15/19] drm/amd/display: 3.2.151

From: Aric Cyr - memory leak fixes - fix unitialized lt_settings pointers - add DP trace functions - add null pointer checks for DP sequence trace functions - expose dsc overhead bw parameter to DM - block abm when odm is enabled Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Signed-off-by

[PATCH 18/19] drm/amd/display: Revert "Directly retrain link from debugfs"

From: Anson Jacob This reverts commit "drm/amd/display: Directly retrain link from debugfs". This patch broke new settings from taking effect. Hotplug is required for new settings to take effect. Reviewed-by: Mikita Lipski Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- d

[PATCH 04/19] drm/amd/display: Fix system hang at boot

c Cyr Acked-by: Mikita Lipski Signed-off-by: Leo (Hanghong) Ma --- .../drm/amd/display/dc/core/dc_link_hwss.c| 2 +- .../display/dc/dce110/dce110_hw_sequencer.c | 27 --- 2 files changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc

[PATCH 05/19] drm/amd/display: Drop unused privacy_mask setters and getters

From: Oliver Logush [Why and How] dwbc_funcs.set/get_privacy_mask isn't being used anymore, drop it Reviewed-by: Charlene Liu Acked-by: Mikita Lipski Signed-off-by: Oliver Logush --- drivers/gpu/drm/amd/display/dc/inc/hw/dwb.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/dr

[PATCH 16/19] drm/amd/display: Fix multiple memory leaks reported by coverity

: 1466017: ("Resource leaks") Reviewed-by: Aurabindo Jayamohanan Pillai Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 6 +- drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 6 +- drivers/gpu/drm/amd/

[PATCH 14/19] drm/amd/display: [FW Promotion] Release 0.0.81

From: Anthony Koo - Fix PSR1 residency to be captured per panel - Merge VBIOS DP AUX change - Pass panel instance in dirty rect message - Z10 bug fixes - add detection required bit to boot status - Match abm_state to interrupt event specified otg_inst Reviewed-by: Anthony Koo Acked-by: Mikita

[PATCH 08/19] drm/amd/display: Add option to defer works of hpd_rx_irq

lost handling flow out from dc_link_handle_hpd_rx_irq() and put those into a new function dc_link_dp_handle_link_loss() * Add one option parameter to decide whether defer works within dc_link_handle_hpd_rx_irq() Reviewed-by: Mikita Lipski Acked-by: Mikita Lipski Signed-off-by: Wayne Lin --- .../gpu

[PATCH 02/19] drm/amd/display: Initialize lt_settings on instantiation

From: Michael Strauss [WHY] lt_settings' pointers remain uninitialized but nonzero if display fails to light up with no DPCD/EDID info populated, leading to a hang on access Reviewed-by: Nicholas Kazlauskas Acked-by: Mikita Lipski Signed-off-by: Michael Strauss --- drivers/gpu/dr

[PATCH 13/19] drm/amd/display: Fix for null pointer access for ddc pin and aux engine.

From: Meenakshikumar Somasundaram [Why] Need a check for NULL pointer access for ddc pin and aux engine. [How] Adding a check for ddc pin and aux engine accesses. Reviewed-by: Jimmy Kizito Acked-by: Mikita Lipski Signed-off-by: Meenakshikumar Somasundaram --- drivers/gpu/drm/amd/display/dc

[PATCH 11/19] drm/amd/display: Add flag to detect dpms force off during HPD

uskas Acked-by: Mikita Lipski Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 +-- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 ++ .../amd/display/amdgpu_dm/amdgpu_dm_hdcp.c| 16 +++ 3 files changed, 28 insertions(+

[PATCH 09/19] drm/amd/display: Fork thread to offload work of hpd_rx_irq

nk_handle_hpd_rx_irq() used to be. * Change function name dm_handle_hpd_rx_irq() to dm_handle_mst_sideband_msg() to be more specific Reviewed-by: Nicholas Kazlauskas Acked-by: Mikita Lipski Signed-off-by: Wayne Lin --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 202 +

[PATCH 00/19] DC Patches August 23, 2021

This DC patchset brings improvements in multiple areas. In summary, we highlight: * Memory leak fixes and false positive warnings removed caught by coverity * Backlight fix for Carrizo/Stoney laptops * Unblocking ABM when ODM is enabled on DCN31 and up * Fork thread to offload work of hpd_rx_irq

[PATCH 03/19] drm/amd/display: Add DPCD writes at key points

From: "Leo (Hanghong) Ma" This reverts "drm/amd/display: Revert "Add DPCD writes at key points"." The following patch will fix the system hang issue. Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Signed-off-by: Leo (Hanghong) Ma --- drivers/gpu/drm/amd/

[PATCH 10/19] drm/amd/display: unblock abm when odm is enabled only on configs that support it

that combination unblocked can lead to one side of the screen appearing brighter than the other. [How] When ODM is enabled, unblock abm on dcn31 and block it on dcn30 Reviewed-by: Anthony Koo Acked-by: Mikita Lipski Signed-off-by: Josip Pavic --- drivers/gpu/drm/amd/display/dc/dcn30

[PATCH 12/19] drm/amd/display: Fix false BAD_FREE warning from Coverity

From: Anson Jacob This is an attempt to fix false warning raised by Coverity via multiple CID's. Addresses-Coverity-ID: 1487412 ("Free of address-of expression") Cc: Wesley Chalmers Reviewed-by: Wesley Chalmers Acked-by: Mikita Lipski Signed-off-by: Anson Jacob --- driv

[PATCH 19/19] drm/amd/display: Add regamma/degamma coefficients and set sRGB when TF is BT709

formula, causing the cutoff point of the linear section of the curve to be incorrect. [How] Set pixel format in the surface update sequence. Add separate coefficient arrays for regamma and degamma. Reviewed-by: Krunoslav Kovac Acked-by: Mikita Lipski Signed-off-by: Jaehyun Chung --- .../amd

[PATCH 17/19] drm/amd/display: Get backlight from PWM if DMCU is not initialized

...@vger.kernel.org Reviewed-by: Josip Pavic Acked-by: Mikita Lipski Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link.c| 16 .../gpu/drm/amd/display/dc/dce/dce_panel_cntl.c | 10 -- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a

[PATCH 07/19] drm/amd/display: move bpp range decision in decide dsc bw range function

. Reviewed-by: George Shen Acked-by: Mikita Lipski Signed-off-by: Wenjing Liu --- drivers/gpu/drm/amd/display/dc/dc_dsc.h | 6 +- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 132 +++- 2 files changed, 76 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 01/19] drm/amd/display: cleanup idents after a revert

From: Angus Wang [WHY] The change has caused high idle memory clock speed and power consumption at some resolutions and frame rates for Navi10 [HOW] Reverted change "drm/amd/display: Fixed Intermittent blue screen on OLED panel" Reviewed-by: Aric Cyr Acked-by: Mikita Lipski Sig

[PATCH 00/19] DC Patches August 23, 2021

This DC patchset brings improvements in multiple areas. In summary, we highlight: * Memory leak fixes and false positive warnings removed caught by coverity * Backlight fix for Carrizo/Stoney laptops * Unblocking ABM when ODM is enabled on DCN31 and up * Fork thread to offload work of hpd_rx_i

Re: [PATCH v3 01/20] drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()

Thanks for the change! Reviewed-by: Mikita Lipski On 2021-04-19 6:55 p.m., Lyude Paul wrote: While working on moving i2c device registration into drm_dp_aux_init() - I realized that in order to do so we need to make sure that drivers calling drm_dp_aux_init() handle any errors it could

Re: [PATCH] drm/amdgpu/display: fix warning when compiling without debugfs

Reviewed-by: Mikita Lipski Thanks, Mikita On 2020-04-08 9:31 a.m., Alex Deucher wrote: fixes unused variable warning. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd

Re: [PATCH 1/2] drm/amd/display: query hdcp capability during link detect

Both patches look good to me. The series is Reviewed-by: Mikita Lipski Thanks, Mikita On 2020-04-01 5:00 p.m., Bhawanpreet Lakha wrote: [Why] Query the hdcp caps of a link, it is useful and can be reported to the user [How] Create a query function and call it during link detect Signed-off

Re: [PATCH] drm/amd/display: Move drm_dp_mst_atomic_check() to the front of dc_validate_global_state()

Reviewed-by: Mikita Lipski Thanks! Mikita On 1/28/20 4:44 PM, Zhan Liu wrote: [Why] Need to do atomic check first, then validate global state. If not, when connecting both MST and HDMI displays and set a bad mode via xrandr, system will hang. [How] Move drm_dp_mst_atomic_check() to the front

Re: [PATCH v2] drm/amd/dm/mst: Ignore payload update failures

On 1/24/20 5:01 PM, Lyude Paul wrote: On Fri, 2020-01-24 at 16:46 -0500, Lyude Paul wrote: On Fri, 2020-01-24 at 14:20 -0500, Mikita Lipski wrote: On 1/24/20 2:10 PM, Lyude Paul wrote: Disabling a display on MST can potentially happen after the entire MST topology has been removed, which

Re: [PATCH v2] drm/amd/dm/mst: Ignore payload update failures

herwise the patch is good. Thanks again! Reviewed-by: Mikita Lipski Mikita return true; } @@ -285,7 +283,6 @@ bool dm_helpers_dp_mst_send_payload_allocation( struct amdgpu_dm_connector *aconnector; struct drm_dp_mst_topology_mgr *mst_mgr; struct drm_dp_

Re: [PATCH] drm/amd/dm/mst: Ignore payload update failures on disable

On 1/24/20 9:55 AM, Harry Wentland wrote: On 2020-01-23 7:06 p.m., Lyude Paul wrote: Disabling a display on MST can potentially happen after the entire MST topology has been removed, which means that we can't communicate with the topology at all in this scenario. Likewise, this also means tha

Re: [PATCH v9 12/18] drm/dp_mst: Add branch bandwidth validation to MST atomic check

On 1/17/20 10:09 AM, Sean Paul wrote: On Fri, Dec 13, 2019 at 3:09 PM wrote: From: Mikita Lipski Hi Mikita, Unfortunately this patch causes a crash on my i915 device when I unplug my MST hub. The panic is below. Hi Sean, I thought this issue was fixed by Wayne Lin in https

Re: [PATCH] drm/dp_mst: fix documentation of drm_dp_mst_add_affected_dsc_crtcs

Thank you, Reviewed-by: Mikita Lipski On 1/8/20 10:24 PM, Alex Deucher wrote: the parameter is the mst manager, not the port. Signed-off-by: Alex Deucher --- drivers/gpu/drm/drm_dp_mst_topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH v9 16/18] drm/amd/display: Recalculate VCPI slots for new DSC connectors

On 12/20/19 4:41 PM, Lyude Paul wrote: So I reviewed this already but realized I made a very silly mistake, comments down below: On Fri, 2019-12-13 at 15:08 -0500, mikita.lip...@amd.com wrote: From: Mikita Lipski [why] Since for DSC MST connector's PBN is claculated differently d

Re: [PATCH] drm/amd/display: replace BUG_ON with WARN_ON

crtc_state to enable CRTC. /* Scaling or underscan settings */ if (is_scaling_state_different(dm_old_conn_state, dm_new_conn_state)) -- Thanks, Mikita Lipski Software Engineer, AMD mikita.lip...@amd.com ___ amd-gfx mailing list amd-gfx@li

Re: [PATCH v8 11/17] drm/dp_mst: Add DSC enablement helpers to DRM

On 12/6/19 7:24 PM, Lyude Paul wrote: Nice! All I've got is a couple of typos I noticed and one question, this looks great :) Thanks! I'll clean it up. The response to the question is below. On Tue, 2019-12-03 at 09:35 -0500, mikita.lip...@amd.com wrote: From: Mikita Lipski

Re: [PATCH v9] drm/dp_mst: Add PBN calculation for DSC modes

te the tests in test-drm_dp_mst_helper.c Reviewed-by: Manasi Navare Reviewed-by: Lyude Paul Reviewed-by: Harry Wentland Signed-off-by: David Francis Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/drm_dp_mst_topology.c

Re: [PATCH v7 11/17] drm/dp_mst: Add DSC enablement helpers to DRM

On 26/11/2019 10:24, Leo wrote: On 2019-11-16 5:01 p.m., mikita.lip...@amd.com wrote: From: Mikita Lipski Adding a helper function to be called by drivers outside of DRM to enable DSC on the MST ports. Function is called to recalculate VCPI allocation if DSC is enabled and raise the DSC

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

On 20/11/2019 05:17, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:11:43PM -0500, Mikita Lipski wrote: On 19/11/2019 16:09, Mikita Lipski wrote: On 19/11/2019 12:11, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote: If you're going to make a

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

On 19/11/2019 16:09, Mikita Lipski wrote: On 19/11/2019 12:11, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 04:59:40PM +, Cornij, Nikola wrote: If you're going to make all of them the same, then u64, please. This is because I'm not sure if calculations require 64-bit at s

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

mikita.lip...@amd.com wrote: From: Mikita Lipski We shouldn't compare int with unsigned long to find the max value and since we are not expecting negative value returned from compute_offset we should make this function return unsigned long so we can compare the values when computing rc pa

Re: [PATCH] drm/dsc: Return unsigned long on compute offset

On 19/11/2019 09:56, Ville Syrjälä wrote: On Tue, Nov 19, 2019 at 09:45:26AM -0500, mikita.lip...@amd.com wrote: From: Mikita Lipski We shouldn't compare int with unsigned long to find the max value and since we are not expecting negative value returned from compute_offset we should

Re: [bug report] drm/amd/display: Add MST atomic routines

Hi Dan, The bug has been fixed by the patch "drm/amd/display: Fix unsigned variable compared to less than zero" by Gustavo A. R. Silva Thanks On 13.11.2019 13:28, Dan Carpenter wrote: Hello Mikita Lipski, The patch b4c578f08378: "drm/amd/display: Add MST atomic routines&qu

Re: [PATCH] drm/amd/display: Fix unsigned variable compared to less than zero

Thanks for catching it! Reviewed-by: Mikita Lipski On 11.11.2019 12:25, Gustavo A. R. Silva wrote: Currenly, the error check below on variable*vcpi_slots* is always false because it is a uint64_t type variable, hence, the values this variable can hold are never less than zero: drivers/gpu

Re: [PATCH][next] drm/amd/display: fix dereference of pointer aconnector when it is null

Thanks! Reviewed-by: Mikita Lipski On 08.11.2019 9:38, Colin King wrote: > From: Colin Ian King > > Currently pointer aconnector is being dereferenced by the call to > to_dm_connector_state before it is being null checked, this could > lead to a null pointer dereference. Fix t

Re: [PATCH 01/13] drm/amd/display: Add MST atomic routines

On 31.10.2019 9:16, Kazlauskas, Nicholas wrote: > On 2019-10-30 3:24 p.m., mikita.lip...@amd.com wrote: >> From: Mikita Lipski >> >> - Adding encoder atomic check to find vcpi slots for a connector >> - Using DRM helper functions to calculate PBN >> - Adding

Re: [PATCH v7] drm/amd/display: Add MST atomic routines

On 30.10.2019 14:19, Kazlauskas, Nicholas wrote: > On 2019-10-28 10:31 a.m., mikita.lip...@amd.com wrote: >> From: Mikita Lipski >> >> - Adding encoder atomic check to find vcpi slots for a connector >> - Using DRM helper functions to calculate PBN >> - Adding

Re: [PATCH v5] drm/amd/display: Add MST atomic routines

On 25.10.2019 8:06, Kazlauskas, Nicholas wrote: > On 2019-10-24 5:06 p.m., mikita.lip...@amd.com wrote: >> From: Mikita Lipski >> >> - Adding encoder atomic check to find vcpi slots for a connector >> - Using DRM helper functions to calculate PBN >> - Adding

Re: [PATCH] drm/amdgpu/display: fix build when CONFIG_DRM_AMD_DC_DSC_SUPPORT=n

Reviewed-by: Mikita Lipski On 16.10.2019 12:13, Alex Deucher wrote: > Add proper config check. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/

Re: [PATCH 13/14] drm/amd/display: Recalculate VCPI slots for new DSC connectors

Linux kernel can be a confusing endeavor. I'm more then happy to help out >> with >> this wherever I can, all you need to do is ask. Asking a few questions about >> something you aren't sure you understand can save both of us a lot of time, >> and avoid having to g

Re: [PATCH 15/15] drm/amd/display: Trigger modesets on MST DSC connectors

; +#endif >> + >> static void get_freesync_config_for_crtc( >> struct dm_crtc_state *new_crtc_state, >> struct dm_connector_state *new_con_state) >> @@ -7388,6 +7456,17 @@ static int amdgpu_dm_atomic_check(struct drm_device >> *dev, >> if (ret) &

Re: [PATCH 05/14] drm/amd/display: Enable SST DSC in DM

Tested-by: Mikita Lipski Mikita Lipski On 2019-08-19 11:50 a.m., David Francis wrote: > In create_stream_for_sink, check for SST DP connectors > > Parse DSC caps to DC format, then, if DSC is supported, > compute the config > > DSC hardware will be programmed by dc_co

Re: [PATCH] drm/amd/display: add a check for display depth validity

On 2018-07-04 04:51 PM, Harry Wentland wrote: On 2018-07-04 04:40 PM, mikita.lip...@amd.com wrote: From: Mikita Lipski [why] HDMI 2.0 fails to validate 4K@60 timing with 10 bpc [how] Adding a helper function that would verify if the display depth assigned would pass a bandwidth validation

Re: [PATCH] drm/amdgpu: Disable irq on device before destroying it

On 2018-03-15 10:15 AM, Alex Deucher wrote: On Thu, Mar 15, 2018 at 10:10 AM, wrote: From: Mikita Lipski Disable irq on devices before destroying them. That prevents use-after-free memory access when unloading the driver. Signed-off-by: Mikita Lipski --- drivers/gpu/drm/amd/amdgpu