stead of embedding it
v2")
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_object.c | 29 -
drivers/gpu/drm/radeon/radeon_object.h | 2 +-
drivers/gpu/drm/radeon/radeon_ttm.c| 13 ++---
3 files changed, 23 insertions(+), 21 deletion
On Wednesday, June 23, 2021 2:55:04 AM EDT Christian König wrote:
> Please rather keep the new resource as parameter here and update before
> adjusting bo->resource.
>
> This way you also don't need to export radeon_update_memory_usage().
I wasn't sure exactly what you intended with the request t
stead of embedding it
v2")
Signed-off-by: Mikel Rychliski
---
v2: Update statistics on ghost object destroy
drivers/gpu/drm/radeon/radeon_object.c | 33 -
drivers/gpu/drm/radeon/radeon_object.h | 7 ---
drivers/gpu/drm/radeon/radeon_ttm
stead of embedding it
v2")
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_object.c | 23 +++
drivers/gpu/drm/radeon/radeon_object.h | 7 ---
drivers/gpu/drm/radeon/radeon_ttm.c| 20 +---
3 files changed, 24 insertions(+), 26
omio() instead of kmemdup().
pci_platform_rom() now has no remaining callers, so remove it.
Signed-off-by: Mikel Rychliski
---
Tested on a MacPro 1,1 with a Radeon X1900 XT card and 32-bit kernel.
Changes in v3:
- Inline pci_platform_rom()
Changes in v2:
- Add iounmap() call in nouveau
- Update
Hi Christoph,
Thanks for your comments. I'm also replying here to your comments on the
previous series.
On Tuesday, March 17, 2020 10:28:35 AM EDT Christoph Hellwig wrote:
> Any reason drivers can't just use pci_map_rom insteadἅ which already
> does the right thing?
Some machines don't expose t
pci_platform_rom() returns an __iomem pointer which should not be
accessed directly. Change radeon_read_platform_bios() to use
memcpy_fromio() instead of calling kmemdup() on the __iomem pointer.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_bios.c | 11 +++
1 file
using ioremap() instead of phys_to_virt() in
pci_platform_rom().
Now that pci_platform_rom() creates a new mapping to access the ROM
image, update all callers to remove this mapping after extracting the
BIOS.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 1
commit messages
Mikel Rychliski (2):
drm/radeon: Stop directly referencing iomem
PCI: Use ioremap(), not phys_to_virt() for platform ROM
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/bios/shadowpci.c | 11 ++-
drivers/gpu/drm/radeon
pci_platform_rom() returns an __iomem pointer which should not be
accessed directly. Change radeon_read_platform_bios() to use
memcpy_fromio() instead of calling kmemdup() on the __iomem pointer.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_bios.c | 11 +++
1 file
This patch series fixes an oops when loading the radeon driver on old Macs
with a 32-bit EFI implementation.
Tested on a MacPro 1,1 with a Radeon X1900 XT card and 32-bit kernel.
Mikel Rychliski (2):
drm/radeon: Stop directly referencing iomem
PCI: Use ioremap(), not phys_to_virt() for
using ioremap() instead of phys_to_virt() in
pci_platform_rom().
Now that pci_platform_rom() creates a new mapping to access the ROM
image, update all callers to remove this mapping after extracting the
BIOS.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 1
On Tuesday, March 3, 2020 9:38:27 AM EST Bjorn Helgaas wrote:
> Cosmetics:
>
> s/ioremap/ioremap()/ (also in commit log)
> s/phys_to_virt/phys_to_virt()/ (also in commit log)
> s/pci_platform_rom/pci_platform_rom()/ (commit log)
> s/rom/ROM/
> This changes the interface of pci_platform_rom() (the
This patch set fixes an opps when loading the radeon driver on old Macs
with a 32-bit EFI implementation.
Tested on a MacPro 1,1 with a Radeon X1900 XT card and 32-bit kernel.
Mikel Rychliski (4):
drm/radeon: Stop directly referencing iomem
PCI: Use ioremap, not phys_to_virt for platform rom
Now that pci_platform_rom creates a new mapping to access the ROM
image, we should remove this mapping after extracting the BIOS.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu
Now that pci_platform_rom creates a new mapping to access the ROM
image, we should remove this mapping after extracting the BIOS.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_bios.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_bios.c
b
map instead of phys_to_virt in pci_platform_rom.
Signed-off-by: Mikel Rychliski
---
drivers/pci/rom.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/pci/rom.c b/drivers/pci/rom.c
index 137bf0cee897..e352798eed0c 100644
--- a/drivers/pci/rom.c
+++ b/drivers/pci/r
pci_platform_rom returns an __iomem pointer which should not be accessed
directly. Change radeon_read_platform_bios to use memcpy_fromio instead of
calling kmemdup on the __iomem pointer.
Signed-off-by: Mikel Rychliski
---
drivers/gpu/drm/radeon/radeon_bios.c | 11 +++
1 file changed, 7
18 matches
Mail list logo
