; 0003
> [ 31.785825] R10: bd72c0623778 R11: 9a93d07fffe8 R12:
> 9a8c8a4cd000
> [ 31.785826] R13: 9a8c832ac200 R14: 0000 R15:
> 9a8c8a4cd000
> [ 31.785827] FS: () GS:9a93de08()
> knlGS:00
lex H)
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 ++-
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 31 ++
.../display/amdgpu_dm/amdgpu_dm_mst_types.c | 21
.../gpu/drm/amd/display/amdgpu_dm/dc_edid.c |
Add Linux opaque object to dc_sink for storing EDID data cross driver,
drm_edid. Also include the Linux call to free this object, the
drm_edid_free()
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.c | 6 ++
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.h | 1
existent drm_edid_eq().
v2:
- rename drm_edid_eq to drm_edid_eq_buf (jani)
- add NULL checks (jani)
v3:
- fix kernel-doc (jani)
- fix parameter names
Reviewed-by: Jani Nikula
Co-developed-by: Rodrigo Siqueira
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
From: Rodrigo Siqueira
As part of the effort of stopping using raw edid, this commit move the
copy of the edid in DC to a dedicated function that will allow the usage
of drm_edid in the next steps.
Signed-off-by: Rodrigo Siqueira
Co-developer-by: Melissa Wen
Signed-off-by: Melissa Wen
From: Rodrigo Siqueira
Since DC is a shared code, this commit introduces a new file to work as
a mid-layer in DC for the edid manipulation.
Signed-off-by: Rodrigo Siqueira
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/Makefile| 1
tions.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link_exports.c | 9 -
drivers/gpu/drm/amd/display/dc/dc.h | 9 -
drivers/gpu/drm/amd/display/dc/inc/link.h | 9 -
drivers/gpu/drm/amd/display/dc/link/link_detection.c
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c
: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 2e6116a6b518
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 22 ++-
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index
Instead of using driver-specific code, use DRM helpers.
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
move drm_edid new func declaration to its section (jani)
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
drivers/gpu/drm/drm_edid.c
m (?);
3. open-coded parser that I suspect is a lot of duplicated code, but
needs careful examining.
I suggest to address those points in a next phase for regression control.
[1] https://lore.kernel.org/amd-gfx/20250308142650.35920-1-m...@igalia.com/
Let me know yours thoughts!
Melissa
Melissa
Use drm_edid_product_id [1] to get debug info from drm_edid instead of
directly parsing raw EDID.
[1] 3ddbd345539e ("drm/edid: add drm_edid_get_product_id()").
Signed-off-by: Melissa Wen
--
v5:
- replace series url to commit hash (Mario)
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm
Groundwork that allocates a temporary drm_edid from raw edid to take
advantage of DRM common-code helpers instead of driver-specific code.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Make sure the drm_edid container stored in aconnector is freed when
destroying the aconnector.
Fixes: 48edb2a4256e ("drm/amd/display: switch amdgpu_dm_connector to use struct
drm_edid")
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display
On 18-07-2025 00:51, Matthew Schwartz wrote:
[...]
>
> Sure, going to use my Legion Go S w/ Z2 Go for this (DCN 3.1.2). All
> of these are from amd-staging-drm-next with AMD_PRIVATE_COLOR=y.
>
> DTN log from Hades II with MangoHud enabled:
> https://gist.github.com/matte-schwartz/0c290ffe99bdb4f0
On 17-07-2025 19:17, Matthew Schwartz wrote:
> On Thu, Jul 17, 2025 at 12:43 PM Melissa Wen wrote:
>>
>>
>>
>> On 17/07/2025 16:28, Matthew Schwartz wrote:
>> > On Thu, Jul 17, 2025 at 12:18 PM Melissa Wen wrote:
>> >> On 17-07-2025 17:57, Matth
On 17/07/2025 16:28, Matthew Schwartz wrote:
On Thu, Jul 17, 2025 at 12:18 PM Melissa Wen wrote:
On 17-07-2025 17:57, Matthew Schwartz wrote:
On Jul 17, 2025, at 9:58 AM, Limonciello, Mario
wrote:
On 7/17/25 11:55 AM, Melissa Wen wrote:
On 17-07-2025 13:39, Limonciello, Mario wrote
On 17-07-2025 17:57, Matthew Schwartz wrote:
>> On Jul 17, 2025, at 9:58 AM, Limonciello, Mario
>> wrote:
>>
>> On 7/17/25 11:55 AM, Melissa Wen wrote:
>>> On 17-07-2025 13:39, Limonciello, Mario wrote:
>>>> On 7/17/25 9:36 AM,
On 17-07-2025 15:58, Limonciello, Mario wrote:
> On 7/17/25 11:55 AM, Melissa Wen wrote:
>> On 17-07-2025 13:39, Limonciello, Mario wrote:
>>> On 7/17/25 9:36 AM, Melissa Wen wrote:
>>>> This reverts commit e1bd5e0bb4ca0d633ad698abd3658f8265009b81.
>>>>
&g
On 17-07-2025 15:55, Melissa Wen wrote:
> On 17-07-2025 13:39, Limonciello, Mario wrote:
>> On 7/17/25 9:36 AM, Melissa Wen wrote:
>>> This reverts commit e1bd5e0bb4ca0d633ad698abd3658f8265009b81.
>>>
>>> The commit causes a regression in Steam Deck (DCN 3
On 17-07-2025 13:39, Limonciello, Mario wrote:
> On 7/17/25 9:36 AM, Melissa Wen wrote:
>> This reverts commit e1bd5e0bb4ca0d633ad698abd3658f8265009b81.
>>
>> The commit causes a regression in Steam Deck (DCN 3.01), reintroducing a
>> functional issue reported in [1] th
river doesn't
clear update flags.
Besides that, the issue the commit e1bd5e0bb4ca tries to address [2]
isn't functional.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3441 [1]
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/4129 [2]
Signed-off-by: Melissa Wen
---
driv
On 14/07/2025 19:43, Melissa Wen wrote:
On 11/07/2025 16:50, Mario Limonciello wrote:
On 7/10/2025 4:25 PM, ivan.lip...@amd.com wrote:
From: Charlene Liu
[why]
dc has some code out of sync:
dc_commit_updates_for_stream handles v1/v2/v3,
but dc_update_planes_and_stream makes v1 asic to
On 11/07/2025 16:50, Mario Limonciello wrote:
On 7/10/2025 4:25 PM, ivan.lip...@amd.com wrote:
From: Charlene Liu
[why]
dc has some code out of sync:
dc_commit_updates_for_stream handles v1/v2/v3,
but dc_update_planes_and_stream makes v1 asic to use v2.
as a reression fix: limit clear_upda
On 17/06/2025 00:17, Alex Hung wrote:
The degamma is to be handled by Color pipeline API.
Signed-off-by: Alex Hung
---
V10:
- Disable CRTC degamma when color pipeline is enabled (Melissa Wen)
.../drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 15 ++-
1 file changed, 10
On 17/06/2025 00:17, Alex Hung wrote:
Check dpp.hw_3d_lut before creating shaper tf/lut and 3dlut colorops in
colorpipeline and handling these colorops.
Signed-off-by: Alex Hung
---
V10:
- Check dpp.hw_3d_lut before creating shaper tf/lut and 3dlut colorops
(Melissa Wen)
.../amd
On 17/06/2025 00:17, Alex Hung wrote:
Expose one 1D curve colorop with support for
DRM_COLOROP_1D_CURVE_SRGB_EOTF and program HW to perform
the sRGB transform when the colorop is not in bypass.
With this change the following IGT test passes:
kms_colorop --run plane-XR30-XR30-srgb_eotf
The co
Reduce direct handling of edid data by resorting to drm helpers that
deal with this info inside drm_edid infrastructure.
v3:
- use dc_edid_sink_edid_free in link_detection
v5:
- no need of drm_edid duplication (Mario)
- fix mem leak on dc_sink->drm_edid
Signed-off-by: Melissa Wen
---
.../
Add Linux opaque object to dc_sink for storing EDID data cross driver,
drm_edid. Also include the Linux call to free this object, the
drm_edid_free()
Signed-off-by: Melissa Wen
---
v3:
- remove uneccessary include (jani)
v5:
- fix comment (Mario)
---
drivers/gpu/drm/amd/display/amdgpu_dm
existent drm_edid_eq().
v2:
- rename drm_edid_eq to drm_edid_eq_buf (jani)
- add NULL checks (jani)
v3:
- fix kernel-doc (jani)
- fix parameter names
Reviewed-by: Jani Nikula
Co-developed-by: Rodrigo Siqueira
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
From: Rodrigo Siqueira
As part of the effort of stopping using raw edid, this commit move the
copy of the edid in DC to a dedicated function that will allow the usage
of drm_edid in the next steps.
Signed-off-by: Rodrigo Siqueira
Co-developer-by: Melissa Wen
Signed-off-by: Melissa Wen
From: Rodrigo Siqueira
Since DC is a shared code, this commit introduces a new file to work as
a mid-layer in DC for the edid manipulation.
Signed-off-by: Rodrigo Siqueira
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
v3:
- rebase on top of asdn
---
.../gpu/drm/amd/display
tions.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link_exports.c | 9 -
drivers/gpu/drm/amd/display/dc/dc.h | 9 -
drivers/gpu/drm/amd/display/dc/inc/link.h | 9 -
drivers/gpu/drm/amd/display/dc/link/link_detection.c
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
Signed-off-by: Melissa Wen
---
v4:
- fix kernel-doc
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +---
.../amd/display/amdg
: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index 10af9db47c39
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 22 ++-
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
index
Instead of using driver-specific code, use DRM helpers.
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
move drm_edid new func declaration to its section (jani)
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
drivers/gpu/drm/drm_edid.c
Use drm_edid_product_id [1] to get debug info from drm_edid instead of
directly parsing raw EDID.
[1] 3ddbd345539e ("drm/edid: add drm_edid_get_product_id()").
Signed-off-by: Melissa Wen
--
v5:
- replace series url to commit hash (Mario)
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm
ss those points in a next phase for regression control.
Finally, I'm not sure amdgpu_dm/dc_edid is the right place and file name
for the mid-layer. Suggestions?
[1] https://lore.kernel.org/amd-gfx/20250308142650.35920-1-m...@igalia.com/
Let me know yours thoughts!
Melissa
Melissa Wen (12)
Groundwork that allocates a temporary drm_edid from raw edid to take
advantage of DRM common-code helpers instead of driver-specific code.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Make sure the drm_edid container stored in aconnector is freed when
destroying the aconnector.
Fixes: 48edb2a4256e ("drm/amd/display: switch amdgpu_dm_connector to use struct
drm_edid")
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display
On 13/06/2025 15:53, Mario Limonciello wrote:
On 6/13/2025 9:58 AM, Melissa Wen wrote:
Since [1], we can use drm_edid_product_id to get debug info from
drm_edid instead of directly parsing EDID.
Link:
https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/
[1]
This
On 13/06/2025 15:48, Mario Limonciello wrote:
On 6/13/2025 9:58 AM, Melissa Wen wrote:
From: Rodrigo Siqueira
Since DC is a shared code, this commit introduces a new file to work as
a mid-layer in DC for the edid manipulation.
v3:
- rebase on top of asdn
Can you put changelog below
On 13/06/2025 15:38, Mario Limonciello wrote:
On 6/13/2025 9:58 AM, Melissa Wen wrote:
From: Rodrigo Siqueira
As part of the effort of stopping using raw edid, this commit move the
copy of the edid in DC to a dedicated function that will allow the usage
of drm_edid in the next steps.
v3
On 13/06/2025 15:35, Mario Limonciello wrote:
On 6/13/2025 9:58 AM, Melissa Wen wrote:
AMD driver has a function used to compare if two edid are the same; this
is useful to some of the link detection algorithms implemented by
amdgpu. Since the amdgpu function can be helpful for other drivers
On 13/06/2025 15:23, Mario Limonciello wrote:
On 6/13/2025 12:42 PM, Melissa Wen wrote:
On 06/13, Mario Limonciello wrote:
On 6/13/2025 7:58 AM, Melissa Wen wrote:
Add Linux opaque object to dc_sink for storing edid data cross driver,
drm_edid. Also include the Linux call to free this
On 13/06/2025 15:26, Mario Limonciello wrote:
On 6/13/2025 9:58 AM, Melissa Wen wrote:
Reduce direct handling of edid data by resorting to drm helpers that
deal with this info inside drm_edid infrastructure.
v3:
- use dc_edid_sink_edid_free in link_detection
Signed-off-by: Melissa Wen
On 06/13, Mario Limonciello wrote:
> On 6/13/2025 7:58 AM, Melissa Wen wrote:
> > Add Linux opaque object to dc_sink for storing edid data cross driver,
> > drm_edid. Also include the Linux call to free this object, the
> > drm_edid_free()
> >
> > v3:
>
Add Linux opaque object to dc_sink for storing edid data cross driver,
drm_edid. Also include the Linux call to free this object, the
drm_edid_free()
v3:
- remove uneccessary include (jani)
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.c | 6 ++
drivers/gpu
Reduce direct handling of edid data by resorting to drm helpers that
deal with this info inside drm_edid infrastructure.
v3:
- use dc_edid_sink_edid_free in link_detection
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++
.../amd/display
existent drm_edid_eq().
v2:
- rename drm_edid_eq to drm_edid_eq_buf (jani)
- add NULL checks (jani)
v3:
- fix kernel-doc (jani)
- fix parameter names
Reviewed-by: Jani Nikula
Co-developed-by: Rodrigo Siqueira
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
Wen
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.c | 8
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.h | 2 ++
drivers/gpu/drm/amd/display/dc/link/link_detection.c | 3 +--
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers
From: Rodrigo Siqueira
Since DC is a shared code, this commit introduces a new file to work as
a mid-layer in DC for the edid manipulation.
v3:
- rebase on top of asdn
Signed-off-by: Rodrigo Siqueira
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display
tions.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link_exports.c | 9 -
drivers/gpu/drm/amd/display/dc/dc.h | 9 -
drivers/gpu/drm/amd/display/dc/inc/link.h | 9 -
drivers/gpu/drm/amd/display/dc/link/link_detection.c
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
v4:
- fix kernel-doc
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +---
.../amd/display/amdg
drm_edid_connector_update() updates display info, filling ELD with
speaker allocation data in the last step of update_dislay_info(). Our
goal is stopping using raw edid, so we can extract SADB from drm_eld
instead of access raw edid to get audio caps.
Signed-off-by: Melissa Wen
---
.../drm/amd
drm_edid_connector_update() updates display info, filling ELD with audio
info from Short-Audio Descriptors in the last step of
update_dislay_info(). Our goal is stopping using raw edid, so we can
extract SAD from drm_eld instead of access raw edid to get audio caps.
Signed-off-by: Melissa Wen
...@igalia.com/
Let me know yours thoughts!
Melissa
Melissa Wen (12):
drm/amd/display: make sure drm_edid stored in aconnector doesn't leak
drm/amd/display: start using drm_edid helpers to parse EDID caps
drm/amd/display: use drm_edid_product_id for parsing EDID product info
drm/edid
Instead of using driver-specific code, use DRM helpers.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu
move drm_edid new func declaration to its section (jani)
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
drivers/gpu/drm/drm_edid.c
Since [1], we can use drm_edid_product_id to get debug info from
drm_edid instead of directly parsing EDID.
Link:
https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/
[1]
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15
Groundwork that allocates a temporary drm_edid from raw edid to take
advantage of DRM common-code helpers instead of driver-specific code.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Make sure the drm_edid container stored in aconnector is freed when
destroying the aconnector.
Fixes: 48edb2a4 ("drm/amd/display: switch amdgpu_dm_connector to use struct
drm_edid")
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/a
lidate_stream_and_context(struct dc *dc,
> if (dc_result == DC_OK)
> dc_result = dc_validate_global_state(dc, dc_state,
> DC_VALIDATE_MODE_ONLY);
>
> -cleanup:
> - if (dc_state)
> - dc_state_release(dc_state);
> -
> - if (dc_plane_state)
>
On 14/05/2025 17:19, Melissa Wen wrote:
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +
.../amd/di
Add Linux opaque object to dc_sink for storing edid data cross driver,
drm_edid. Also include the Linux call to free this object, the
drm_edid_free()
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.c | 6 ++
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.h | 1
Reduce direct handling of edid data by resorting to drm helpers that
deal with this info inside drm_edid infrastructure.
v3:
- remove uneccessary include (jani)
- use dc_edid_sink_edid_free in link_detection
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26
existent drm_edid_eq().
v2:
- rename drm_edid_eq to drm_edid_eq_buf (jani)
- add NULL checks (jani)
v3:
- fix kernel-doc (jani)
- fix parameter names
Reviewed-by: Jani Nikula
Co-developed-by: Rodrigo Siqueira
Signed-off-by: Rodrigo Siqueira
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
Wen
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.c | 8
drivers/gpu/drm/amd/display/amdgpu_dm/dc_edid.h | 2 ++
drivers/gpu/drm/amd/display/dc/link/link_detection.c | 3 +--
3 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers
tions.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link_exports.c | 9 -
drivers/gpu/drm/amd/display/dc/dc.h | 9 -
drivers/gpu/drm/amd/display/dc/inc/link.h | 9 -
drivers/gpu/drm/amd/display/dc/link/link_detection.c
From: Rodrigo Siqueira
Since DC is a shared code, this commit introduces a new file to work as
a mid-layer in DC for the edid manipulation.
v3:
- rebase on top of asdn
Signed-off-by: Rodrigo Siqueira
Co-developed-by: Melissa Wen
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display
d is the right place and file name
for the mid-layer. Suggestions?
[1] https://lore.kernel.org/amd-gfx/20250308142650.35920-1-m...@igalia.com/
Let me know yours thoughts!
Melissa
Melissa Wen (12):
drm/amd/display: make sure drm_edid stored in aconnector doesn't leak
drm/amd/display: sta
move drm_edid new func declaration to its section (jani)
Signed-off-by: Melissa Wen
---
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +-
drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
drivers/gpu/drm/display/drm_dp_mst_topology.c | 2 +-
drivers/gpu/drm/drm_edid.c
Instead of using driver-specific code, use DRM helpers.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c
b/drivers/gpu
drm_edid_connector_update() updates display info, filling ELD with audio
info from Short-Audio Descriptors in the last step of
update_dislay_info(). Our goal is stopping using raw edid, so we can
extract SAD from drm_eld instead of access raw edid to get audio caps.
Signed-off-by: Melissa Wen
drm_edid_connector_update() updates display info, filling ELD with
speaker allocation data in the last step of update_dislay_info(). Our
goal is stopping using raw edid, so we can extract SADB from drm_eld
instead of access raw edid to get audio caps.
Signed-off-by: Melissa Wen
---
.../drm/amd
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c
Groundwork that allocates a temporary drm_edid from raw edid to take
advantage of DRM common-code helpers instead of driver-specific code.
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c| 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff
Since [1], we can use drm_edid_product_id to get debug info from
drm_edid instead of directly parsing EDID.
Link:
https://lore.kernel.org/dri-devel/cover.1712655867.git.jani.nik...@intel.com/
[1]
Signed-off-by: Melissa Wen
---
.../drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 15
Make sure the drm_edid container stored in aconnector is freed when
destroying the aconnector.
Fixes: 48edb2a4 ("drm/amd/display: switch amdgpu_dm_connector to use struct
drm_edid")
Reviewed-by: Mario Limonciello
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/amdgpu_dm/a
On 08/05/2025 08:47, Jani Nikula wrote:
On Tue, 06 May 2025, Melissa Wen wrote:
AMD driver has a function used to compare if two edid are the same; this
is useful to some of the link detection algorithms implemented by
amdgpu. Since the amdgpu function can be helpful for other drivers, this
On 08/05/2025 08:39, Jani Nikula wrote:
On Tue, 06 May 2025, Melissa Wen wrote:
Original drm_edid_get_monitor_name encapsulates raw edid in drm_edid and
then call get_monitor_name. AMD still stores the display name for
debugging, but it is migrating to drm_edid, on the other hand
Color gamut_remap state log may be not avaiable for some hw versions, so
prevent null pointer dereference by checking if there is a function to
collect data for this hw version.
v2:
- initialize is_gamut_remap_available (Alex H)
Signed-off-by: Melissa Wen
---
.../amd/display/dc/hwss/dcn20
look.
Melissa
Thanks
On 4/30/25 08:20, Melissa Wen wrote:
Hi,
I've been examining dcn401 code to figure out what is causing a wrong
cursor gamma on HDR issue reported in [1], and I found unnecessary code
duplications during this inspection. I don't have the HW, so I'd
appreciate if
On 13/05/2025 15:27, Alex Hung wrote:
On 4/25/25 14:49, Melissa Wen wrote:
Color gamut_remap state log may be not avaiable for some hw versions, so
prevent null pointer dereference by checking it there is a function to
collect data for this hw version.
Signed-off-by: Melissa Wen
5-41 and 43 are:
Reviewed-by: Melissa Wen
And I dropped some comments and questions to some AMD-specific patches.
>
> v5 of this patchset fleshed out documentation for colorops and the
> various defines that are being introduced.
>
> v6 addresses a few comments from various reviewers.
On 05/12, Alex Hung wrote:
>
>
> On 5/12/25 18:52, Melissa Wen wrote:
> > On 04/29, Alex Hung wrote:
> > > This adds support for a 3D LUT.
> > >
> > > The color pipeline now consists of the following colorops:
> > > 1. 1D curve colorop
>
On 05/13, Pekka Paalanen wrote:
> On Mon, 12 May 2025 15:50:17 -0300
> Melissa Wen wrote:
>
> > On 04/29, Alex Hung wrote:
> > > Expose one 1D curve colorop with support for
> > > DRM_COLOROP_1D_CURVE_SRGB_EOTF and program HW to perform
> > > the sRGB t
On 04/29, Alex Hung wrote:
> This adds support for a 3D LUT.
>
> The color pipeline now consists of the following colorops:
> 1. 1D curve colorop
> 2. Multiplier
> 3. 3x4 CTM
> 4. 1D curve colorop
> 5. 1D LUT
> 6. 3D LUT
> 7. 1D curve colorop
> 8. 1D LUT
>
> Signed-off-by: Alex Hung
> Reviewed-b
On 29/04/2025 22:11, Alex Hung wrote:
Typo in the commit msg: mutliplier -> multiplier
This introduces a new drm_colorop_type: DRM_COLOROP_MULTIPLIER.
It's a simple multiplier to all pixel values. The value is
specified via a S31.32 fixed point provided via the
"MULTIPLIER" property.
Review
On 04/29, Alex Hung wrote:
> From: Harry Wentland
>
> This adds support for the BT.709/BT.2020 transfer functions
> on all current 1D curve plane colorops, i.e., on DEGAM, SHAPER,
> and BLND blocks.
>
> With this change the following IGT subtests pass:
> kms_colorop --run plane-XR30-XR30-bt2020_
On 04/29, Alex Hung wrote:
> Expose one 1D curve colorop with support for
> DRM_COLOROP_1D_CURVE_SRGB_EOTF and program HW to perform
> the sRGB transform when the colorop is not in bypass.
>
> With this change the following IGT test passes:
> kms_colorop --run plane-XR30-XR30-srgb_eotf
>
> The co
On 04/29, Alex Hung wrote:
> From: Harry Wentland
>
> Add the default Bypass pipeline and ensure it passes the
> kms_colorop test plane-XR30-XR30-bypass.
>
> Signed-off-by: Alex Hung
> Signed-off-by: Harry Wentland
> Reviewed-by: Daniel Stone
> ---
> .../amd/display/amdgpu_dm/amdgpu_dm_plane
On 04/29, Alex Hung wrote:
> Create a new macro for_each_new_colorop_in_state to access new
> drm_colorop_state updated from uapi.
>
> Reviewed-by: Simon Ser
> Signed-off-by: Alex Hung
> Reviewed-by: Daniel Stone
> ---
> include/drm/drm_atomic.h | 20
> 1 file changed, 20
In DCN401 pre-blending degamma LUT isn't affecting cursor as in previous
DCN version. As this is not the behavior close to what is expected for
CRTC degamma LUT, disable CRTC degamma LUT property in this HW.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/4176
Signed-off-by: Meliss
Pass dc_sink to dm_helpers_parse_edid_caps(), since it already contains
edid info. It's a groundwork to get rid of raw edid stored as dc_edid.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 5 +
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c
Reduce direct handling of edid data by resorting to drm helpers that
deal with this info inside drm_edid infrastructure.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 26 +++
.../amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 24
1 - 100 of 671 matches
Mail list logo
