RE: [PATCH] drm/amdgpu: ignoring unsupported ras blocks when MCA bank dispatches

2024-05-06 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: Wang, Yang(Kevin) Sent: Tuesday, May 7, 2024 9:36 AM To: Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Li, Candice ; Zhou, Hao (Claire) Subject

RE: [PATCH] drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query mode

2024-01-09 Thread Li, Candice
[AMD Official Use Only - General] I agree. Thanks, Candice -Original Message- From: Zhang, Hawking Sent: Wednesday, January 10, 2024 10:48 AM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: RE: [PATCH] drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query

RE: [PATCH] drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware query mode

2024-01-09 Thread Li, Candice
[AMD Official Use Only - General] Sorry, please ignore the patch. Thanks, Candice -Original Message- From: Li, Candice Sent: Wednesday, January 10, 2024 10:11 AM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amd/pm: Enable smu v13_0_6 eccinfo in firmware

RE: [PATCH] drm/amdgpu: Fix NULL pointer issue

2023-10-26 Thread Li, Candice
[AMD Official Use Only - General] Looks like Tao's patch already fixed it, [PATCH] drm/amdgpu: check RAS supported first in ras_reset_error_count Thanks, Candice -Original Message- From: amd-gfx On Behalf Of Jesse Zhang Sent: Thursday, October 26, 2023 4:37 PM To: amd-gfx@lists.freed

RE: [PATCH v2] drm/amd/pm: call smu_cmn_get_smc_version in is_mode1_reset_supported.

2023-10-24 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: Zhang, Yifan Sent: Wednesday, October 25, 2023 9:40 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Feng, Kenneth ; Li, Candice ; Zhang, Yifan

RE: [PATCH] drm/amdgpu: fix typo for amdgpu ras error data print

2023-10-19 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Thursday, October 19, 2023 3:15 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: fix typo

RE: [PATCH] Revert "drm/amdgpu: enable mcbp by default on gfx9"

2023-07-12 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: Deucher, Alexander Sent: Thursday, July 13, 2023 2:47 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Li, Candice Subject: [PATCH] Revert "drm/amdgpu: enable mc

RE: [PATCH] drm/amdgpu: skip address adjustment for GFX RAS injection

2023-06-29 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, June 29, 2023 6:01 PM To: amd-gfx@lists.freedesktop.org; Li, Candice ; Zhang, Hawking ; Yang, Stanley ; Chai, Thomas Cc: Zhou1, Tao

RE: [PATCH Review 1/1] drm/amdgpu: print ras drv fw debug info

2023-03-23 Thread Li, Candice
[AMD Official Use Only - General] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: amd-gfx On Behalf Of Stanley.Yang Sent: Thursday, March 23, 2023 4:35 PM To: amd-gfx@lists.freedesktop.org Cc: Yang, Stanley Subject: [PATCH Review 1/1] drm/amdgpu: print ras drv fw de

RE: [PATCH] drm/amdgpu: Add fatal error handling in nbio v4_3

2023-03-22 Thread Li, Candice
[Public] Reviewed-by: Candice Li Thanks, Candice -Original Message- From: Zhang, Hawking Sent: Thursday, March 23, 2023 10:24 AM To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, Stanley ; Li, Candice ; Chai, Thomas Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: Add fatal

RE: [PATCH] drm/amdgpu: fix cleaning up reserved VMID on release

2023-01-15 Thread Li, Candice
[AMD Official Use Only - General] Tested-by: Candice Li Thanks, Candice -Original Message- From: Alex Deucher Sent: Saturday, January 14, 2023 12:48 AM To: Christian König Cc: amd-gfx@lists.freedesktop.org; Li, Candice Subject: Re: [PATCH] drm/amdgpu: fix cleaning up reserved

Re: [PATCH] drm/amdgpu: remove the check of init status in psp_ras_initialize

2022-11-10 Thread Li, Candice
[Public] Reviewed-by: Candice Li mailto:candice...@amd.com>> Thanks Candice From: Zhou1, Tao Sent: Thursday, November 10, 2022 3:04:00 PM To: amd-gfx@lists.freedesktop.org ; Li, Candice ; Zhang, Hawking ; Chai, Thomas ; Yang, Stanley Cc: Zhou1, Tao S

RE: [PATCH] drm/amdgpu: Enable full reset when RAS is supported on gc v11_0_0

2022-09-08 Thread Li, Candice
[AMD Official Use Only - General] Good point, thanks for the review. I will send a new one. Thanks, Candice -Original Message- From: Kuehling, Felix Sent: Thursday, September 8, 2022 11:54 AM To: Li, Candice ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Enable

RE: [PATCH v2] drm/amdgpu: Resolve RAS GFX error count issue v2

2022-06-01 Thread Li, Candice
[AMD Official Use Only - General] Thanks, added the tag before pushing. Thanks, Candice -Original Message- From: Alex Deucher Sent: Thursday, June 2, 2022 2:02 AM To: Li, Candice Cc: amd-gfx list Subject: Re: [PATCH v2] drm/amdgpu: Resolve RAS GFX error count issue v2 On Wed, Jun

RE: [PATCH] drm/amdgpu: Resolve RAS GFX error count issue v2

2022-06-01 Thread Li, Candice
ndice -Original Message- From: Alex Deucher Sent: Thursday, June 2, 2022 1:19 AM To: Li, Candice Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: Resolve RAS GFX error count issue v2 On Wed, Jun 1, 2022 at 1:10 PM Candice Li wrote: > > Fix misleading indentation > Might want to split

RE: [PATCH] drm/amdgpu: Correct if identation that causes GCC warning

2022-06-01 Thread Li, Candice
: Wednesday, June 1, 2022 10:14 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Li, Candice ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: Correct if identation that causes GCC warning GCC is complaining about misleading indentation: error: this ‘if’ clause does not guard... [-Werror

RE: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

2022-04-21 Thread Li, Candice
[Public] Thanks, Candice -Original Message- From: Lazar, Lijo Sent: Thursday, April 21, 2022 7:01 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support On 4/21/2022 4:08 PM, Li

RE: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

2022-04-21 Thread Li, Candice
[Public] Thanks, Candice -Original Message- From: Lazar, Lijo Sent: Thursday, April 21, 2022 6:03 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support On 4/21/2022 3:28 PM, Li

RE: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

2022-04-21 Thread Li, Candice
[Public] Thanks, Candice -Original Message- From: Lazar, Lijo Sent: Thursday, April 21, 2022 5:23 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: Re: [PATCH v2 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support On 4/20/2022 4:43 PM

RE: [PATCH 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

2022-04-18 Thread Li, Candice
[Public] Thanks for the review, comments in line. Thanks, Candice From: Wang, Yang(Kevin) Sent: Monday, April 18, 2022 11:50 AM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: Re: [PATCH 2/2] drm/amdgpu: Add debugfs TA load/unload/invoke support

RE: [PATCH 1/2] drm/amdgpu: Use indirect buffer and save response status for TA load/invoke

2022-04-18 Thread Li, Candice
uct psp_context *psp, uint32_t ta_cmd_id); int psp_dtm_invoke(struct psp_context *psp, uint32_t ta_cmd_id); -- 2.17.1 Thanks, Candice -Original Message- From: Zhou1, Tao Sent: Monday, April 18, 2022 11:56 AM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Li, Candice ; Clements, Joh

RE: [PATCH] drm/amdgpu: Add recovery_lock to save bad pages function

2021-11-16 Thread Li, Candice
ved */ if (save_count > 0) { if (amdgpu_ras_eeprom_append(control, -- 2.17.1 Thanks, Candice -Original Message- From: Zhou1, Tao Sent: Tuesday, November 16, 2021 4:27 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John Subject: RE: [PATCH] d

RE: [PATCH] drm/amdgpu: Clear RAS interrupt status on aldebaran

2021-08-30 Thread Li, Candice
[AMD Official Use Only] Reviewed-by: Candice Li mailto:candice...@amd.com>> Thanks, Candice From: Clements, John Sent: Tuesday, August 31, 2021 2:27 PM To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amdgpu: Clear RAS interrupt status on aldebaran [AMD Offici

[PATCH] drm/amd/amdgpu: remove unnecessary RAS context field

2021-08-13 Thread Li, Candice
[Public] Delete ras_if->name in the RAS ctx structure and remove related lines. Signed-off-by: Candice Li candice...@amd.com<mailto:candice...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_hdp.c | 1 - drivers/gpu/drm/amd/amdgpu/amdgp

RE: [PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

2021-08-02 Thread Li, Candice
[Public] Exactly, I forgot to change it accordingly. Thanks @Chen, Guchun<mailto:guchun.c...@amd.com> Thanks, Candice From: Chen, Guchun Sent: Tuesday, August 3, 2021 2:04 PM To: Li, Candice ; amd-gfx@lists.freedesktop.org Cc: Clements, John ; Li, Candice Subject: RE: [PATCH] d

[PATCH] drm/amd/amdgpu: remove redundant host to psp cmd buf

2021-08-02 Thread Li, Candice
[Public] Signed-off-by: Candice Li candice...@amd.com<mailto:candice...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 253 1 file changed, 78 insertions(+), 175 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/

[PATCH] drm/amd/amdgpu: add consistent PSP FW loading size checking

2021-07-21 Thread Li, Candice
[Public] Signed-off-by: Candice Li candice...@amd.com<mailto:candice...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 108 -- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 32 +++ drivers/gpu/drm/amd/

RE: [PATCH] drm/amdgpu: correct ROM_INDEX/DATA offset for VEGA20

2020-03-04 Thread Li, Candice
[AMD Official Use Only - Internal Distribution Only] Tested-by: Candice Li Reviewed-by: Candice Li -Original Message- From: Hawking Zhang Sent: 2020年3月4日 17:27 To: amd-gfx@lists.freedesktop.org; Li, Candice Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: correct ROM_INDEX/DATA

RE: [PATCH] drm/amdgpu: disallow direct upload save restore list from gfx driver

2019-11-04 Thread Li, Candice
Reviewed-by: Candice Li Thanks, Candice Li -Original Message- From: Zhang, Hawking Sent: Monday, November 04, 2019 6:18 PM To: amd-gfx@lists.freedesktop.org; Clements John ; Li, Candice Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: disallow direct upload save restore list from