On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello
wrote:
>
> On 12/6/2023 19:23, Kai-Heng Feng wrote:
> > On Wed, Dec 6, 2023 at 4:29 AM Mario Limonciello
> > wrote:
> >>
> >> On 12/5/2023 14:17, Hamza Mahfooz wrote:
> >>> We currently don'
On Thu, Dec 7, 2023 at 10:10 AM Mario Limonciello
wrote:
>
> On 12/6/2023 20:07, Kai-Heng Feng wrote:
> > On Thu, Dec 7, 2023 at 9:57 AM Mario Limonciello
> > wrote:
> >>
> >> On 12/6/2023 19:23, Kai-Heng Feng wrote:
> >>> On Wed, Dec 6
SU FFU for all rotated planes (including cursor planes).
> >
>
> Here is the email for the original reporter to give an attribution tag.
>
> Reported-by: Kai-Heng Feng
For this particular issue,
Tested-by: Kai-Heng Feng
>
> > Cc: sta...@vger.kernel.org
> > Link:
On Wed, Mar 29, 2023 at 9:23 PM Mario Limonciello
wrote:
>
>
> On 3/29/23 04:59, Kai-Heng Feng wrote:
> > When the power is lost due to ACPI power resources being turned off, the
> > driver should reset the GPU so it can work anew.
> >
> > First, _PR3 support o
On Wed, Mar 29, 2023 at 9:21 PM Alex Deucher wrote:
>
> On Wed, Mar 29, 2023 at 6:00 AM Kai-Heng Feng
> wrote:
> >
> > When the power is lost due to ACPI power resources being turned off, the
> > driver should reset the GPU so it can work anew.
> >
> > Fir
Since the original issue is resolved by a new fix, the ASPM workaround
can be dropped.
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 15 ---
drivers/gpu/drm/amd/amdgpu/nv.c| 2 +-
drivers
supported for the GFX slot.
Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1885
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp
ntel Alder Lake based systems"), to
workaround the issue on Navi cards too.
Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458
Reviewed-by: Alex Deucher
Signed-off-by: Kai-Heng Feng
---
v2:
- Rename the quirk f
ntel Alder Lake based systems"), to
workaround the issue on Navi cards too.
Fixes: 0064b0ce85bb ("drm/amd/pm: enable ASPM by default")
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2458
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1
_reset() to noirq callback, so it's called after HDA
function is in D3.
Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)")
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 18 --
1 file changed, 12 insertions(+), 6 d
.
BugLink: https://bugs.launchpad.net/bugs/1920674
Fixes: 25030321ba28 ("drm/amd: add pm domain for ACP IP sub blocks")
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 49 +
1 file changed, 25 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/
On Fri, Apr 30, 2021 at 12:57 PM Kai-Heng Feng
wrote:
>
> Screen flickers rapidly when two 4K 60Hz monitors are in use. This issue
> doesn't happen when one monitor is 4K 60Hz (pixelclock 594MHz) and
> another one is 4K 30Hz (pixelclock 297MHz).
>
> The issu
NDS_MAX_SMC_PERFORMANCE_LEVELS_PER_SWSTATE instead of
> SISLANDS_MAX_SMC_PERFORMANCE_LEVELS_PER_SWSTATE - 1.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1583
> Fixes: 96e27e8d919e ("drm/radeon/si_dpm: Replace one-element array with
> flexible-array in struct SISLANDS_
the indication, we found that the issue occurs when
sclk is too low.
So resolve the issue by disabling sclk switching when there are two
monitors requires high pixelclock (> 297MHz).
v2:
- Only apply the fix to Oland.
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/radeon/radeon.h|
high". Following the lead, we found that the issue only occurs when
sclk is too low.
So resolve the issue by disabling sclk switching when there are two
monitors that requires high pixelclock (> 297MHz).
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/radeon/radeon.h| 1 +
drivers/gp
o register VGA clients that early, so solve
the issue by putting them after all the goto cleanups.
v2:
- Remove redundant vga_switcheroo cleanup in failed: label.
Fixes: 4192f7b57689 ("drm/amdgpu: unmap register bar on device init failure")
Signed-off-by: Kai-Heng Feng
---
drivers/gp
o register VGA clients that early, so solve
the issue by putting them after all the goto cleanups.
Fixes: 4192f7b57689 ("drm/amdgpu: unmap register bar on device init failure")
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 +++---
> On Sep 2, 2020, at 00:30, Alex Deucher wrote:
>
> On Tue, Sep 1, 2020 at 12:21 PM Kai-Heng Feng
> wrote:
>>
>>
>>
>>> On Sep 1, 2020, at 22:19, Alex Deucher wrote:
>>>
>>> On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng
>>>
> On Sep 1, 2020, at 22:19, Alex Deucher wrote:
>
> On Tue, Sep 1, 2020 at 3:32 AM Kai-Heng Feng
> wrote:
>>
>> Suspend with s2idle or by the following steps cause screen frozen:
>> # echo devices > /sys/power/pm_test
>> # echo freez
/335839/
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/radeon/radeon_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c
b/drivers/gpu/drm/radeon/radeon_device.c
index 266e3cbbd09b..df823b9ad79f 100644
--- a/drivers/gpu/drm/radeon/radeon_device
he
original fix.
Fixes: 2e26ccb119bd ("drm/radeon: prefer lower reference dividers")
BugLink: https://bugs.launchpad.net/bugs/1791312
BugLink: https://bugs.launchpad.net/bugs/1861554
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/radeon/radeon_display.c | 2 +-
1 file changed, 1
piron 3180 (Stoney Ridge) and Dell Latitude 5495
(Raven Ridge).
Cc:
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/a
Needs ATPX rather than _PR3 to really turn off the dGPU. This can save
~5W when dGPU is runtime-suspended.
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
b
at 21:33, Deucher, Alexander wrote:
Thanks for finding this! I think the attached patch should fix the issue
and it's much less invasive.
Yes it also fix the issue, please add by tested-by:
Tested-by: Kai-Heng Feng
I took this more or less future proof approach because I think this
solve the issue.
[1]
https://lore.kernel.org/lkml/3eb0e920-31d7-4c91-a360-dbfb4417a...@canonical.com/
Fixes: 005440066f92 ("drm/amdgpu: enable gfxoff again on raven series (v2)")
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 589 +
dr
at 14:29, Huang, Ray wrote:
-Original Message-
From: Kai-Heng Feng
Sent: Thursday, August 08, 2019 1:45 AM
To: Huang, Ray
Cc: Deucher, Alexander ; Koenig, Christian
; Zhou, David(ChunMing)
; amd-gfx list ;
dri-de...@lists.freedesktop.org; LKML ;
Anthony Wong
Subject: Re: [Regression
: 0x
VBIOS version: 113-RAVEN-103
Kai-Heng
Thanks,
Ray
From: Kai-Heng Feng
Sent: Wednesday, August 7, 2019 8:50 PM
To: Huang, Ray
Cc: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); amd-gfx
list; dri-de...@lists.freedesktop.org; LKML; Anthony Wong
Subject: [Regression
Hi,
After commit 005440066f92 ("drm/amdgpu: enable gfxoff again on raven series
(v2)”), browsers on Raven Ridge systems cause serious corruption like this:
https://launchpadlibrarian.net/436319772/Screenshot%20from%202019-08-07%2004-20-34.png
Firmwares for Raven Ridge is up-to-date.
Kai-Heng
Hi AMDGPU folks,
I’ve filed a bug [1] a while back, but no response so far.
I wonder if you still use BFO? Or do you migrate to another bug tracking
system?
[1]https://bugs.freedesktop.org/show_bug.cgi?id=110886
Kai-Heng
___
amd-gfx mailing list
am
at 01:41, Alex Deucher wrote:
On Tue, Jun 5, 2018 at 2:47 AM, Kai-Heng Feng
wrote:
The original issue on these laptops was about _PR3, not audio controller
prevents gfx auto suspending.
Have you verified that this this patch is still necessary with the HDA
driver fix in place?
Yes I did
ck to atpx quirk table.
Fixes: 444d95f0eeef ("Partially revert: drm/amdgpu: add atpx quirk handling
(v2)")
Fixes: c6f5b3155fbc ("Revert "drm/amdgpu: add new device to use atpx quirk"")
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c |
The affected system (0x0813) is pretty similar to another one (0x0812),
it also needs to use ATPX power control.
Signed-off-by: Kai-Heng Feng
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atpx_handler.c
32 matches
Mail list logo
