Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Jiabing Wan
led checkinclude.pl in linux/script. The robot just run the script and catch it ;). There will be more scripts in the robot and I think it will be public available soon. >btw, applied to amd-staging-drm-next. Thank you very much. > >Thanks >On 04/29, Jiabing Wan wrote: >> >> &g

Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

2021-04-29 Thread Jiabing Wan
>Nice catch! > >Are you using any tool to identify this problem? Yes, I have a robot including many detecting scripts :) >Reviewed-by: Rodrigo Siqueira > >On 04/29, Wan Jiabing wrote: >> In commit 482812d56698e ("drm/amd/display: Set max TTU on >> DPG enable"), "hubp.h" was added which caused

Re:Re: [PATCH] drm/amd/display: Remove duplicate declaration of dc_state

2021-04-29 Thread Jiabing Wan
>Hi Wan, > >Instead of remove the first dc_state, remove the second one. > >Thanks Hi Rodrigo, Thanks for your reply. OK, in fact, there are no functions using struct dc_state between two struct declarations. So I think removing anyone is OK. Remove the first one to make it more closer to user