Re: [RFC PATCH v3 1/6] drm/doc: Color Management and HDR10 RFC

2021-09-15 Thread Jeremy Cline
s, comments below. Excellent to > have > pictures included. I wrote this reply over several days, sorry if > it's > not quite coherent. > > > > > > + > > + > > +Overview and background > > +=== > > + > > +I highly recommend y

[PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Jeremy Cline
mically (v2)") Suggested-by: Felix Kuehling Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 8cac497c2c45..a56

Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-11 Thread Jeremy Cline
Hi, On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote: > Am 08.01.21 um 22:58 schrieb Jeremy Cline: > > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) > > calls which can sleep, but kernel_fpu_begin() disables preemption and > > sleepi

Re: [PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-08 Thread Jeremy Cline
On Fri, Jan 08, 2021 at 06:46:17PM -0500, Felix Kuehling wrote: > Am 2021-01-08 um 11:31 a.m. schrieb Jeremy Cline: > > KASAN reported a slab-out-of-bounds read of size 1 in > > kdf_create_vcrat_image_cpu(). > > > > This occurs when, for example, when on an x86

[PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-08 Thread Jeremy Cline
,max}_fill_clk_mhz. Narrow the scope to just these two parts to avoid sleeping while using the FPU. Fixes: 7a8a3430be15 ("amdgpu: Wrap FPU dependent functions in dc20") Cc: Timothy Pearson Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 8 --

[PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-08 Thread Jeremy Cline
ad and hopefully makes the pointer arithmetic clearer. It should have no functional change beyond removing the out-of-bounds read. Fixes: b7b6c38529c9 ("drm/amdkfd: Calculate CPU VCRAT size dynamically (v2)") Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/amdkfd

Re: [PATCH v2 13/20] drm/nouveau: Remove references to struct drm_device.pdev

2020-12-10 Thread Jeremy Cline
On Thu, Dec 10, 2020 at 08:56:08AM +0100, Thomas Zimmermann wrote: > Hi > > Am 09.12.20 um 19:04 schrieb Jeremy Cline: > > Hi, > > > > On Tue, Dec 01, 2020 at 11:35:35AM +0100, Thomas Zimmermann wrote: > > > Using struct drm_device.pdev is d

Re: [PATCH v2 13/20] drm/nouveau: Remove references to struct drm_device.pdev

2020-12-09 Thread Jeremy Cline
Hi, On Tue, Dec 01, 2020 at 11:35:35AM +0100, Thomas Zimmermann wrote: > Using struct drm_device.pdev is deprecated. Convert nouveau to struct > drm_device.dev. No functional changes. > > Signed-off-by: Thomas Zimmermann > Cc: Ben Skeggs > --- > drivers/gpu/drm/nouveau/dispnv04/arb.c | 12

Regression: no display with Vega 56 AMD GPU bisected to commit bfdec2340478

2018-07-02 Thread Jeremy Cline
Hi folks, A Fedora user, Mikhail (CCed), reported[0] a regression with their Vega 56 AMD GPU introduced by bfdec2340478 ("drm/amd/display: Implement dm_pp_get_clock_levels_by_type_with_latency"). The symptom is that nothing is displayed and looking at the logs (attached to the Bugzilla), I see gno