On Tue, 29 Sep 2020 08:14:04 +0200, Jean Delvare wrote:
> On Mon, 28 Sep 2020 17:44:28 -0400, Alex Deucher wrote:
> > Nice analysis. I've applied the patch.
>
> Unfortunately, further testing shows that this partial revert is
> insufficient to fully fix the probl
On Tue, 29 Sep 2020 08:14:04 +0200, Jean Delvare wrote:
> I'm not familiar enough with the amdgpu driver to efficiently continue
> debugging this issue on my own, so I'll do what I can, but some
> guidance would be welcome.
As an additional data point, here's what I
Hi Alex,
On Mon, 28 Sep 2020 17:44:28 -0400, Alex Deucher wrote:
> On Mon, Sep 28, 2020 at 9:23 AM Jean Delvare wrote:
> > I have recently experienced a regression in stable kernel series 5.8.
> > The problem is that my display will randomly turn to black after just a
>
before that line pretty much implies that we *want* to keep the
reference.
So I think we want to apply a partial revert like the following:
From: Jean Delvare
Subject: drm/amdgpu: restore proper ref count in amdgpu_display_crtc_set_config
A recent attempt to fix a ref count leak in
amdgpu_display_c
/show_bug.cgi?id=107825
Signed-off-by: Jean Delvare
Reviewed-by: Ville Syrjälä
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
---
Changes since v1:
* Treat CEA extension version < 3 as non-error too (suggested by Ville
Syrjälä)
drivers/gpu/drm/drm_edi
-by: Jean Delvare
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
Cc: David Airlie
Cc: Daniel Vetter
---
Changes since v1:
* Fixed subject
drivers/gpu/drm/radeon/radeon_audio.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-5.2.
It is fine for displays without audio functionality to not provide
any SAD block in their EDID. Do not log an error in that case,
just return quietly.
This fixes half of bug fdo#107825:
https://bugs.freedesktop.org/show_bug.cgi?id=107825
Signed-off-by: Jean Delvare
Cc: Alex Deucher
Cc
:
* Fixed subject of patch 2
* Treat CEA extension version < 3 as non-error too (suggested by Ville
Syrjälä)
--
Jean Delvare
SUSE L3 Support
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
On Mon, 2 Sep 2019 14:46:51 +0300, Ville Syrjälä wrote:
> On Fri, Aug 30, 2019 at 06:16:52PM +0200, Jean Delvare wrote:
> > It is fine for displays without audio functionality to not implement
> > CEA extension in their EDID. Do not return an error in that case,
> > instead
It is fine for displays without audio functionality to not provide
any SAD block in their EDID. Do not log an error in that case,
just return quietly.
This fixes half of bug fdo#107825:
https://bugs.freedesktop.org/show_bug.cgi?id=107825
Signed-off-by: Jean Delvare
Cc: Alex Deucher
Cc
=107825
Signed-off-by: Jean Delvare
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/drm_edid.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-5.2.orig/drivers/gpu/drm/drm_edid.c 2019-08-30 17:57
Oops, sorry, I messed up the subject line of that one, which should
really read "drm/radeon: be quiet when no SAD block is found".
--
Jean Delvare
SUSE L3 Support
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freed
-by: Jean Delvare
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
Cc: David Airlie
Cc: Daniel Vetter
---
drivers/gpu/drm/radeon/radeon_audio.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-5.2.orig/drivers/gpu/drm/radeon/radeon_au
Hi all,
This is my attempt to fix bug fdo#107825:
https://bugs.freedesktop.org/show_bug.cgi?id=107825
[PATCH 1/3] drm/amd: be quiet when no SAD block is found
[PATCH 2/3] drm/radeon: be quiet when no SAD block is found
[PATCH 3/3] drm/edid: no CEA extension is not an error
--
Jean Delvare
SUSE
me, but I don't know if there could be
legitimate reasons to distinguish between no audio information block
from display and empty audio information from display in the future.
What do you think?
Thanks,
--
Jean Delvare
SUSE L3 Support
___
amd
Comparing adev->family with CHIP constants is not correct.
adev->family can only be compared with AMDGPU_FAMILY constants and
adev->asic_type is the struct member to compare with CHIP constants.
They are separate identification spaces.
Signed-off-by: Jean Delvare
Fixes: 62a37553414a (&q
The driver does not support these sensors yet and there is no point in
creating sysfs attributes which will always return an error.
Signed-off-by: Jean Delvare
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
---
This works for me however I couldn'
his is something that can be implemented or not?
If it can't be implemented because the hardware does not have these
sensors then I would prefer if the attributes are not created at all so
as to not clutter the output of "sensors".
message at KERN_WARNING level regardless of the level of the message
being suppressed. This makes ratelimiting debug, info or notice
messages awkward. Looks like a design overlook to me, maybe it should
be fixed, but that's a much bigger and intrusive change than the
proposal above.
different version for older kernels already,
I'll post it to stable@ after the fix is merged into Linus' tree.
--
Jean Delvare
SUSE L3 Support
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
ommit isn't an actual revert of the original.
This fixes bug #194761:
https://bugzilla.kernel.org/show_bug.cgi?id=194761
Signed-off-by: Jean Delvare
Fixes: f8d9422ef80c ("drm/amdgpu: update tile table for oland/hainan")
Cc: Flora Cui
Cc: Junwei Zhang
Cc: Alex Deucher
Cc: M
Include a missing header to get rid of the following warning:
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c:521:6: warning: no previous prototype for
'dce_v6_0_disable_dce' [-Wmissing-prototypes]
void dce_v6_0_disable_dce(struct amdgpu_device *adev)
^
Signed-off-by: Jean Delvare
driver doesn't have any such fallthrough,
so I suspect this is not supposed to happen.
Signed-off-by: Jean Delvare
Fixes: 62a37553414a ("drm/amdgpu: add si implementation v10")
Cc: Ken Wang
Cc: Alex Deucher
Cc: "Marek Olšák"
Cc: "Christian König"
Cc: Flo
There are no external users of function radeon_atif_handler so it can
be static.
Signed-off-by: Jean Delvare
Cc: Alex Deucher
Cc: "Christian König"
---
drivers/gpu/drm/radeon/radeon_acpi.c |2 +-
drivers/gpu/drm/radeon/radeon_acpi.h |3 ---
2 files changed, 1 insertion(+), 4
Include a missing header to get rid of the following warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c:65:6: warning: no previous prototype for
‘amdgpu_pm_acpi_event_handler’ [-Wmissing-prototypes]
void amdgpu_pm_acpi_event_handler(struct amdgpu_device *adev)
^
Signed-off-by: Jean Delvare
There are no external users of function amdgpu_atif_handler so it can
be static.
Signed-off-by: Jean Delvare
Cc: Alex Deucher
Cc: "Christian König"
---
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.12.orig/drivers/g
26 matches
Mail list logo
