RE: [PATCH v1 2/3] drm/amdgpu: add vcn_v3_0 ip dump support

2024-07-24 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: amd-gfx On Behalf Of Khatri, Sunil Sent: Wednesday, July 24, 2024 10:00 PM To: Alex Deucher ; Khatri, Sunil Cc: Deucher, Alexander ; Liu, Leo ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: Re

RE: [PATCH] drm/amdgpu/umsch: don't execute umsch test when GPU is in reset/suspend

2024-04-19 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Looks good to me. Reviewed-by: Veerabadhran Gopalakrishnan Regards, Veera -Original Message- From: Yu, Lang Sent: Friday, April 19, 2024 1:22 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Yu

RE: [PATCH] drm/amdgpu/vcn: enable vcn1 fw load for VCN 4_0_6

2024-03-12 Thread Gopalakrishnan, Veerabadhran (Veera)
, Sathishkumar ; Gopalakrishnan, Veerabadhran (Veera) ; Deucher, Alexander Cc: Rao, Srinath Subject: [PATCH] drm/amdgpu/vcn: enable vcn1 fw load for VCN 4_0_6 v1 - update the fw header for each vcn instance (Veera) VCN1 has different FW binary in VCN v4_0_6. Add changes to load the VCN1 fw binary Signed

RE: [PATCH] drm/amdgpu: remove asymmetrical irq disabling in jpeg 4.0.5 suspend

2024-02-01 Thread Gopalakrishnan, Veerabadhran (Veera)
@lists.freedesktop.org Cc: Deucher, Alexander ; Jamadar, Saleemkhan ; Gopalakrishnan, Veerabadhran (Veera) ; Zhang, Yifan ; Ma, Li Subject: [PATCH] drm/amdgpu: remove asymmetrical irq disabling in jpeg 4.0.5 suspend A supplement to commit: 45fa6f32276f7ce571227f8368cf17378b804aa1 There is an irq warning of

RE: [PATCH] drm/amdgpu: remove asymmetrical irq disabling in vcn 4.0.5 suspend

2024-01-31 Thread Gopalakrishnan, Veerabadhran (Veera)
Cc: Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Jamadar, Saleemkhan ; Zhang, Yifan Subject: [PATCH] drm/amdgpu: remove asymmetrical irq disabling in vcn 4.0.5 suspend There is no irq enabled in vcn 4.0.5 resume, causing wrong amdgpu_irq_src status. Beside, current set function

RE: [PATCH v1] drm/amdgpu/jpeg: configure doorbell for each playback

2023-12-07 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Looking good to me. Reviewed-by: Veerabadhran Gopalakrishnan Regards, Veera -Original Message- From: Jamadar, Saleemkhan Sent: Thursday, December 7, 2023 9:22 PM To: Jamadar, Saleemkhan ; Liu, Leo ; Gopalakrishnan, Veerabadhran (Veera) ; amd-gfx

RE: [PATCH] drm/amdgpu/umsch: add suspend and resume callback

2023-10-13 Thread Gopalakrishnan, Veerabadhran (Veera)
[Public] Reviewed-by: Veerabadhran Gopalakrishnan veerabadhran.gopalakrish...@amd.com<mailto:veerabadhran.gopalakrish...@amd.com> -Veera From: Deucher, Alexander Sent: Friday, October 13, 2023 7:04 PM To: Yu, Lang ; amd-gfx@lists.freedesktop.org Cc: Gopalakrishnan, Veerabadhran

RE: [PATCH 2/2] drm/amdgpu/umsch: fix missing stuff during rebase

2023-10-12 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] The series is Reviewed-by: Veerabadhran Gopalakrishnan -Veera -Original Message- From: Yu, Lang Sent: Thursday, October 12, 2023 1:05 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Yu, Lang

RE: [PATCH 3/3] drm/amdgpu/umsch: enable doorbell for umsch

2023-10-09 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Reviewed-by: Veerabadhran Gopalakrishnan -Veera -Original Message- From: Yu, Lang Sent: Saturday, October 7, 2023 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Gopalakrishnan, Veerabadhran (Veera) ; Yu, Lang

RE: [PATCH 2/3] drm/amdgpu/umsch: power on/off UMSCH by DLDO

2023-10-09 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Reviewed-by: Veerabadhran Gopalakrishnan -Veera -Original Message- From: Yu, Lang Sent: Saturday, October 7, 2023 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Gopalakrishnan, Veerabadhran (Veera) ; Yu, Lang

RE: [PATCH 1/3] drm/amdgpu/umsch: fix psp frontdoor loading

2023-10-09 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Reviewed-by: Veerabadhran Gopalakrishnan -Veera -Original Message- From: Yu, Lang Sent: Saturday, October 7, 2023 2:24 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Yifan ; Gopalakrishnan, Veerabadhran (Veera) ; Yu, Lang

RE: [PATCH 2/2] drm/amdgpu: Add FW shared flag for DRM KEY INJECT

2023-07-14 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only - General] Suresh, Please modify the commit message to a more meaningful one. 1. add a commit title 2. write about the changes than the effect of the change. Something like Enabling FW workaround in using shared memory for VCN 4 3. Can you please check if this change is appl

RE: [PATCH 2/2] Revert "drm/amdgpu:update kernel vcn ring test"

2023-07-12 Thread Gopalakrishnan, Veerabadhran (Veera)
; Liu, Leo ; Gopalakrishnan, Veerabadhran (Veera) Cc: Sundararaju, Sathishkumar Subject: [PATCH 2/2] Revert "drm/amdgpu:update kernel vcn ring test" VCN FW depncencies revert it to unblock others This reverts commit ce085b8068e1071b0068f9a5dee78c97ef587022. Signed-off-by: Saleemkh

Re: [PATCH 1/2] drm/amdgpu: extract a PSP function to execute IP FW loading commands

2023-07-05 Thread Gopalakrishnan, Veerabadhran (Veera)
Looks good to me. The patch set is Reviewed-by: Veerabadhran Gopalakrishnan Regards, Veera On 6/27/2023 10:18 AM, Lang Yu wrote: This function is more general and easy to use by more clients. Signed-off-by: Lang Yu --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 29

RE: [PATCH] tests/amdgpu: Add VCN test support for Biege Goby

2022-01-13 Thread Gopalakrishnan, Veerabadhran (Veera)
[AMD Official Use Only] Reviewed-By: Veerabadhran Gopalakrishnan -Original Message- From: Alex Deucher Sent: Thursday, January 13, 2022 7:47 PM To: Chen, Guchun Cc: amd-gfx list ; Deucher, Alexander ; Gopalakrishnan, Veerabadhran (Veera) ; Liu, Leo Subject: Re: [PATCH] tests