s@msm/dpu@renesas/r-car@ in the Subject.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists
ä
> drivers/gpu/drm/renesas/shmobile/shmob_drm_kms.c | 3 ++-
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I
people from
disabling MMU support on a system that has both a PCI bus and an MMU.
But other people may not agree, or care?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with te
not support the AMD ISP.
Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl")
Signed-off-by: Geert Uytterhoeven
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index cbb81f
misc/drm-misc-next' into drm-tip").
What am I missing?
Thanks!
P.S. Sima: noticed while resolving a merge conflict using drm-tip. Thx!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In p
Hi Dmitry,
CC sfr
On Tue, Jan 21, 2025 at 11:44 AM Dmitry Baryshkov
wrote:
> On Tue, 21 Jan 2025 at 11:13, Geert Uytterhoeven wrote:
> > On Tue, Jan 7, 2025 at 12:31 PM Dmitry Baryshkov
> > wrote:
> > > On Sat, 14 Dec 2024 15:37:04 +0200, Dmitry Baryshkov wrote:
>
d int
color_mode)
+{
+ u32 fourcc = drm_driver_color_mode_format(dev, color_mode);
+
+ drm_client_setup_with_fourcc(dev, fourcc);
+}
+EXPORT_SYMBOL(drm_client_setup_with_color_mode);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There'
lient_setup_with_fourcc()
>
> Signed-off-by: Thomas Zimmermann
> Cc: Laurent Pinchart
> Cc: Geert Uytterhoeven
> Reviewed-by: Laurent Pinchart
Reviewed-by: Geert Uytterhoeven
Tested-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeve
homas Zimmermann
Cc: Yannick Fertre
Cc: Raphael Gallais-Pou
Cc: Philippe Cornu
Cc: Maxime Coquelin
Cc: Alexandre Torgue
Acked-by: Raphael Gallais-Pou
Acked-by: Raphael Gallais-Pou
WARNING: Duplicate signature
Gr{oetje,eeting}s,
Geert
--
_data->smc_state_table.GraphicsLevel[i].pcieDpmLevel =
> highest_pcie_level_enabled;
> + smu_data->smc_state_table.GraphicsLevel[i].pcieDpmLevel =
> + hightest_pcie_level_enabled;
> }
>
> /* set pcieDpmLevel to lowest_pcie_level_enabled*/
Gr{oetje,eeting}s,
mware
\"%s\"\n", fw_name);
| ^~
Fix this by converting the if/else if/... construct into a proper
switch() statement with a default to handle the error case.
As a bonus, the generated code is ca. 100 bytes smaller (with gcc 11.4.0
targeting arm32).
On Mon, 27 May 2024, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.10-rc1[1] compared to v6.9[2].
Summarized:
- build errors: +27/-20
- build warnings: +3/-1601
Happy fixing! ;-)
Thanks to the linux-next team for providing the build
the holes in structures.
>
> Thanks! I don't see a __packed attribute on struct drm_connector, but
> I'll put it near by other bools in case that changes in the future.
FTR, don't add __packed unless you have a very good reason to do so.
With __packed, the compiler will emit
shifts and masks, but the shifts
are not needed; lots of tables can be halved, etc...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical peop
On Tue, Nov 28, 2023 at 11:47 AM Thomas Zimmermann wrote:
> Remove unnecessary include statements for .
> The file contains helpers for non-atomic code and should not be
> required by most drivers. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Gee
On Tue, Nov 28, 2023 at 11:47 AM Thomas Zimmermann wrote:
> Remove unnecessary include statements for .
> The file contains helpers for non-atomic code and should not be
> required by most drivers. No functional changes.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Geert Uy
Hi Christian,
On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven wrote:
> On Fri, Jul 7, 2023 at 2:06 PM Christian König
> wrote:
> > Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven:
> > > On 32-bit:
> > >
> > > ../tests/amdgpu/amdgpu_stress.c: In f
Hi Christian,
On Mon, Aug 21, 2023 at 11:34 AM Christian König
wrote:
> Am 21.08.23 um 11:14 schrieb Geert Uytterhoeven:
> > On Fri, Jul 7, 2023 at 9:36 PM Geert Uytterhoeven
> > wrote:
> >> On Fri, Jul 7, 2023 at 2:06 PM Christian König
> >> wrote:
> &g
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
Reviewed-by: Hamza Mahfooz
---
v2:
- Add Reviewed-by.
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task
fbdev drivers
Two patches with the exact same one-line summary. Please make them
unique.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call m
uot; | sort | uniq -c | sort -rn |
> head -20
> 38494 struct device *dev
> 16388 struct net_device *dev
>4184 struct drm_device *dev
>2780 struct pci_dev *dev
>1916 struct comedi_device *dev
>1510 struct mlx5_core_dev *dev
> 1057 struct mlx4_dev *dev
in the
shmob_drm-specific subclasses of drm_{crtc,connector,plane} to "base".
https://lore.kernel.org/dri-devel/b3daca80f82625ba14e3aeaf2fca6dcefa056e47.1687423204.git.geert+rene...@glider.be
> Also the functions that deal with both a struct device and a struct
> drm_device ofte
EL_DISABLED);
drivers/video/fbdev/core/fbcon.c: int fast_imageblit = (cap &
FBINFO_HWACCEL_IMAGEBLIT) &&
drivers/video/fbdev/core/fbcon.c: !(cap &
FBINFO_HWACCEL_DISABLED);
BTW, I'm surprised FBINFO_HWACCEL_FILLRECT is not handled.
But looking at the full history, it never
Hi Christian,
On Fri, Jul 7, 2023 at 2:06 PM Christian König
wrote:
> Am 06.07.23 um 10:36 schrieb Geert Uytterhoeven:
> > On 32-bit:
> >
> > ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’:
> > ../tests/amdgpu/amdgpu_stress.c:178:49: warning: format
int’} [-Wformat=]
fprintf(stderr, "Buffer size to small %lu\n", size);
~~^
%llu
Fix this by using the proper "PRI?64" format specifiers.
Fixes: d77ccdf3ba6f5a39 ("amdgpu: add amdgpu_stress utility v2")
Signed-off-by: Geert Uytterhoeven
---
On Linux/a
On Wed, Jul 5, 2023 at 5:17 PM Geert Uytterhoeven
wrote:
>
> On 32-bit:
>
> ../tests/amdgpu/amdgpu_stress.c: In function ‘alloc_bo’:
> ../tests/amdgpu/amdgpu_stress.c:178:49: warning: format ‘%lx’ expects
> argument of type ‘long unsigned int’, but argument 4 has ty
3f360e7529c2 ("amdgpu: Eliminate void* arithmetic in
amdgpu_find_bo_by_cpu_mapping")
Signed-off-by: Geert Uytterhoeven
---
amdgpu/amdgpu_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c
index f4e0435254f6aa9f..672f000d64801012 100644
---
int’} [-Wformat=]
fprintf(stderr, "Buffer size to small %lu\n", size);
~~^
%llu
Fix this by using the proper "%ll" format specifier prefix.
Fixes: d77ccdf3ba6f5a39 ("amdgpu: add amdgpu_stress utility v2")
Signed-off-by: Geert Uytterhoeven
---
tests/amdg
On Mon, 5 Jun 2023, Geert Uytterhoeven wrote:
JFYI, when comparing v6.4-rc5[1] to v6.4-rc4[3], the summaries are:
- build errors: +2/-4
arm64-gcc5/arm64-allmodconfig (seen before)
[1]
http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9561de3a55bed6bdd44a12820ba81ec416e705a7/
(151 out
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task_barrier.h | 2 +-
4 files changed, 4 insertions(+), 4
Hi Marc,
On Tue, Apr 11, 2023 at 12:49 PM Marc Dionne wrote:
> On Tue, Apr 11, 2023 at 7:44 AM Geert Uytterhoeven
> wrote:
> >
> > Fix a misspelling of "rendez-vouz".
> >
> > Signed-off-by: Geert Uytterhoeven
> > --- a/include/drm/task_
Fix a misspelling of "rendez-vouz".
Signed-off-by: Geert Uytterhoeven
---
include/drm/task_barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h
index 217c1cf21c1ab7d5..59ead429acb2afb0 100644
--- a/i
Fix misspellings of "semaphore".
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/i915/i915_request.c | 2 +-
drivers/gpu/drm/radeon/cik.c| 2 +-
drivers/gpu/drm/radeon/r600.c | 2 +-
include/drm/task_barrier.h | 2 +-
4 files changed, 4 insertions(+), 4
Fix a misspelling of "rendez-vous".
Signed-off-by: Geert Uytterhoeven
---
v2:
- s/vouz/vous/.
---
include/drm/task_barrier.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/task_barrier.h b/include/drm/task_barrier.h
index 217c1cf21c1ab7d5..f6e6ed
(resend with the right subject)
On Mon, 10 Apr 2023, Geert Uytterhoeven wrote:
On Mon, 10 Apr 2023, Geert Uytterhoeven wrote:
JFYI, when comparing v6.3-rc6[1] to v6.3-rc5[3], the summaries are:
- build errors: +2/-0
+ /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: error
On Mon, 6 Mar 2023, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.3-rc1[1] compared to v6.2[2].
Summarized:
- build errors: +9/-14
- build warnings: +4/-1447
Happy fixing! ;-)
Thanks to the linux-next team for providing the build service
Hi Adrian,
On Tue, Jan 17, 2023 at 6:06 PM John Paul Adrian Glaubitz
wrote:
> On 1/17/23 18:01, Geert Uytterhoeven wrote:
> > The issue is that some of the parameters are not arrays, but
> > NULL. E.g.:
> >
> > arch/sh/kernel/cpu/sh2/setup-sh7619.c:static
> > DEC
Hi Adrian,
On Tue, Jan 17, 2023 at 5:42 PM John Paul Adrian Glaubitz
wrote:
> On 1/6/23 16:17, Geert Uytterhoeven wrote:
> >> I'm not seeing this one, but I am getting this one instead:
> >>
> >> In file included from ./arch/sh/include/asm/hw_irq.h:6,
> >
Hi Rodrigo,
On Tue, Jan 10, 2023 at 4:44 PM Rodrigo Siqueira
wrote:
> Geert Uytterhoeven reported compiler issues in some specific gcc
> versions that point to a large stack size for DCN31/314. Unfortunately,
> I could not reproduce the problem with the latest version of GCC/Clang;
>
Hi John,
On Fri, Jan 6, 2023 at 4:10 PM John Paul Adrian Glaubitz
wrote:
> On 12/27/22 09:35, Geert Uytterhoeven wrote:
> >+ /kisskb/src/include/linux/compiler_types.h: error: call to
> > '__compiletime_assert_262' declared with attribute error: Unsupported
> &
On Fri, Jan 6, 2023 at 4:17 PM Geert Uytterhoeven wrote:
>
> Hi John,
Bummer, "Hi Adrian", ofc ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with tec
On Tue, 27 Dec 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.2-rc1[1] compared to v6.1[2].
Summarized:
- build errors: +11/-13
amd-gfx@lists.freedesktop.org
linux-arm-ker...@lists.infradead.org
linux-me...@vger.kernel.org
linux-wirel
On Tue, 22 Nov 2022, Geert Uytterhoeven wrote:
JFYI, when comparing v6.1-rc6[1] to v6.1-rc5[3], the summaries are:
- build errors: +6/-0
+ /kisskb/src/arch/sh/include/asm/io.h: error: cast to pointer from integer of
different size [-Werror=int-to-pointer-cast]: => 239:34
sh4-gcc11
Hi Maciej,
On Tue, Oct 18, 2022 at 12:39 PM Maciej W. Rozycki wrote:
> On Mon, 17 Oct 2022, Geert Uytterhoeven wrote:
> > .> [1]
> > http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/
> > (all 149 configs)
> > >
On Mon, 17 Oct 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.1-rc1[1] compared to v6.0[2].
Summarized:
- build errors: +25/-13
[1]
http://kisskb.ellerman.id.au/kisskb/branch/linus/head/9abf2313adc1ca1b6180c508c25f22f9395cc780/
(all
On Mon, 5 Sep 2022, Geert Uytterhoeven wrote:
JFYI, when comparing v6.0-rc4[1] to v6.0-rc3[3], the summaries are:
- build errors: +3/-16
+ /kisskb/src/arch/sh/kernel/machvec.c: error: array subscript 'struct
sh_machine_vector[0]' is partly outside array bounds of 'long in
On Mon, 15 Aug 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v6.0-rc1[1] compared to v5.19[2].
Summarized:
- build errors: +26/-15
+ /kisskb/src/arch/parisc/kernel/vdso32/restart_syscall.S: Error: .cfi_endproc
without corresponding
uple of days ago.
Yes, post-rc6 should be fine, as the fix went in... for the third time.
Combine people that keep on switching back to macros without reading
a file's history with unresponsive maintainers...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven
Hi Günter,
On Thu, Jul 14, 2022 at 3:20 PM Guenter Roeck wrote:
> On 7/14/22 00:23, Geert Uytterhoeven wrote:
> > On Wed, Jul 13, 2022 at 11:51 PM Linus Torvalds
> > wrote:
> >> On Wed, Jul 13, 2022 at 2:01 PM Alex Deucher wrote:
> >>> If you want to
linux-m68k.org
[2] https://lore.kernel.org/all/20220711064425.3084093-1-ge...@linux-m68k.org
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker
YPE ==
ISA_TYPE_ENEC) ? isa_rom_outb((val), (port)) : isa_outb((val),
(port)))
where isa_rom_outb() leads to rom_out_8() returning u8, while
isa_outb() leads to the out_8() that includes the cast to void.
So the best solution seems to be to add more "(void)" casts, to e.g.
rom_o
On Fri, May 20, 2022 at 2:40 PM Geert Uytterhoeven wrote:
> On Thu, May 19, 2022 at 8:48 AM Guenter Roeck wrote:
> > On 5/18/22 17:55, kernel test robot wrote:
> > > tree/branch:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.g
Hi Alex,
On Mon, Jan 24, 2022 at 7:52 PM Alex Deucher wrote:
> On Mon, Jan 24, 2022 at 5:25 AM Geert Uytterhoeven
> wrote:
> > On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
> > > + /kisskb/src/drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:
> > > error: c
On Sun, 23 Jan 2022, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v5.17-rc1[1] compared to v5.16[2].
Summarized:
- build errors: +17/-2
- build warnings: +23/-25
Note that there may be false regressions, as some logs are incomplete.
Still
Hi Christophe,
On Tue, Mar 9, 2021 at 10:58 AM Christophe Leroy
wrote:
> Le 09/03/2021 à 10:16, Geert Uytterhoeven a écrit :
> > On Tue, Mar 9, 2021 at 9:52 AM Christophe Leroy
> > wrote:
> >> Le 09/03/2021 à 09:45, Geert Uytterhoeven a écrit :
> >>> On Tu
)
> +{
> + BUILD_BUG();
> +}
> #endif
I'm wondering how this is any better than the current situation: using
BUILD_BUG() will still cause a build failure?
What about adding "depends on !POWERPC || VSX" instead, to prevent
the issue from happening in the first pl
Hi Christophe,
On Tue, Mar 9, 2021 at 9:52 AM Christophe Leroy
wrote:
> Le 09/03/2021 à 09:45, Geert Uytterhoeven a écrit :
> > On Tue, Mar 9, 2021 at 9:39 AM Christophe Leroy
> > wrote:
> >> Add stub instances of enable_kernel_vsx() and disable_kernel_vsx()
> >&g
Hi Alex,
On Tue, Mar 2, 2021 at 8:30 PM Alex Deucher wrote:
> On Mon, Mar 1, 2021 at 9:21 AM Geert Uytterhoeven
> wrote:
> > On Mon, 1 Mar 2021, Geert Uytterhoeven wrote:
> > > Below is the list of build error/warning regressions/improvements in
> > > v5
On Mon, 1 Mar 2021, Geert Uytterhoeven wrote:
Below is the list of build error/warning regressions/improvements in
v5.12-rc1[1] compared to v5.11[2].
Summarized:
- build errors: +2/-0
[1]
http://kisskb.ellerman.id.au/kisskb/branch/linus/head/fe07bfda2fb9cdef8a4d4008a409bb02f35f1bd8/
(all
sed uninitialized" warnings thrown up by gcc-4.1, until
(a bit later than) support for that compiler was removed...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal con
Variables of type atomic{,64}_t can be used fine with
debugfs_create_u{32,64}, when passing a pointer to the embedded counter.
This allows to get rid of the casts, which prevented compiler checks.
Signed-off-by: Geert Uytterhoeven
---
drivers/crypto/nx/nx_debugfs.c | 18 +-
1
There is no need to cast a typed pointer to a void pointer when calling
a function that accepts the latter. Remove it, as the cast prevents
further compiler checks.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +-
1 file changed, 1 insertion
There is no need to cast a typed pointer to a void pointer when calling
a function that accepts the latter. Remove it, as the cast prevents
further compiler checks.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2
There is no need to cast a typed pointer to a void pointer when calling
a function that accepts the latter. Remove it, as the cast prevents
further compiler checks.
Signed-off-by: Geert Uytterhoeven
---
drivers/power/avs/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Currently bool ionic_cq.done_color is exported using
debugfs_create_u8(), which requires a cast, preventing further compiler
checks.
Fix this by switching to debugfs_create_bool(), and dropping the cast.
Signed-off-by: Geert Uytterhoeven
---
drivers/net/ethernet/pensando/ionic/ionic_debugfs.c
comments!
Geert Uytterhoeven (5):
crypto: nx - Improve debugfs_create_u{32,64}() handling for atomics
cxgb4/cxgb4vf: Remove superfluous void * cast in debugfs_create_file()
call
drm/amdgpu: Remove superfluous void * cast in debugfs_create_file()
call
power: avs: smartreflex: Remove
Fix sent
https://lore.kernel.org/lkml/20190813093046.4976-1-geert+rene...@glider.be/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical peop
"git diff" says:
\ No newline at end of file
after modifying the file.
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/amd/display/modules/power/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/modules/power/Makefile
Signed-off-by: Geert Uytterhoeven
---
drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
index 84d1ffd1eef95048..a7d273d472107821 100644
--- a
y about asking if that has been asked already.
>
> Wouldn't it be slightly less intrusive to simply redefined
> pr_warning() as a synonym for pr_warn()?
That's already the case.
This series cleans up the cruft, so we can catch all users with
"git grep -w pr_warn".
G
70 matches
Mail list logo
