[PATCH libdrm] amdgpu: Use the canonical form in branch predicate

Suggested-by: Emil Velikov Signed-off-by: Edward O'Callaghan --- amdgpu/amdgpu_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_cs.c b/amdgpu/amdgpu_cs.c index 0993a6d..868eb7b 100644 --- a/amdgpu/amdgpu_cs.c +++ b/amdgpu/amdgpu_cs.c @@ -559,7 +559,7 @

Re: [PATCH] drm/amd/powerplay: add error message to remind user updating firmware

Reviewed-by: Edward O'Callaghan On 04/20/2017 05:33 PM, Huang Rui wrote: > Signed-off-by: Huang Rui > --- > drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay

Re: [PATCH libdrm 1/2] amdgpu: add the interface of waiting multiple fences

On 04/19/2017 04:28 AM, Nicolai Hähnle wrote: > On 18.04.2017 17:47, Edward O'Callaghan wrote: >> On 04/14/2017 12:47 AM, Nicolai Hähnle wrote: >>> From: Nicolai Hähnle >>> >>> Signed-off-by: Junwei Zhang >>> [v2: allow returning the first

[libdrm] amdgpu/: concisely && consistently check null ptrs in canonical form

Be consistent and use the canonical form while sanity checking null pointers, also combine a few branches for brevity. Signed-off-by: Edward O'Callaghan --- amdgpu/amdgpu_bo.c | 2 +- amdgpu/amdgpu_cs.c | 36 +++- amdgpu/amdgpu_gpu_info.c

Re: [PATCH libdrm 1/2] amdgpu: add the interface of waiting multiple fences

On 04/14/2017 12:47 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Signed-off-by: Junwei Zhang > [v2: allow returning the first signaled fence index] > Signed-off-by: monk.liu > [v3: > - cleanup *status setting > - fix amdgpu symbols check] > Signed-off-by: Nicolai Hähnle > Reviewed-

Re: [PATCH umr] Add new AI+ field to RELEASE_MEM decoding

Reviewed-by: Edward O'Callaghan On 04/17/2017 10:43 PM, Tom St Denis wrote: > As well as add EVENT type decoding to human readable > string. > > Signed-off-by: Tom St Denis > --- > src/lib/ring_decode.c | 66 > +++

Re: [PATCH umr] Prevent reading sensors far too quickly.

Reviewed-by: Edward O'Callaghan On 04/12/2017 11:10 PM, Tom St Denis wrote: > On platforms without GPU_POWER sensors the thread reading sensors would > proceed > far too quickly. So it is now rate limited to 50Hz to be consistent. > > Signed-off-by: Tom St Denis > --

Re: [PATCH umr] Add AI sensors to --top

Reviewed-by: Edward O'Callaghan On 04/07/2017 08:47 PM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > src/app/top.c | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/src/app/top.c b/src/app/top.c > index b8a91e3

Re: [PATCH umr] Add family text for family 141

Reviewed-by: Edward O'Callaghan On 03/25/2017 01:08 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > src/app/print_config.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/app/print_config.c b/src/app/print_config.c > index 6dbe0d42b8dc..e

Re: [PATCH] Fix a misspelling of 'acceleration' in amdgpu_kms.c

Reviewed-by: Edward O'Callaghan On 03/26/2017 12:38 AM, Nicholas Molloy wrote: > --- > src/amdgpu_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amdgpu_kms.c b/src/amdgpu_kms.c > index 4821e93..c4ac90d 100644 > --- a/src/amdgpu_kms.

Re: [PATCH umr] Add program memory dump to wave status.

Reviewed-by: Edward O'Callaghan On 03/22/2017 01:11 AM, Tom St Denis wrote: > It will display the leading 4 words up to > the current PC value and then 4 words after. > > Signed-off-by: Tom St Denis > --- > src/app/print_waves.c | 44 +++

Re: [PATCH 0/6] drm/amdgpu: add get clockgating functions for new asic

This series is, Reviewed-by: Edward O'Callaghan On 03/24/2017 04:47 PM, Huang Rui wrote: > Hi all, > > This patch set adds get_clockgating functions, after that, we can use > debugfs pm to check the dynamic clockgating status. > > Thanks, > Rui > > Hu

Re: [PATCH 000/100] Add Vega10 Support

On 03/21/2017 05:36 PM, Christian König wrote: > Am 21.03.2017 um 00:38 schrieb Tom St Denis: >> On 03/20/2017 06:34 PM, Jan Ziak wrote: >>> On Mon, Mar 20, 2017 at 10:41 PM, Alex Deucher >> > wrote: >>> >>> On Mon, Mar 20, 2017 at 5:36 PM, Jan Ziak <0xe2.0x9a.0.

Re: [PATCH umr] Add more PKT3 decoders ...

Reviewed-by: Edward O'Callaghan On 03/21/2017 03:50 AM, Tom St Denis wrote: > Various SI related PKT3 decoders. > > Signed-off-by: Tom St Denis > --- > src/lib/ring_decode.c | 52 > +++ > 1 file changed, 52 insertion

Re: [PATCH umr] sync up registers/bits with staging tree

ost) > -pk=/nas/work/repos/linux/drivers/gpu/drm/amd/include/asic_reg/ > +if [ "$pk" == "" ]; then > + pk=/nas/work/repos/linux/drivers/gpu/drm/amd/include/asic_reg/ > +fi > Hmm, perhaps this hunk should not be conflated in with the rest. The rest of this patc

Re: [PATCH] drm/amdgpu: bump version for PRT support

Reviewed-by: Edward O'Callaghan Alex, as a matter of procedure could you perhaps have the actual version bump as part of the final patch in a given series? This would mitigate the issue of forgetting to bump the version for a given relevant changeset. Kindly, Edward. On 03/17/2017 01:

Re: [PATCH umr] PM4 packets list number of dwords not bytes

Reviewed-by: Edward O'Callaghan On 03/09/2017 07:03 AM, Tom St Denis wrote: > When counting size of IBs count in dwords... > > Signed-off-by: Tom St Denis > --- > src/lib/ring_decode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sr

Re: [PATCH umr] Add ability to read from virtual memory

Reviewed-by: Edward O'Callaghan On 03/09/2017 06:06 AM, Tom St Denis wrote: > Updates the --vram command to add the ability to read from > one of the VM domains instead. > > Signed-off-by: Tom St Denis > --- > doc/umr.1 | 7 --- > src/app/main.c | 16 +

Re: [PATCH 2/2] drm/amdgpu: bump driver version for some new features

On 03/09/2017 10:18 AM, Alex Deucher wrote: > We added new gem ioctl flags and the new fences ioctl, but forgot > to bump the version. Reviewed-by: Edward O'Callaghan Form which commit Alex? perhaps CC stable? > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/

Re: [PATCH umr] Fix ring offset to dword instead of bytes

Acked-by: Edward O'Callaghan On 03/09/2017 03:31 AM, Tom St Denis wrote: > This allows you to specify (say) > > -R gfx[16:32] to read words 16 through 32 which is > consistent with how the data is presented. > > This patch also correctly enables the PM4 decoder >

Re: [PATCH] drm/amdgpu: fix coding style and printing in amdgpu_doorbell_init

Reviewed-by: Edward O'Callaghan On 03/07/2017 12:54 AM, Christian König wrote: > From: Christian König > > Based on commit "drm/radeon: remove useless and potentially wrong message". > > The size of the info printing is incorrect and the PCI subsystems prints

Re: [PATCH] drm/amdgpu/powerplay: enable LEDs on Fiji boards

Hi guys, Shouldn't this hook into the "led framework" of the kernel? https://www.kernel.org/doc/Documentation/leds/leds-class.txt Kind Regards, Edward. On 02/24/2017 10:03 AM, Alex Deucher wrote: > On Thu, Feb 23, 2017 at 5:50 PM, Alexandre Demers > wrote: >> First, sorry for not replying dire

Re: [PATCH] drm/amdgpu: trace amdgpu_job fence details

Reviewed-by: Edward O'Callaghan On 02/23/2017 10:47 AM, Andres Rodriguez wrote: > This trace is intended to provide the required information to associate > the completion of an amdgpu_job with its corresponding dma_fence_* > tracepoints. > > Signed-off-by: Andres Rodriguez

Re: [PATCH umr] Simplify --scan and --list-regs syntax

e(struct umr_asic *asic, char *path) > +{ > + static char asicname[256], block[256], *dot; > + > + memset(asicname, 0, sizeof asicname); > + if ((dot = strstr(path, "."))) { > + memset(block, 0, sizeof block); perhaps move this block zero'ing memset o

Re: [PATCH v3] drm/amdgpu: add DP audio support for si dce6 (v3)

Reviewed-by: Edward O'Callaghan On 02/22/2017 02:37 PM, Xiaojie Yuan wrote: > v2: refine dce_v6_0_audio_endpt_wreg() and unify inconsistent method names > v3: fix num_pins for tahiti, pitcairn, verde and oland > > Signed-off-by: Xiaojie Yuan > --- > drivers/gpu/dr

Re: [PATCH] drm/amdgpu: add HDMI audio support for si dce6

Reviewed-by: Edward O'Callaghan On 02/21/2017 09:39 PM, Xiaojie Yuan wrote: > Signed-off-by: Xiaojie Yuan > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 130 > +++--- > 1 file changed, 121 insertions(+), 9 deletions(-) > > diff --git a/

Re: [PATCH 17/35] drivers/gpu: Convert remaining uses of pr_warning to pr_warn

;> 20 uses of pr_warn in drivers/gpu >> >> Signed-off-by: Joe Perches > > Acked-by: Christian König . Reviewed-by: Edward O'Callaghan > >> --- >> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +- >> drivers/gpu/drm/amd/powerplay/

Re: [PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h

disregard this, sorry for the noise. On 02/16/2017 07:42 PM, Edward O'Callaghan wrote: > We should properly prefix which kernel module this spewed > from in dmesg for consistency to the user. > > Signed-off-by: Edward O'Callaghan > --- > drivers/gpu/drm/amd/p

Re: [PATCH umr] Add SENSOR for SI/CIK/KV systems.

Reviewed-by: Edward O'Callaghan On 02/18/2017 06:26 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > src/app/top.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/src/app/top.c b/src/app/top.c > index 92ab8ab

[PATCH] amdgpu/powerplay: Fixup printk() usage in pp_debug.h

We should properly prefix which kernel module this spewed from in dmesg for consistency to the user. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/powerplay/inc/pp_debug.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/powe

Re: [PATCH 1/1] drm/amdgpu: export gfx capability by gpu info

> Then I send it out for guys review whether to add in the amdgpu_device > directly > or keep current style till we have other features besides gfx. Hmmk, its nothing to stress about I was just more curious about it. Reviewed-by: Edward O'Callaghan Kindly, Edward. > > Regard

Re: Change queue/pipe split between amdkfd and amdgpu

On 02/16/2017 03:00 PM, Bridgman, John wrote: > Any objections to authorizing Oded to post the kfdtest binary he is using to > some public place (if not there already) so others (like Andres) can test > changes which touch on amdkfd ? > > We should check it for embarrassing symbols but otherw

Re: [PATCH 1/1] drm/amdgpu: export gfx capability by gpu info

Hi, Question, is this a bit premature to have a new function and struct for this, could it just be put in amdgpu_gfx for now or are we expecting amdgpu_gfx_cap to start growing quickly with far more cap state info? Kind Regards, Edward. On 02/16/2017 01:53 PM, Junwei Zhang wrote: > Change-Id: Ib

Re: [PATCH] Add GPU_POWER sensors

, 255, 255, &umr_bitfield_default }, > -//{ "OUTSTANDING_HUB_ATOMIC_RET", 255, 255, &umr_bitfield_default }, >{ "OUTSTANDING_RPB_READ", 255, 255, &umr_bitfield_default }, >{ "OUTSTANDING_RPB_WRITE", 255, 255, &umr_

Re: [PATCH] drm/amdgpu: clear framebuffer with GPU

On 02/08/2017 12:24 PM, Pixel Ding wrote: > CPU is not efficient to do this job. There's a failure caused by this > is that handshaking gets timeout of SRIOV virtual function. Can you fixup the commit message a little but otherwise, Reviewed-by: Edward O'Callaghan > >

Re: [RFC]: More robust build sys for UMR

FC it. I expect this to work out the box on all distributions right off the bat and I would be interested in feedback for that. > > (I'm not saying NAK I'm simply asking for my own edification). Sure sure, this only took me a hour to put together because of _my_ itch so don't

[PATCH 3/4] README: minor update for cmake buildsys

Signed-off-by: Edward O'Callaghan --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index 2700736..7d8b025 100644 --- a/README +++ b/README @@ -32,6 +32,7 @@ To build umr you will need pciaccess and ncurses headers and libraries. Which are available in both F

[PATCH 2/4] cmake: Initial build system

V.2: squash in, cmake: Add docs manpage build target cmake: Add install targets cmake: Misc fixes Signed-off-by: Edward O'Callaghan --- CMakeLists.txt | 40 doc/CMakeLists.txt | 3 +++ src/CMakeLists.txt

[PATCH 4/4] drop orginal Makefile && stub bin/ directory

Signed-off-by: Edward O'Callaghan --- Makefile | 80 --- bin/.keep | 0 2 files changed, 80 deletions(-) delete mode 100644 Makefile delete mode 100644 bin/.keep diff --git a/Makefile b/Makefile deleted file mode 100644

[RFC]: More robust build sys for UMR

usual cmake way: `cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr ..` Please kindly review, Edward O'Callaghan (4): [PATCH 1/4] cmake_modules: Add libpciaccess finder [PATCH 2/4] cmake: Initial build system [PATCH 3/4] README: minor update for cmake buildsys [PATCH 4/4] drop orginal Makefile &

[PATCH 1/4] cmake_modules: Add libpciaccess finder

Signed-off-by: Edward O'Callaghan --- cmake_modules/FindPCIAccess.cmake | 35 +++ 1 file changed, 35 insertions(+) create mode 100644 cmake_modules/FindPCIAccess.cmake diff --git a/cmake_modules/FindPCIAccess.cmake b/cmake_modules/FindPCIAccess.cmake new

Re: [PATCH v5 0/3] Allow ASYNC flip with atomic helpers.

Reviewed-by: Edward O'Callaghan On 02/04/2017 04:46 AM, Alex Deucher wrote: > On Thu, Feb 2, 2017 at 4:56 PM, Andrey Grodzovsky > wrote: >> This series is a folow-up on >> https://patchwork.kernel.org/patch/9501787/ >> >> The first patch makes changes to atom

Re: [PATCH 13/13] drm/amdgpu: new queue policy, take first 2 queues of each pipe

This series is, Reviewed-by: Edward O'Callaghan On 02/04/2017 03:51 PM, Andres Rodriguez wrote: > Instead of taking the first pipe and givint the rest to kfd, take the s/givint/giving/ > first 2 queues of each pipe. > > Effectively, amdgpu and amdkfd own the same numb

Re: [PATCH libdrm 0/3] some -pro patches for integration

This series is, Reviewed-by: Edward O'Callaghan On 01/29/2017 06:49 AM, Grazvydas Ignotas wrote: > I've taken several patches from amdgpu-pro libdrm that look useful > to me and I think can be applied already. The only things I did was > rebasing, fixing some typos and

Re: [PATCH v2 0/3] Allow ASYNC flip with atomic helpers.

This series is, Reviewed-by: Edward O'Callaghan On 01/17/2017 04:16 PM, Andrey Grodzovsky wrote: > This series is a folow-up on > https://patchwork.kernel.org/patch/9501787/ > > The first patch makes changes to atomic helpers to allow for > drives with ASYNC flip support to

Re: More specific libdrm error message

Hi Xie, Perhaps you want to use `fprintf(stderr, "...")` over `printf("..")` and lose the space before the start parenthesis. Also, line wrap your commit message. Side note, use git send-email so that the patch is inline and not a HTML email for easy review and application of the patch. Kind Reg

Re: [PATCH 0/2] drm/amd/amdgpu: locking fixes

this series is, Reviewed-by: Edward O'Callaghan On 01/11/2017 06:31 PM, Nicolai Hähnle wrote: > Hi all, > > two fixes for locking issues that I noticed. > > The first one is something that I actually encountered live; it probably > only matters when lock debugging is

Re: [PATCH] drm/amd/display: drop min/max wrappers

Reviewed-by: Edward O'Callaghan On 01/10/2017 09:35 AM, Dave Airlie wrote: > From: Dave Airlie > > These aren't needed, and aren't really used in too many places. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/amd/display/dc/core/dc.c| 2

Re: [PATCH] drm/amd/display: start using linux hdmi header

Reviewed-by: Edward O'Callaghan On 01/10/2017 10:33 AM, Dave Airlie wrote: > From: Dave Airlie > > DAL has defines for things, and it doesn't even use them itself. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 1

Re: [PATCH 01/10] drm/radeon/si: load special ucode for certain MC configs

@@ static int si_init_microcode(struct radeon_device *rdev) > default: BUG(); > } > Hi Alex, I suggest just a short one line comment above here and also in the amdgpu patch too explaining what a 'si58_fw' actually means for a non-AMD eng. With that this series is, A

Re: [PATCH] drm/amd/amdgpu: fix spelling mistake: "comleted" -> "completed"

Reviewed-by: Edward O'Callaghan On 12/30/2016 12:39 PM, Zhou, David(ChunMing) wrote: > +amd-gfx, patch is Reviewed-by: Chunming Zhou > > -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, December 29, 2016 11:47 PM >

Re: [PATCH v2 0/6] drm/amd/powerplay: refine pr_* prints for powerplay

Merry Christmas Huang Rui, This set looks way better and a much more complete solution, good job working though it all! Patches 1-6 are, Reviewed-by: Edward O'Callaghan Kindest Regards, Edward. On 12/26/2016 06:56 PM, Huang Rui wrote: > From: Huang Rui > > Hi all, > >

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

On 12/23/2016 08:54 PM, Huang Rui wrote: > On Fri, Dec 23, 2016 at 05:32:58PM +0800, Edward O'Callaghan wrote: >> Hi, >> >> I would say drop all the header relocation churn, it distracts away from >> the functional changes in this commit. Also see inline commen

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

Hi, I would say drop all the header relocation churn, it distracts away from the functional changes in this commit. Also see inline comments. With those fixes, Acked-by: Edward O'Callaghan Kindest Regards, Edward. On 12/23/2016 01:45 PM, Huang Rui wrote: > Powerplay will be used them

Re: [PATCH] drm/amdgpu: Remove checking for atombios

Reviewed-by: Edward O'Callaghan On 12/15/2016 07:52 AM, Nils Wallménius wrote: > This is a left over from radeon, amdgpu doesn't support any > non-atombios parts and amdgpu_device_init would bail if the > check for atombios failed anyway. > > Signed-off-by: Nils Wallmén

Re: some minor dal cleanups and example of future patches

This series is, Acked-by: Edward O'Callaghan On 12/13/2016 05:41 PM, Dave Airlie wrote: > So whenever I look at DAL I find myself trying to figure out what > all of it does, and this leads me to deleting things, so I'm just > sending out some stuff that I cleaned today. >

Re: [PATCH] drm/amd/powerplay: use pr_debug to print function not implemented message

Reviewed-by: Edward O'Callaghan On 12/08/2016 06:28 AM, Alex Deucher wrote: > From: Arindam Nath > > For CZ, some function pointers like display_configuration_changed > are not set. So when HW manager tries to configure display, we > end up with messages like > > &q

Re: [PATCH] drm/amdgpu: use pin rather than pin_restricted in a few cases

Reviewed-by: Edward O'Callaghan On 12/08/2016 08:17 AM, Alex Deucher wrote: > We don't require a resticted pinning in these cases, so just > use plain pin. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +- > drivers

Re: [PATCH 1/2] drm/amd/amdgpu: stored bios_size

1&2 are Reviewed-by: Edward O'Callaghan On 12/08/2016 06:22 AM, Alex Deucher wrote: > From: Evan Quan > > It's necessary if we want to export vbios image out. > > Signed-off-by: Evan Quan > Reviewed-by: Alex Deucher > Reviewed-by: Christian Ko

Re: GPR read support via debugfs (v2)

This series is, Acked-by: Edward O'Callaghan On 12/07/2016 01:50 AM, Tom St Denis wrote: > These patches introduce debugfs access to read GPRs (SGPRs for now). > > (v2): Fixes white space, addressing is in dwords not bytes, and removes > the bugg

Re: [PATCH 1/3] drm/amd/amdgpu: Add debugfs support for reading GPRs

Hi Tom, On 12/06/2016 05:36 AM, Tom St Denis wrote: > Implemented for SGPRs for GFX v8 initially. > > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 + > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 72 > ++ > drivers/gpu/drm/amd

Re: amdgpu: ratelimit on vm faults to avoid spaming console

------ >> *From:* amd-gfx on behalf of >> Alex Deucher >> *Sent:* Monday, November 7, 2016 13:35 >> *To:* Edward O'Callaghan; Nicolai Hähnle; Marek Olsak >> *Cc:* Michel Dänzer; amd-gfx list >> *Subject:* Re: amdgpu: ratelimit on vm faults to av

amdgpu: ratelimit on vm faults to avoid spaming console

These are rather minor however should help stop some folks machines grinding to a halt when a userspace application somehow gets the GPU into some horrible state causing the console to fill very quickly. Applies on top of master. Please kindly review, Edward O'Callaghan (2): [PATCH v

[PATCH v2 1/2] amdgpu: Use dev_err() over vanilla printk() in vm_decode_fault()

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c index aa0c4b9..a0

[PATCH v2 2/2] amdgpu: Wrap dev_err() calls on vm faults with printk_ratelimit()

rate. - Michel Dänzer. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 16 +--- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 16 +--- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 16 +--- 3 files changed, 27 insertions(+), 21 dele

Re: [PATCH 2/2] amdgpu: Use 'dev_err_ratelimited()' over 'dev_err()' on vm faults

On 11/07/2016 02:55 PM, Michel Dänzer wrote: > On 07/11/16 12:47 PM, Edward O'Callaghan wrote: >> It can be the case that upon GPU page faults we start trashing >> the logs, and so let us ratelimit here to avoid that. >> >> Signed-off-by: Edward O'Callaghan

[PATCH 1/2] amdgpu: Use dev_err() over vanilla printk() in vm_decode_fault()

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c index aa0c4b9..a0

[PATCH 2/2] amdgpu: Use 'dev_err_ratelimited()' over 'dev_err()' on vm faults

It can be the case that upon GPU page faults we start trashing the logs, and so let us ratelimit here to avoid that. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 8 drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 8 drivers/gpu/drm/amd/amdgpu/gmc

amdgpu: ratelimit on vm faults to avoid spaming console

These are rather minor however should help stop some folks machines grinding to a halt when a userspace application somehow gets the GPU into some horrible state causing the console to fill very quickly. Applies on top of master. Please kindly review, Edward O'Callaghan (2): [PATCH 1/2] a

Re: [PATCH 1/2] drm/amd/powerplay: export a function to read fan rpm

Howdy, On 10/30/2016 07:28 AM, Grazvydas Ignotas wrote: > Powerplay hwmgr already has an implementation, all we need to do is to call > it. > > Signed-off-by: Grazvydas Ignotas > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 18 ++ > drivers/gpu/drm/amd/powerplay/in

Re: [PATCH] drm/amd/powerplay: don't succeed in getters if fan is missing

Reviewed-by: Edward O'Callaghan On 10/30/2016 07:32 AM, Grazvydas Ignotas wrote: > Otherwise callers end up using uninitialized data. > > Signed-off-by: Grazvydas Ignotas > --- > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 6 +++--- > 1 file changed, 3 ins

Re: [PATCH] drm/amdgpu: update kernel-doc for some functions

Reviewed-by: Edward O'Callaghan On 10/24/2016 05:31 AM, Grazvydas Ignotas wrote: > The names were wrong. > > Signed-off-by: Grazvydas Ignotas > --- > drivers/gpu/drm/amd/scheduler/sched_fence.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

Re: [PATCH] drm/amdgpu: use amdgpu_bo_[create|free]_kernel for wb

Acked-by: Edward O'Callaghan On 10/22/2016 06:31 AM, Alex Deucher wrote: > Rather than open coding it. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 37 > ++ > 1 file changed, 7 insertions(+), 30 de

Re: [PATCH] drm/amdgpu/atom: remove a bunch of unused functions

Reviewed-by: Edward O'Callaghan On 10/22/2016 06:55 AM, Alex Deucher wrote: > Leftovers from the radeon. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 82 > > drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 1/3] x86/pat: export io memory reserve/free api.

On 10/18/2016 07:29 PM, Dave Airlie wrote: > On 18 Oct. 2016 17:23, "Edward O'Callaghan" <mailto:funfunc...@folklore1984.net>> wrote: >> >> NACK, >> >> I think you want to use 'iomap_create_wc()' instead to avoid aliasing. > >

Re: [PATCH 1/3] x86/pat: export io memory reserve/free api.

NACK, I think you want to use 'iomap_create_wc()' instead to avoid aliasing. Kind Regards, Edward. On 10/18/2016 05:13 PM, Dave Airlie wrote: > From: Dave Airlie > > These functions are needed for gpu/ttm drivers to reserve the > VRAM area as write combined. In a lot of places we don't ioremap

Re: [PATCH] drm/amdgpu: fix warning in dce_virtual.c

Reviewed-by: Edward O'Callaghan if possible can you squash it into the original bad commit? On 10/15/2016 05:00 AM, Alex Deucher wrote: > copy paste typo when I re-arranged the code. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/dce_virtual.c |

Re: [PATCH] drm/radeon: allow TA_CS_BC_BASE_ADDR on SI

On 10/10/2016 10:23 PM, Marek Olšák wrote: > From: Marek Olšák > > Required for border colors in compute shaders. > > Signed-off-by: Marek Olšák Reviewed-by: Edward O'Callaghan > --- > drivers/gpu/drm/radeon/radeon_drv.c | 3 ++- > drivers/gpu/drm/radeon/si.c

Re: [PATCH] drm/amd/powerplay: don't give up if DPM is already running

Reviewed-by: Edward O'Callaghan On 10/10/2016 06:23 AM, Grazvydas Ignotas wrote: > Currently the driver crashes if smu7_enable_dpm_tasks() returns early, > which it does if DPM is already active. It seems to be better just to > continue anyway, at least I haven't noticed an

Re: [PATCH] drm/amdgpu: remove DRM_AMD_POWERPLAY

Reviewed-by: Edward O'Callaghan On 09/29/2016 06:42 AM, Alex Deucher wrote: > Powerplay is no longer optional after the recently cleanups > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/Kconfig| 1 - > drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 9/9] drm/amdgpu:properly fix some JumpTable issues

On 09/28/2016 06:36 PM, Monk Liu wrote: > we found some MEC ucode leads to IB test fail or even > ring test fail if Jump Table of it is not start in > FW bo with page aligned address, fixed by always make > JT address page aligned. > > we don't need to patch JT2 for MEC2, because for VI, > MEC2

Re: [PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

#x27;s nice and clean looking. > > > Tom > > > > > *From:* amd-gfx on behalf of > Christian König > *Sent:* Tuesday, September 27, 2016 08:52 > *To:* Edward O'Callaghan; amd-gfx@lists

Additional amdkfd cleanups for 4.9

These additional minor changes apply on top of my previous set. Nothing too interesting here just yet more clean ups to make way for future changes. Please review, Kind Regards, Edward O'Callaghan (2): [PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state [PATCH 2/2] drm/a

[PATCH 2/2] drm/amdkfd: Decode bit fields in 'cik_ih_ring_entry' directly

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 15 +-- drivers/gpu/drm/amd/amdkfd/cik_int.h | 20 2 files changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/a

[PATCH 1/2] drm/amdkfd: Use kfd_vm_info struct to carry consts state

Use a struct to carry the calculated const state inside the main kfd_dev state to use where we need it. Minor cleanups while we are here. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c| 9 ++--- drivers/gpu/drm/amd/amdkfd/kfd_dev

Re: VRAM manager

This series is, to the best of my ability, Reviewed-by: Edward O'Callaghan On 09/27/2016 07:49 PM, Christian König wrote: > Hi guys, > > after fixing all those nasty little bugs this seems to be stable now. > > Anybody brave enough to give it an review? >

Re: [PATCH 3/3] drm/amd/amdgpu: Various cleanups for DCEv6

This patch is, Review-by: Edward O'Callaghan On 09/23/2016 02:43 AM, Tom St Denis wrote: > Signed-off-by: Tom St Denis > --- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 46 > --- > 1 file changed, 10 insertions(+), 36 deletions(-) > >

Re: [PATCH 1/5] drm/amdgpu:changes of virtualization cases probe (v2)

On 09/20/2016 03:12 AM, Alex Deucher wrote: > From: Monk Liu > > 1,Changes on virtualization detections > 2,Don't load smu & mc firmware if using sr-iov bios > 3,skip vPost for sriov & force vPost if dev pass-through > > v2: agd: fix missed SI case > > Signed-off-by: Monk Liu > Reviewed-by:

Re: [PATCH 2/5] drm/amdgpu: make sriov bios detection generic (v2)

Reviewed-by: Edward O'Callaghan as with the rest of the respective series. On 09/20/2016 04:44 AM, Alex Deucher wrote: > It's not asic specific. > > v2: drop asic macro > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 -

Re: [PATCH 1/5] drm/amdgpu/vi: whitespace fixes

Series is, Reviewed-by: Edward O'Callaghan On 09/20/2016 04:35 AM, Alex Deucher wrote: > function declaration parens should be a new line. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/vi.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletio

Re: [PATCH] drm/amdgpu: use powerplay module for dgpu of VI.

So now just pure PP paths for Tonga, Fiji & Topaz. Is there any perf or power usage difference from this change-set across any of these ASIC's? Acked-by: Edward O'Callaghan On 09/19/2016 10:17 PM, Rex Zhu wrote: > delete vi dpm related code and file

Re: [PATCH 0/3] drm/amdgpu: implement raster configuration

This series is, Acked-by: Edward O'Callaghan On 09/18/2016 12:36 PM, Huang Rui wrote: > Hi all, > > This patch set is to introduce the raster configuration for all gfx > generations. > > Thanks, > Rui > > Huang Rui (3): > drm/amdgpu: implement raster conf

[PATCH 5/6] drm/amdkfd: Unify multiple calls to pr_debug() into one

Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c b/drivers/gpu/drm/amd/amdkfd/kfd_doorbell.c index a7d3cb3..453c5d6 100644 --- a/dr

[PATCH 4/6] drm/amdkfd: Fix possible infinite loop

When the loop predicating timeout parameter passed happens to not be a multiple of 20 the unsigned integer will overflow and the loop will become unbounded. Signed-off-by: Edward O'Callaghan Reviewed-by: Oded Gabbay --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c

[PATCH 1/6] drm/amdkfd: Tidy up kfd_generate_gpu_id() uint64_t bitshift unpack

Dereference the one time and unpack the lower and upper 32bit portions with the proper kernel helper macros. Signed-off-by: Edward O'Callaghan Reviewed-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --

[PATCH 2/6] drm/amdkfd: Add some missing memset zero'ing in queue init func

Signed-off-by: Edward O'Callaghan Reviewed-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c b/drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c index 9beae87..291c69d 100644

drm/amdkfd: Misc patchset lineup for drm-next-4.9

x27;t wait up. Please review.. Kind Regards, Edward O'Callaghan (6): [PATCH 1/6] drm/amdkfd: Tidy up kfd_generate_gpu_id() uint64_t [PATCH 2/6] drm/amdkfd: Add some missing memset zero'ing in queue [PATCH 3/6] drm/amdkfd: Reuse function to find a process through [PATCH 4/6] drm/amdkf

[PATCH 6/6] drm/amdkfd: Pass 'struct queue_propertices' by reference

Allow init_queue() to take 'struct queue_properties' by reference. Signed-off-by: Edward O'Callaghan --- drivers/gpu/drm/amd/amdkfd/kfd_kernel_queue.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_process_queu

[PATCH 3/6] drm/amdkfd: Reuse function to find a process through pasid

The kfd_lookup_process_by_pasid() is just for that purpose, so use it instead of repeating the code. V.2: return on the condition (p == NULL) instead of BUG_ON(!p). Signed-off-by: Edward O'Callaghan Reviewed-by: Oded Gabbay --- drivers/gpu/drm/amd/amdkfd/kfd_process.c

Re: Powerplay sensors (v2.5)

This series is, Reviewed-by: Edward O'Callaghan On 09/16/2016 10:44 PM, Tom St Denis wrote: > I've rebased the backend to squash the carrizo + rest patches together > and then touched up the debugfs entry per Edwards suggestions. > > Tested on Tong

  1   2   >