Re: [PATCH 2/2] drm/amdgpu: update mmhub 3.3 client id mappings

2025-07-29 Thread David Wu
get printed when there is a mmhub page fault. v2: fix typos spotted by David Wu. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 105 +++- 1 file changed, 104 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c b/dri

Re: [PATCH v2 5/9] drm/amdgpu: read back register after written

2025-05-15 Thread David Wu
On 2025-05-15 13:25, Dong, Ruijing wrote: [AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Wu, David Sent: Thursday, May 15, 2025 12:41 PM To: amd-gfx@lists.freedesktop.org; Koenig, Christian Cc: Deucher, Alexander ; Liu, Leo ; Jiang, Sonny ; Dong, R

Re: [PATCH V2 2/2] drm/amdgpu: read back register after written for VCN v4.0.0 and v5.0.0

2025-05-13 Thread David Wu
On 2025-05-13 17:01, Alex Deucher wrote: On Tue, May 13, 2025 at 4:33 PM David Wu wrote: On 2025-05-13 15:29, Alex Deucher wrote: On Tue, May 13, 2025 at 3:01 PM David Wu wrote: On 2025-05-13 14:40, Alex Deucher wrote: On Tue, May 13, 2025 at 2:23 PM David (Ming Qiang) Wu wrote: V2

Re: [PATCH V2 2/2] drm/amdgpu: read back register after written for VCN v4.0.0 and v5.0.0

2025-05-13 Thread David Wu
On 2025-05-13 15:29, Alex Deucher wrote: On Tue, May 13, 2025 at 3:01 PM David Wu wrote: On 2025-05-13 14:40, Alex Deucher wrote: On Tue, May 13, 2025 at 2:23 PM David (Ming Qiang) Wu wrote: V2: not to add extra read-back in vcn_v4_0_start and vcn_v5_0_0_start as there are read-back

Re: [PATCH V2 2/2] drm/amdgpu: read back register after written for VCN v4.0.0 and v5.0.0

2025-05-13 Thread David Wu
On 2025-05-13 14:40, Alex Deucher wrote: On Tue, May 13, 2025 at 2:23 PM David (Ming Qiang) Wu wrote: V2: not to add extra read-back in vcn_v4_0_start and vcn_v5_0_0_start as there are read-back calls already. New comments for better understanding. Similar to the previous changes made fo

Re: [PATCH 1/2] drm/amdgpu: read back DB_CTRL register after written for VCN v4.0.5

2025-05-13 Thread David Wu
sounds great! will adjust accordingly. David On 2025-05-13 12:44, Alex Deucher wrote: On Tue, May 13, 2025 at 12:38 PM David (Ming Qiang) Wu wrote: On VCN v4.0.5 there is a race condition where the WPTR is not updated after starting from idle when doorbell is used. The read-back of regVCN_RB1

Re: [PATCH 2/2] drm/amdgpu: add sysfs reset mask for vcn 5.0.1

2024-12-10 Thread David Wu
Series is: Reviewed-by: David (Ming Qiang) Wu one thing I would like to do: return amdgpu_vcn_sysfs_reset_mask_init(adev); On 2024-12-10 15:03, Alex Deucher wrote: Add the calls to the vcn 5.0.1 code. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 10 ++

Re: [PATCH 5/5] drm/amdgpu/sdma7: Add queue reset sysfs for sdmav7

2024-12-10 Thread David Wu
On 2024-12-09 22:53, jesse.zh...@amd.com wrote: sdmv7 queue reset already supports by mmio, add its sys file. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v7_0.

Re: [PATCH 1/2] drm/amd/amdgpu: command submission parser for JPEG

2024-08-06 Thread David Wu
sounds good - will fix them - thanks! David On 2024-08-06 16:09, Alex Deucher wrote: On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu wrote: Add JPEG IB command parser to ensure registers in the command are within the JPEG IP block. Signed-off-by: David (Ming Qiang) Wu --- drivers/gp

Re: [PATCH] drm/amdgpu/jpeg5: Add support for DPG mode

2024-06-26 Thread David Wu
On 2024-06-24 13:58, Sonny Jiang wrote: From: Sonny Jiang Add DPG support for JPEG 5.0 Signed-off-by: Sonny Jiang Reviewed-by: David (Ming Qiang) Wu tested fine as well - thanks! --- drivers/gpu/drm/amd/amdgpu/amdgpu_jpeg.h | 31 + drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_0.c | 159

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
On 2024-06-20 13:21, Alex Deucher wrote: On Thu, Jun 20, 2024 at 1:18 PM David Wu wrote: see inline, please David On 2024-06-20 12:50, Alex Deucher wrote: On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: I think the "break;" there is to silence the compilation warning - it i

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
see inline, please David On 2024-06-20 12:50, Alex Deucher wrote: On Thu, Jun 20, 2024 at 12:07 PM David Wu wrote: I think the "break;" there is to silence the compilation warning - it is ugly but needed. Which break? It looks fine to me. example here - code is fine but the com

Re: [PATCH] drm/amd/display: Remove redundant code and semicolons

2024-06-20 Thread David Wu
I think the "break;" there is to silence the compilation warning - it is ugly but needed. David On 2024-06-20 11:38, Alex Deucher wrote: Applied. Thanks! Alex On Thu, Jun 20, 2024 at 5:07 AM Jiapeng Chong wrote: No functional modification involved. ./drivers/gpu/drm/amd/display/dc/dml2/d

Re: [PATCH] drm/amdgpu: drop some kernel messages in VCN code

2024-05-23 Thread David Wu
please see in line. On 2024-05-23 12:02, Dong, Ruijing wrote: [AMD Official Use Only - AMD Internal Distribution Only] Please see my question inline below. Thanks, Ruijing -Original Message- From: Wu, David Sent: Thursday, May 23, 2024 11:05 AM To: amd-gfx@lists.freedesktop.org; Koen

Re: [PATCH] drm/amdgpu/vcn: update vcn5 enc/dec capabilities

2024-05-16 Thread David Wu
Reviewed-by: David (Ming Qiang) Wu On 2024-05-15 15:19, Ruijing Dong wrote: Update the capabilities for supporting 8k encoding/decoding. Signed-off-by: Ruijing Dong --- drivers/gpu/drm/amd/amdgpu/soc24.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers

Re: [PATCH] drm/amdgpu/vcn: remove irq disabling in vcn 5 suspend

2024-05-13 Thread David Wu
On 2024-05-13 13:43, Christian König wrote: Am 13.05.24 um 19:41 schrieb David Wu: On 2024-05-13 13:11, Christian König wrote: Am 09.05.24 um 20:40 schrieb David (Ming Qiang) Wu: We do not directly enable/disable VCN IRQ in vcn 5.0.0. And we do not handle the IRQ state as well. So the

Re: [PATCH] drm/amdgpu/vcn: remove irq disabling in vcn 5 suspend

2024-05-13 Thread David Wu
On 2024-05-13 13:11, Christian König wrote: Am 09.05.24 um 20:40 schrieb David (Ming Qiang) Wu: We do not directly enable/disable VCN IRQ in vcn 5.0.0. And we do not handle the IRQ state as well. So the calls to disable IRQ and set state are removed. This effectively gets rid of the warining

Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

2024-05-09 Thread David Wu
24-05-09 17:36, Alex Deucher wrote: On Thu, May 9, 2024 at 5:31 PM David Wu wrote: Hi Alex, Thanks for the suggestion! What I am thinking is "DRM_DEV_INFO" should not be the one we want - as it is more like a debug message. [drm:jpeg_v5_0_0_hw_init [amdgpu]] JPEG decode initialized succ

Re: [PATCH] drm/amdgpu/jpeg: keep drm kernel message consistent

2024-05-09 Thread David Wu
Hi Alex, Thanks for the suggestion! What I am thinking is "DRM_DEV_INFO" should not be the one we want - as it is more like a debug message. [drm:jpeg_v5_0_0_hw_init [amdgpu]] JPEG decode initialized successfully. instead I prefer to use this format: "amdgpu :43:00.0: amdgpu: JPEG deco

Re: [PATCH v2 2/2] drm/amd/display: Override DCN410 IP version

2024-04-30 Thread David Wu
On 2024-04-30 10:48, Harry Wentland wrote: On 2024-04-30 09:43, Aurabindo Pillai wrote: Override DCN IP version to 4.0.1 from 4.1.0 temporarily until change is made in DC codebase to use 4.1.0 Signed-off-by: Aurabindo Pillai Series is Reviewed-by: Harry Wentland Harry --- drivers/gpu