linux-6.15-rc6/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c: possible cut'n'paste error ?

->state_array[i].phyclk_mhz = max_phyclk_mhz; p->out_states->state_array[i].dtbclk_mhz = max_dtbclk_mhz; Suggest code rework. Regards David Binderman

linux-6.12-rc1/drivers/gpu/drm/amd/display/dc/dml/dcn20/display_rq_dlg_calc_20.c:653: Possible &/&& mixup ?

& (log2_dpte_req_height_ptes == 0) & surf_vert) //reduced, in this case, will have page fault within a group IMHO, looks odd. Was && intended ? Regards David Binderman

linux-6.6-rc1/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c:2175:26: style: Array index 'i' is used before limits check. [arrayIndexThenCheck]

lt; optimal_dcfclk_for_uclk[j]) { Regards David Binderman

dcn321_fpu.c:626: Array index check in wrong place ?

_uclk[j] && i < num_dcfclk_sta_targets) { It might be wise to move the limits check to before use. Regards David Binderman

linux-5.7-rc4/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1393: bad loop termination condition ?

- 1; j >= 0; j--) { but unsigned int i, j, closest_clk_lvl; so it looks like the loop never terminates. Suggest code rework. Regards David Binderman ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

drivers/gpu/drm/amd/display/modules/hdcp/hdcp1_execution.c:33:33: error: Buffer is accessed out of bounds

five bytes long. Suggest code rework. Regards David Binderman ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

linux-5.6-rc1/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8411:45: error: Division by zero.

. Regards David Binderman ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

linux-4.18-rc1/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c:207: broken nested if ?

dgpu_dpm_enable_uvd(adev, true); else amdgpu_device_ip_set_powergating_state(adev, AMD_IP_BLOCK_TYPE_VCN, AMD_PG_STATE_UNGATE); So second function call never happens. Suggest code rework.

linux-4.16-rc5/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c:1723]: (warning) Possible null pointer dereference: pipe_ctx

e_ctx->stream->sink->link->connector_signal != SIGNAL_TYPE_EDP)     return false; Suggest add some code to deal with the case that the for loop doesn't find what it is looking for and so pipe_ctx is NULL. Regards David Binderman

drivers/gpu/drm/radeon/r100.c:3303]: (style) Redundant condition

in the same file: [drivers/gpu/drm/radeon/r100.c:2550]: (style) Variable 'tmp' is assigned a value that is never used. [drivers/gpu/drm/radeon/r100.c:2875]: (style) Variable 'tmp' is assigned a value that is never used. Regards David Binderman

linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs

r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS); return 0; Regards David Binderman ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx