*speed = pcie_get_speed_cap(parent);
^^
Then we are toasted here.
6194 *width = pcie_get_width_cap(parent);
6195 }
6196 }
regards,
dan carpenter
11491 return false;
11492 }
regards,
dan carpenter
_SDMA_INSTANCES (16)
bits. So this bug does not affect anything in real life.
Still, for correctness sake, u64 bit masks should use BIT_ULL().
Fixes: d2e3961ae371 ("drm/amdgpu: add amdgpu_sdma_sched_mask debugfs")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu
}
2914 }
2915
2916 free:
2917 if (from_rom)
2918 kfree(err_data.err_addr);
2919 out:
2920 mutex_unlock(&con->recovery_lock);
2921
2922 return ret;
2923 }
regards,
dan carpenter
Thanks!
regards,
dan carpenter
Always non-NULL
918DMUB_TRACE_BUFFER_SIZE;
919 max_entries = (tbuf_size - sizeof(struct
dmub_debugfs_trace_header)) /
920 sizeof(struct dmub_debugfs_trace_entry);
921
922 num_entries =
regards,
dan carpenter
if (!tbuf_base)
> return 0;
>
> + if (adev->dm.dmub_srv)
> + fw_meta_info = &adev->dm.dmub_srv->meta_info;
> +
> tbuf_size = fw_meta_info ? fw_meta_info->trace_buffer_size :
> DMUB_TRACE_BUFFER_SIZE;
> max_entries = (tbuf_size - sizeof(struct dmub_debugfs_trace_header)) /
regards,
dan carpenter
x63 to support limit single process feature.\n");
> + dev_err(mes->adev->dev, "MES FW version must be larger
> than 0x63 to support limit single process feature.\n");
What does "to support limit single process feature" mean?
regards,
dan carpenter
: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202411071102.0cmtieio-...@intel.com/
smatch warnings:
drivers/gpu/drm/display/drm_dp_mst_topology.c:6043
drm_dp_mst_dsc_aux_for_port() warn: variable dereferenced before check 'port'
(see line 6033)
This NULL check is reversed so the function doesn't work.
Fixes: dad01f93f432 ("drm/amdgpu: validate hw_fini before function call")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
This was supposed to be an unlock instead of a lock. The original
code will lead to a deadlock.
Fixes: ee52489d1210 ("drm/amdgpu: Place NPS mode request on unload")
Signed-off-by: Dan Carpenter
---
>From static analysis, not testing.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c |
The >= ARRAY_SIZE() should be > ARRAY_SIZE() to prevent an out of
bounds read.
Fixes: 012be6f22c01 ("drm/amdgpu: Add sysfs interfaces for NPS mode")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
3 *out = ring;
1234 return 0;
1235
1236 clean_up_ring:
1237 amdgpu_ring_fini(ring);
1238 clean_up_memory:
1239 kfree(ring);
--> 1240 amdgpu_mes_unlock(&adev->mes);
^^
1241 return r;
1242 }
regards,
dan carpenter
/202409231002.bmp89ipm-...@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 14.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https
Indent the "break" statement one more tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
index 0f
These tabs were deleted accidentally in commit d07722e1fc74 ("drm/amd/display:
DML2.1 Reintegration for Various Fixes"). Add them back.
Signed-off-by: Dan Carpenter
---
.../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c| 4 ++--
1 file changed, 2 insertions(+), 2 deletion
On Tue, Aug 20, 2024 at 10:39:09AM -0400, Alex Deucher wrote:
> Otherwise we can fail to drop the software mutex when
> we fail to take the hardware mutex.
>
> Fixes: 76acba7b7f12 ("drm/amdgpu/gfx11: add a mutex for the gfx semaphore")
> Reported-by: Dan Carpenter
>
mutex_unlock(&adev->gfx.reset_sem_mutex);
return -EINVAL;
}
But I really think it would be nicer in the caller.
4777
--> 4778 return 0;
4779 }
regards,
dan carpenter
gpu: Update VF2PF interface")
> Signed-off-by: Su Hui
> Signed-off-by: Dan Carpenter
> Signed-off-by: wenlunpeng
> Signed-off-by: WangYuli
> ---
Thanks for doing this, but these Signed-off-by tags aren't correct.
Signed-off-by is like signing a legal document. It came
_kbytes = %u\n",
__func__, p->rob_buffer_size_kbytes);
3846 #endif
3847 }
3848 #ifdef __DML_VBA_DEBUG__
3849 dml2_printf("DML::%s: compbuf_reserved_space_64b = %u\n",
__func__, *p->compbuf_reserved_space_64b);
3850 #endif
3851
3852 *p->hw_debug5 = false;
3853 for (unsigned int k = 0; k < p->NumberOfActiveSurfaces; ++k) {
3854 if (!(p->mrq_present) && (!p->UnboundedRequestEnabled)
&& (TotalActiveDPP == 1)
^^
This checks if the pointer to enabled is NULL. Probably *p was intended.
3855 &&
p->display_cfg->plane_descriptors[k].surface.dcc.enable
3856 && ((p->rob_buffer_size_kbytes * 1024 *
(p->mrq_present ? MAXIMUMCOMPRESSION : 1)
regards,
dan carpenter
eturn 0;
309
310 out_err_unreserve:
311 amdgpu_bo_unreserve(vm->root.bo);
312 out_err_release:
313 kfd_queue_release_buffers(pdd, properties);
314 return err;
315 }
regards,
dan carpenter
break;
7205 }
7206
7207 if (aconnector->base.connector_type ==
DRM_MODE_CONNECTOR_WRITEBACK)
regards,
dan carpenter
uncs->set_output_gamma(mpc, mpcc_id, params);
Then it will crash
402 return ret;
403 }
regards,
dan carpenter
This code works, but it's not aligned correctly. Add a couple missing
tabs.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdg
We recently added locking to add_queue_mes() but this error path was
overlooked. Add an unlock to the error path.
Fixes: 1802b042a343 ("drm/amdgpu/kfd: remove is_hws_hang and is_resetting")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 1
gfx_v11_0_rlc_backdoor_autoload_enable(adev);
Unchecked dereference inside the function. (Probably just delete the
NULL check?)
4504 if (r)
4505 return r;
4506 } else {
regards,
dan carpenter
^^^
stream->timing.v_total is u32 so it makes the subtract u32 thus it's
always >= 0.
1007
1008 return ((safe_refresh_v_total - stream->timing.v_total) >= 0)
? (safe_refresh_v_total - stream->timing.v_total) : 0;
^^^
Same.
1009 }
regards,
dan carpenter
fore check 'bo' (see line 500)'
>
> Signed-off-by: Sreekant Somasekharan
> Suggested-by: Dan Carpenter
> ---
This is fine, but you're overthinking these... The v1 patch was also
fine.
regards,
dan carpenter
s out_clks;
572 unsigned int result = 0;
573 bool need_recalculation = false;
574 uint32_t cstate_enter_plus_exit_z8_ns;
575
576 if (!context || context->stream_count == 0)
Checked too late
577 return true;
578
regards,
dan carpenter
The "ret" variable is zero. No need to check.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index a0
*flags &= ~AMDGPU_PTE_VALID;
516 }
517
518 if (bo && bo->flags & (AMDGPU_GEM_CREATE_COHERENT |
^^
But previously we assumed bo could be NULL.
519 AMDGPU_GEM_CREATE_UNCACHED)
&crtc_state->stream->cursor_attributes;
8441
8442 if (!dc_stream_set_cursor_position(crtc_state->stream,
8443&position))
8444 DRM_ERROR("DC failed to set cursor
position\n");
8445
8446 update->cursor_position =
&crtc_state->stream->cursor_position;
8447 }
8448 }
regards,
dan carpenter
2);
174 }
175 } else {
176 if (ring->use_doorbell) {
177 DRM_DEBUG("Using doorbell -- "
178 "wptr_offs == 0x%08x "
regards,
dan carpenter
Return -EINVAL on error instead of success. Also on the success path,
return a literal zero instead of "return result;"
Fixes: e098bc9612c2 ("drm/amd/pm: optimize the power related source code
layout")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/pm/powerplay/hwmg
dc_allow_idle_optimizations(dc, false);
regards,
dan carpenter
at I could replace
"scl_data->dscl_prog_data." with just "data->" and shorten the lines a
bit. It's more readable without the line breaks.
I also tried to align it so you can see what is changing on each line.
Signed-off-by: Dan Carpenter
---
.../displ
The "instance" variable needs to be signed for the error handling to work.
Fixes: b34ddc71267a ("drm/amdgpu: add error handle to avoid out-of-bounds")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
These lines are indented too far. Clean the whitespace.
Signed-off-by: Dan Carpenter
---
v2: Delete another blank line (checkpatch.pl --strict).
drivers/gpu/drm/amd/display/dc/core/dc.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc
On Wed, Apr 24, 2024 at 03:11:08PM +0200, Christian König wrote:
> Am 24.04.24 um 13:41 schrieb Dan Carpenter:
> > These lines are indented too far. Clean the whitespace.
> >
> > Signed-off-by: Dan Carpenter
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc.c
On Wed, Apr 24, 2024 at 03:33:11PM +0200, Christian König wrote:
> Am 24.04.24 um 15:20 schrieb Dan Carpenter:
> > On Wed, Apr 24, 2024 at 03:11:08PM +0200, Christian König wrote:
> > > Am 24.04.24 um 13:41 schrieb Dan Carpenter:
> > > > These lines are indented
These lines are indented too far. Clean the whitespace.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
b/drivers/gpu/drm/amd/display/dc/core/dc.c
if (tf->type == TF_TYPE_HWPWL)
1123
dpp_base->funcs->dpp_program_degamma_pwl(dpp_base,
regards,
dan carpenter
feature_enabled;
but the patch assumes link can be NULL. Somebody is wrong.
regards,
dan carpenter
"timing" is "&pipe_ctx[i]->stream->timing" where ->timing is not the
first struct member of ->stream. So it's the address which points into
the middle of a struct. It can't be NULL so delete the NULL check.
Signed-off-by: Dan Carpenter
gards,
dan carpenter
242 drm_printf(&p, "AMDGPU register dumps:\nOffset:
Value:\n");
243
244 for (i = 0; i < coredump->adev->reset_info.num_regs;
i++)
245 drm_printf(&p, "0x%08x: 0x%08x\n",
246
coredump->adev->reset_info.reset_dump_reg_list[i],
247
coredump->adev->reset_info.reset_dump_reg_value[i]);
248 }
249
250 return count - iter.remain;
251 }
regards,
dan carpenter
srv_is_hw_pwr_up(dc->ctx->dmub_srv, true))
1396 ASSERT(0);
1397
--> 1398 DC_LOG_IPS("%s exit (count rcg=%d ips1=%d ips2=%d)",
1399 __func__,
1400 rcg_exit_count,
1401 ips1_exit_count,
1402 ips2_exit_count);
used here
1403 }
regards,
dan carpenter
memset(&dc_em_sink->edid_caps, 0, sizeof(struct
dc_edid_caps));
6685 memmove(dc_em_sink->dc_edid.raw_edid, edid,
(edid->extensions + 1) * EDID_LENGTH);
regards,
dan carpenter
These ANDs should be ORs or it will lead to a NULL dereference.
Fixes: fb5a3d037082 ("drm/amd/display: Add NULL test for 'timing generator' in
'dcn21_set_pipe()'")
Fixes: 886571d217d7 ("drm/amd/display: Fix 'panel_cntl' could be null in
'
On Thu, Feb 01, 2024 at 02:53:42PM +0100, Sebastian Andrzej Siewior wrote:
> On 2024-02-01 15:18:04 [+0300], Dan Carpenter wrote:
> > Hello Sebastian Andrzej Siewior,
> Hi Dan,
>
> > The patch de5e73dc6baf: "drm/amd/display: Simplify the per-CPU
> > usage."
78 dc->caps.max_planes = pool->base.pipe_count;
2579
2580 for (i = 0; i < dc->caps.max_planes; ++i)
2581 dc->caps.planes[i] = plane_cap;
2582
2583 dc->cap_funcs = cap_funcs;
2584
2585 if (dc->ctx->dc_bios-&
=
link_dpia_secondary->dpia_bw_alloc_config.estimated_bw;
227 }
228 break;
229 }
230 }
231
232 return total_bw;
233 }
regards,
dan carpenter
if (vm->is_compute_context && bo_va->base.bo &&
^^
The patch adds this NULL check but hopefully it's not required.
1481 bo_va->base.bo->tbo.base.import_attach &&
1482 (!bo_va->base.bo->tbo.resource ||
regards,
dan carpenter
The aca_bank_hwip_is_matched() function is type bool. This error path
return -EINVAL which is cast to true, but it should return false
instead.
Fixes: 22a4fa4709e3 ("drm/amdgpu: implement RAS ACA driver framework")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu
-denominator :
denominator);
67
68 uint16_t remainder;
69
regards,
dan carpenter
ery)) {
543 spin_unlock(&kiq->ring_lock);
544 return 0;
545 }
546
547 if (kiq_ring->sched.ready && !adev->job_hang)
548 r = amdgpu_ring_test_helper(kiq_ring);
549 spin_unlock(&kiq->ring_lock);
regards,
dan carpenter
^
This macro dereferences dc_dmub_srv.
1042 return;
1043 }
1044
1045 dmub = dc_dmub_srv->dmub;
regards,
dan carpenter
er amdgpu_gfx_disable_kcq() which is holding
spin_lock(&kiq->ring_lock). And we can't take a mutex if we're already
holding a spin_lock. Turn on CONFIG_DEBUG_ATOMIC_SLEEP to see the
warning.
regards,
dan carpenter
dml2->v20.scratch.dml_to_dc_pipe_mapping.dml_pipe_idx_to_plane_id[num_pipes] =
dml2->v20.scratch.dml_to_dc_pipe_mapping.disp_cfg_to_plane_id[i];
80
dml2->v20.scratch.dml_to_dc_pipe_mapping.dml_pipe_idx_to_plane_id_valid[num_pipes]
= true;
81 num_pipes++;
82 }
83 }
84 }
regards,
dan carpenter
132.0 * 383.0 / 384.0 * 65536.0 / 65540.0;
There are a bunch of other warnings as well. Too many to review.
regards,
dan carpenter
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2903 dm_resume()
warn: inconsistent indenting
drivers/gpu/drm/amd/amdgpu/../display/dc/basics/dc
;
802 }
803
804 if (!dc_dmub_srv_get_diagnostic_data(dc_dmub_srv, &diag_data)) {
regards,
dan carpenter
}
546
547 return drm_dp_dpcd_read(&aconnector->dm_dp_aux.aux, address,
data,
548 size) == size;
549 }
regards,
dan carpenter
"ret" was checked earlier inside the loop, so we know it is zero here.
No need to check a second time.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13
979
980 if (ctx->dc_bios && ctx->dc_bios->integrated_info &&
ctx->dc->config.use_default_clock_table == false) {
This NULL check is too late. It will already have crashed.
981 dcn35_clk_mgr_helper_populate_bw_params(
982 &clk_mgr->base,
regards,
dan carpenter
Here is the list of new warning which were introduced while I was out
of office. The line numbers are from linux-next next-20230905.
regards,
dan carpenter
drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:292
dcn35_update_clocks() warn: inconsistent indenting
drivers/gpu
This loop will exit with "retry" set to -1 if it fails but the code
checks for if "retry" is zero. Fix this by changing post-op to a
pre-op. --retry vs retry--.
Fixes: e01eeffc3f86 ("drm/amd/pm: avoid driver getting empty metrics table for
the first time"
On Wed, Sep 06, 2023 at 07:07:32PM +0800, Lang Yu wrote:
> On 09/06/ , Dan Carpenter wrote:
>
> Thanks for reporting this bug. Can you give a link to this bug report? Commit
> message requests it.
> ("Reported-by: should be immediately followed by Link: with a URL to the
>
x27;t be less than zero.
339 r = test->pasid;
340 goto error_fini_vm;
341 }
342
343 r = amdgpu_bo_create_kernel(adev, sizeof(struct
umsch_mm_test_ctx_data),
regards,
dan carpenter
link->replay_settings.replay_feature_enabled)
860 replay->funcs->replay_enable(replay,
*allow_active, wait, panel_inst);
861 link->replay_settings.replay_allow_active =
*allow_active;
862 }
863
864 return true;
865 }
regards,
dan carpenter
tr->attr_update :
default_attr_update;
regards,
dan carpenter
This error path needs to unlock the "aconnector->handle_mst_msg_ready"
mutex before returning.
Fixes: bb4fa525f327 ("drm/amd/display: Add polling method to handle MST reply
packet")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst
&stream_update);
8794 mutex_unlock(&dm->dc_lock);
8795 kfree(dummy_updates);
regards,
dan carpenter
fbdev: Remove FBINFO_DEFAULT from static structs
fbdev: Remove FBINFO_DEFAULT from kzalloc() structs
fbdev: Remove FBINFO_DEFAULT from devm_kzalloc() structs
regards,
dan carpenter
its(ring->wptr));
5207 }
5208 }
5209 }
regards,
dan carpenter
"Mark the associated types properly packed individually, rather than
use the disgusting "pragma pack()" that should never be used."
https://lore.kernel.org/linux-sparse/CAHk-=wi7jgz+bvbt-ufxokpeqdhzf3z2hbjkgdjh8q4dvpp...@mail.gmail.com/
regards,
dan carpenter
return r;
Smatch complains that we don't necessarily enter the loop. I think
I'm going to disable this type of "enter the loop" warning when you
don't have the cross function database available. That will silence
these for the kbuild bot.
regards,
dan carpenter
Hi
On Tue, Jun 20, 2023 at 10:37:59AM +0300, Dan Carpenter wrote:
> "Mark the associated types properly packed individually, rather than
> use the disgusting "pragma pack()" that should never be used."
>
> https://lore.kernel.org/linux-sparse/CAHk-=wi7jgz+bvb
The "target" either comes from kfd_create_process() which returns error
pointers on error or kfd_lookup_process_by_pid() which returns NULL on
error. So we need to check for both types of errors.
Fixes: a42e42c4e3b1 ("drm/amdkfd: prepare per-process debug enable and disable"
ulfill the OD support for SMU13.0.7")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 4 ++--
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu1
r drm_mm_takedown() are holding spinlocks so it's a
sleeping in atomic bug.
The problematic callers are ttm_range_man_fini_nocheck() and
amdgpu_gtt_mgr_fini().
1002 }
regards,
dan carpenter
ctx->dc_bios && ctx->dc_bios->integrated_info) {
Check for NULL is too late.
776 rn_clk_mgr_helper_populate_bw_params
(clk_mgr->base.bw_params, &clock_table, ctx->dc_bios->integrated_info);
777 /* treat memory config as single channel if
memory is asymmetrics. */
regards,
dan carpenter
/amdgpu: Update debugfs for XCC support (v3)")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
ind
ig as single channel if
memory is asymmetrics. */
778 if (ctx->dc->config.is_asymmetric_memory)
779 clk_mgr->base.bw_params->num_channels =
1;
780 }
781 }
782
783 /* enable powerfeatures when displaycount goes to 0 */
784 if (clk_mgr->smu_ver >= 0x00371500)
785 rn_vbios_smu_enable_48mhz_tmdp_refclk_pwrdwn(clk_mgr,
!debug->disable_48mhz_pwrdwn);
786 }
regards,
dan carpenter
1220 if (!aconnector || !aconnector->dc_link)
^^^
Too late. Dead already.
1221 return -EINVAL;
1222
1223 if (size == 0)
regards,
dan carpenter
On Mon, May 15, 2023 at 10:11:39AM -0400, Alex Deucher wrote:
> On Mon, May 15, 2023 at 3:17 AM Dan Carpenter
> wrote:
> >
> > On Mon, May 15, 2023 at 09:34:28AM +0800, Su Hui wrote:
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> &g
u probably want to change the order now that the lengths have
changed. Same in the other places as well.
regards,
dan carpenter
This function was releasing the incorrect lock on the error path.
Reported-by: kernel test robot
Fixes: 9bfa241d1289 ("drm/amdgpu: add [en/dis]able_kgq() functions")
Signed-off-by: Dan Carpenter
---
The LKP robot sent me an email about this after I had already written
the patch. (I
v9_0")
Signed-off-by: Dan Carpenter
---
The Fixes tag is weird, but I think it's correct?
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
i
We changed which lock we are supposed to take but this error path
was accidentally over looked so it still drops the old lock.
Fixes: def799c6596d ("drm/amdgpu: add multi-xcc support to amdgpu_gfx
interfaces (v4)")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu
* are done programming.
2008 */
2009 if (hwseq->funcs.program_mall_pipe_config)
2010 hwseq->funcs.program_mall_pipe_config(dc, context);
2011
regards,
dan carpenter
There is a mixup where AMDGPU_RAS_BLOCK__DF is used as a mask instead of
a shifter. It means that this condition will be true for
AMDGPU_RAS_BLOCK__MMHUB instead of for AMDGPU_RAS_BLOCK__DF.
Fixes: b6f512168478 ("drm/amdgpu: Add fatal error handling in nbio v4_3")
Signed-off-by: Dan
+tries < 50);
356 }
357
--> 358 return result;
^^
result is a non-zero enum so this always returns true. Which is fine
because the caller doesn't check.
359 }
regards,
dan carpenter
^
Too late.
1863 return BP_RESULT_BADBIOSTABLE;
1864
regards,
dan carpenter
364
365 if (!link->link_enc) {
^^
Checked too late
366 DC_ERROR("Failed to create link encoder!\n");
367 goto link_enc_create_fail;
368 }
369
regards,
dan carpenter
Checked too late.
258
259 /* 1. Check no memory request case for CAB.
regards,
dan carpenter
} while (++tries < 50);
351 }
352
--> 353 return result;
354 }
regards,
dan carpenter
This tab was deleted accidentally and triggers a Smatch warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:1006 gfx_v8_0_init_microcode()
warn: inconsistent indenting
Add it back.
Fixes: 0aaafb7359d2 ("drm/amd: Use `amdgpu_ucode_*` helpers for GFX8")
Signed-off-by: Dan
test robot
| Reported-by: Dan Carpenter
smatch warnings:
drivers/gpu/drm/drm_buddy.c:501 find_continuous_blocks() error: uninitialized
symbol 'block'.
vim +/block +501 drivers/gpu/drm/drm_buddy.c
8a257b57bc11a2 xinhui pan 2022-12-18 472 static struct drm_buddy_block *
8a257b57bc11a2
We re-arranged this code recently so "ret" is always zero at this point.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
b/drivers/gpu/drm/
On Wed, Nov 16, 2022 at 03:49:18PM -0500, Felix Kuehling wrote:
> Am 2022-11-16 um 03:04 schrieb Ma Jun:
> > Release the topology_lock in error case
> >
> > Signed-off-by: Ma Jun
> > Reported-by: Dan Carpenter
> Dan, did you change your email address, is this on
1 - 100 of 377 matches
Mail list logo
