[AMD Official Use Only]
A coding style issue, "Do not unnecessarily use braces where a single statement
will do."
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Yifan Zhang
Sent: Wednesday, July 28, 2021 11:40 AM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Yifan
Subje
[Public]
Ok, I see. Thanks!
Regards,
Jiansong
From: Deucher, Alexander
Sent: Thursday, July 15, 2021 10:55 AM
To: Chen, Jiansong (Simon) ; Alex Deucher
; Zeng, Oak
Cc: Xu, Feifei ; Kuehling, Felix ;
Liu, Leo ; amd-gfx list ;
Zhang, Hawking
Subject: Re: [PATCH 2/3] drm/amdgpu: Fix a
[Public]
Hi Alex,
Is DRM_DEV_INFO more suitable than dev_info as far as DRM subsystem is
concerned? Thanks!
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Alex Deucher
Sent: Wednesday, July 14, 2021 11:48 PM
To: Zeng, Oak
Cc: Xu, Feifei ; Kuehling, Felix ;
Liu, Leo ;
[AMD Official Use Only]
Is DRM_WARN more suitable for the case?
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Guchun Chen
Sent: Tuesday, July 13, 2021 1:56 PM
To: amd-gfx@lists.freedesktop.org; Wang, Chao-kai (Stylon)
; Kazlauskas, Nicholas ;
Siqueira, Rodrigo ; Yin,
[AMD Official Use Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Chengming Gui
Sent: Friday, July 9, 2021 4:29 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao ; Chen, Jiansong (Simon)
; Chen, Guchun ; Feng, Kenneth
; Zhang, Hawking ; Gui, Jack
Subject: [PATCH] drm
[AMD Official Use Only]
Internal ticket number is not appropriate to appear in upstream patch, and
percise->precise in the subject?
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Roy Sun
Sent: Monday, July 5, 2021 6:24 PM
To: amd-gfx@lists.freedesktop.org
Cc: Sun, Roy
[AMD Official Use Only]
BTW, there is an obvious typo in the subject, Walk thorugh => Walk through.
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Felix
Kuehling
Sent: Thursday, June 17, 2021 7:09 AM
To: Pan, Xinhui ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
I think we still could keep them to be more informative for the moment.
Regards,
Jiansong
-Original Message-
From: Chen, Guchun
Sent: Tuesday, May 25, 2021 3:47 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Cc: Chen, Jiansong (Simon)
Subject: RE: [PATCH] drm/amdgpu
[AMD Official Use Only]
Please ignore the patch, will resend after removing multiple assignments.
-Original Message-
From: Jiansong Chen
Sent: Tuesday, May 25, 2021 2:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Chen, Jiansong (Simon)
Subject: [PATCH] drm/amdgpu: refine
[AMD Official Use Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Chengming Gui
Sent: Thursday, May 20, 2021 3:55 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gui, Jack ; Zhou1, Tao ; Chen,
Jiansong (Simon) ; Zhang, Hawking
; Feng, Kenneth
Subject: [PATCH] drm/amd/pm: Update
if (AMDGPU_PREAMBLE_IB_PRESENT_FIRST & flags)
dw2 |= 0x1000;
}
-Original Message-
From: Christian König
Sent: Monday, May 17, 2021 2:56 PM
To: Chen, Jiansong (Simon) ; Koenig, Christian
; amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu
From: Koenig, Christian
Sent: Monday, May 17, 2021 2:42 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: optimize to drop preamble IB for old GPUs
Well NAK, as discussed checking the global flag is more flexible since it will
still enable the pre
[AMD Official Use Only - Internal Distribution Only]
Better to make the commit msg more specific, eg. Change predicate accordingly
since aspm is enabled by default.
Either way, Reviewed-by: Jiansong Chen
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Kenneth Feng
Sent
[AMD Official Use Only - Internal Distribution Only]
Hi Alex,
I notice there is already similar logic in sdma_v5_0_ring_emit_ib, do we need
remove it?
Regards,
Jiansong
@@ -410,6 +410,18 @@ static void sdma_v5_0_ring_emit_ib(struct amdgpu_ring
*ring,
unsigned vmid = AMDGPU_JOB_GET_VMID
[AMD Official Use Only - Internal Distribution Only]
I still wonder how the issue takes place? According to my humble knowledge in
driver model, the reference count of the kobject
for the device will not reach zero when there is still some device mem access,
and shutdown should not happen.
Rega
We still need reserve "return 0", otherwise may trigger warning "not all
control paths return a value".
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Chen, Guchun
Sent: Thursday, March 18, 2021 5:28 PM
To: Quan, Evan ; amd-gfx@lists.freedesktop.org
Cc: Lazar, Lijo ; Qua
[AMD Official Use Only - Internal Distribution Only]
For all the "locked = likely(!amdgpu_in_recovery_thread(adev)) & !in_irq();",
logical operator "&&" should be used,
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Dennis Li
Sent: Monday, March 1, 2021 7:12 PM
To: amd
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Sunday, February 7, 2021 4:52 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm
If it's just for dev usage, why don't use UMR tool instead?
~/tools$ sudo ./umr -r *.mp*.mmMP1_SMN_EXT_SCRATCH0
0x0040
-Original Message-
From: amd-gfx On Behalf Of Quan, Evan
Sent: Monday, January 18, 2021 2:06 PM
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander
[AMD Public Use]
Can you help explain why we need introduce such a callback? Seems it has
presupposed pmfw's internal
Implementation.
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Friday, January 15, 2021 5:34 PM
To: amd-gfx@lists.freedesktop.org
Cc: D
[AMD Public Use]
Hi Rui,
Seems the change has violated the kernel coding style😊, please help check.
https://www.kernel.org/doc/html/latest/process/coding-style.html
Allocating memory
..
The preferred form for passing a size of a struct is the following:
p = kmalloc(sizeof(*p), ...);
The alte
!
Regards,
Jiansong
-Original Message-
From: Paul Menzel
Sent: Monday, January 11, 2021 7:58 PM
To: Chen, Jiansong (Simon)
Cc: Zhou1, Tao ; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: enable gpu recovery for navy_flounder
Dear Jiansong,
Am 11.01.21 um 10
Ok, I will send another patch.
Regards,
Jiansong
-Original Message-
From: Zhang, Hawking
Sent: Wednesday, December 30, 2020 6:02 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao ; Chen, Jiansong (Simon)
Subject: RE: [PATCH] drm/amdgpu: correct releasing
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Dennis Li
Sent: Wednesday, December 30, 2020 2:46 PM
To: amd-gfx@lists.freedesktop.org; Clements, John ;
Zhang, Hawking ; Koenig, Christian
Cc: Li, Dennis
Subject: [PATCH] drm/amdgpu: fi
[AMD Public Use]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Wednesday, December 16, 2020 11:40 AM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amdgpu: print mmhub client name for
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, December 15, 2020 6:23 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm
Chen, Jiansong (Simon) would like to recall the message, "[PATCH 5/5]
drm/amd/pm: fulfill sienna cichlid 2nd usb2.0 port workaround".
___
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
[AMD Official Use Only - Internal Distribution Only]
Hi Evan,
Besides Navi21, other Navi2x Asics reuse sienna_cichlid_ppt.c and the
callbacks, have you taken their user cases into consideration?
Thanks!
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Evan Quan
Sent: Wedn
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Monday, December 7, 2020 2:06 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amd
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Friday, November 27, 2020 12:28 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, November 17, 2020 3:33 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm
[AMD Official Use Only - Internal Distribution Only]
In the subject Ptable->pptable, except that,
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, November 17, 2020 11:32 AM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Friday, November 13, 2020 4:51 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amd
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, November 10, 2020 2:30 PM
To: Chen, Jiansong (Simon) ; Gui, Jack
; Zhang, Hawking ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm
[AMD Official Use Only - Internal Distribution Only]
Please ignore the change.
-Original Message-
From: Jiansong Chen
Sent: Friday, October 30, 2020 10:57 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu, James ;
Liu, Leo ; Zhou1, Tao ; Chen, Jiansong
(Simon)
Subject
[AMD Official Use Only - Internal Distribution Only]
Hi James,
Thanks for your input, v2 patch is sent out.
Regards,
Jiansong
-Original Message-
From: Zhu, James
Sent: Friday, October 30, 2020 9:06 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Zhu
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: amd-gfx On Behalf Of Likun Gao
Sent: Tuesday, September 22, 2020 11:17 AM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Feng, Kenneth ;
Zhang, Hawking
Subject: [PATCH] drm/amd
It makes nonsense to call gfxoff when smu failure has happened.
Regards,
Jiansong
-Original Message-
From: Chen, Guchun
Sent: Monday, September 14, 2020 4:14 PM
To: Chen, Jiansong (Simon) ;
amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao ; Feng, Kenneth ; Quan,
Evan ; Chen, Jiansong
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Gao, Likun
Sent: Thursday, September 10, 2020 4:27 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Feng, Kenneth
; Chen, Jiansong (Simon) ; Gao,
Likun
Subject: [PATCH
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Zhou1, Tao
Sent: Tuesday, August 25, 2020 11:20 AM
To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ;
Chen, Jiansong (Simon) ; Gui, Jack
Cc: Zhou1, Tao
Subject: [PATCH] drm
[AMD Official Use Only - Internal Distribution Only]
Reviewed-by: Jiansong Chen
-Original Message-
From: Wang, Kevin(Yang)
Sent: Monday, August 24, 2020 8:41 PM
To: amd-gfx@lists.freedesktop.org
Cc: Huang, Ray ; Deucher, Alexander
; Chen, Jiansong (Simon) ;
Wang, Kevin(Yang) ; Chen
[AMD Official Use Only - Internal Distribution Only]
Good point, but I wonder whether the outmost uint64_t cast is necessary?
Regards,
Jiansong
-Original Message-
From: amd-gfx On Behalf Of Kevin
Sent: Monday, August 24, 2020 4:59 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexan
[AMD Official Use Only - Internal Distribution Only]
See my comments below.
-Original Message-
From: Gao, Likun
Sent: Friday, July 24, 2020 5:39 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Feng, Kenneth
; Chen, Jiansong (Simon) ; Gao,
Likun
Subject: [PATCH] drm/amd
[AMD Official Use Only - Internal Distribution Only]
Then why we don't handle it directly in smu_cmn_send_smc_msg_with_param where
is more near to the source of the problem.
And there is similar logic already.
if (index < 0)
return index == -EACCES ? 0 : index;
Regards,
Jiansong
-Original Me
44 matches
Mail list logo
