the suggested-by tag. Added it in v2.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Matthew Auld
---
drivers/gpu/drm/drm_buddy.c | 316 ++--
include/drm/drm_buddy.h | 15 +-
2 files changed, 204 insertions(+), 127 deletions(-)
diff --git a/drivers/gpu
% with the RB tree
(rbtree_insert.isra.0), despite performing the same sorted insert.
This also improves performance in heavily fragmented workloads,
such as games or graphics tests that stress memory.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/drm_buddy.c | 141
% with the RB tree
(rbtree_insert.isra.0), despite performing the same sorted insert.
This also improves performance in heavily fragmented workloads,
such as games or graphics tests that stress memory.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/drm_buddy.c | 141
: Arunpravin Paneer Selvam
---
drivers/gpu/drm/drm_buddy.c | 316 ++--
include/drm/drm_buddy.h | 15 +-
2 files changed, 204 insertions(+), 127 deletions(-)
diff --git a/drivers/gpu/drm/drm_buddy.c b/drivers/gpu/drm/drm_buddy.c
index 19e9773b41be..0ffb68474b83 100644
On 7/16/2025 4:31 PM, Christian König wrote:
On 16.07.25 12:47, Christian König wrote:
On 16.07.25 12:28, Arunpravin Paneer Selvam wrote:
Hi Dave,
I am trying to push this series into drm-misc-fixes, but I get the below error
when dim push-branch drm-misc-fixes.
dim:ERROR:e24c180b4300
Hi Christian,
On 7/16/2025 4:17 PM, Christian König wrote:
On 16.07.25 12:28, Arunpravin Paneer Selvam wrote:
Hi Dave,
I am trying to push this series into drm-misc-fixes, but I get the below error
when dim push-branch drm-misc-fixes.
dim:ERROR:e24c180b4300("drm/amdgpu:Reset the clear
cked-by is required to push the patches into
drm-misc-fixes ?
Regards,
Arun.
On 7/16/2025 1:21 PM, Arunpravin Paneer Selvam wrote:
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist.
- This is necessary because, upon resuming, the VR
On 7/16/2025 1:21 PM, Christian König wrote:
On 16.07.25 09:41, Arunpravin Paneer Selvam wrote:
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist.
- This is necessary because, upon resuming, the VRAM becomes
cluttered with BIOS data, yet
to avoid the use of extra reset flag.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Acked-by: Christian König
Reviewed-by: Matthew Auld
Cc: sta...@vger.kernel.org
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
Closes: https://gitlab.freed
when the blocks clear reset
function is called.
Signed-off-by: Arunpravin Paneer Selvam
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/tests/drm_buddy_test.c | 41 ++
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
b/drivers/gpu/drm
(Christian).
- Modified the patch subject name.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
to avoid the use of extra reset flag.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Reviewed-by: Matthew Auld
Cc: sta...@vger.kernel.org
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
Closes: https://gitlab.freedesktop.org/drm/amd/-/i
when the blocks clear reset
function is called.
Signed-off-by: Arunpravin Paneer Selvam
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/tests/drm_buddy_test.c | 41 ++
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
b/drivers/gpu/drm
(Christian).
- Modified the patch subject name.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
On 7/10/2025 7:50 PM, Matthew Auld wrote:
On 10/07/2025 08:14, Arunpravin Paneer Selvam wrote:
On 7/8/2025 2:30 PM, Matthew Auld wrote:
On 08/07/2025 07:54, Arunpravin Paneer Selvam wrote:
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist
On 7/8/2025 2:30 PM, Matthew Auld wrote:
On 08/07/2025 07:54, Arunpravin Paneer Selvam wrote:
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist.
- This is necessary because, upon resuming, the VRAM becomes
cluttered with BIOS data, yet the
when the blocks clear reset
function is called.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/tests/drm_buddy_test.c | 41 ++
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
b/drivers/gpu/drm/tests/drm_buddy_test.c
index
to avoid the use of extra reset flag.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Cc: sta...@vger.kernel.org
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3812
---
drivers/gpu/drm/
(Christian).
- Modified the patch subject name.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Cc: sta...@vger.kernel.org
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.h | 5 -
1 file changed, 4
Hi Matthew,
On 7/4/2025 2:22 PM, Matthew Auld wrote:
On 01/07/2025 20:08, Arunpravin Paneer Selvam wrote:
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist.
- This is necessary because, upon resuming, the VRAM becomes
cluttered with BIOS
On 7/2/2025 7:11 PM, Christian König wrote:
On 02.07.25 13:58, Arunpravin Paneer Selvam wrote:
Hi Christian,
On 7/2/2025 1:27 PM, Christian König wrote:
On 01.07.25 21:08, Arunpravin Paneer Selvam wrote:
Set the dirty bit when the memory resource is not cleared
during BO release.
v2
Hi Christian,
On 7/2/2025 1:27 PM, Christian König wrote:
On 01.07.25 21:08, Arunpravin Paneer Selvam wrote:
Set the dirty bit when the memory resource is not cleared
during BO release.
v2(Christian):
- Drop the cleared flag set to false.
- Improve the amdgpu_vram_mgr_set_clear_state
drm_buddy_clear_reset_blocks()(Matthew Auld)
- Force merge the two dirty blocks.(Matthew Auld)
- Add a new unit test case for this issue.(Matthew Auld)
- Having this function being able to flip the state either way would be
good. (Matthew Brost)
Signed-off-by: Arunpravin Paneer Selvam
when the blocks clear reset
function is called.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/tests/drm_buddy_test.c | 41 ++
1 file changed, 41 insertions(+)
diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c
b/drivers/gpu/drm/tests/drm_buddy_test.c
index
Set the dirty bit when the memory resource is not cleared
during BO release.
v2(Christian):
- Drop the cleared flag set to false.
- Improve the amdgpu_vram_mgr_set_clear_state() function.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Cc: sta...@vger.kernel.org
Fixes
Set the dirty bit when the memory resource is not cleared
during BO release.
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
Cc: sta...@vger.kernel.org
Fixes: a68c7eaa7a8f ("drm/amdgpu: Enable clear page functionality")
---
drivers/gpu/drm/amd/amdgpu/amdgp
- Added a handler in DRM buddy manager to reset the cleared
flag for the blocks in the freelist.
- This is necessary because, upon resuming, the VRAM becomes
cluttered with BIOS data, yet the VRAM backend manager
believes that everything has been cleared.
Signed-off-by: Arunpravin Paneer
-
From: Paneer Selvam, Arunpravin
Sent: Friday, May 30, 2025 1:57 PM
To: Ma, Li ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; Koenig, Christian
; Yuan, Perry
Subject: Re: [PATCH] drm/amdgpu: Fix potential dma_fence leak in
amdgpu_ttm_clear_buffer
Hi Ma,
On 5/29/2025 6:37 PM, Li Ma w
Hi Ma,
On 5/29/2025 6:37 PM, Li Ma wrote:
The original code did not properly release the dma_fence `next` in case
amdgpu_ttm_fill_mem failed during buffer clearing.
Signed-off-by: Li Ma
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
di
On 5/28/2025 1:13 AM, Natalie Vock wrote:
Cleared blocks that are handed out to users after allocation cannot be
presumed to remain cleared. Thus, allocators using drm_buddy need to
dirty all blocks on the allocation success path. Provide a helper for
them to use.
Fixes: 96950929eb232 ("drm/bu
On 5/28/2025 2:59 PM, Natalie Vock wrote:
Hi,
On 5/28/25 09:07, Christian König wrote:
On 5/27/25 21:43, Natalie Vock wrote:
If we hand out cleared blocks to users, they are expected to write
at least some non-zero values somewhere. If we keep the CLEAR bit
set on
the block, amdgpu_fill_b
On 5/15/2025 9:19 PM, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 12:41 PM, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 12:39 PM, Christian König wrote:
On 5/11/25 22:37, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 2:03 AM, Paneer Selvam, Arunpravin wrote:
On 5/3/2025 5:53 PM
On 5/12/2025 12:41 PM, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 12:39 PM, Christian König wrote:
On 5/11/25 22:37, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 2:03 AM, Paneer Selvam, Arunpravin wrote:
On 5/3/2025 5:53 PM, Paneer Selvam, Arunpravin wrote:
On 5/2/2025 9:02 PM
On 5/9/2025 4:51 PM, Christian König wrote:
On 5/9/25 12:10, Jesse.Zhang wrote:
This patch resolves a kernel warning that occurs during user queue
initialization:
[ 428.714241] WARNING: CPU: 23 PID: 1965 at drivers/gpu/drm/ttm/ttm_bo.c:823
ttm_bo_validate+0x15c/0x1a0 [ttm]
[ 428.714758]
On 5/12/2025 12:39 PM, Christian König wrote:
On 5/11/25 22:37, Paneer Selvam, Arunpravin wrote:
On 5/12/2025 2:03 AM, Paneer Selvam, Arunpravin wrote:
On 5/3/2025 5:53 PM, Paneer Selvam, Arunpravin wrote:
On 5/2/2025 9:02 PM, John Olender wrote:
On 4/30/25 5:44 PM, Paneer Selvam
On 5/12/2025 2:03 AM, Paneer Selvam, Arunpravin wrote:
On 5/3/2025 5:53 PM, Paneer Selvam, Arunpravin wrote:
On 5/2/2025 9:02 PM, John Olender wrote:
On 4/30/25 5:44 PM, Paneer Selvam, Arunpravin wrote:
On 5/1/2025 2:50 AM, Alex Deucher wrote:
+ Christian
On Tue, Apr 29, 2025 at 7
On 5/3/2025 5:53 PM, Paneer Selvam, Arunpravin wrote:
On 5/2/2025 9:02 PM, John Olender wrote:
On 4/30/25 5:44 PM, Paneer Selvam, Arunpravin wrote:
On 5/1/2025 2:50 AM, Alex Deucher wrote:
+ Christian
On Tue, Apr 29, 2025 at 7:24 AM John Olender
wrote:
The drm_mm allocator tolerated
On 5/2/2025 9:02 PM, John Olender wrote:
On 4/30/25 5:44 PM, Paneer Selvam, Arunpravin wrote:
On 5/1/2025 2:50 AM, Alex Deucher wrote:
+ Christian
On Tue, Apr 29, 2025 at 7:24 AM John Olender
wrote:
The drm_mm allocator tolerated being passed end > mm->size, but the
drm_buddy all
On 5/1/2025 2:50 AM, Alex Deucher wrote:
+ Christian
On Tue, Apr 29, 2025 at 7:24 AM John Olender wrote:
The drm_mm allocator tolerated being passed end > mm->size, but the
drm_buddy allocator does not.
Restore the pre-buddy-allocator behavior of allowing such placements.
Closes: https://
destruction.
Otherwise, we would gather those references until we
don't have any more space left and crash.
Libdrm MR: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/408
Mesa MR: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34493
Signed-off-by: Arunpravin Paneer S
/mesa/-/merge_requests/34493
Signed-off-by: Arunpravin Paneer Selvam
Suggested-by: Christian König
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 20 +++
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.h | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 1 -
include/uap
Add lock before accessing dma_fence_is_signaled_locked.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/drivers/gpu/drm/amd/amdgpu
+0x17e/0x1d0
[ +0.06] softirqs last disabled at (749): []
__irq_exit_rcu+0x17e/0x1d0
[ +0.05] ---[ end trace ]---
Signed-off-by: Arunpravin Paneer Selvam
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 116 +++---
1 file changed, 69 insertions(
Fix DEBUG_LOCKS_WARN_ON(lock->magic != lock) warning logs.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
b/drivers/gpu/drm/amd/amd
+0x17e/0x1d0
[ +0.05] ---[ end trace ]---
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c
b/drivers/gpu/drm
&fence_drv->fence_list_lock);
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_us
Hi Alex,
I requested the tester to reproduce the suspend/resume hang issue with
this patch series.
I will update as soon as I get the results.
Thanks,
Arun.
On 3/20/2025 10:22 PM, Alex Deucher wrote:
So we can iterate across them when we need to manage
all user queues.
Signed-off-by: Alex D
Hi Alex,
This patch didn't help to resolve the system hang issue during suspend
that was introduced
by the series - https://patchwork.freedesktop.org/series/141717/
But as you mentioned, the runtime pm needs this change while user queues
are running.
Reviewed-by: Arunpravin Paneer S
The seq64 VM cache policy should be set to UC (Uncached) to
match with userqueue fence address kernel mapped memory's
cache settings.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --
Hi Jani,
I merged the below patch into drm-misc-next, Please try rebuilding the
drm-tip.
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=00728273bdf1001f8d2f7b65bc398000d7defe0b
Thanks,
Arun.
On 1/15/2025 5:08 PM, Jani Nikula wrote:
On Thu, 26 Dec 2024, Arunpravin Paneer Selvam
Hi Matthew,
Ping?
Regards,
Arun.
On 12/26/2024 12:31 PM, Arunpravin Paneer Selvam wrote:
- Added a testcase to verify the multiroot force merge fini.
- Added a new field in_use to track the mm freed status.
v2:(Matthew)
- Add kunit_fail_current_test() when WARN_ON is true.
Signed-off-by
] do_syscall_64+0x4d/0x120
[ +0.08] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ +0.07] RIP: 0033:0x7f7c3d31a94f
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd
From: Lin.Cao
If buddy manager have more than one roots and each root have sub-block
need to be free. When drm_buddy_fini called, the first loop of
force_merge will merge and free all of the sub block of first root,
which offset is 0x0 and size is biggest(more than have of the mm size).
In subseq
- Added a testcase to verify the multiroot force merge fini.
- Added a new field in_use to track the mm freed status.
v2:(Matthew)
- Add kunit_fail_current_test() when WARN_ON is true.
Signed-off-by: Arunpravin Paneer Selvam
Signed-off-by: Lin.Cao
---
drivers/gpu/drm/drm_buddy.c
51199] ? amdgpu_display_user_framebuffer_create+0x215/0x320 [amdgpu]
[ 7197.251329] ? drm_internal_framebuffer_create+0xb7/0x1a0
[ 7197.251332] ? srso_alias_return_thunk+0x5/0xfbef5
Signed-off-by: Arunpravin Paneer Selvam
Fixes: 4a5ad08f5377 ("drm/amdgpu: Add address alignment support to DCC buffers")
---
drivers/gpu
Hi Matthew,
On 12/16/2024 11:52 PM, Matthew Auld wrote:
On 16/12/2024 13:07, Arunpravin Paneer Selvam wrote:
- Added a testcase to verify the multiroot force merge fini.
- Added a new field in_use to track the mm freed status.
Signed-off-by: Arunpravin Paneer Selvam
Signed-off-by: Lin.Cao
On 12/20/2024 4:08 PM, Christian König wrote:
Hi Arun,
Am 20.12.24 um 11:34 schrieb Paneer Selvam, Arunpravin:
Hi Christian,
On 12/19/2024 4:11 PM, Christian König wrote:
Am 19.12.24 um 11:38 schrieb Arunpravin Paneer Selvam:
Fix out-of-bounds issue in userq fence create when
Hi Christian,
On 12/19/2024 4:11 PM, Christian König wrote:
Am 19.12.24 um 11:38 schrieb Arunpravin Paneer Selvam:
Fix out-of-bounds issue in userq fence create when
accessing the userq xa structure. Added a lock to
protect the race condition.
v2:(Christian)
- Acquire xa lock only for
2] RBP: 7f3a009ff8f0 R08: 0001 R09:
[ +0.01] R10: 0002 R11: 0246 R12: 561824bf39e0
[ +0.02] R13: c0406458 R14: 000c R15: 561824a25b60
[ +0.06]
Signed-off-by: Arunpravin Paneer Selvam
---
.../gp
Make the xa field names used in the userqueue and userfence
structure more understandable and add more clarity.
Signed-off-by: Arunpravin Paneer Selvam
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 31 ++-
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.h | 4 +--
drivers/gpu
] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ +0.07] RIP: 0033:0x7f7c3d31a94f
Signed-off-by: Arunpravin Paneer Selvam
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 43 +++
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.h | 3 +-
2 files changed, 17 insertions(+), 29 deletions
Hi Christian,
On 12/13/2024 6:29 PM, Christian König wrote:
Am 13.12.24 um 12:24 schrieb Paneer Selvam, Arunpravin:
Hi Christian,
On 12/13/2024 4:13 PM, Christian König wrote:
Am 12.12.24 um 15:25 schrieb Arunpravin Paneer Selvam:
Fix out-of-bounds issue in userq fence create when
- Added a testcase to verify the multiroot force merge fini.
- Added a new field in_use to track the mm freed status.
Signed-off-by: Arunpravin Paneer Selvam
Signed-off-by: Lin.Cao
---
drivers/gpu/drm/drm_buddy.c| 20 -
drivers/gpu/drm/tests/drm_buddy_test.c | 30
From: Lin.Cao
If buddy manager have more than one roots and each root have sub-block
need to be free. When drm_buddy_fini called, the first loop of
force_merge will merge and free all of the sub block of first root,
which offset is 0x0 and size is biggest(more than have of the mm size).
In subseq
Hi Christian,
On 12/13/2024 4:13 PM, Christian König wrote:
Am 12.12.24 um 15:25 schrieb Arunpravin Paneer Selvam:
Fix out-of-bounds issue in userq fence create when
accessing the userq xa structure. Added a lock to
protect the race condition.
BUG: KASAN: slab-out-of-bounds in
Apply sign extension to seq64 va address.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
] x64_sys_call+0x1205/0x20d0
[ +0.07] do_syscall_64+0x4d/0x120
[ +0.08] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ +0.07] RIP: 0033:0x7f7c3d31a94f
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 4 +++-
1 file changed, 3 insertions(+), 1
] x64_sys_call+0x1209/0x20d0
[ 366.492299] do_syscall_64+0x51/0x120
[ 366.492303] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ 366.492418] RIP: 0033:0x7f86f3b1a94f
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 1 +
1 file changed, 1 insertion(+)
diff
-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 877cb17a14e9..3a88f754a395 100644
--- a
: Arunpravin Paneer Selvam
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 122 +++---
1 file changed, 72 insertions(+), 50 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 49dc78c2f0d7..5c39681c9720
From: Christian König
Modify the MES process va end limit to max pfn.
Signed-off-by: Christian König
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 3 +--
drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c | 2 +-
drivers/gpu/drm/amd/amdgpu
Add mqd for userq compute queue for gfx11/gfx12
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c| 4
drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c| 4
drivers/gpu/drm/amd/include/v11_structs.h | 4 ++--
drivers/gpu/drm/amd/include/v12_structs.h | 4
Hi Christian,
Thank you.
Reviewed-by: Arunpravin Paneer Selvam
Regards,
Arun.
On 11/29/2024 8:38 PM, Christian König wrote:
When starting the mpv player, Radeon R9 users are observing
the below error in dmesg.
[drm:amdgpu_uvd_cs_pass2 [amdgpu]]
*ERROR* msg/fb buffer ff00f7c000-ff00f7e000 out
] x64_sys_call+0x1205/0x20d0
[ +0.07] do_syscall_64+0x4d/0x120
[ +0.08] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ +0.07] RIP: 0033:0x7f7c3d31a94f
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 4 +++-
1 file changed, 3 insertions(+), 1
] x64_sys_call+0x1209/0x20d0
[ 366.492299] do_syscall_64+0x51/0x120
[ 366.492303] entry_SYSCALL_64_after_hwframe+0x76/0x7e
[ 366.492418] RIP: 0033:0x7f86f3b1a94f
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 1 +
1 file changed, 1 insertion(+)
diff
Add mqd support for userq compute queue.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 13 ++---
drivers/gpu/drm/amd/include/v11_structs.h| 4 ++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
index 877cb17a14e9..3a88f754a395 100644
--- a
Hi Christian,
On 11/20/2024 4:04 PM, Christian König wrote:
Am 20.11.24 um 10:26 schrieb Arunpravin Paneer Selvam:
We are observing a NULL value in the non userq fences,
thus added a NULL pointer check just to avoid the
NULL pointer dereference crash.
v2: Moved the NULL check above the non
Hi Christian,
On 11/20/2024 4:06 PM, Christian König wrote:
Am 20.11.24 um 10:26 schrieb Arunpravin Paneer Selvam:
Fix the warning issue generated at lib/xarray.c:1849.
v2: keep the error handling same as before when the
xalloc() call fails to store the fence_drv ref.
Signed-off-by
We are observing a NULL value in the non userq fences,
thus added a NULL pointer check just to avoid the
NULL pointer dereference crash.
v2: Moved the NULL check above the non userq check.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 3 +++
1
Add mqd support for userq compute queue.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 13 ++---
drivers/gpu/drm/amd/include/v11_structs.h| 4 ++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
Fix the warning issue generated at lib/xarray.c:1849.
v2: keep the error handling same as before when the
xalloc() call fails to store the fence_drv ref.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 6 --
1 file changed, 4 insertions
We are observing a NULL value in the non userq fences,
thus added a NULL pointer check just to avoid the
NULL pointer dereference crash.
v2: Moved the NULL check above the non userq check.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 3 +++
1
Fix the Page fault and warning issue when xalloc fails to store
the fence_drv.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
Add mqd support for userq compute queue.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/mes_v11_0_userqueue.c | 13 ++---
drivers/gpu/drm/amd/include/v11_structs.h| 4 ++--
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm
On 11/14/2024 9:17 PM, Christian König wrote:
Am 14.11.24 um 16:38 schrieb Paneer Selvam, Arunpravin:
Hi Christian,
On 11/11/2024 3:33 PM, Christian König wrote:
Am 11.11.24 um 09:05 schrieb Arunpravin Paneer Selvam:
When starting the mpv player, Radeon R9 users are observing
the below
Hi Christian,
On 11/11/2024 3:33 PM, Christian König wrote:
Am 11.11.24 um 09:05 schrieb Arunpravin Paneer Selvam:
When starting the mpv player, Radeon R9 users are observing
the below error in dmesg.
[drm:amdgpu_uvd_cs_pass2 [amdgpu]]
*ERROR* msg/fb buffer ff00f7c000-ff00f7e000 out of
We are observing a NULL value in the non userq fences,
thus added a NULL pointer check just to avoid the
NULL pointer dereference crash.
v2: Moved the NULL check above the non userq check.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 3 +++
1
Reviewed-by: Arunpravin Paneer Selvam
On 11/13/2024 2:37 PM, Sunil Khatri wrote:
Add argument description for the input argument
gpu_addr for amdgpu_seq64_alloc.
Fixes the warning raised by the compiler:
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c:168:
warning: Function parameter or struct
struct member 'gpu_addr' not described in
'amdgpu_seq64_alloc
Cc: Arunpravin Paneer Selvam
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
b/drivers/gpu
We are observing a NULL value in the non userq fences,
thus added a NULL pointer check just to avoid the
NULL pointer dereference crash.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu
and not set cases.
Closes:https://gitlab.freedesktop.org/drm/amd/-/issues/3599
Closes:https://gitlab.freedesktop.org/drm/amd/-/issues/3501
Signed-off-by: Arunpravin Paneer Selvam
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 18 +++---
1 file changed, 11
and not set cases.
Closes:https://gitlab.freedesktop.org/drm/amd/-/issues/3599
Closes:https://gitlab.freedesktop.org/drm/amd/-/issues/3501
Signed-off-by: Arunpravin Paneer Selvam
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 18 +++---
1 file changed, 11
Modify kernel UAPI userq signal/wait struct field names and
description corresponding to the libdrm UAPI review comments.
libdrm MR: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/392
Signed-off-by: Arunpravin Paneer Selvam
---
.../gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 20
Keep the user queue fence signal and wait IOCTLs in the
kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ.
v2(Christian):
- Remove the userq specific config added for kernel queues fence init
function.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
On 10/29/2024 7:33 PM, Christian König wrote:
Am 29.10.24 um 14:32 schrieb Alex Deucher:
On Tue, Oct 29, 2024 at 5:38 AM Christian König
wrote:
Am 24.10.24 um 14:10 schrieb Arunpravin Paneer Selvam:
Keep the user queue fence signal and wait IOCTLs in the
kernel config
Keep the user queue fence signal and wait IOCTLs in the
kernel config CONFIG_DRM_AMDGPU_NAVI3X_USERQ.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 4
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 16
2 files changed, 20
Add gpu address support to seq64 alloc function.
v1:(Christian)
- Add the user of this new interface change to the same
patch.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 10 --
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.h | 3
um 15:26 schrieb Arunpravin Paneer Selvam:
Add gpu address support to seq64 alloc function.
Looks good to me, but when adding interfaces you should probably have
the user of this in the same patch set.
Regards,
Christian.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/a
Add gpu address support to seq64 alloc function.
Signed-off-by: Arunpravin Paneer Selvam
---
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 10 --
drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.h | 3 ++-
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu
1 - 100 of 600 matches
Mail list logo
