Re: [RFC PATCH v4 06/42] drm/vkms: Add kunit tests for VKMS LUT handling

2024-02-27 Thread Arthur Grillo
v3: > - Use include way of testing static functions (Arthur) > > Signed-off-by: Harry Wentland > Cc: Arthur Grillo > --- > drivers/gpu/drm/vkms/Kconfig | 5 + > drivers/gpu/drm/vkms/tests/.kunitconfig | 4 + > drivers/gpu/drm/vkms/tests/vkms_color_

Re: [PATCH -next 6/7] drm/format-helper: Remove unnecessary NULL values

2023-08-09 Thread Arthur Grillo
ff-by: Ruan Jinjie > --- > .../gpu/drm/tests/drm_format_helper_test.c| 28 +-- > 1 file changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Arthur Grillo Best Regards, ~Arthur Grillo > > diff --git a/drivers/gpu/drm/tests/drm_format_helper_test.c > b/drivers/gp

[PATCH v2 0/3] Resolve warnings from AMDGPU

2023-02-17 Thread Arthur Grillo
Hi, This series resolve some of the warnings that appear when compiling AMDGPU with W=1. Each patch is focused in a specific warning. This is my First Patch for the GSoC Project Idea about increasing code coverage of the DRM code[1]. Thanks for reviewing! Best regards, Arthur Grillo [1

[PATCH v2 3/3] drm/amd/display: Remove unused local variables and function

2023-02-17 Thread Arthur Grillo
Remove a couple of local variables that are only set but never used, also remove an static utility function that is never used in consequence of the variable removal. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- .../gpu/drm/amd/display/dc

[PATCH v2 2/3] drm/amd/display: Remove unused local variables

2023-02-17 Thread Arthur Grillo
Remove local variables that were just set but were never used. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 +-- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 7

[PATCH v2 1/3] drm/amd/display: Fix implicit enum conversion

2023-02-17 Thread Arthur Grillo
| locals->ODMCombineEnablePerState[i][k] = true; | ^ Signed-off-by: Arthur Grillo --- .../amd/display/dc/dml/dcn20/display_mode_vba_20.c | 9 + .../amd/display/dc/dml/dc

[PATCH 08/10] drm/amd/display: Remove unused local variables

2023-02-13 Thread Arthur Grillo
Remove local variables that were just set but were never used. This decrease the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.c | 3 --- drivers/gpu/drm/amd/display/dc/dcn201/dcn201_dpp.c | 7

[PATCH 07/10] drm/amd/amdgpu: Deal with possible fail allocation

2023-02-13 Thread Arthur Grillo
Deal with return value of an allocation. This reduces the number of -Wunused-but-set-variable warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd

[PATCH 06/10] drm/amd/display: Fix implicit enum conversion

2023-02-13 Thread Arthur Grillo
| locals->ODMCombineEnablePerState[i][k] = true; | ^ Signed-off-by: Arthur Grillo --- .../amd/display/dc/dml/dcn20/display_mode_vba_20.c | 9 + .../amd/display/dc/dml/dc

[PATCH 05/10] drm/amd/display: Fix excess arguments on kernel-doc

2023-02-13 Thread Arthur Grillo
Remove arguments present on kernel-doc that are not present on the function declaration and add the new ones if present. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c| 15 +++ drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c | 2 +- .../gpu

[PATCH 04/10] drm/amd/display: Add previously missing includes

2023-02-13 Thread Arthur Grillo
Add includes that were previously missing to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn32/dcn32_init.c | 1 + drivers/gpu/drm/amd/display/dc/link/accessories/link_dp_trace.c | 1 + 2 files changed, 2

[PATCH 03/10] drm/amd/amdgpu: Add function prototypes to headers

2023-02-13 Thread Arthur Grillo
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h b/drivers/gpu/drm/amd/amdgpu

[PATCH 02/10] drm/amd/display: Add function prototypes to headers

2023-02-13 Thread Arthur Grillo
Add function prototypes to headers to reduce the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/dcn31/dcn31_hubbub.h | 2 ++ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubbub.h | 2 ++ drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hubp.h

[PATCH 01/10] drm/amd/display: Turn global functions into static

2023-02-13 Thread Arthur Grillo
Turn global functions that are only used locally into static ones. This reduces the number of -Wmissing-prototypes warnings. Signed-off-by: Arthur Grillo --- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/irq/dcn201/irq_service_dcn201.c | 2

[PATCH 00/10] Resolve warnings from AMDGPU

2023-02-13 Thread Arthur Grillo
Hi, This series resolve some of the warnings that appear when compiling AMDGPU with W=1. Each patch is focused in a specific warning. This is my First Patch for the GSoC Project Idea about increasing code coverage of the DRM code[1]. Thanks for reviewing! Best regards, Arthur Grillo [1