[PATCH v4] drm/amd/amdgpu: Add GPIO resources required for amdisp

ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor driver to enable and disable sensor module. - GPIO 85 to allow ISP driver to enable and disable ISP RGB str

Re: [PATCH v3] drm/amd/amdgpu: Add GPIO resources required for amdisp

On 5/16/2025 5:38 PM, Mario Limonciello wrote: On 5/16/2025 4:31 PM, Pratap Nirujogi wrote: ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor driver to en

Re: [PATCH v3] drm/amd/amdgpu: Add GPIO resources required for amdisp

On 5/16/2025 4:31 PM, Pratap Nirujogi wrote: ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor driver to enable and disable sensor module. - GPIO 85 to all

[PATCH v3] drm/amd/amdgpu: Add GPIO resources required for amdisp

ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor driver to enable and disable sensor module. - GPIO 85 to allow ISP driver to enable and disable ISP RGB str

Re: [PATCH v2] drm/amd/amdgpu: Add GPIO resources required for amdisp

Hi Mario, On 5/16/2025 3:42 PM, Mario Limonciello wrote: On 5/15/2025 5:16 PM, Pratap Nirujogi wrote: ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor d

[PATCH] drm/amd/display: Add module param to limit max_bpc

Some users are reporting issues with displays not lighting up after we made 16 bpc the default maximum for outputs. It's difficult to debug these issues when we can't repro them, but it'd be good to give people the ability to help themselves. Introduce a new amdgpu.max_bpc module param that can be

[pull] amdgpu, amdkfd, radeon drm-next-6.16

Hi Dave, Simona, Last few updates for 6.16. The following changes since commit 1faeeb315fdbd005bbc1bc74214e39087971dda9: Merge tag 'amd-drm-next-6.16-2025-05-09' of https://gitlab.freedesktop.org/agd5f/linux into drm-next (2025-05-12 07:14:34 +1000) are available in the Git repository at:

Re: [PATCH v2 9/9] drm/amdgpu: read back register after written

hahaha! ok - I can drop this one (as no need but rather make it clear that any register read should do) I kind of disagree about guarantee  - as long as the theory(read post write on PCIe will allow writes hit hardware) hold it is guaranteed. Why I ask for testing is to prove it works as expecte

Re: [PATCH v2 1/3] PM: Use hibernate flows for system power off

On Fri, May 16, 2025 at 9:33 PM Mario Limonciello wrote: > > On 5/16/2025 9:58 AM, Rafael J. Wysocki wrote: > > On Wed, May 14, 2025 at 9:34 PM Mario Limonciello > > wrote: > >> > >> From: Mario Limonciello > >> > >> When the system is powered off the kernel will call device_shutdown() > >> whi

Re: [PATCH v2] drm/amd/amdgpu: Add GPIO resources required for amdisp

On 5/15/2025 5:16 PM, Pratap Nirujogi wrote: ISP is a child device to GFX, and its device specific information is not available in ACPI. Adding the 2 GPIO resources required for ISP_v4_1_1 in amdgpu_isp driver. - GPIO 0 to allow sensor driver to enable and disable sensor module. - GPIO 85 to all

Re: [PATCH v2 1/3] PM: Use hibernate flows for system power off

On 5/16/2025 9:58 AM, Rafael J. Wysocki wrote: On Wed, May 14, 2025 at 9:34 PM Mario Limonciello wrote: From: Mario Limonciello When the system is powered off the kernel will call device_shutdown() which will issue callbacks into PCI core to wake up a device and call it's shutdown() callback

Re: [PATCH v3] drm/amdkfd: Change svm_range_get_info return type

On 2025-04-02 10:12, Ваторопин Андрей wrote: > From: Andrey Vatoropin > > Static analysis shows that pointer "svms" cannot be NULL because it points > to the object "struct svm_range_list". Remove the extra NULL check. It is > meaningless and harms the readability of the code. > > In the function

Re: [PATCH v2 9/9] drm/amdgpu: read back register after written

Well testing only falsifies things. I agree that it should server the same purpose, but we don't have a guarantee for that and as far as I can see there is not need to switch to a different register. So this change seems superfluous if not dangerous to me. Regards, Christian. On 5/16/25 18:23

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

On Thu, May 15, 2025 at 9:23 PM Leonardo Gomes wrote: > > Thanks for your reply Alex, > > I just realize with your comment that > drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c import dal_hw_gpio_get_value > and dal_hw_gpio_set_value. > So to make those functions inside > drivers/gpu/drm/amd/dis

Re: [PATCH v2 9/9] drm/amdgpu: read back register after written

Hi Christian, For this change on VCN5.0.1 I will leave it to Sonny for a test. Since the readback is for each VCN instance it should work for that clock domain. As Alex has pointed out that readback post all writes will let the writes hit hardware, using UVD_STATUS instead of VCN_RB1_DB_CTRL s

Re: Kernels >= 6.3 disable video output

On 2025-05-15 19:59, Harry Wentland wrote: > Hi Steven, > > thanks for the bisect. > > In order to avoid display artifacts (especially for HDR) we had to > allow higher bit depth color output on the wire. The driver should > fallback to a lower resolution as needed but looks like there's a > bug

Re: [PATCH 3/3] drm/amdkfd: destroy_pdds release pdd->drm_file at end

On 5/16/2025 8:07 AM, Philip Yang wrote: On 2025-05-15 17:31, Chen, Xiaogang wrote: On 5/15/2025 3:45 PM, Philip Yang wrote: On 2025-05-15 10:29, Chen, Xiaogang wrote: Does this patch fix a bug or just make code look more reasonable? kfd_process_destroy_pdds releases pdd related buffers

Re: [PATCH v2 1/3] PM: Use hibernate flows for system power off

On Wed, May 14, 2025 at 9:34 PM Mario Limonciello wrote: > > From: Mario Limonciello > > When the system is powered off the kernel will call device_shutdown() > which will issue callbacks into PCI core to wake up a device and call > it's shutdown() callback. This will leave devices in ACPI D0 wh

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

On 16/05/2025 14:38, Philipp Stanner wrote: On Fri, 2025-05-16 at 13:10 +0100, Tvrtko Ursulin wrote: On 16/05/2025 12:53, Tvrtko Ursulin wrote: On 16/05/2025 08:28, Philipp Stanner wrote: On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: On 15/05/2025 16:00, Christian König wrote:

Re: [PATCH 3/3] drm/amdkfd: destroy_pdds release pdd->drm_file at end

On 2025-05-15 17:31, Chen, Xiaogang wrote: On 5/15/2025 3:45 PM, Philip Yang wrote: On 2025-05-15 10:29, Chen, Xiaogang wrote: Does this patch fix a bug or just make code look more reasonable? kfd_process_destroy_pdds releases pdd related buffers, not related to operations on vm. So vm t

Re: [PATCH] drm/scheduler: signal scheduled fence when kill job

On Fri, 2025-05-16 at 02:21 +, cao, lin wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > > Hi Philipp, > > > I updated the commit message to better clarify the issue. Would you > mind reviewing if this revised description adequately explains the > bug and the rati

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

D] drm/amd/display: Adjust get_value function with prefix to help in ftrace config: sparc-allmodconfig (https://download.01.org/0day-ci/archive/20250516/202505162041.ftj48e6x-...@intel.com/config) compiler: sparc64-linux-gcc (GCC) 14.2.0 reproduce (this is a W=1 build): (https://download.01.o

linux-6.15-rc6/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c: possible cut'n'paste error ?

Hello there, Static analyser cppcheck says: linux-6.15-rc6/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c:595:45: style: Variable 'p->out_states->state_array[i].dtbclk_mhz' is reassigned a value before the old one has been used. [redundantAssignment] linux-6.15-rc6/drivers/gpu/dr

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: > > On 15/05/2025 16:00, Christian König wrote: > > Sometimes drivers need to be able to submit multiple jobs which > > depend on > > each other to different schedulers at the same time, but using > > drm_sched_job_add_dependency() can't fai

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

On 16/05/2025 12:53, Tvrtko Ursulin wrote: On 16/05/2025 08:28, Philipp Stanner wrote: On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: On 15/05/2025 16:00, Christian König wrote: Sometimes drivers need to be able to submit multiple jobs which depend on each other to different sche

Re: [PATCH 1/3] drm/sched: add drm_sched_prealloc_dependency_slots v3

On 16/05/2025 08:28, Philipp Stanner wrote: On Thu, 2025-05-15 at 17:17 +0100, Tvrtko Ursulin wrote: On 15/05/2025 16:00, Christian König wrote: Sometimes drivers need to be able to submit multiple jobs which depend on each other to different schedulers at the same time, but using drm_sched_

Re: [PATCH v5 4/4] drm/amdgpu: fix fence fallback timer expired error

On 5/12/2025 12:11 PM, Samuel Zhang wrote: > IH is not working after switching a new gpu index for the first time. > > The msix table in virtual machine is faked. The real msix table will be > programmed by QEMU when guest enable/disable msix interrupt. But QEMU > accessing VF msix table (regis

RE: [PATCH 1/4] drm/amd/pm: Add support to query partition metrics

[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Friday, May 16, 2025 17:19 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Kamal, Asad ; Kamal, Asad

Re: [PATCH v5 2/4] drm/amdgpu: update GPU addresses for SMU and PSP

On 5/12/2025 12:11 PM, Samuel Zhang wrote: > add amdgpu_bo_fb_aper_addr() and update the cached GPU addresses to use > the FB aperture address for SMU and PSP. > > 2 reasons for this change: > 1. when pdb0 is enabled, gpu addr from amdgpu_bo_create_kernel() is GART > aperture address, it is not

[PATCH 4/4] drm/amd/pm: Fetch partition metrics on SMUv13.0.12

Add support to fetch compute partition related metrics in SMUv13.0.12 SOCs. Signed-off-by: Lijo Lazar Reviewed-by: Asad Kamal --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 56 +++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 9 +++ .../drm/amd/pm/swsmu/smu13/smu_v13_0_

[PATCH 2/4] drm/amdgpu: Add sysfs nodes for partition

Add sysfs nodes to provide compute paritition specific data. Signed-off-by: Lijo Lazar Reviewed-by: Asad Kamal --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 +- drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.c| 144 - drivers/gpu/drm/amd/amdgpu/amdgpu_xcp.h| 6 +- 3

[PATCH 3/4] drm/amd/pm: Fetch partition metrics on SMUv13.0.6

Add support to fetch compute partition related metrics in SMUv13.0.6 SOCs. Signed-off-by: Lijo Lazar Reviewed-by: Asad Kamal --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6

[PATCH 1/4] drm/amd/pm: Add support to query partition metrics

Add interfaces to query compute partition related metrics data. Signed-off-by: Lijo Lazar Reviewed-by: Asad Kamal --- .../gpu/drm/amd/include/kgd_pp_interface.h| 24 ++ drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 32 +++ drivers/gpu/drm/amd/pm/inc/amdgpu_dpm.

Re: Kernels >= 6.3 disable video output

On Mon, May 12 2025 at 08:10:40 PM +, Alex Deucher wrote: See: https://docs.kernel.org/admin-guide/bug-bisect.html ... identify the exact commit which broke caused your issue. One heck of a journey! But tested the solution on the first broken kernel 6.3. Too chicken to force revert attemp

Re: [PATCH V9 26/43] drm/amd/display: Add support for sRGB EOTF in DEGAM block

On Tue, 13 May 2025 16:39:51 -0400 Harry Wentland wrote: > On 2025-05-13 11:36, Melissa Wen wrote: > > On 05/13, Pekka Paalanen wrote: > >> On Mon, 12 May 2025 15:50:17 -0300 > >> Melissa Wen wrote: > >> > >>> On 04/29, Alex Hung wrote: > Expose one 1D curve colorop with support for >

Re: [PATCH 1/2 RESEND] drm/amd/display: Adjust get_value function with prefix to help in ftrace

Thanks for your reply Alex, I just realize with your comment that *drivers/gpu/drm/amd/display/dc/gpio/hw_gpio.c* import *dal_hw_gpio_get_value *and *dal_hw_gpio_set_value*. So to make those functions inside *drivers/gpu/drm/amd/display/dc/gpio/hw_hpd.c* more clear what do you think to change the

[PATCH] drm: radeon: ci_dpm: Add error handling for ci_send_msg_to_smc_with_parameter()

The ci_enable_uvd_dpm() calls ci_send_msg_to_smc_with_parameter() but does not check the return value. This could lead to the execution with potentially invalid data. A proper implementation can be found in the ci_fan_ctrl_start_smc_fan_control(). Add a check after calling ci_send_msg_to_smc_with_

Re: [PATCH V9 00/43] Color Pipeline API w/ VKMS

On 5/15/25 15:39, Daniel Stone wrote: > Hi, > > On Thu, 15 May 2025 at 19:02, Harry Wentland wrote: >> On 2025-05-15 13:19, Daniel Stone wrote: >>> Yeah, the Weston patches are marching on. We've still been doing a >>> little bit of cleanup and prep work in the background to land them, >>> but

Re: [PATCH v3 2/3] drm/doc: Add a section about "App information" for the wedge API

On Mon, May 12, 2025 at 05:34:36PM -0300, André Almeida wrote: > Add a section about "App information" for the wedge API. > > Signed-off-by: André Almeida > --- > v3: > - Change "app that caused ..." to "app involved ..." > - Clarify that devcoredump have more information about what happened >

Re: Kernels >= 6.3 disable video output

On Thu, May 15 2025 at 05:59:55 PM +, Harry Wentland wrote: Are you able to share the specific TV model? From TV itself: Sansui S55VAUG. From System info within tv menu: Settings: Device Name: GoogleTV8931 Model: Apollo Premium 4KTV from cat /sys/class/drm/card0/card0-HDMI-A-1/edid: bina

Re: [PATCH v3 2/3] drm/doc: Add a section about "App information" for the wedge API

Hi André, On 2025-05-12 at 17:34:36 -0300, André Almeida wrote: > Add a section about "App information" for the wedge API. > > Signed-off-by: André Almeida > --- > v3: > - Change "app that caused ..." to "app involved ..." > - Clarify that devcoredump have more information about what happened

Re: [PATCH v3 1/3] drm: Create an app info option for wedge events

Hi André, > When a device get wedged, it might be caused by a guilty application. > For userspace, knowing which app was the cause can be useful for some > situations, like for implementing a policy, logs or for giving a chance > for the compositor to let the user know what app caused the problem.

Re: [PATCH v2 1/9] drm/amdgpu: read back register after written

On 5/15/25 18:40, David (Ming Qiang) Wu wrote: > V2: use common register UVD_STATUS for readback (standard PCI MMIO > behavior, i.e. readback post all writes to let the writes hit > the hardware) > add read-back in ..._stop() for more coverage. > > Similar to the changes made for VCN v

Re: [PATCH v2 9/9] drm/amdgpu: read back register after written

On 5/15/25 18:41, David (Ming Qiang) Wu wrote: > The addition of register read-back in VCN v5.0.1 is intended to prevent > potential race conditions. > > Signed-off-by: David (Ming Qiang) Wu > --- > drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c | 22 -- > 1 file changed, 20 inserti

Re: [PATCH 2/3] drm/sched: Add a test for prealloced fence slots

On 5/15/2025 8:30 PM, Christian König wrote: Just to exercise the functionality. Signed-off-by: Christian König --- drivers/gpu/drm/scheduler/tests/tests_basic.c | 59 ++- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/scheduler/tests/tests_ba

Re: [PATCH v5 0/4] enable xgmi node migration support for hibernate on SRIOV.

[AMD Official Use Only - AMD Internal Distribution Only] Hi @Koenig, Christian and @Lazar, Lijo, Ping… Thanks Sam From: Zhang, Owen(SRDC) Date: Wednesday, May 14, 2025 at 18:07 To: Koenig, Christian , Zhang, GuoQing (Sam) , amd-gfx@