[PATCH v2 ratelimit 05/14] drm/amd/pm: Avoid open-coded use of ratelimit_state structure's internals

2025-04-18 Thread Paul E. McKenney
The amdgpu_set_thermal_throttling_logging() function directly accesses the ratelimit_state structure's ->missed field, which work, but which also makes it more difficult to change this field. Therefore, make use of the ratelimit_state_reset_miss() function instead of directly accessing the ->misse

[PATCH v3 5/7] drm/amd/pm: Fill static metrics data

2025-04-18 Thread Asad Kamal
Fill static metrics data for smu_v13_0_6 v2: Proceed with driver load just with warning even if board voltage reads invalid value v3: Use multiplier to convert volt to millivolt as new fw reports voltage in volt Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsm

Re: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-18 Thread Jani Nikula
On Thu, 17 Apr 2025, Christian König wrote: > Am 17.04.25 um 11:35 schrieb Jani Nikula: >> On Thu, 17 Apr 2025, Sunil Khatri wrote: >>> Add a drm helper macro which append the process information for >>> the drm_file over drm_err. >>> >>> v5: change to macro from function (Christian Koenig) >>>

Re: [PATCH 02/13] drm/amd/display: use drm_edid_product_id for parsing EDID product info

2025-04-18 Thread Michel Dänzer
On 2025-04-17 15:27, Melissa Wen wrote: > On 15/04/2025 06:32, Michel Dänzer wrote: >> On 2025-04-11 22:08, Melissa Wen wrote: >>> Since [1], we can use drm_edid_product_id to get debug info from >>> drm_edid instead of directly parsing EDID. >>> >>> Link: >>> https://lore.kernel.org/dri-devel/cov

Re: [PATCH] drm/amd/display: do not copy invalid CRTC timing info

2025-04-18 Thread Alex Hung
No issues from promotion tests. Reviewed-by: Alex Hung On 4/8/25 10:55, Alex Hung wrote: Hi Gergo, Thanks for the patch. I am sending this patch for testing and I will update test result next week. On 4/2/25 11:03, Gergo Koteles wrote: Since b255ce4388e0, it is possible that the CRTC tim

Re: [PATCH v6 1/5] drm: add macro drm_file_err to print process info

2025-04-18 Thread Christian König
Am 17.04.25 um 13:07 schrieb Jani Nikula: > On Thu, 17 Apr 2025, Christian König wrote: >> Am 17.04.25 um 11:35 schrieb Jani Nikula: >>> On Thu, 17 Apr 2025, Sunil Khatri wrote: Add a drm helper macro which append the process information for the drm_file over drm_err. v5: chan

[PATCH V8 2/5] drm/amdgpu: add drm_file reference in userq_mgr

2025-04-18 Thread Sunil Khatri
drm_file will be used in usermode queues code to enable better process information in logging and hence add drm_file part of the userq_mgr struct. update the drm_file pointer in userq_mgr for each amdgpu_driver_open_kms. Signed-off-by: Sunil Khatri Reviewed-by: Tvrtko Ursulin --- drivers/gpu/d

RE: [PATCH 7/7] drm/amdgpu/userq: use consistent function naming

2025-04-18 Thread Liang, Prike
[Public] Reviewed-by: Prike Liang Regards, Prike > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 7/7] drm/amdgpu/userq: use consistent functio

Re: [PATCH v2] drm/amd/pm/powerplay/smumgr/fiji_smumgr: Add error check in fiji_populate_smc_boot_level()

2025-04-18 Thread Alex Deucher
On Tue, Apr 15, 2025 at 6:23 AM Wentao Liang wrote: > > The return value of fiji_populate_smc_boot_level() is needs to be checked. > An error handling is also needed to phm_find_boot_level() to reset the > boot level when the function fails. A proper implementation can be found > in tonga_populate

Re: [PATCH 3/4] drm/amdgpu: trace the scheduler dependent job fence name

2025-04-18 Thread Christian König
Am 16.04.25 um 16:16 schrieb Liang, Prike: > [Public] > >> From: Koenig, Christian >> Sent: Wednesday, April 16, 2025 7:04 PM >> To: Liang, Prike ; amd-gfx@lists.freedesktop.org >> Cc: Deucher, Alexander >> Subject: Re: [PATCH 3/4] drm/amdgpu: trace the scheduler dependent job fence >> name >> >>

RE: [PATCH 6/7] drm/amdgpu/userq: rename eviction helpers

2025-04-18 Thread Liang, Prike
[Public] > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 6/7] drm/amdgpu/userq: rename eviction helpers > > suspend/resume -> evict/restore > > Rename

RE: [PATCH 2/7] drm/amdgpu/userq: optimize enforce isolation and s/r

2025-04-18 Thread Liang, Prike
[Public] Reviewed-by: Prike Liang Regards, Prike > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 2/7] drm/amdgpu/userq: optimize enforce isola

[PATCH v3 6/7] drm/amd/pm: Add voltage caps for smu_v13_0_6

2025-04-18 Thread Asad Kamal
Add & enable board voltage caps for smu_v13_0_6 v3: Update version check for board voltage support Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.h | 1 + 2 files changed, 4

[PATCH v3 1/7] drm/amd/pm: Add ip version check for smu_v13_0_12 functions

2025-04-18 Thread Asad Kamal
Add ip version check to use smu_v13_0_12 specific functions Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.

RE: [PATCH 5/7] drm/amdgpu/userq: move waiting for last fence before umap

2025-04-18 Thread Liang, Prike
[Public] > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 5/7] drm/amdgpu/userq: move waiting for last fence before umap > > Need to wait for the last fence before unmapping. This

[PATCH v3 2/7] drm/amd/pm: Update pmfw headers for smu_v_13_0_6

2025-04-18 Thread Asad Kamal
Update pmfw headers for smu_v_13_0_6 to include static metrics table v3: Update header as per new fw to report voltage in volt Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_pmfw.h| 7 +++ .../gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_

[PATCH v3 4/7] drm/amd/pm: Use common function to fetch static metrics table

2025-04-18 Thread Asad Kamal
Use common function to fetch static metrics table for smu_v13_0_12 Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_12_ppt.c | 22 +-- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 2 +- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.h |

[PATCH v3 3/7] drm/amd/pn: Fetch static metrics table

2025-04-18 Thread Asad Kamal
Fetch static metrics table for smu_v13_0_6 v2: Add static metrics caps check to fetch static metrics table v3: Update version having all fixes for static metrics support Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 28 ++

[PATCH v3 7/7] drm/amd/pm: Add board voltage node to hwmon

2025-04-18 Thread Asad Kamal
Add and expose board voltage node as vddboard to hwmon for smu_v13_0_6 v2: Replace ip check with supported sensor attribute(Lijo) Signed-off-by: Asad Kamal Reviewed-by: Lijo Lazar --- .../gpu/drm/amd/include/kgd_pp_interface.h| 1 + drivers/gpu/drm/amd/pm/amdgpu_pm.c| 34 +

[PATCH v2] drm/amdgpu: check a user-provided number of BOs in list

2025-04-18 Thread Denis Arefev
The user can set any value to the variable ‘bo_number’, via the ioctl command DRM_IOCTL_AMDGPU_BO_LIST. This will affect the arithmetic expression ‘in->bo_number * in->bo_info_size’, which is prone to overflow. Add a valid value check. Found by Linux Verification Center (linuxtesting.org) with SVA

RE: [PATCH 4/7] drm/amdgpu/userq: unmap queues amdgpu_userq_mgr_fini()

2025-04-18 Thread Liang, Prike
[Public] Reviewed-by: Prike Liang Regards, Prike > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 4/7] drm/amdgpu/userq: unmap queues > amdgpu_

RE: [PATCH 3/7] drm/amdgpu: switch from queue_active to queue state

2025-04-18 Thread Liang, Prike
[Public] > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 3/7] drm/amdgpu: switch from queue_active to queue state > > Track the state of the queue rath

[PATCH] drm/amdgpu: don't remap HDP registers if page size is > 4K

2025-04-18 Thread Alex Deucher
We remap the HDP registers to an open part of the MMIO aperture if page size is <= 4K, but if it's > 4k, we remap the HDP registers back to themselves. Rather than doing that, just skip the remap. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/nv.c| 3 ++- drivers/gpu/drm/amd/am

Re: [PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-18 Thread Alex Deucher
Applied patches 1, 3, 4. Thanks! On Thu, Apr 17, 2025 at 8:28 PM wrote: > > From: "Dr. David Alan Gilbert" > > rn_vbios_smu_set_dprefclk() was added in 2019 by > commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") > rv1_vbios_smu_set_dprefclk() was also added in 2019 by > commit d

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread Alex Deucher
On Fri, Apr 18, 2025 at 2:18 AM Christophe JAILLET wrote: > > Le 18/04/2025 à 02:21, li...@treblig.org a écrit : > > From: "Dr. David Alan Gilbert" > > > > radeon_doorbell_free() was added in 2013 by > > commit 75efdee11b5d ("drm/radeon: implement simple doorbell page > > allocator") > > but neve

RE: [PATCH 1/7] drm/amdgpu/userq: add a helper to check which IPs are enabled

2025-04-18 Thread Liang, Prike
[Public] Reviewed-by: Prike Liang Regards, Prike > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Thursday, April 17, 2025 6:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH 1/7] drm/amdgpu/userq: add a helper to check

[PATCH 4/4] drm/amd/display: Remove unused *vbios_smu_set_dprefclk

2025-04-18 Thread linux
From: "Dr. David Alan Gilbert" rn_vbios_smu_set_dprefclk() was added in 2019 by commit 4edb6fc91878 ("drm/amd/display: Add Renoir clock manager") rv1_vbios_smu_set_dprefclk() was also added in 2019 by commit dc88b4a684d2 ("drm/amd/display: make clk mgr soc specific") neither have been used. Rem

RE: [PATCH] drm/amdgpu: Print kernel message when error logged by scrub

2025-04-18 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Liu, Xiang(Dean) Sent: Friday, April 18, 2025 17:01 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Liu, Xiang(Dean) Subject: [PATCH] drm/amdgpu: Print k

[PATCH] drm/amdgpu: Print kernel message when error logged by scrub

2025-04-18 Thread Xiang Liu
Print a kernel message when the scrub bit of status register is set to indicate that errors are being logged by the scrub. Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/driver

RE: [PATCH] drm/amdgpu: Print kernel message when error logged by scrub

2025-04-18 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] It's okay to only check scrub bit so the check includes all the scenarios rather than solely for poison creation. Please also update the kernel message to "hardware error logged by the scrubber" Regards, Hawking -Original Message

[PATCH 1/4] drm/radeon/radeon_audio: Remove unused r600_hdmi_audio_workaround

2025-04-18 Thread linux
From: "Dr. David Alan Gilbert" The last use of r600_hdmi_audio_workaround() was removed by 2014's commit 6e72376dcc66 ("radeon/audio: consolidate audio_mode_set() functions") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/r600_hdmi.c | 22 --

[PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread linux
From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/radeon.h| 1 - drivers/gpu/drm/radeon/ra

[PATCH 3/4] drm/radeon: Remove unused radeon_fence_wait_any

2025-04-18 Thread linux
From: "Dr. David Alan Gilbert" radeon_fence_wait_any() last use was removed in 2023's commit 254986e324ad ("drm/radeon: Use the drm suballocation manager implementation.") Remove it. Signed-off-by: Dr. David Alan Gilbert --- drivers/gpu/drm/radeon/radeon.h | 3 -- drivers/gpu/drm/radeo

Re: [PATCH 2/4] drm/radeon: Remove unused radeon_doorbell_free

2025-04-18 Thread Christophe JAILLET
Le 18/04/2025 à 02:21, li...@treblig.org a écrit : From: "Dr. David Alan Gilbert" radeon_doorbell_free() was added in 2013 by commit 75efdee11b5d ("drm/radeon: implement simple doorbell page allocator") but never used. Hi, I think than instead of being removed, it should be used in the error

[PATCH 0/4] drm/amd & radeon deadcoding

2025-04-18 Thread linux
From: "Dr. David Alan Gilbert" Hi, Another set of deadcoding around amd/radeon GPU stuff. Dave Signed-off-by: Dr. David Alan Gilbert Dr. David Alan Gilbert (4): drm/radeon/radeon_audio: Remove unused r600_hdmi_audio_workaround drm/radeon: Remove unused radeon_doorbell_free drm/radeon:

回复: 回复: [REGRESSION] amdgpu: async system error exception from hdp_v5_0_flush_hdp()

2025-04-18 Thread Fugang Duan
发件人: Alex Deucher 发送时间: 2025年4月17日 21:08 >On Wed, Apr 16, 2025 at 8:43 PM Fugang Duan wrote: >> >> 发件人: Alex Deucher 发送时间: 2025年4月16日 >22:49 >> >收件人: Alexey Klimov On Wed, Apr 16, 2025 at >> >9:48 AM Alexey Klimov wrote: >> >> >> >> On Wed Apr 16, 2025 at 4:12 AM BST, Fugang Duan wrote: >> >>

Re: [PATCH 1/2] drm/ttm: fix the warning for hit_low and evict_low

2025-04-18 Thread Khatri, Sunil
On 4/17/2025 5:01 PM, Tvrtko Ursulin wrote: On 17/04/2025 10:34, Sunil Khatri wrote: fix the below warning messages: ttm/ttm_bo.c:1098: warning: Function parameter or struct member 'hit_low' not described in 'ttm_bo_swapout_walk' ttm/ttm_bo.c:1098: warning: Function parameter or struct membe

[PATCH] drm/amdgpu: Print kernel message when error logged by scrub

2025-04-18 Thread Xiang Liu
Print a kernel message when the scrub bit of status register is set to indicate that errors are being logged by the scrub. Signed-off-by: Xiang Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drive