Re: [PATCH v1 1/3] drm: function to get process name and pid

2025-04-13 Thread Khatri, Sunil
Ping? On 4/11/2025 6:34 PM, Sunil Khatri wrote: Add helper function which get the process information for the drm_file and updates the user provided character buffer with the information of process name and pid as a string. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/drm_file.c | 30

Re: [PATCH] drm/amdgpu: fix no_user_submission check for SDMA

2025-04-13 Thread Sun, Ce(Overlord)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Ce Sun From: amd-gfx on behalf of Khatri, Sunil Sent: Saturday, April 12, 2025 12:33 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: fix no_user_

Re: [PATCH 10/10] drm/amdgpu/userq: integrate with enforce isolation

2025-04-13 Thread Khatri, Sunil
Acked-by: Sunil Khatri On 4/12/2025 12:18 AM, Alex Deucher wrote: Enforce isolation serializes access to the GFX IP. User queues are isolated in the MES scheduler, but we still need to serialize between kernel queues and user queues. For enforce isolation, group KGD user queues with KFD user q

[PATCH v2 1/2] drm/amdgpu: Clear overflow for SRIOV

2025-04-13 Thread Emily Deng
For VF, it doesn't have the permission to clear overflow, clear the bit by reset. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 15 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 1 + drivers/gpu/drm/amd/amdgpu/ih_v6_0.c | 6 +- drivers/gpu/drm/amd/amdg

Re: [PATCH V2 09/10] drm/amdgpu/userq: add helpers to start/stop scheduling

2025-04-13 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri On 4/12/2025 12:18 AM, Alex Deucher wrote: This will be used to stop/start user queue scheduling for example when switching between kernel and user queues when enforce isolation is enabled. v2: use idx Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH 08/10] drm/amdgpu/userq: track the xcp_id associated with the queue

2025-04-13 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri On 4/12/2025 12:18 AM, Alex Deucher wrote: Track this to align with KFD for enforce isolation handling. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH v2 2/2] drm/amdgpu: Clean up error handling in amdgpu_userq_fence_driver_alloc()

2025-04-13 Thread Yadav, Arvind
Reviewed-by:Arvind Yadav On 4/12/2025 8:09 PM, Dan Carpenter wrote: 1) Checkpatch complains if we print an error message for kzalloc() failure. The kzalloc() failure already has it's own error messages built in. Also this allocation is small enough that it is guaranteed to succeed

Re: [PATCH v2 1/2] drm/amdgpu: Fix double free in amdgpu_userq_fence_driver_alloc()

2025-04-13 Thread Yadav, Arvind
Reviewed-by:Reviewed-by:Arvind Yadav On 4/12/2025 8:09 PM, Dan Carpenter wrote: The goto frees "fence_drv" so this is a double free bug. There is no need to call amdgpu_seq64_free(adev, fence_drv->va) since the seq64 allocation failed so change the goto to goto free_fence_drv. Also propagate

RE: [PATCH] drm/amdgpu: Clear overflow for SRIOV

2025-04-13 Thread Deng, Emily
[AMD Official Use Only - AMD Internal Distribution Only] >-Original Message- >From: amd-gfx On Behalf Of Alex Deucher >Sent: Friday, April 11, 2025 9:11 PM >To: Deng, Emily >Cc: amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH] drm/amdgpu: Clear overflow for SRIOV > >On Fri, Apr 11, 20

[PATCH] drm/amdgpu: add missing DCE6 to dce_version_to_string()

2025-04-13 Thread Alexandre Demers
Missing DCE 6.0 6.1 and 6.4 are identified as UNKNOWN. Fix this. Signed-off-by: Alexandre Demers --- drivers/gpu/drm/amd/display/dc/dc_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc_helper.c b/drivers/gpu/drm/amd/display/dc/dc_helper.c index

[PATCH] drm/amdgpu/userq: move runpm handling into core userq code

2025-04-13 Thread Alex Deucher
Pull it out of the MES code and into the generic code. It's not MES specific and needs to be applied to all user queues regardless of the backend. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_userqueue.c | 13 + drivers/gpu/drm/amd/amdgpu/mes_userqueue.c| 15

[PATCH 3/4] drm/sdma6: properly reference trap interrupts for userqs

2025-04-13 Thread Alex Deucher
We need to take a reference to the interrupts to make sure they stay enabled even if the kernel queues have disabled them. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 31 +- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 2/4] drm/amdgpu/gfx12: properly reference EOP interrupts for userqs

2025-04-13 Thread Alex Deucher
Regardless of whether we disable kernel queues, we need to take an extra reference to the pipe interrupts for user queues to make sure they stay enabled in case we disable them for kernel queues. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 9 ++--- 1 file changed

[PATCH 4/4] drm/sdma7: properly reference trap interrupts for userqs

2025-04-13 Thread Alex Deucher
We need to take a reference to the interrupts to make sure they stay enabled even if the kernel queues have disabled them. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v7_0.c | 31 +- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/4] drm/amdgpu/gfx11: properly reference EOP interrupts for userqs

2025-04-13 Thread Alex Deucher
Regardless of whether we disable kernel queues, we need to take an extra reference to the pipe interrupts for user queues to make sure they stay enabled in case we disable them for kernel queues. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 9 ++--- 1 file changed

Re: [PATCH v2 7/9] drm/amdgpu/gfx: Clean up gfx_v7_0_get_csb_buffer

2025-04-13 Thread Alex Deucher
On Sat, Apr 12, 2025 at 4:22 PM Rodrigo Siqueira wrote: > > CHIP_KAVERI, CHIP_KABINI, and CHIP_MULLINS have the same buffer > manipulation as the default option in the switch case. Remove those > specific manipulations and rely on the default behavior for them. > > Signed-off-by: Rodrigo Siqueira

Re: [PATCH 0/6] Introduce a generic function to get the CSB buffer

2025-04-13 Thread Alex Deucher
On Sat, Apr 12, 2025 at 4:29 PM Rodrigo Siqueira wrote: > > On 04/08, Rodrigo Siqueira wrote: > > On 04/07, Alex Deucher wrote: > > > On Mon, Apr 7, 2025 at 4:15 PM Rodrigo Siqueira > > > wrote: > > > > > > > > On 04/07, Alex Deucher wrote: > > > > > On Sun, Apr 6, 2025 at 7:07 PM Rodrigo Siquei

Re: [PATCH] drm/amdgpu: Remove PACKET2 from amdgpu since it is not used

2025-04-13 Thread Alex Deucher
On Sat, Apr 12, 2025 at 4:44 PM Rodrigo Siqueira wrote: > > It looks like that CP_PACKET2 is from the radeon GPU driver and was > brought to amdgpu, but it was never used. This commit removes PACKET2 > and related defines from amdgpu. > > Signed-off-by: Rodrigo Siqueira > --- > drivers/gpu/drm/a