[PATCH v2 3/4] drm/amdgpu: Add flag to make VBIOS read optional

Certain SOCs may not need much data from VBIOS. Some data like VBIOS version used will be missed but it doesn't affect functionality. Add a flag to make VBIOS image optional. Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 69 +

[PATCH v2 4/4] drm/amdgpu: Make VBIOS image read optional

Keep VBIOS image read optional for select SOCs in passthrough mode. Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/

[PATCH v2 2/4] drm/amdgpu: Add VBIOS flags

Instead of read_bios, use get_bios_flags to get various options around reading VBIOS. Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH v2 1/4] drm/amdgpu: Add wrapper for freeing vbios memory

Use bios_release wrapper to release memory allocated for vbios image and reset the variables. v2: Use the same wrapper for clean up in sw_fini (Alex Deucher) Signed-off-by: Lijo Lazar Reviewed-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/a

RE: [PATCH] drm/amd/include : MES v11 and v12 API header update

[AMD Official Use Only - AMD Internal Distribution Only] Acked-by: Srinivasan Shanmugam -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, February 6, 2025 12:44 AM To: Liu, Shaoyun Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/include : MES v11

Re: [PATCH] drm/amdgpu: Set snoop bit for SDMA for MI series

On 2025-02-04 18:02, Harish Kasiviswanathan wrote: SDMA writes has to probe invalidate RW lines. Set snoop bit in mmhub for this to happen. Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 25 ++ drivers/gpu

[PATCH 4/4] drm/sched: Make the type of drm_sched_job->last_dependency consistent

Dependency tracking via xarray uses xa_limit_32b so there is not need for the struct member to be unsigned long. At the same time re-order some struct members and take u32 credits outside of the pointer sandwich and avoid a hole. Pahole report before: /* size: 160, cachelines: 3, members:

[AMDGPU/PM/legacy] PATCH SI/CIK: suspend / resume gpu hang [issue 2524]

A patch has been laying dormant for more than a year that would fix suspend/resume GPU hangs happening on SI/CIK's pm suspend/resume cycles. See: https://gitlab.freedesktop.org/drm/amd/-/issues/2524 I'm not the original proposer of the patch, however this person hasn't been answering after a few m

[PATCH 2/4] drm/amdgpu: Use drm_sched_cancel_all_jobs helper

Replace amdgpu_job_stop_all_jobs_on_sched() helper by scheduler common drm_sched_cancel_all_jobs() and remove one duplicated instance of the to_drm_sched_job() macro. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner --- drivers/gpu/

[PATCH] drm/amd/display: avoid NPD when ASIC does not support DMUB

sn't support DMUB */ + if (!link->ctx->dmub_srv) + return false; if (link->psr_settings.psr_version == DC_PSR_VERSION_SU_1 || link->psr_settings.psr_version == DC_PSR_VERSION_1) return true; --- base-commit: 2014c95afece

[PATCH 3/4] drm/sched: Add internal job peek/pop API

Idea is to add helpers for peeking and poppling jobs from entities with the goal of decoupling the hidden assumption in the code that queue_node is the first element in struct drm_sched_job. That assumption usually comes in the form of: while ((job = to_drm_sched_job(spsc_queue_pop(&entity->job

[PATCH 1/4] drm/scheduler: Add drm_sched_cancel_all_jobs helper

The helper copies code from the existing amdgpu_job_stop_all_jobs_on_sched with the purpose of reducing the amount of driver code which directly touch scheduler internals. If or when amdgpu manages to change the approach for handling the permanently wedged state this helper can be removed. Signed

[PATCH v2 0/4] Decouple amdgpu from the scheduler, a bit

General idea is to try and access scheduler data structures less from the drivers so the series basically adds some helpers to move closer towards that goal. Three copies of the same to_drm_sched_job macro get removed and by the end of the series, as a bonus, we can now re-order members of struct

Re: Rework and fix queue reset for gfx7-gfx10

Hi Christian, Em 04/02/2025 11:31, Christian König escreveu: Hi guys, I finally found time to work on queue reset a bit more and also gave it some more testing. How are you testing this series?

[pull] amdgpu drm-fixes-6.14

Hi Dave, Simona, Fixes for 6.14. The following changes since commit 2014c95afecee3e76ca4a56956a936e23283f05b: Linux 6.14-rc1 (2025-02-02 15:39:26 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.14-2025-02-05 for you to fe

Re: [PATCH 4/4] drm/amdgpu: Make VBIOS image read optional

[Public] 2-4 are: Reviewed-by: Alex Deucher From: Lazar, Lijo Sent: Wednesday, February 5, 2025 6:38 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH 4/4] drm/amdgpu: Make VBIOS image read optional Keep VBIOS image

Re: [PATCH 1/4] drm/amdgpu: Add wrapper for freeing vbios memory

[Public] Might be nice to apply this to where we free the vbios in amdgpu_device_fini_sw() as well. Either way: Reviewed-by: Alex Deucher Alex From: Lazar, Lijo Sent: Wednesday, February 5, 2025 6:38 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ;

Re: [PATCH] drm/amd: Refactor find_system_memory()

On 2/5/2025 14:43, Felix Kuehling wrote: On 2025-02-05 15:36, Mario Limonciello wrote: On 2/5/2025 14:33, Felix Kuehling wrote: On 2025-02-05 14:31, Mario Limonciello wrote: On 2/4/2025 17:19, Felix Kuehling wrote: On 2025-02-04 17:21, Mario Limonciello wrote: From: Mario Limonciello

Re: [PATCH] drm/amd: Refactor find_system_memory()

On 2025-02-05 15:36, Mario Limonciello wrote: > On 2/5/2025 14:33, Felix Kuehling wrote: >> >> >> On 2025-02-05 14:31, Mario Limonciello wrote: >>> On 2/4/2025 17:19, Felix Kuehling wrote: On 2025-02-04 17:21, Mario Limonciello wrote: > From: Mario Limonciello > > find_sys

Re: [PATCH] drm/amd: Refactor find_system_memory()

On 2/5/2025 14:33, Felix Kuehling wrote: On 2025-02-05 14:31, Mario Limonciello wrote: On 2/4/2025 17:19, Felix Kuehling wrote: On 2025-02-04 17:21, Mario Limonciello wrote: From: Mario Limonciello find_system_memory() pulls out two fields from an SMBIOS type 17 device and sets them on KF

Re: [PATCH] drm/amd: Refactor find_system_memory()

On 2025-02-05 14:31, Mario Limonciello wrote: > On 2/4/2025 17:19, Felix Kuehling wrote: >> >> On 2025-02-04 17:21, Mario Limonciello wrote: >>> From: Mario Limonciello >>> >>> find_system_memory() pulls out two fields from an SMBIOS type 17 >>> device and sets them on KFD devices. This however

Re: [PATCH] drm/amdgpu: Clean up atom header file inclusion

[Public] Reviewed-by: Alex Deucher From: Lazar, Lijo Sent: Wednesday, February 5, 2025 2:50 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH] drm/amdgpu: Clean up atom header file inclusion atom bios header files ar

[PATCH] drm/amdgpu: Add flags to distinguish vf/pf/pt mode

From: Asad Kamal Add extra flag definition for ids_flag field to distinguish between vf/pf/pt modes v2: Updated kms driver minor version & removed pf check as default is 0 v3: Fix up version (Alex) v4: rebase (Alex) Proposed userspace: https://github.com/ROCm/amdsmi/commit/e663bed7d6b3df79f5959

Re: [PATCH 10/44] drm/amdgpu/vcn: move more instanced data to vcn_instance

On Tue, Feb 4, 2025 at 10:42 PM Boyuan Zhang wrote: > > > On 2025-01-31 11:57, Alex Deucher wrote: > > Move more per instance data into the per instance structure. > > > > v2: index instances directly on vcn1.0 and 2.0 to make > > it clear that they only support a single instance (Lijo) > > > > Si

Re: [PATCH] drm/amd: Refactor find_system_memory()

On 2/4/2025 17:19, Felix Kuehling wrote: On 2025-02-04 17:21, Mario Limonciello wrote: From: Mario Limonciello find_system_memory() pulls out two fields from an SMBIOS type 17 device and sets them on KFD devices. This however is pulling from the middle of the field in the SMBIOS device and le

Re: [PATCH] drm/amd/include : MES v11 and v12 API header update

Acked-by: Alex Deucher On Wed, Feb 5, 2025 at 1:57 PM Shaoyun Liu wrote: > > MES requires driver set cleaner_shader_fence_mc_addr > for cleaner shader support. > > Signed-off-by: Shaoyun Liu > --- > drivers/gpu/drm/amd/include/mes_v11_api_def.h | 3 ++- > drivers/gpu/drm/amd/include/mes_v12_ap

[PATCH 14/14] drm/amd/display: 3.2.320

From: Taimur Hassan Summary: * Start enabling support for 4-plane MPO * DML21 Updates * SPL Updates * Other minor fixes Signed-off-by: Taimur Hassan Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

[PATCH 00/14] DC Patches for 10 Feb 2025

Summary: * Start enabling support for 4-plane MPO * DML21 Updates * SPL Updates * Other minor fixes -- Aurabindo Pillai (1): drm/amd/display: Make dcn401_program_pipe non static Ausef Yousof (1): drm/amd/disp

[PATCH 11/14] drm/amd/display: pass calculated dram_speed_mts to dml2

From: Charlene Liu [why] currently dml2 is using a hard coded 16 to convert memclk to dram_speed_mts. for apu, this depends on wck_ratio. change to pass the already calculated dram_speed_mts from fpu to dml2. v2: use existing calculation of dram_speed_mts for now to avoid regression Signed-off

[PATCH] drm/amd/include : Update MES v12 API for fence update

MES fence_value will be updated in fence_addr if API success, otherwise upper 32 bit will be used to indicate error code. In any case, MES will trigger an EOP interrupt with 0xb1 as context id in the interrupt cookie Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/include/mes_v12_api_def.h |

[PATCH 06/14] drm/amd/display: remove TF check for LLS policy

From: Samson Tam [Why & How] LLS policy not affected by TF. Remove check in don't care case and use pixel format only. Reviewed-by: Navid Assadian Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/sspl/dc_spl.c | 31 +--- 1 file cha

[PATCH 03/14] drm/amd/display: Don't try AUX transactions on disconnected link

From: Ilya Bakoulin [Why] Setting link DPMS off in response to HPD disconnect creates AUX transactions on a link that is supposed to be disconnected. This can cause issues in some cases when the sink re-asserts HPD and expects source to re-enable the link. [How] Avoid AUX transactions on disconn

[PATCH 02/14] drm/amd/display: docstring definitions MAX_SURFACES and MAX_PLANES

From: Zaeem Mohamed MAX_SURFACES and MAX_PLANES now have docstrings that better show the difference between the two. Reviewed-by: Sun peng Li Signed-off-by: Zaeem Mohamed Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/dc.h | 6 ++ 1 file changed, 6 insertions(+) dif

[PATCH 08/14] drm/amd/display: limit coverage of optimization skip

From: Ausef Yousof [why&how] causing some regression on dgpu which still needs the pre-emptive return, limit this to reporter asic version it is simple to include different dcn versions from this point forward, each dcn resource is initialized with the flag and can be enabled at will Reviewed-by

[PATCH 12/14] drm/amd/display: Make dcn401_program_pipe non static

Allow reuse of code by making dcn401_program_pipe() non static. Fixes: 0ed6d68efd76 ("drm/amd/display: Allow reuse of of DCN4x code") Signed-off-by: Aurabindo Pillai Signed-off-by: Karthi Kandasamy Reviewed-by: Alvin Lee --- drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c | 2 +- dri

[PATCH 07/14] drm/amd/display: add new IRQ enum for underflows

From: Leo Zeng [WHY & HOW] needed in certain scenarios for debugging and logging Reviewed-by: Joshua Aberback Reviewed-by: Martin Leung Signed-off-by: Leo Zeng Signed-off-by: Aurabindo Pillai --- drivers/gpu/drm/amd/display/dc/irq_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH 13/14] drm/amd/display: sspl: cleanup filter code

From: Samson Tam [Why & How] Remove unused filters and functions Add static to limit scope Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai Reviewed-by: Jun Lei --- .../display/dc/sspl/dc_spl_isharp_filters.c | 321 +- .../display/dc/sspl/dc_spl_isharp_filters.h

[PATCH 05/14] drm/amd/display: use s1_12 filter tables in SPL

From: Samson Tam [Why & How] Instead of converting tables from s1_10 to s1_12, added s1_12 tables instead in SPL Remove init calls that do the conversion Reviewed-by: Alvin Lee Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/display/dc/resource/dcn401/dcn401_re

[PATCH 01/14] drm/amd/display: Expose 3 secondary planes for supported ASICs

From: Zaeem Mohamed [why] For enabling 4-plane MPO, we need dc to expose 4 planes for DCN35 and beyond, as well as DCN21 [how] Set dc_caps.max_slave_*planes to 3 for appropriate ASICs Reviewed-by: Sun peng Li Signed-off-by: Zaeem Mohamed Signed-off-by: Aurabindo Pillai --- .../gpu/drm/amd/d

[PATCH 10/14] drm/amd/display: add workaround flag to link to force FFE preset

From: Brendan Tam [Why] There have been instances of some monitors being unable to link train on their reported link speed using their selected FFE preset. If a different FFE preset is found that has a higher rate of success during link training this workaround can be used to force its FFE preset

[PATCH 09/14] drm/amd/display: add s1_12 filter tables

From: Samson Tam [Why & How] Instead of converting tables from s1_10 to s1_12, add s1_12 tables instead. Remove init calls that do the conversion. Add APIs to read s1_10 tables Reviewed-by: Navid Assadian Signed-off-by: Samson Tam Signed-off-by: Aurabindo Pillai --- .../display/dc/sspl/dc_sp

[PATCH] drm/amd/include : MES v11 and v12 API header update

MES requires driver set cleaner_shader_fence_mc_addr for cleaner shader support. Signed-off-by: Shaoyun Liu --- drivers/gpu/drm/amd/include/mes_v11_api_def.h | 3 ++- drivers/gpu/drm/amd/include/mes_v12_api_def.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/d

[PATCH] drm/amdgpu: Set snoop bit for SDMA for MI series

SDMA writes has to probe invalidate RW lines. Set snoop bit in mmhub for this to happen. v2: Missed a few mmhub_v9_4. Added now. Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_7.c | 25 ++ drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c | 27 ++

Re: [PATCH] amdkfd: properly free gang_ctx_bo when failed to init user queue

On 2025-02-05 3:08, Zhu Lingshan wrote: > The destructor of a gtt bo is declared as > void amdgpu_amdkfd_free_gtt_mem(struct amdgpu_device *adev, void **mem_obj); > Which takes void** as the second parameter. > > GCC allows passing void* to the function because void* can be implicitly > casted

Re: [PATCH 05/11] drm/amdgpu/sdma5.2: use amdgpu_gfx_off_ctrl_immediate()

ping on patches 1-5 of this series. Alex On Mon, Feb 3, 2025 at 4:52 PM Alex Deucher wrote: > > In begin_use/end_use use amdgpu_gfx_off_ctrl_immediate() > rather than amdgpu_gfx_off_ctrl() as we don't need the > extra delay before we allow gfxoff again. > > Signed-off-by: Alex Deucher > --- >

Re: [PATCH 1/4] drm/scheduler: Add drm_sched_cancel_all_jobs helper

Adding Hawking for commenting on RAS. Am 05.02.25 um 16:33 schrieb Tvrtko Ursulin: The helper copies code from the existing amdgpu_job_stop_all_jobs_on_sched with the purpose of reducing the amount of driver code which directly touch scheduler internals. If or when amdgpu manages to change the

Re: [PATCH 19/44] drm/amdgpu/vcn5.0.0: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 13/44] drm/amdgpu/vcn1.0: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 17/44] drm/amdgpu/vcn4.0.3: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 20/44] drm/amdgpu/vcn5.0.1: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 15/44] drm/amdgpu/vcn2.5: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 12/44] drm/amdgpu/vcn3.0: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 16/44] drm/amdgpu/vcn4.0: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 18/44] drm/amdgpu/vcn4.0.5: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. Signed-off-by: Alex Deucher R

Re: [PATCH 14/44] drm/amdgpu/vcn2.0: convert internal functions to use vcn_inst

On 2025-01-31 11:57, Alex Deucher wrote: Pass the vcn instance structure to these functions rather than adev and the instance number. TODO: clean up the function internals to use the vinst state directly rather than accessing it indirectly via adev->vcn.inst[]. v2: index instances directly on

Re: [PATCH 11/44] drm/amdgpu/vcn: switch vcn helpers to be instance based

On 2025-01-31 11:57, Alex Deucher wrote: Pass the instance to the helpers. Signed-off-by: Alex Deucher Reviewed-by: Boyuan Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 437 drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 12 +-

[PATCH 4/4] drm/amdgpu: Make VBIOS image read optional

Keep VBIOS image read optional for select SOCs in passthrough mode. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index ddccd

[PATCH 1/4] drm/amdgpu: Add wrapper for freeing vbios memory

Use bios_release wrapper to release memory allocated for vbios image and reset the variables. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

[PATCH 2/4] drm/amdgpu: Add VBIOS flags

Instead of read_bios, use get_bios_flags to get various options around reading VBIOS. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/d

[PATCH 3/4] drm/amdgpu: Add flag to make VBIOS read optional

Certain SOCs may not need much data from VBIOS. Some data like VBIOS version used will be missed but it doesn't affect functionality. Add a flag to make VBIOS image optional. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 70 +-- .../gpu/drm/amd/amd

RE: [PATCH 5/5] drm/amdgpu: rework gfx10 queue reset

[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Christian > König > Sent: Tuesday, February 4, 2025 10:31 PM > To: timur.kris...@gmail.com; Deucher, Alexander ; > amd-gfx@lists.freedesktop.org > Subject: [PATCH 5/5] drm/amdgpu: re

RE: [PATCH] drm/amdgpu/sdma4: drop gfxoff calls in dump ip state

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kenneth Feng kenneth.f...@amd.com -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Monday, February 3, 2025 11:41 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgp

RE: [PATCH] drm/amdgpu: refine smu send msg debug log format

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Kenneth Feng kenneth.f...@amd.com -Original Message- From: Wang, Yang(Kevin) Sent: Wednesday, February 5, 2025 3:51 PM To: amd-gfx@lists.freedesktop.org Cc: Feng, Kenneth Subject: [PATCH] drm/amdgpu: refine smu send

RE: [PATCH 1/3] drm/amd/pm: Add APIs for device access checks

[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Asad Kamal Thanks & Regards Asad -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Tuesday, February 4, 2025 12:08 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander

[PATCH] amdkfd: properly free gang_ctx_bo when failed to init user queue

The destructor of a gtt bo is declared as void amdgpu_amdkfd_free_gtt_mem(struct amdgpu_device *adev, void **mem_obj); Which takes void** as the second parameter. GCC allows passing void* to the function because void* can be implicitly casted to any other types, so it can pass compiling. However,