Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread Alex Deucher
On Fri, Jan 24, 2025 at 4:34 PM Marek Olšák wrote: > > So it's implemented but not enabled by default, right? Yes. Alex > > Marek > > On Fri, Jan 24, 2025 at 12:40 PM Alex Deucher wrote: >> >> On Fri, Jan 24, 2025 at 12:38 PM SRINIVASAN SHANMUGAM >> wrote: >> > >> > >> > On 1/24/2025 10:01 PM

Re: amdgpu 100% CPU usage causing freeze 1002:15d8

2025-01-24 Thread Alex Deucher
On Fri, Jan 24, 2025 at 9:17 AM Marco Moock wrote: > > Am 20.01.2025 um 11:35:07 Uhr schrieb Alex Deucher: > > > On Thu, Jan 16, 2025 at 11:57 AM Marco Moock wrote: > > > > > > Am 16.01.2025 um 11:32:42 Uhr schrieb Alex Deucher: > > > > > > > I'd like to see the driver messages leading up to that

Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread Marek Olšák
So it's implemented but not enabled by default, right? Marek On Fri, Jan 24, 2025 at 12:40 PM Alex Deucher wrote: > On Fri, Jan 24, 2025 at 12:38 PM SRINIVASAN SHANMUGAM > wrote: > > > > > > On 1/24/2025 10:01 PM, Marek Olšák wrote: > > > > Does this commit really enable it though? Or is it ju

Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread Alex Deucher
On Fri, Jan 24, 2025 at 12:38 PM SRINIVASAN SHANMUGAM wrote: > > > On 1/24/2025 10:01 PM, Marek Olšák wrote: > > Does this commit really enable it though? Or is it just for sysfs? > > Yes it enables cleaner shader support not only sysfs. It enables the functionality in the kernel. It can be turn

Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread SRINIVASAN SHANMUGAM
On 1/24/2025 10:01 PM, Marek Olšák wrote: Does this commit really enable it though? Or is it just for sysfs? Yes it enables cleaner shader support not only sysfs. Best regards, Srini Marek On Fri, Jan 24, 2025 at 1:42 AM Srinivasan Shanmugam wrote: Enable the cleaner shader for GFX

Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread Marek Olšák
Does this commit really enable it though? Or is it just for sysfs? Marek On Fri, Jan 24, 2025 at 1:42 AM Srinivasan Shanmugam < srinivasan.shanmu...@amd.com> wrote: > Enable the cleaner shader for GFX10.1.1/10.1.2 GPUs to provide data > isolation between GPU workloads. The cleaner shader is resp

Re: [pull] amdgpu, amdkfd drm-next-6.14

2025-01-24 Thread Simona Vetter
On Fri, Jan 24, 2025 at 10:21:52AM -0500, Alex Deucher wrote: > Hi Dave, Simona, > > Fixes for 6.14 from last two weeks. Fixed missing s-o-b. > > The following changes since commit 24c61d553302ee49e9c21dd251275ba8c36dcfe4: > > Merge tag 'drm-msm-next-2025-01-07' of gitlab.freedesktop.org:drm/

[PATCH] drm/amdgpu: add a BO metadata flag to disable write compression for Vulkan

2025-01-24 Thread Marek Olšák
Required by Vulkan because it can allocate whole VRAM as 1 BO and parts of it bypass compression and read raw data. Signed-off-by: Marek Olšák From 98d5342d1b6f247fc6addca48febf0334a445bf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Fri, 24 Jan 2025 09:43:45 -0500 Su

Re: [PATCH] drm/amdgpu/gfx10: Enable cleaner shader for GFX10.1.1/10.1.2 GPUs

2025-01-24 Thread Alex Deucher
On Fri, Jan 24, 2025 at 1:42 AM Srinivasan Shanmugam wrote: > > Enable the cleaner shader for GFX10.1.1/10.1.2 GPUs to provide data > isolation between GPU workloads. The cleaner shader is responsible for > clearing the Local Data Store (LDS), Vector General Purpose Registers > (VGPRs), and Scalar

Re: [PATCH 14/14] drm/amd/display: 3.2.318

2025-01-24 Thread Pillai, Aurabindo
[AMD Official Use Only - AMD Internal Distribution Only] Series is Acked-by: Aurabindo Pillai -- Regards, Jay From: Mohamed, Zaeem Sent: Tuesday, January 21, 2025 2:39 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry ; Li, Sun peng (Leo) ; Siqueira,

[pull] amdgpu, amdkfd drm-next-6.14

2025-01-24 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.14 from last two weeks. Fixed missing s-o-b. The following changes since commit 24c61d553302ee49e9c21dd251275ba8c36dcfe4: Merge tag 'drm-msm-next-2025-01-07' of gitlab.freedesktop.org:drm/msm into drm-next (2025-01-13 11:14:07 +1000) are available in the Git rep

Re: [v6 5/5] drm/amdgpu: fix invalid memory access in amdgpu_fence_driver_sw_fini()

2025-01-24 Thread Christian König
Am 24.01.25 um 06:19 schrieb Jiang Liu: Introduce amdgpu_device_fini_schedulers() to clean scheduler related resources, and avoid possible invalid memory access. Signed-off-by: Jiang Liu I can't say much about the RAS stuff but that patch here is Reviewed-by: Christian König . Alex will pr

Re: amdgpu 100% CPU usage causing freeze 1002:15d8

2025-01-24 Thread Marco Moock
Am 20.01.2025 um 11:35:07 Uhr schrieb Alex Deucher: > On Thu, Jan 16, 2025 at 11:57 AM Marco Moock wrote: > > > > Am 16.01.2025 um 11:32:42 Uhr schrieb Alex Deucher: > > > > > I'd like to see the driver messages leading up to that. > > > > I've now attached the entire dmesg without the firewa

[PATCH v11 0/5] Introduce DRM device wedged event

2025-01-24 Thread Raag Jadav
This series introduces device wedged event in DRM subsystem and uses it in xe, i915 and amdgpu drivers. Detailed description in commit message. This was earlier attempted as xe specific uevent in v1 and v2 on [1]. Similar work by André Almeida on [2]. Wedged event support for amdgpu by André Almei

Re: [pull] amdgpu drm-next-6.14

2025-01-24 Thread Simona Vetter
On Wed, Jan 22, 2025 at 11:32:52AM -0500, Alex Deucher wrote: > Hi Dave, Simona, > > Fixes for 6.14. > > The following changes since commit 97e5c9e4139087a67c2469488360a6d6afdd4b69: > > drm/amd/display: fix CEC DC_DEBUG_MASK documentation (2025-01-16 16:23:22 > -0500) > > are available in th

[PATCH 6.1.y] drm/amd/display: fixed integer types and null check locations

2025-01-24 Thread Imkanmod Khan
From: Sohaib Nadeem [ Upstream commit 0484e05d048b66d01d1f3c1d2306010bb57d8738 ] [why]: issues fixed: - comparison with wider integer type in loop condition which can cause infinite loops - pointer dereference before null check Cc: Mario Limonciello Cc: Alex Deucher Cc: sta...@vger.kernel.org

[PATCH v11 3/5] drm/xe: Use device wedged event

2025-01-24 Thread Raag Jadav
This was previously attempted as xe specific reset uevent but dropped in commit 77a0d4d1cea2 ("drm/xe/uapi: Remove reset uevent for now") as part of refactoring. Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. W

[PATCH v11 1/5] drm: Introduce device wedged event

2025-01-24 Thread Raag Jadav
Introduce device wedged event, which notifies userspace of 'wedged' (hanged/unusable) state of the DRM device through a uevent. This is useful especially in cases where the device is no longer operating as expected and has become unrecoverable from driver context. Purpose of this implementation is

[PATCH v11 4/5] drm/i915: Use device wedged event

2025-01-24 Thread Raag Jadav
Now that we have device wedged event provided by DRM core, make use of it and support both driver rebind and bus-reset based recovery. With this in place, userspace will be notified of wedged device on gt reset failure. Signed-off-by: Raag Jadav Reviewed-by: Aravind Iddamsetty --- drivers/gpu/d

[PATCH v11 5/5] drm/amdgpu: Use device wedged event

2025-01-24 Thread Raag Jadav
From: André Almeida Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Alme

[PATCH v11 2/5] drm/doc: Document device wedged event

2025-01-24 Thread Raag Jadav
Add documentation for device wedged event in a new 'Device wedging' chapter. The describes basic definitions, prerequisites and consumer expectations along with an example. v8: Improve documentation (Christian, Rodrigo) v9: Add prerequisites section (Christian) v10: Clarify mmap cleanup and cons

[PATCH] drm/amdgpu/gfx10: Extend Cleaner Shader Support for Additional GFX10.3.x Versions

2025-01-24 Thread Srinivasan Shanmugam
This commit extends the cleaner shader support to additional versions of the GFX10.3.x series, specifically including versions 10.3.1, 10.3.3, 10.3.6, and 10.3.7. The cleaner shader is important for clearing leftover locals and ensuring process isolation on the GPU. Cc: Mario Sopena-Novales Cc: C