[PATCH] drm/amdgpu: reduce RLC safe mode request for gfx clock gating

2024-12-23 Thread Prike Liang
The driver can only request one time for the power safe mode instead of polling and disabling the power feature each time prior to program the GFX clock gating control registers. This update will reduce the latency on the GFX clock gating entry. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd

Re: [PATCH v6 9/9] drm/amd/display: Mark dc_fixpt_from_fraction() noinline

2024-12-23 Thread Nathan Chancellor
On Sun, Dec 22, 2024 at 12:27:47PM +0800, Tiezhu Yang wrote: > On 12/21/2024 03:40 PM, Xi Ruoyao wrote: > > On Fri, 2024-12-20 at 15:34 -0700, Nathan Chancellor wrote: > > > > Now, the thing is, these ASSERT()s are checking for divide-by-zero, I > > > > suspect clang figured that out and invokes UB

[PATCH] drm/amd: set the workload type based on MALL status

2024-12-23 Thread Aurabindo Pillai
From: Kenneth Feng set the workload type based on MALL status Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 4 ++-- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c | 12 ++-- drivers/gpu/drm/a

Re: [PATCH 0/3] drm/amd/display: fixes for kernel crashes since cursor overlay mode

2024-12-23 Thread Melissa Wen
On 19/12/2024 18:23, Rodrigo Siqueira Jordao wrote: On 12/17/24 1:45 PM, Melissa Wen wrote: Hi, Some issues have been found by Cosmic users of AMD display since the introduction of cursor overlay mode: page fault and divide errors causing interface freezes. Both are 100% reproducible and

[PATCH 1/3] drm/amdgpu: Use memset32 for padding IB ring

2024-12-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use memset32 instead of open coding it, just because it is that bit nicer. Signed-off-by: Tvrtko Ursulin Cc: Christian König Cc: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/dr

[PATCH v3 0/3] Ring padding micro-optimisation etc

2024-12-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I have finally rebased my old series from July and October on top of the similar approach Sunil landed in October but limited to GFX rings. This covers SDMA and VPE (as an outlier, because it uses the same helper), plus contains a patch to cache the SDMA instance in the ring

[PATCH 3/3] drm/amdgpu: Cache SDMA instance and index in the ring

2024-12-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A bunch of SDMA ring vfuncs seem to have a little bit of an identity crisis not knowing to what SDMA instance they belong and have to walk the list of instances on every invocation. We can improve that by simply storing the relevant into in the ring itself. Signed-off-by: Tv

[PATCH 2/3] drm/amdgpu: Use efficient ring padding with more rings

2024-12-23 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can easily expand the approach of writing nops in blocks using memset32 (via the respective helper) to more rings. We do that by trivially factoring out a new amdgpu_ring_fill() helper out of amdgpu_ring_insert_nop() and call it from SDMA and VPE vfuncs. The amount of pa

[PATCH v2] drm/amdgpu: Fix Illegal opcode in command stream Error

2024-12-23 Thread Arvind Yadav
When applications closes, it triggers the drm_file_free function which subsequently releases all allocated buffer objects. Concurrently, the resume_worker thread will attempt to map the usermode queue. However, since the wptr buffer object has already been deallocated, this will result in an Illega

Re: [REGRESSION] amdgpu: thinkpad e495 backlight brightness resets after suspend

2024-12-23 Thread Alex Deucher
On Mon, Dec 23, 2024 at 4:08 AM Siva Mahadevan wrote: > > #regzbot introduced: 99a02eab8 > > Observed behaviour: > linux-stable v6.12.5 has a regression on my thinkpad e495 where > suspend/resume of the laptop results in my backlight brightness settings > to be reset to some very high value. After

RE: [PATCH 00/28] DC Patches December 20, 2024

2024-12-23 Thread Wheeler, Daniel
[Public] Hi all, This week is the last test set for the year, the testing will resume the week of the 6th of January 2025. Have a great holiday break everyone! This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types

[PATCH] amdgpu: tear down ttm range manager for doorbell in amdgpu_ttm_fini()

2024-12-23 Thread Kent Russell
From: Jiang Liu Tear down ttm range manager for doorbell in function amdgpu_ttm_fini(), to avoid memory leakage. Signed-off-by: Jiang Liu Signed-off-by: Kent Russell --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdg

Re: (subset) [PATCH 00/35] Reorganize kerneldoc parameter names

2024-12-23 Thread Srinivas Kandagatla
On Mon, 30 Sep 2024 13:20:46 +0200, Julia Lawall wrote: > Reorganize kerneldoc parameter names to match the parameter > order in the function header. > > The misordered cases were identified using the following > Coccinelle semantic patch: > > // > @initialize:ocaml@ > @@ > > [...] Applied,

Re: [PATCH v6 9/9] drm/amd/display: Mark dc_fixpt_from_fraction() noinline

2024-12-23 Thread Xi Ruoyao
On Fri, 2024-12-20 at 15:34 -0700, Nathan Chancellor wrote: > > Now, the thing is, these ASSERT()s are checking for divide-by-zero, I > > suspect clang figured that out and invokes UB on us and just stops > > code-gen. > > Yeah, I think your analysis is spot on, as this was introduced by a > chang

Re: [PATCH v6 9/9] drm/amd/display: Mark dc_fixpt_from_fraction() noinline

2024-12-23 Thread Tiezhu Yang
On 12/21/2024 03:40 PM, Xi Ruoyao wrote: On Fri, 2024-12-20 at 15:34 -0700, Nathan Chancellor wrote: Now, the thing is, these ASSERT()s are checking for divide-by-zero, I suspect clang figured that out and invokes UB on us and just stops code-gen. Yeah, I think your analysis is spot on, as thi

[REGRESSION] amdgpu: thinkpad e495 backlight brightness resets after suspend

2024-12-23 Thread Siva Mahadevan
#regzbot introduced: 99a02eab8 Observed behaviour: linux-stable v6.12.5 has a regression on my thinkpad e495 where suspend/resume of the laptop results in my backlight brightness settings to be reset to some very high value. After resume, I'm able to increase brightness further until max brightnes