[PATCH] drm/amdgpu: Refine ip detection log message

2024-12-16 Thread Lijo Lazar
'add ip block' causes a confusion if the blocks are disabled later with ip_block_mask. Instead change to 'detected' and also add device context. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH v2 4/7] drm/amdgpu: Fix out-of-bounds issue in user fence

2024-12-16 Thread Paneer Selvam, Arunpravin
Hi Christian, On 12/13/2024 6:29 PM, Christian König wrote: Am 13.12.24 um 12:24 schrieb Paneer Selvam, Arunpravin: Hi Christian, On 12/13/2024 4:13 PM, Christian König wrote: Am 12.12.24 um 15:25 schrieb Arunpravin Paneer Selvam: Fix out-of-bounds issue in userq fence create when accessin

RE: [PATCH] drm/amdgpu: Enable psp v14_0_3 RAS support for non-SRIOV configurations.

2024-12-16 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Candice Li Sent: Monday, December 16, 2024 17:24 To: amd-gfx@lists.freedesktop.org Cc: Li, Candice Subject: [PATCH] drm/amdgpu: Enable psp

Re: [PATCH 3/3] drm/amdgpu/pm: Implement SDMA queue reset for different asic

2024-12-16 Thread Huang, Tim
[AMD Official Use Only - AMD Internal Distribution Only] Looks ok to me. This Series is, Reviewed-by: Tim Huang mailto:tim.hu...@amd.com>> From: jesse.zh...@amd.com Sent: Monday, December 16, 2024 5:29:56 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Ale

Re: [WARNING][AMDGPU] WQ_MEM_RECLAIM with Radeon RX 6600

2024-12-16 Thread Matthew Brost
On Mon, Dec 16, 2024 at 01:36:29PM -0500, Alex Deucher wrote: > On Fri, Dec 13, 2024 at 7:53 AM Chris Rankin wrote: > > > > Hi, > > > > I've just noticed this warning in my dmesg log. This is a vanilla > > 6.12.4 kernel, with a Radeon RX6600 graphics card. > > That was caused by this commit: > >

Re: [PATCH] drm/amdgpu: Make the submission path memory reclaim safe

2024-12-16 Thread Matthew Brost
On Fri, Nov 22, 2024 at 02:36:59PM +, Tvrtko Ursulin wrote: > > On 22/11/2024 13:46, Christian König wrote: > > Am 22.11.24 um 12:34 schrieb Tvrtko Ursulin: > > > On 13/11/2024 14:42, Tvrtko Ursulin wrote: > > > > On 13/11/2024 14:26, Christian König wrote: > > > > > Am 13.11.24 um 14:48 schri

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Marek Olšák
On Mon, Dec 16, 2024 at 9:53 AM Simona Vetter wrote: > On Mon, Dec 16, 2024 at 11:46:13AM +0100, Lucas Stach wrote: > > Am Montag, dem 16.12.2024 um 10:27 +0100 schrieb Michel Dänzer: > > > On 2024-12-15 21:53, Marek Olšák wrote: > > > > The comment explains the problem with DRM_FORMAT_MOD_LINEAR

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Marek Olšák
On Mon, Dec 16, 2024 at 5:46 AM Lucas Stach wrote: > Am Montag, dem 16.12.2024 um 10:27 +0100 schrieb Michel Dänzer: > > On 2024-12-15 21:53, Marek Olšák wrote: > > > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > > > > > > Signed-off-by: Marek Olšák marek.ol...@amd.com>> > > > >

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Marek Olšák
On Mon, Dec 16, 2024 at 4:28 AM Dmitry Baryshkov < dmitry.barysh...@linaro.org> wrote: > On Mon, Dec 16, 2024 at 12:40:54AM -0500, Marek Olšák wrote: > > git send-email (or rather the way it sends email) has been banned by > gmail > > due to being considered unsecure. I don't plan to find a way to

Re: [PATCH] drm/amd: decrease CP queue sleep time

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 4:43 PM Elena Sakhnovitch wrote: > > From: Elena Sakhnovitch > > CP_IQ_WAIT_TIME2.QUE_SLEEP hardware default is 0x40, i.e. > 64, so we put the queue to sleep for 64,000 clock cycles. > This is too long, and setting it to 0x1 shoul be enough to > load date out of memory du

[PATCH] drm/amd: decrease CP queue sleep time

2024-12-16 Thread Elena Sakhnovitch
From: Elena Sakhnovitch CP_IQ_WAIT_TIME2.QUE_SLEEP hardware default is 0x40, i.e. 64, so we put the queue to sleep for 64,000 clock cycles. This is too long, and setting it to 0x1 shoul be enough to load date out of memory during queue connect. Signed-off-by: Elena Sakhnovitch --- drivers/gpu/

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Marek Olšák
On Mon, Dec 16, 2024 at 4:27 AM Michel Dänzer wrote: > On 2024-12-15 21:53, Marek Olšák wrote: > > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > > > > Signed-off-by: Marek Olšák marek.ol...@amd.com>> > > > > diff --git a/include/uapi/drm/drm_fourcc.h > b/include/uapi/drm/drm_fou

Re: [PATCH v2 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-12-16 Thread Lyude Paul
Reviewed-by: Lyude Paul On Sat, 2024-12-14 at 15:37 +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid > callback of drm_encoder_slave to also accept const argument. > > Review

Re: [PATCH v2 5/5] drm/connector: make mode_valid take a const struct drm_display_mode

2024-12-16 Thread Lyude Paul
For the nouveau portions: Reviewed-by: Lyude Paul On Sat, 2024-12-14 at 15:37 +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > take a const struct drm_display_mode argument. Change the mode_valid > callback of drm_connector to also take a cons

Re: [PATCH 12/17] Revert "drm/amd/display: Fix green screen issue after suspend"

2024-12-16 Thread Mario Limonciello
On 12/13/2024 09:52, Rodrigo Siqueira wrote: This reverts commit 87b7ebc2e16c14d32a912f18206a4d6cc9abc3e8. Blast from the past, that's from 5.7! Nice tech debt removal. A long time ago, we had an issue with the Raven system when it was connected to two displays: one with DP and another with

Re: [PATCH 4/5] drm/amdgpu: Constify 'struct bin_attribute'

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 6:53 AM Thomas Weißschuh wrote: > > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Alex D

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Harry Wentland
On 2024-12-16 10:31, Alex Deucher wrote: > On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov > wrote: >> >> On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: >>> >>> >>> >>> On 2024-12-10 16:20, Dmitry Baryshkov wrote: On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: >>

Re: [WARNING][AMDGPU] WQ_MEM_RECLAIM with Radeon RX 6600

2024-12-16 Thread Alex Deucher
On Fri, Dec 13, 2024 at 7:53 AM Chris Rankin wrote: > > Hi, > > I've just noticed this warning in my dmesg log. This is a vanilla > 6.12.4 kernel, with a Radeon RX6600 graphics card. That was caused by this commit: commit 746ae46c11137ba21f0c0c68f082a9d8c1222c78 Author: Matthew Brost Date: We

Re: [PATCH] drm/amdgpu: Fix potential integer overflow in scheduler mask calculations

2024-12-16 Thread Alex Deucher
Applied. Thanks! On Sun, Dec 15, 2024 at 7:38 AM Karol Przybylski wrote: > > The use of 1 << i in scheduler mask calculations can result in an > unintentional integer overflow due to the expression being > evaluated as a 32-bit signed integer. > > This patch replaces 1 << i with 1ULL << i to ens

Re: [PATCH 1/2] drm/buddy: fix issue that force_merge cannot free all roots

2024-12-16 Thread Matthew Auld
On 16/12/2024 13:07, Arunpravin Paneer Selvam wrote: From: Lin.Cao If buddy manager have more than one roots and each root have sub-block need to be free. When drm_buddy_fini called, the first loop of force_merge will merge and free all of the sub block of first root, which offset is 0x0 and si

Re: [PATCH 2/2] drm/buddy: Add a testcase to verify the multiroot fini

2024-12-16 Thread Matthew Auld
On 16/12/2024 13:07, Arunpravin Paneer Selvam wrote: - Added a testcase to verify the multiroot force merge fini. - Added a new field in_use to track the mm freed status. Signed-off-by: Arunpravin Paneer Selvam Signed-off-by: Lin.Cao --- drivers/gpu/drm/drm_buddy.c| 20 ++

Re: [PATCH 3/3] drm/amdgpu/pm: Implement SDMA queue reset for different asic

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 4:30 AM jesse.zh...@amd.com wrote: > > Implement sdma queue reset by SMU_MSG_ResetSDMA2 > > Suggested-by: Tim Huang > Signed-off-by: Jesse Zhang Series is: Acked-by: Alex Deucher > --- > .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 30 ++- > 1 file

Re: [PATCH 3/3] drm/amdgpu: partially revert "reduce reset time"

2024-12-16 Thread Alex Deucher
On Fri, Dec 13, 2024 at 4:03 AM Christian König wrote: > > This partially reverts commit 194eb174cbe4fe2b3376ac30acca2dc8c8beca00. > > This commit introduced a new state variable into adev without even > remotely worrying about CPU barriers. > > Since we already have the amdgpu_in_reset() function

[PATCH v12 5/5] drm/amdgpu: track bo memory stats at runtime

2024-12-16 Thread Yunxiang Li
Before, every time fdinfo is queried we try to lock all the BOs in the VM and calculate memory usage from scratch. This works okay if the fdinfo is rarely read and the VMs don't have a ton of BOs. If either of these conditions is not true, we get a massive performance hit. In this new revision, we

Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Fri, 06 Dec 2024 11:43:03 +0200, Dmitry Baryshkov wrote: > The connector->eld is accessed by the .get_eld() callback. This access > can collide with the drm_edid_to_eld() updating the data at the same > time. Add drm_connector.eld_mutex to protect the data from concurrenct > access. > > The ind

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-16 Thread Maxime Ripard
Hi, On Thu, Dec 12, 2024 at 12:37:59PM +0200, Raag Jadav wrote: > On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote: > > On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > > > + misc maintainers > > > > > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: >

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Mon, 16 Dec 2024 at 17:32, Alex Deucher wrote: > > On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov > wrote: > > > > On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > > > > > > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmit

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov wrote: > > On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: > > >> Reading access to connector->eld can happen

Re: [PATCH v2 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 16:02 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma S

Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-16 Thread Maxime Ripard
On Mon, Dec 16, 2024 at 01:24:29PM +0200, Dmitry Baryshkov wrote: > On Fri, Dec 06, 2024 at 11:43:03AM +0200, Dmitry Baryshkov wrote: > > The connector->eld is accessed by the .get_eld() callback. This access > > can collide with the drm_edid_to_eld() updating the data at the same > > time. Add drm

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: > >> Reading access to connector->eld can happen at the same time the > >> drm_edid_to_eld() updates the data. Take the new

Re: [PATCH 5/5] drm/amd/display: Constify 'struct bin_attribute'

2024-12-16 Thread Harry Wentland
On 2024-12-16 06:34, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Harry Wentland Ha

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Harry Wentland
On 2024-12-10 16:20, Dmitry Baryshkov wrote: > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: >> Reading access to connector->eld can happen at the same time the >> drm_edid_to_eld() updates the data. Take the newly added eld_mutex in >> order to protect connector->eld from co

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Simona Vetter
On Mon, Dec 16, 2024 at 11:46:13AM +0100, Lucas Stach wrote: > Am Montag, dem 16.12.2024 um 10:27 +0100 schrieb Michel Dänzer: > > On 2024-12-15 21:53, Marek Olšák wrote: > > > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > > >     > > > Signed-off-by: Marek Olšák > >

RE: [PATCH 00/17] DC Patches Dec 13, 2024

2024-12-16 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types. APU • Single Display eDP -> 1080p 60hz, 2560x1600 120hz, 1920x1200 165hz • Single Display DP (SST DSC) -> 4k144hz, 4k240hz

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian Köni

[PATCH 0/5] drm: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- Thomas Weißschuh (5): drm/sysfs: Constify 'struct bin_attribute' drm/lim

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Raag Jadav
On Mon, Dec 16, 2024 at 10:15:00AM -0300, André Almeida wrote: > Em 16/12/2024 10:10, Christian König escreveu: > > Am 16.12.24 um 14:04 schrieb André Almeida: > > > Em 16/12/2024 07:38, Lazar, Lijo escreveu: > > > > > > > > > > > > On 12/16/2024 3:48 PM, Christian König wrote: > > > > > Am 13.12

[PATCH 1/5] drm/sysfs: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/drm_sysfs.c | 10 +- 1 file changed, 5 insertions(+), 5 del

[PATCH 5/5] drm/amd/display: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 8 1 file changed

[PATCH 3/5] drm/i915: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 drivers/gpu/drm/i915/i915_sysf

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 16/12/2024 10:10, Christian König escreveu: Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024

[PATCH 4/5] drm/amdgpu: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/

[PATCH 2/5] drm/lima: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/lima/lima_drv.c | 8 1 file changed, 4 insertions(+), 4 de

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 7:09 PM, Christian König wrote: > Am 16.12.24 um 14:36 schrieb Lazar, Lijo: >> I had asked earlier about the utility of this one here. If this is just >> to inform userspace that driver has done a reset and recovered, it >> would >> need some additional context also

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:36 schrieb Lazar, Lijo: I had asked earlier about the utility of this one here. If this is just to inform userspace that driver has done a reset and recovered, it would need some additional context also. We have a mechanism in KFD which sends the context in which a reset has to

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 6:45 PM, André Almeida wrote: > > > Em 16/12/2024 10:10, Christian König escreveu: >> Am 16.12.24 um 14:04 schrieb André Almeida: >>> Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: > Am 13.12.24 um 16:56 schrieb André A

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:15 schrieb André Almeida: Em 16/12/2024 10:10, Christian König escreveu: Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, R

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Chris

[PATCH 2/2] drm/buddy: Add a testcase to verify the multiroot fini

2024-12-16 Thread Arunpravin Paneer Selvam
- Added a testcase to verify the multiroot force merge fini. - Added a new field in_use to track the mm freed status. Signed-off-by: Arunpravin Paneer Selvam Signed-off-by: Lin.Cao --- drivers/gpu/drm/drm_buddy.c| 20 - drivers/gpu/drm/tests/drm_buddy_test.c | 30 +++

[PATCH 1/2] drm/buddy: fix issue that force_merge cannot free all roots

2024-12-16 Thread Arunpravin Paneer Selvam
From: Lin.Cao If buddy manager have more than one roots and each root have sub-block need to be free. When drm_buddy_fini called, the first loop of force_merge will merge and free all of the sub block of first root, which offset is 0x0 and size is biggest(more than have of the mm size). In subseq

Re: [PATCH 3/5] drm/i915: Constify 'struct bin_attribute'

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Jani Nikula > ---

Re: [PATCH 1/5] drm/sysfs: Constify 'struct bin_attribute'

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Jani Nikula > ---

Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Fri, Dec 06, 2024 at 11:43:03AM +0200, Dmitry Baryshkov wrote: > The connector->eld is accessed by the .get_eld() callback. This access > can collide with the drm_edid_to_eld() updating the data at the same > time. Add drm_connector.eld_mutex to protect the data from concurrenct > access. > > T

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Lucas Stach
Am Montag, dem 16.12.2024 um 10:27 +0100 schrieb Michel Dänzer: > On 2024-12-15 21:53, Marek Olšák wrote: > > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. > >     > > Signed-off-by: Marek Olšák > > > > > > diff --git a/include/uapi/drm/drm_fourcc.h b/in

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 3:48 PM, Christian König wrote: > Am 13.12.24 um 16:56 schrieb André Almeida: >> Em 13/12/2024 11:36, Raag Jadav escreveu: >>> On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian König escreveu: > Am 12.12.2

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian König escreveu: Am 12.12.24 um 20:09 schrieb André Almeida: Use DRM's device wedged event to notif

[PATCH] drm/amdgpu: Enable psp v14_0_3 RAS support for non-SRIOV configurations.

2024-12-16 Thread Candice Li
Enable psp v14_0_3 RAS support for non-SRIOV configurations. Signed-off-by: Candice Li --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index db081618

[PATCH 2/3] drm/amdgpu/pm: add PPSMC_MSG_ResetSDMA2 definition

2024-12-16 Thread jesse.zh...@amd.com
add the PPSMC_MSG_ResetSDMA2 definition for smu 13.0.6 Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/pm/swsmu/inc/pmfw_if/smu_v13_0_6_ppsmc.h | 1 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 ++- drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 + 3 fi

[PATCH 3/3] drm/amdgpu/pm: Implement SDMA queue reset for different asic

2024-12-16 Thread jesse.zh...@amd.com
Implement sdma queue reset by SMU_MSG_ResetSDMA2 Suggested-by: Tim Huang Signed-off-by: Jesse Zhang --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 30 ++- 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/

[PATCH 1/3] drm/amdgpu/sdma4.4.2: add apu support in sdma queue reset

2024-12-16 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Remove apu check in sdma queue reset. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c ind

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Dmitry Baryshkov
On Mon, Dec 16, 2024 at 12:40:54AM -0500, Marek Olšák wrote: > git send-email (or rather the way it sends email) has been banned by gmail > due to being considered unsecure. I don't plan to find a way to make it > work and I don't plan to use a different email provider. It doesn't matter > because

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Michel Dänzer
On 2024-12-15 21:53, Marek Olšák wrote: > The comment explains the problem with DRM_FORMAT_MOD_LINEAR. >     > Signed-off-by: Marek Olšák mailto:marek.ol...@amd.com>> > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > index 78abd819fd62e..8ec4163429014 100644 > --- a/

RE: [PATCH 3/3] drm/amdgpu/pm: Implement SDMA queue for different asic

2024-12-16 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Tim -Original Message- From: Huang, Tim Sent: Monday, December 16, 2024 4:29 PM To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian ; Zhu, Jiadong ; Zhang, Jesse(Jie) ; Zhang, Jesse

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian König escreveu: Am 12.12.24 um 20:09 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Hi Christian, Em 13/12/2024 04:34, Christian König escreveu: Am 12.12.24 um 20:09 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. Signed-off-by: André Almeida ---   drivers/gpu/drm

[PATCH] drm/amdgpu: Fix potential integer overflow in scheduler mask calculations

2024-12-16 Thread Karol Przybylski
The use of 1 << i in scheduler mask calculations can result in an unintentional integer overflow due to the expression being evaluated as a 32-bit signed integer. This patch replaces 1 << i with 1ULL << i to ensure the operation is performed as a 64-bit unsigned integer, preventing overflow Disco

Re: [PATCH 10/34] drm/amd/display: Add debug prints for IPS testing

2024-12-16 Thread Guenter Roeck
On 12/11/24 08:18, Hung, Alex wrote: [AMD Official Use Only - AMD Internal Distribution Only] Hi Guenter, Thanks for the updates. This may be a real issue. Please file a bug at https://gitlab.freedesktop.org/drm/amd/-/issues  and share your s

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Raag Jadav
On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: > Hi Christian, > > Em 13/12/2024 04:34, Christian König escreveu: > > Am 12.12.24 um 20:09 schrieb André Almeida: > > > Use DRM's device wedged event to notify userspace that a reset had > > > happened. For now, only use `none` method

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-16 Thread Raag Jadav
On Thu, Dec 12, 2024 at 03:31:01PM -0300, André Almeida wrote: > Hi Raag, > > Thank you for your patch. > > Em 28/11/2024 12:37, Raag Jadav escreveu: > > [...] > > > +int drm_dev_wedged_event(struct drm_device *dev, unsigned long method) > > +{ > > + const char *recovery = NULL; > > + unsig

RE: [PATCH 3/3] drm/amdgpu/pm: Implement SDMA queue for different asic

2024-12-16 Thread Huang, Tim
[AMD Official Use Only - AMD Internal Distribution Only] Hi Jesse, > -Original Message- > From: jesse.zh...@amd.com > Sent: Friday, December 13, 2024 7:41 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Zhu, Jiadong ; Huang, > Tim ; Zhang, Jesse(Ji