RE: [PATCH] drm/amdgpu: Remove gfxoff usage

2024-11-26 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Lazar, Lijo Sent: Wednesday, November 27, 2024 14:14 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Khatri, Sunil Subject: [PATCH]

[PATCH] drm/amdgpu: Remove gfxoff usage

2024-11-26 Thread Lijo Lazar
GFXOFF is not valid for these IP versions. Also, SDMA v4.4.2 is not in GFX domain. Signed-off-by: Lijo Lazar --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 4 drivers/gpu/drm/amd/amdgpu/sdma_v4_4_2.c | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Mario Limonciello
On 11/26/24 09:37, Lazar, Lijo wrote: On 11/26/2024 7:50 PM, Mario Limonciello wrote: Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? Then hibernate would fail under

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Lazar, Lijo
On 11/26/2024 7:50 PM, Mario Limonciello wrote: Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? >>> >>> Then hibernate would fail under memory pressure.

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Mario Limonciello
Based on https://gitlab.freedesktop.org/drm/amd/-/issues/3781 What if this callback takes care only of suspend case and leaves the hibernate case to dpm_prepare callback? Then hibernate would fail under memory pressure. My take is this failure with hibernate is a userspace problem (whether use

Re: [PATCH v4 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-26 Thread Lazar, Lijo
On 11/25/2024 9:46 PM, Mario Limonciello wrote: > > > On 11/25/24 08:59, Lazar, Lijo wrote: >> >> >> On 11/25/2024 12:30 AM, Mario Limonciello wrote: >>> From: Mario Limonciello >>> >>> As part of the suspend sequence VRAM needs to be evicted on dGPUs. >>> In order to make suspend/resume more

Re: [PATCH] drm/amdgpu: fix sriov reinit late orders

2024-11-26 Thread Lazar, Lijo
On 11/26/2024 4:45 PM, Yiqing Yao wrote: > Use found block to call correct init/resume function on the block. > Set status.hw for resume and init. > > Print re-init result again. Change to use dev_info. > Use amdgpu_device_ip_get_ip_block to get target block instead of > loop. > > Fixes: 17eb6

RE: [PATCH] drm/amdgpu: use sjt mec fw on gfx943 for sriov

2024-11-26 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Zhao, Victor Sent: Tuesday, November 26, 2024 17:56 To: Zhao, Victor ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: use sj

[PATCH] drm/amdgpu: fix sriov reinit late orders

2024-11-26 Thread Yiqing Yao
Use found block to call correct init/resume function on the block. Set status.hw for resume and init. Print re-init result again. Change to use dev_info. Use amdgpu_device_ip_get_ip_block to get target block instead of loop. Fixes: 17eb6e7137a7 ("drm/amdgpu: validate resume before function call")

RE: [PATCH] drm/amdgpu: use sjt mec fw on gfx943 for sriov

2024-11-26 Thread Zhao, Victor
[AMD Official Use Only - AMD Internal Distribution Only] Ping. Please help review. -Original Message- From: Victor Zhao Sent: Saturday, November 23, 2024 9:59 PM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Victor Subject: [PATCH] drm/amdgpu: use sjt mec fw on gfx943 for sriov Use secon

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-26 Thread Raag Jadav
On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: > Am 22.11.24 um 17:02 schrieb Raag Jadav: > > On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: > > > Am 22.11.24 um 08:07 schrieb Raag Jadav: > > > > On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote:

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-26 Thread Christian König
Am 26.11.24 um 07:38 schrieb Raag Jadav: On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: Am 22.11.24 um 17:02 schrieb Raag Jadav: On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: Am 22.11.24 um 08:07 schrieb Raag Jadav: On Mon, Nov 18, 2024 at 08:26:37PM +0530