Kernel warning in dcn30_dpp.c; short freezing, crashes in KWin

2024-11-22 Thread Forest Crossman
Hi, all. I have a laptop with an AMD Radeon 780M, and I'm getting a warning message shortly after boot (see the end of this email for the message). I noticed the message while investigating some issues that I began to experience after performing some software updates. The first issue I noticed was

RE: [PATCH] drm/amdgpu/jpeg1.0: fix idle work handler

2024-11-22 Thread Zhang, George
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Alex > Deucher > Sent: Friday, November 22, 2024 2:04 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander > Subject: [PATCH] drm/amdgpu/jpeg1.0: fix idle work handler >

Re: [PATCH v2 1/2] drm/amd: Invert APU check for amdgpu_device_evict_resources()

2024-11-22 Thread Mario Limonciello
On 11/22/2024 11:00, Alex Deucher wrote: On Fri, Nov 22, 2024 at 11:17 AM Mario Limonciello wrote: Resource eviction isn't needed for s3 or s2idle on APUs, but should be run for S4. As amdgpu_device_evict_resources() will be called by prepare notifier adjust logic so that APUs only cover S4.

[PATCH v3 2/3] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Mario Limonciello
As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspend sequence would fail but the system could remain operational under high memory usage suspend. Another class of issues

[PATCH v3 3/3] drm/amd: Drop needless call to evict resources in prepare()

2024-11-22 Thread Mario Limonciello
As resources are now evicted by the pm notifier chain, there is no need to also evict them during the pm prepare() callback. Signed-off-by: Mario Limonciello --- v3: * New patch --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/dr

[PATCH v3 1/3] drm/amd: Invert APU check for amdgpu_device_evict_resources()

2024-11-22 Thread Mario Limonciello
Resource eviction isn't needed for s3 or s2idle on APUs, but should be run for S4. As amdgpu_device_evict_resources() will be called by prepare notifier adjust logic so that APUs only cover S4. Suggested-by: Lijo Lazar Signed-off-by: Mario Limonciello -- v2: * New patch --- drivers/gpu/drm/amd

[PATCH] drm/amdgpu/jpeg1.0: fix idle work handler

2024-11-22 Thread Alex Deucher
On VCN 1.0, VCN and JPEG use the same worker thread so cancel the vcn worker rather than jpeg. On VCN 2.0 and newer there are separate workers for each. Fixes: 93df74873703 ("drm/amdgpu/jpeg: cancel the jpeg worker") Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 2 +-

Re: [PATCH v2 1/2] drm/amd: Invert APU check for amdgpu_device_evict_resources()

2024-11-22 Thread Alex Deucher
On Fri, Nov 22, 2024 at 11:17 AM Mario Limonciello wrote: > > Resource eviction isn't needed for s3 or s2idle on APUs, but should > be run for S4. As amdgpu_device_evict_resources() will be called > by prepare notifier adjust logic so that APUs only cover S4. > > Suggested-by: Lijo Lazar > Signed

[PATCH 4/5] drm/amdgpu/hdp6.0: do a posting read when flushing HDP

2024-11-22 Thread Alex Deucher
Need to read back to make sure the write goes through. Cc: David Belanger Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/hdp_v6_0.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v6_0.c b/drivers/gpu/drm/amd/amdgpu/hdp_v6_0.

[PATCH 3/5] drm/amdgpu/hdp5.2: do a posting read when flushing HDP

2024-11-22 Thread Alex Deucher
Need to read back to make sure the write goes through. Cc: David Belanger Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/hdp_v5_2.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v5_2.c b/drivers/gpu/drm/amd/amdgpu/hdp_v5_2.

[PATCH 5/5] drm/amdgpu/hdp7.0: do a posting read when flushing HDP

2024-11-22 Thread Alex Deucher
Need to read back to make sure the write goes through. Cc: David Belanger Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/hdp_v7_0.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v7_0.c b/drivers/gpu/drm/amd/amdgpu/hdp_v7_0.

[PATCH 1/5] drm/amdgpu/hdp4.0: do a posting read when flushing HDP

2024-11-22 Thread Alex Deucher
Need to read back to make sure the write goes through. Cc: David Belanger Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v4_0.c b/drivers/gpu/drm/amd/amdgpu/hd

[PATCH 2/5] drm/amdgpu/hdp5.0: do a posting read when flushing HDP

2024-11-22 Thread Alex Deucher
Need to read back to make sure the write goes through. Cc: David Belanger Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/hdp_v5_0.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/hdp_v5_0.c b/drivers/gpu/drm/amd/amdgpu/hdp_v5_0

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Mario Limonciello
On 11/22/2024 09:59, Alex Deucher wrote: On Fri, Nov 22, 2024 at 10:57 AM Mario Limonciello wrote: On 11/22/2024 08:28, Lazar, Lijo wrote: On 11/19/2024 1:33 AM, Mario Limonciello wrote: As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Alex Deucher
On Fri, Nov 22, 2024 at 10:57 AM Mario Limonciello wrote: > > On 11/22/2024 08:28, Lazar, Lijo wrote: > > > > > > On 11/19/2024 1:33 AM, Mario Limonciello wrote: > >> As part of the suspend sequence VRAM needs to be evicted on dGPUs. > >> In order to make suspend/resume more reliable we moved this

[PATCH v2 1/2] drm/amd: Invert APU check for amdgpu_device_evict_resources()

2024-11-22 Thread Mario Limonciello
Resource eviction isn't needed for s3 or s2idle on APUs, but should be run for S4. As amdgpu_device_evict_resources() will be called by prepare notifier adjust logic so that APUs only cover S4. Suggested-by: Lijo Lazar Signed-off-by: Mario Limonciello -- v2: * New patch --- drivers/gpu/drm/amd

[PATCH v2 2/2] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Mario Limonciello
As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspend sequence would fail but the system could remain operational under high memory usage suspend. Another class of issues

[pull] amdgpu, amdkfd, radeon drm-fixes-6.13

2024-11-22 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.13. The following changes since commit a163b895077861598be48c1cf7f4a88413c28b22: Merge tag 'drm-xe-next-fixes-2024-11-15' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next (2024-11-18 13:38:46 +1000) are available in the Git repository at: https:/

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Lazar, Lijo
On 11/19/2024 1:33 AM, Mario Limonciello wrote: > As part of the suspend sequence VRAM needs to be evicted on dGPUs. > In order to make suspend/resume more reliable we moved this into > the pmops prepare() callback so that the suspend sequence would fail > but the system could remain operational

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Mario Limonciello
On 11/22/2024 08:28, Lazar, Lijo wrote: On 11/19/2024 1:33 AM, Mario Limonciello wrote: As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspend sequence would fail but t

RE: [PATCH 0/9] DC Patches Nov 19, 2024

2024-11-22 Thread Wheeler, Daniel
[Public] Hi all, This week this patchset was tested on 4 systems, two dGPU and two APU based, and tested across multiple display and connection types. APU * Single Display eDP -> 1080p 60hz, 2560x1600 120hz, 1920x1200 165hz * Single Display DP -> 4k144hz, 4k240hz * Multi

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Alex Deucher
On Fri, Nov 22, 2024 at 5:03 AM Christian König wrote: > > Am 18.11.24 um 21:03 schrieb Mario Limonciello: > > As part of the suspend sequence VRAM needs to be evicted on dGPUs. > > In order to make suspend/resume more reliable we moved this into > > the pmops prepare() callback so that the suspen

Re: [PATCH] drm/amdgpu: Make the submission path memory reclaim safe

2024-11-22 Thread Christian König
Am 22.11.24 um 12:34 schrieb Tvrtko Ursulin: On 13/11/2024 14:42, Tvrtko Ursulin wrote: On 13/11/2024 14:26, Christian König wrote: Am 13.11.24 um 14:48 schrieb Tvrtko Ursulin: From: Tvrtko Ursulin As commit 746ae46c1113 ("drm/sched: Mark scheduler work queues with WQ_MEM_RECLAIM") points

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-22 Thread Raag Jadav
On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: > On 15/11/24 10:37, Raag Jadav wrote: > > Introduce device wedged event, which notifies userspace of 'wedged' > > (hanged/unusable) state of the DRM device through a uevent. This is > > useful especially in cases where the device

Re: [REGRESSION][BISECTED] 58a261bfc967: choppy GPU performance

2024-11-22 Thread John Rowley
John Rowley wrote: > The attached patch seems to improve rendering performance a lot; animations > and desktop performance are generally smoother again. > > But it doesn't seem 100%, e.g. if I let the laptop idle for 10 secs before > interacting with the touchpad, the desktop cursor seems to sti

RE: [PATCH v4 0/2] Refactor MST DSC Determination Policy

2024-11-22 Thread Jani Nikula
On Thu, 21 Nov 2024, "Zuo, Jerry" wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Lyude, Jani, Imre, Simona: > > Please kindly review the patch series at your convenient > time. Thanks. There's still way too much going on in one patch. It's too hard to do proper

[bugreport] Invoking Xorg -retro and using radeon.ko renders root window stipple in colored dots, not B/W standard stipple

2024-11-22 Thread xkabe
Subject: [bugreport] Invoking Xorg -retro and using radeon.ko renders root window stipple in colored dots, not B/W standard stipple Graphic card: RV280 ATI Radeon 9200 Pro (PCI id 1002:5960,subid 148c:2094) kernel: kernel-5.14.0-427.42.1.el9_4 (Rocky Linux 9.4) Xorg: xorg-x11-server-Xorg-1.20.11-

Re: [PATCH v2 1/2] drm/amdgpu: Update the variable name to dma_buf

2024-11-22 Thread Christian König
Am 22.11.24 um 09:03 schrieb Sunil Khatri: Instead of fixing the warning for missing variable its better to update the variable name to match with the style followed in the code. This will fix the below mentioned warning: warning: Function parameter or struct member 'dbuf' not described in 'amd

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-22 Thread Christian König
Am 22.11.24 um 08:07 schrieb Raag Jadav: On Mon, Nov 18, 2024 at 08:26:37PM +0530, Aravind Iddamsetty wrote: On 15/11/24 10:37, Raag Jadav wrote: Introduce device wedged event, which notifies userspace of 'wedged' (hanged/unusable) state of the DRM device through a uevent. This is useful especi

Re: [PATCH] drm/amd: Add Suspend/Hibernate notification callback support

2024-11-22 Thread Christian König
Am 18.11.24 um 21:03 schrieb Mario Limonciello: As part of the suspend sequence VRAM needs to be evicted on dGPUs. In order to make suspend/resume more reliable we moved this into the pmops prepare() callback so that the suspend sequence would fail but the system could remain operational under hi

[PATCH v2 1/2] drm/amdgpu: Update the variable name to dma_buf

2024-11-22 Thread Sunil Khatri
Instead of fixing the warning for missing variable its better to update the variable name to match with the style followed in the code. This will fix the below mentioned warning: warning: Function parameter or struct member 'dbuf' not described in 'amdgpu_bo_create_isp_user' warning: Excess funct

[PATCH v2 2/2] drm/amdgpu: add "restore" missing variable comment

2024-11-22 Thread Sunil Khatri
add "restore" missing variable in the fucntions sdma_v4_4_2_page_resume and sdma_v4_4_2_inst_start. This fixes the warning: warning: Function parameter or struct member 'restore' not described in 'sdma_v4_4_2_page_resume' warning: Function parameter or struct member 'restore' not described in 's