RE: [PATCH 3/3 V2] drm/amdgpu: Fix sysfs warning when hotplugging

2024-11-17 Thread Huang, Tim
[Public] This Series is, Reviewed-by: Tim Huang > -Original Message- > From: amd-gfx On Behalf Of > jesse.zh...@amd.com > Sent: Monday, November 18, 2024 1:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Prosyak, Vitaly ; > Huang, Tim ; Zhang,

[PATCH] drm/amdgpu: Prefer RAS recovery for scheduler hang

2024-11-17 Thread Lijo Lazar
Before scheduling a recovery due to scheduler/job hang, check if a RAS error is detected. If so, choose RAS recovery to handle the situation. A scheduler/job hang could be the side effect of a RAS error. In such cases, it is required to go through the RAS error recovery process. A RAS error recover

RE: [PATCH 3/3] drm/amdgpu: Fix sysfs warning when hotplugging

2024-11-17 Thread Huang, Tim
[Public] Hi Jesse, > -Original Message- > From: amd-gfx On Behalf Of > jesse.zh...@amd.com > Sent: Monday, November 18, 2024 12:31 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Prosyak, Vitaly ; > Huang, Tim ; Zhang, Jesse(Jie) > ; Dong, Andy >

[PATCH 2/3] Revert "drm/amdgpu: fix warning when removing sysfs"

2024-11-17 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" This reverts commit 330d97e9b14e0c85cc8b63e0092e4abcb9ce99c8. the dev->unplugged flag will also be set to true , Only uninstall the driver by amdgpu_exit,not actually unplug the device. that will cause a new issue. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/

[PATCH 3/3] drm/amdgpu: Fix sysfs warning when hotplugging

2024-11-17 Thread jesse.zh...@amd.com
Replace the check drm_dev_enter with sysfs directory entry. Because the dev->unplugged flag will also be set to true, Only uninstall the driver by amdgpu_exit, not actually unplug the device. Signed-off-by: Jesse Zhang Reported-by: Andy Dong --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c |

RE: [PATCH] drm/amdgpu: Fix sysfs warning when hotplugging

2024-11-17 Thread Huang, Tim
[Public] Hi Jesse, I recommend reverting the old patch "[PATCH V2] drm/amdgpu: fix warning when removing sysfs" first, and then applying your change. Thanks Tim Huang > -Original Message- > From: jesse.zh...@amd.com > Sent: Friday, November 15, 2024 10:08 AM > To: amd-gfx@lists.freede

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Dmitry Baryshkov
On Mon, 18 Nov 2024 at 01:33, Laurent Pinchart wrote: > > On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > > > > The mode_valid() callbacks of drm_en

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Laurent Pinchart
On Mon, Nov 18, 2024 at 01:22:12AM +0200, Dmitry Baryshkov wrote: > On Sun, 17 Nov 2024 at 22:54, Laurent Pinchart wrote: > > On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > > > accept const struct drm_disp

Re: [PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Dmitry Baryshkov
On Sun, 17 Nov 2024 at 23:24, Laurent Pinchart wrote: > > Hi Dmitry, > > Thank you for the patch. > > On Fri, Nov 15, 2024 at 11:09:30PM +0200, Dmitry Baryshkov wrote: > > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > > accept const struct drm_display_mode argument. Change t

Re: [PATCH 5/5] drm/connector: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:30PM +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid > callback of drm_connector to also accept const argume

Re: [PATCH 3/5] drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx()

2024-11-17 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:28PM +0200, Dmitry Baryshkov wrote: > Make hda_get_mode_idx() accept const struct drm_display_mode pointer > instead of just raw struct drm_display_mode. This is a preparation to > converting the mode_valid() callback of drm_conne

Re: [PATCH 4/5] drm/connector: make mode_valid_ctx accept const struct drm_display_mode

2024-11-17 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:29PM +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid_ctx > callback of drm_connector to also accept const ar

Re: [PATCH 2/5] drm/amdgpu: don't change mode in amdgpu_dm_connector_mode_valid()

2024-11-17 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:27PM +0200, Dmitry Baryshkov wrote: > Make amdgpu_dm_connector_mode_valid() duplicate the mode during the > test rather than modifying the passed mode. This is a preparation to > converting the mode_valid() callback of drm_connecto

Re: [PATCH 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-11-17 Thread Laurent Pinchart
Hi Dmitry, Thank you for the patch. On Fri, Nov 15, 2024 at 11:09:26PM +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid > callback of drm_encoder_slave to also accept const ar

[PATCH] drm/amd/display: 3.2.310

2024-11-17 Thread Yuan Feng
From: Aric Cyr This version brings along the following: - DC core fixes - DCN35 fix - DCN4+ fixes - DML2 fix - New SPL features Reviewed-by: Alex Hung Signed-off-by: Aric Cyr Signed-off-by: Hamza Mahfooz Tested-by: Daniel Wheeler --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file chang

Re: [PATCH 4/7] drm/vmwgfx: use the new drm_exec object

2024-11-17 Thread kernel test robot
ig: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20241117/202411171611.9lezwwse-...@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411171611.9lezwwse-...@intel.com/reproduce) If you fix