Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Christian König
Am 22.10.24 um 19:09 schrieb Li, Yunxiang (Teddy): [AMD Official Use Only - AMD Internal Distribution Only] It sounds like it makes the most sense to ignore the BOs that have no placement or private placements then, it would simplify the code too. Yeah, that works for me. Regards, Christian.

[PATCH 06/16] drm/amd/display: Refactoring if and endif statements to enable DC_LOGGER

2024-10-22 Thread Tom Chung
From: Lohita Mudimela [Why] For Header related changes for core [How] Refactoring if and endif statements to enable DC_LOGGER Reviewed-by: Mounika Adhuri Reviewed-by: Alvin Lee Signed-off-by: Lohita Mudimela Signed-off-by: Tom Chung --- .../gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mg

[PATCH 15/16] drm/amd/display: [FW Promotion] Release 0.0.240.0

2024-10-22 Thread Tom Chung
From: Taimur Hassan Add some scruct for secure display. Acked-by: Wayne Lin Signed-off-by: Taimur Hassan Signed-off-by: Tom Chung --- .../gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 53 +++ 1 file changed, 44 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 09/16] drm/amd/display: Remove useless assignments and variables

2024-10-22 Thread Tom Chung
From: Alex Hung [WHAT & HOW] misc0, temp and split_pipe are assigned but immediately re-assigned to other values. The early assignments are useless and are removed. Unused variables are removed as well. This fixes 5 UNUSED_VALUE issues reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed

[PATCH 16/16] drm/amd/display: 3.2.307

2024-10-22 Thread Tom Chung
From: Aric Cyr This version brings along following fixes: - Fix polling DSC registers during S0i3 - Fix idle optimizations entry log - Change MPC Tree visual confirm colours - Fix underflow when playing 8K video in full screen mode - Optimize power up sequence for specific OLED Acked-by: Wayne L

[PATCH 14/16] drm/amd/display: store sharpness 1dlut table in dscl_prog_data

2024-10-22 Thread Tom Chung
From: Samson Tam [Why] Previously dscl_prog_data stored pointer to sharpness 1dlut table. SPL had four pre-generated tables, one for each setup. This allowed us to minimize number of times we had to recalculate table when switching between setups. However, with dual display, this becomes an issue

[PATCH 13/16] drm/amd/display: Do not read DSC state if not in use

2024-10-22 Thread Tom Chung
From: Ovidiu Bunea [why & how] DSC may be power gated when coming out of S0i3, so avoid polling DSC registers since it will fail anyways. Only read if it is known that DSC is in use. Reviewed-by: Charlene Liu Signed-off-by: Ovidiu Bunea Signed-off-by: Tom Chung --- .../drm/amd/display/dc/hws

[PATCH 12/16] drm/amd/display: Fix idle optimizations entry log

2024-10-22 Thread Tom Chung
From: Aurabindo Pillai [Why & How] Whether we really enter idle optimizations are decided within DC. Printing into dmesg before calling the DC API gives an incorrect indication that we are entering idle optimization in cases where its disabled manually. To fix this, remove the print in DM and ad

[PATCH 08/16] drm/amd/display: fix handling of max_downscale_src_width fail check in SPL

2024-10-22 Thread Tom Chung
From: Samson Tam [Why] If max_downscale_src_width check fails, we exit early from spl_calculate_scaler_params but dscl_prog_data is not fully populated. If viewport is left at 0, it can cause crash in dml. [How] Call spl_set_dscl_prog_data before we exit early from spl_calculate_scaler_params to

[PATCH 11/16] drm/amd/display: Change MPC Tree visual confirm colours

2024-10-22 Thread Tom Chung
From: Joshua Aberback [Why] MPC background colours that use fractional components look different if MPC OGAM is in use vs in bypass mode. The current red and orange colours look very similar when OGAM is in bypass, so the colours need to change to be consistently very easy to tell apart. [How] U

[PATCH 10/16] drm/amd/display: Simplify dcn35_is_ips_supported()

2024-10-22 Thread Tom Chung
From: Alex Hung [WHAT & HOW] The variable "ips_supported" is redundant and we can return from dcn35_smu_get_ips_supported directly. This fixes 1 UNUSED_VALUE issue reported by Coverity. Reviewed-by: Rodrigo Siqueira Signed-off-by: Alex Hung Signed-off-by: Tom Chung --- drivers/gpu/drm/amd/d

[PATCH 07/16] drm/amd/display: Fix underflow when playing 8K video in full screen mode

2024-10-22 Thread Tom Chung
From: Leo Ma [Why&How] Flickering observed while playing 8k HEVC-10 bit video in full screen mode with black border. We didn't support this case for subvp. Make change to the existing check to disable subvp for this corner case. Reviewed-by: Alvin Lee Signed-off-by: Leo Ma Signed-off-by: Dillo

[PATCH 04/16] Revert "drm/amd/display: update DML2 policy EnhancedPrefetchScheduleAccelerationFinal DCN35"

2024-10-22 Thread Tom Chung
From: Ovidiu Bunea This reverts commit db88df35a509 ("drm/amd/display: update DML2 policy EnhancedPrefetchScheduleAccelerationFinal DCN35") [why & how] The offending commit exposes a hang with lid close/open behavior. Both issues seem to be related to ODM 2:1 mode switching, so there is another

[PATCH 05/16] drm/amd/display: Reduce HPD Detection Interval for IPS

2024-10-22 Thread Tom Chung
From: Fangzhi Zuo Fix DP Compliance test 4.2.1.3, 4.2.2.8, 4.3.1.12, 4.3.1.13 when IPS enabled. Original HPD detection interval is set to 5s which violates DP compliance. Reduce the interval parameter, such that link training can be finished within 5 seconds. Fixes: afca033f10d3 ("drm/amd/displ

[PATCH 03/16] drm/amd/display: Add P-State Stall Timeout Recovery Support for dcn401

2024-10-22 Thread Tom Chung
From: Dillon Varone [WHY&HOW] Adds support for P-State stall timeout detection in DCHUBBUB. Reviewed-by: Alvin Lee Signed-off-by: Dillon Varone Signed-off-by: Tom Chung --- .../dc/dml2/dml21/inc/dml_top_dchub_registers.h | 1 + .../dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 3

[PATCH 02/16] drm/amd/display: Add a boot option to reduce phy ssc for HBR3

2024-10-22 Thread Tom Chung
From: Hansen Dsouza [Why] Spread on DPREFCLK by 0.3 percent can have a negative effect on sink when PHY SSC is also spread by 0.3 percent [How] Add boot option for DMU to lower PHY SSC Reviewed-by: Nicholas Kazlauskas Signed-off-by: Hansen Dsouza Signed-off-by: Tom Chung --- drivers/gpu/drm/

[PATCH 01/16] drm/amd/display: Optimize power up sequence for specific OLED

2024-10-22 Thread Tom Chung
From: Ovidiu Bunea [why & how] OLED power up sequence takes an extra 150ms via hardcoded delay, but there is a strict requirement on DisplayOn resume time. For customer panel, remove these delays to meet target until a cleaner solution is can be put in place. Reviewed-by: Charlene Liu Signed-of

[PATCH 00/16] DC Patches Oct 28 2024

2024-10-22 Thread Tom Chung
This DC patchset brings improvements in multiple areas. In summary, we highlight: - Fix polling DSC registers during S0i3 - Fix idle optimizations entry log - Change MPC Tree visual confirm colours - Fix underflow when playing 8K video in full screen mode - Optimize power up sequence for specific

RE: [PATCH 1/2] drm/amdgpu: add amdgpu_gfx_sched_mask and amdgpu_compute_sched_mask debugfs

2024-10-22 Thread Zhang, Jesse(Jie)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Jiadong, -Original Message- From: Zhu, Jiadong Sent: Wednesday, October 23, 2024 11:10 AM To: Zhang, Jesse(Jie) ; Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Koenig, Christian Subject: RE: [PATC

[PATCH] drm/amd/pm: correct the workload setting

2024-10-22 Thread Kenneth Feng
Correct the workload setting in order not to mix the setting with the end user. Update the workload mask accordingly. Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 17 ++-- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 4 +- .../drm/amd/pm/swsmu/smu13/smu

RE: [PATCH v4 3/3] drm/amdgpu/sdma4.4.2: implement ring reset callback for sdma4.4.2

2024-10-22 Thread Zhu, Jiadong
[AMD Official Use Only - AMD Internal Distribution Only] Ping on the series. Thanks, Jiadong > -Original Message- > From: Zhu, Jiadong > Sent: Wednesday, October 16, 2024 2:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Lazar, Lijo > ; Zhu, Jiadong > Subject: [PAT

RE: [PATCH 1/2] drm/amdgpu: add amdgpu_gfx_sched_mask and amdgpu_compute_sched_mask debugfs

2024-10-22 Thread Zhu, Jiadong
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Zhang, > Jesse(Jie) > Sent: Tuesday, October 22, 2024 11:12 AM > To: Zhang, Jesse(Jie) ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > > Subject: RE:

[PATCH 5/5 V2] drm/amdgpu: Add sysfs interface for jpeg reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add the sysfs interface for jpeg: jpeg_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead of some flags (Christian) Signed

[PATCH 4/5 V2] drm/amdgpu: Add sysfs interface for vpe reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add the sysfs interface for vpe: vpe_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead of some flags (Christian) Sign

[PATCH 3/5 V2] drm/amdgpu: Add sysfs interface for vcn reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add the sysfs interface for vcn: vcn_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead of some flags (Christian) Signed-o

[PATCH 1/5 V2] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add two sysfs interfaces for gfx and compute: gfx_reset_mask compute_reset_mask These interfaces are read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead

[PATCH 2/5 V2] drm/amdgpu: Add sysfs interface for sdma reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add the sysfs interface for sdma: sdma_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. V2: the sysfs node returns a text string instead of some flags (Christian) Signed

RE: [PATCH] drm/amdgpu: avoid dummy_read_page overlapping mappings

2024-10-22 Thread Liang, Prike
[AMD Official Use Only - AMD Internal Distribution Only] Hold on to this patch for a while. I need to further investigate whether it requires allocating a separate page for the second VGA device. Thanks, Prike > -Original Message- > From: Liang, Prike > Sent: Tuesday, October 22, 2024

Re: [PATCH] drm/amdgpu: Add dcn30 drm_panic support

2024-10-22 Thread Jocelyn Falempe
On 22/10/2024 22:10, Alex Deucher wrote: On Fri, Oct 4, 2024 at 5:09 AM Jocelyn Falempe wrote: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. It should work on all readeon using amdgpu_dm_plane.c, when the

Re: [PATCH] drm/amdgpu: Add dcn30 drm_panic support

2024-10-22 Thread Alex Deucher
On Fri, Oct 4, 2024 at 5:09 AM Jocelyn Falempe wrote: > > Add support for the drm_panic module, which displays a pretty user > friendly message on the screen when a Linux kernel panic occurs. > > It should work on all readeon using amdgpu_dm_plane.c, when the radeon > framebuffer is linear (like

[PATCH] drm/amdkfd: flag per-queue reset support for gfx9

2024-10-22 Thread Jonathan Kim
Flag KFD support for per-queue reset on GFX9 devices. Signed-off-by: Jonathan Kim --- drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 2 ++ include/uapi/linux/kfd_sysfs.h| 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/dr

RE: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] It sounds like it makes the most sense to ignore the BOs that have no placement or private placements then, it would simplify the code too. Teddy

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Christian König
Am 22.10.24 um 18:46 schrieb Li, Yunxiang (Teddy): [Public] I suppose we could add a field like amd-memory-private: to cover the private placements. No, that is not really appropriate either. GWS, GDS and OA are not memory in the first place. Those BOs are HW blocks which the driver alloca

RE: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Li, Yunxiang (Teddy)
[Public] I suppose we could add a field like amd-memory-private: to cover the private placements. When would a BO not have a placement, is it when it is being moved? Since we are tracking the state changes, I wonder if such situations can be avoided now so whenever we call these stat update fun

Re: [PATCH] drm/amdgpu: enable userqueue support for GFX12

2024-10-22 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Thanks Alex, I have created an integration branch for GFX12, and cleaned up and ported these patches. We will finish testing and start the code review of these patches soon. Regards Shashank From: Alex Deuc

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Christian König
Am 22.10.24 um 17:17 schrieb Li, Yunxiang (Teddy): [Public] +static uint32_t fold_memtype(uint32_t memtype) { In general please add prefixes to even static functions, e.g. amdgpu_vm_ or amdgpu_bo_. + /* Squash private placements into 'cpu' to keep the legacy userspace view. */ + switch

Re: [PATCH 1/2] drm/amd/display: increase max surfaces in line with planes and streams

2024-10-22 Thread Melissa Wen
Hi, Gentle ping to land the fix for the kernel crash. If faster, I can send a new version increasing max surfaces to 4 as previously discussed. There are now two bug reports for the same issue: - https://gitlab.freedesktop.org/drm/amd/-/issues/3693 - https://gitlab.freedesktop.org/drm/amd/-/is

RE: [PATCH] drm/amdgpu: Increase MES log buffer to dump mes scratch data

2024-10-22 Thread Liu, Shaoyun
[AMD Official Use Only - AMD Internal Distribution Only] ping -Original Message- From: amd-gfx On Behalf Of Liu, Shaoyun Sent: Friday, October 11, 2024 12:57 PM To: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: Increase MES log buffer to dump mes scratch data [AMD Offi

RE: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Li, Yunxiang (Teddy)
[Public] > > > > +static uint32_t fold_memtype(uint32_t memtype) { > > In general please add prefixes to even static functions, e.g. amdgpu_vm_ or > amdgpu_bo_. > > > + /* Squash private placements into 'cpu' to keep the legacy userspace > > view. > */ > > + switch (mem_type) { > > + case T

Re: [PATCH v2] drm/amdgpu: Fix the logic for NPS request failure

2024-10-22 Thread Alex Deucher
On Fri, Oct 18, 2024 at 2:35 AM Lijo Lazar wrote: > > On a hive, NPS request is placed by the first one for all devices in the > hive. If the request fails, mark the mode as UNKNOWN so that subsequent > devices on unload don't request it. Also, fix the mutex double lock > issue in error condition,

Re: [PATCH] drm/amdkfd: remove extra use of volatile

2024-10-22 Thread Alex Deucher
On Tue, Oct 22, 2024 at 10:03 AM Victor Zhao wrote: > > as the adding of mb() should be sufficient in function unmap_queues_cpsch, > remove the add of volatile type as recommended > > Signed-off-by: Victor Zhao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager

Re: [PATCH] drm/amdkfd: remove extra use of volatile

2024-10-22 Thread Christian König
Am 22.10.24 um 15:53 schrieb Victor Zhao: as the adding of mb() should be sufficient in function unmap_queues_cpsch, remove the add of volatile type as recommended Signed-off-by: Victor Zhao Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- d

Re: [PATCH] drm/amdgpu: handle default profile on on devices without fullscreen 3D

2024-10-22 Thread Lazar, Lijo
On 10/22/2024 7:20 PM, Alex Deucher wrote: > Some devices do not support fullscreen 3D. > > v2: Make the check generic. > > Fixes: 336568de918e ("drm/amdgpu/swsmu: default to fullscreen 3D profile for > dGPUs") > Signed-off-by: Alex Deucher > Cc: Kenneth Feng > Cc: Lijo Lazar Reviewed-by:

[PATCH] drm/amdkfd: remove extra use of volatile

2024-10-22 Thread Victor Zhao
as the adding of mb() should be sufficient in function unmap_queues_cpsch, remove the add of volatile type as recommended Signed-off-by: Victor Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.h | 2 +- 2 files changed, 2

[PATCH] drm/amdgpu: handle default profile on on devices without fullscreen 3D

2024-10-22 Thread Alex Deucher
Some devices do not support fullscreen 3D. v2: Make the check generic. Fixes: 336568de918e ("drm/amdgpu/swsmu: default to fullscreen 3D profile for dGPUs") Signed-off-by: Alex Deucher Cc: Kenneth Feng Cc: Lijo Lazar --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 11 ++- 1 file chang

Re: [PATCH] drm/amdkfd: fix the hang caused by the write reorder to fence_addr

2024-10-22 Thread Philip Yang
On 2024-10-21 04:12, Christian König wrote: Am 18.10.24 um 23:59 schrieb Philip Yang: On 2024-10-18 14:28, Felix Kuehling wrote: On 2024-10-17 04:34, Victor Zhao wrote: make sure KFD_FENC

Re: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1

2024-10-22 Thread Alex Deucher
Please double check the COMPUTE profile set by KFD as well. Thanks, Alex On Mon, Oct 21, 2024 at 9:18 PM Feng, Kenneth wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alex, > > I have found another problem with the current code based on the default > workload setting t

Re: [PATCH v2] drm/amdgpu: Fix the logic for NPS request failure

2024-10-22 Thread Lazar, Lijo
On 10/18/2024 12:05 PM, Lijo Lazar wrote: > On a hive, NPS request is placed by the first one for all devices in the > hive. If the request fails, mark the mode as UNKNOWN so that subsequent > devices on unload don't request it. Also, fix the mutex double lock > issue in error condition, should h

Re: [PATCH] drm/amdgpu: Fix kernel config name for gfx-userqueue

2024-10-22 Thread Sharma, Shashank
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Shashank Sharma Regards Shashank From: Yadav, Arvind Sent: Tuesday, October 22, 2024 2:58 PM To: Sharma, Shashank ; amd-gfx@lists.freedesktop.org Cc: Yadav, Arvind ; Yadav, Arvind Subject:

[PATCH] drm/amdgpu: Fix kernel config name for gfx-userqueue

2024-10-22 Thread Arvind Yadav
DRM_AMD_USERQ_GFX was an old config flag and the new config flag name is updated later which was missing. Cc: Shashank Sharma Signed-off-by: Arvind Yadav --- drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx

Re: [PATCH 29/32] drm/amdgpu: dump_ip_state for each vcn instance

2024-10-22 Thread Khatri, Sunil
Hello Boyuan It probably wont work fine as memory allocated for core dump also needs to change based on ip design where not we have an ip_block for each instance too. So here is what i think and let me know if that sounds fine with you. Once you get the review complete for patches #1 - #27 g

RE: [PATCH] drm/amdgpu: Reduce redundant gpu resets on nbio v7.4

2024-10-22 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Tuesday, October 22, 2024 2:33 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Li, Candice ; Wang, Yang(Kevin) > ; Yang, Stanley

Re: [PATCH 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-22 Thread Christian König
Am 22.10.24 um 09:59 schrieb jesse.zh...@amd.com: Add two sysfs interfaces for gfx and compute: gfx_reset_mask compute_reset_mask These interfaces are read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe rese

Re: [PATCH] drm/amdgpu: handle default profile on GC 9.4.1

2024-10-22 Thread Lazar, Lijo
On 10/19/2024 12:50 AM, Alex Deucher wrote: > It does not support fullscreen 3D. > > Fixes: 336568de918e ("drm/amdgpu/swsmu: default to fullscreen 3D profile for > dGPUs") > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ++- > 1 file changed, 2 insertions(

RE: [PATCH 29/32] drm/amdgpu: dump_ip_state for each vcn instance

2024-10-22 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] Validate the ip dump date first for vcn before committing. I reviewed based on the code changes as it looks fine. From: amd-gfx On Behalf Of Khatri, Sunil Sent: Tuesday, October 22, 2024 2:27 PM To: Zhang, Boyuan ; amd-gfx@lists.freedeskt

Re: [PATCH 29/32] drm/amdgpu: dump_ip_state for each vcn instance

2024-10-22 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri > On 10/17/2024 6:50 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Perform dump_ip_state only for the instance of the current vcn IP block, instead of perform it for all vcn instances. Signed-off-by: Boyuan Zhang --- drivers/g

Re: [PATCH 28/32] drm/amdgpu: print_ip_state for each vcn instance

2024-10-22 Thread Khatri, Sunil
Reviewed-by: Sunil Khatri > On 10/17/2024 6:50 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Perform print_ip_state only for the instance of the current vcn IP block, instead of perform it for all vcn instances. Signed-off-by: Boyuan Zhang --- drivers/

Re: [PATCH] amdkfd: Explicitly specify data type amdkfd_process_info in related functions

2024-10-22 Thread Zhu Lingshan
On 10/22/2024 12:20 PM, Felix Kuehling wrote: > > On 2024-10-14 23:51, Zhu Lingshan wrote: >> This commit specifies data type struct amdkfd_process_info >> rather than general void* in ralted functions. > Several interfaces in amdgpu_amdkfd.h use void * as opaque pointers, e.g. > process_info,

[PATCH 3/5] drm/amdgpu: Add sysfs interface for vcn reset mask

2024-10-22 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Add the sysfs interface for vcn: vcn_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. Signed-off-by: Jesse Zhang Suggested-by:Alex Deucher

[PATCH 5/5] drm/amdgpu: Add sysfs interface for jpeg reset mask

2024-10-22 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Add the sysfs interface for jpeg: jpeg_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. Signed-off-by: Jesse Zhang Suggested-by:Alex Deuche

[PATCH 1/5] drm/amdgpu: Add sysfs interface for gc reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add two sysfs interfaces for gfx and compute: gfx_reset_mask compute_reset_mask These interfaces are read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. Signed-off-by: Jesse Zhang Suggested-by:Alex De

[PATCH 4/5] drm/amdgpu: Add sysfs interface for vpe reset mask

2024-10-22 Thread jesse.zh...@amd.com
From: "jesse.zh...@amd.com" Add the sysfs interface for vpe: vpe_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. Signed-off-by: Jesse Zhang Suggested-by:Alex Deuc

[PATCH 2/5] drm/amdgpu: Add sysfs interface for sdma reset mask

2024-10-22 Thread jesse.zh...@amd.com
Add the sysfs interface for sdma: sdma_reset_mask The interface is read-only and show the resets supported by the IP. For example, full adapter reset (mode1/mode2/BACO/etc), soft reset, queue reset, and pipe reset. Signed-off-by: Jesse Zhang Suggested-by:Alex Deucher --- drivers/gpu/drm/amd/am

Re: [PATCH 08/32] drm/amdgpu: pass ip_block in set_clockgating_state

2024-10-22 Thread Khatri, Sunil
On 10/17/2024 6:50 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Pass ip_block instead of adev in set_clockgating_state() and is_idle() callback functions. Modify set_clockgating_state() and is_idle() ip functions for all correspoding ip blocks. Signed-off-by: Boyuan Zhang --- driver

Re: [PATCH v5 4/4] drm/amdgpu: track bo memory stats at runtime

2024-10-22 Thread Christian König
Am 18.10.24 um 15:33 schrieb Yunxiang Li: Before, every time fdinfo is queried we try to lock all the BOs in the VM and calculate memory usage from scratch. This works okay if the fdinfo is rarely read and the VMs don't have a ton of BOs. If either of these conditions is not true, we get a massiv

Re: [PATCH 07/32] drm/amdgpu: pass ip_block in set_powergating_state

2024-10-22 Thread Khatri, Sunil
On 10/17/2024 6:50 PM, boyuan.zh...@amd.com wrote: From: Boyuan Zhang Pass ip_block instead of adev in set_powergating_state callback function. Modify set_powergating_state ip functions for all correspoding ip blocks. v2: fix a ip block index error. Signed-off-by: Boyuan Zhang Suggested-by

Re: [PATCH v5 3/4] drm/amdgpu: stop tracking visible memory stats

2024-10-22 Thread Christian König
Am 18.10.24 um 15:33 schrieb Yunxiang Li: Since on modern systems all of vram can be made visible anyways, to simplify the new implementation, drops tracking how much memory is visible for now. If this is really needed we can add it back on top of the new implementation, or just report all the BO

[PATCH] drm/amdgpu: avoid dummy_read_page overlapping mappings

2024-10-22 Thread Prike Liang
In the A+A system, the dummy_read_page is mapped twice during the device graphics memory software initialization. To avoid page remapping, export the ttm_glob_use_count to the driver for checking whether the same page has already been mapped. Signed-off-by: Prike Liang --- drivers/gpu/drm/amd/a

Re: [PATCH v5 2/4] drm/amdgpu: make drm-memory-* report resident memory

2024-10-22 Thread Christian König
Am 18.10.24 um 15:33 schrieb Yunxiang Li: The old behavior reports the resident memory usage for this key and the documentation say so as well. However this was accidentally changed to include buffers that was evicted. Fixes: a2529f67e2ed ("drm/amdgpu: Use drm_print_memory_stats helper from fdi