On 9/10/2024 10:45 AM, Jane Jian wrote:
> write OP of HDP_DEBUG1(0x3fbc) is no longer functional, so remove it.
>
You may copy the title/description from the one I shared -
Subj: Remove unneeded write in JPEG v4.0.3
Desc:
HDP_DEBUG1(offset = 0x3fbc) is no longer functional, remove the
redun
Thanks, I will try clearing with compute and check the performance.
Regards,
Arun.
On 9/6/2024 7:37 PM, Marek Olšák wrote:
Can you also bump the DRM version, so that userspace knows when to
skip its own clear?
Also, clearing with SDMA takes up to 33 times more time (= is up to
97% slower) than
[AMD Official Use Only - AMD Internal Distribution Only]
Yes, thank you for the suggestion. There will be a separate patch for cleaning
up the setting and checking of the suspend_complete flag.
Thanks,
Prike
> -Original Message-
> From: Alex Deucher
> Sent: Monday, September 9, 2024 11
On 9/10/2024 9:29 AM, Tao Zhou wrote:
> The feature is not applicable to specific app platform.
>
> v2: update the disablement condition and commit description
>
> Signed-off-by: Tao Zhou
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff -
write OP of HDP_DEBUG1(0x3fbc) is no longer functional, so remove it.
Signed-off-by: Jane Jian
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
b/drivers/gpu/drm/amd/amdgpu/jpeg_v4
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx On Behalf Of Tao Zhou
Sent: Tuesday, September 10, 2024 11:59
To: amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: [PATCH] drm/amdgpu: disable GPU
The feature is not applicable to specific app platform.
v2: update the disablement condition and commit description
Signed-off-by: Tao Zhou
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
b/drivers/gpu
From: Jiadong Zhu
Implement sdma queue reset callback using mes_reset_queue_mmio.
v2: check instance id before reset queue.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/amd
From: Jiadong Zhu
Reset sdma queue through mmio based on me_id and queue_id.
v2: simplify callflows and register calculation.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +-
drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 27 -
2 files changed
From: Jiadong Zhu
Extract the resume sequence for individual sdma instance from
sdma_v6_0_gfx_resume.
The function could be used for start/restart scenario on a certain instance.
Signed-off-by: Jiadong Zhu
---
drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 240 ++---
1 file chan
Hi Maintainers,
On 28/05/24 10:19, Vignesh Raman wrote:
Hi Maintainers,
There are some flaky tests reported for amdgpu driver testing in drm-ci.
# Board Name: hp-11A-G6-EE-grunt
# IGT Version: 1.28-g0df7b9b97
# Linux Version: 6.9.0-rc7
# Failure Rate: 50
kms_async_flips@async-flip-with-page-fl
On Mon, Sep 2, 2024 at 4:03 AM Lijo Lazar wrote:
>
> A reset on initialization will be needed if a new PSP TOS needs to be
> loaded than the one currently active on the system. This is possible
> only on SOCs which support a full device reset which results in unload
> of active PSP TOS.
>
> Signed
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Add interface to check if a different TOS needs to be loaded than the
> one which is which is already active on the SOC. Presently the interface
> is restricted to specific variants of PSPv13.0.
>
> Signed-off-by: Lijo Lazar
Reviewed-by: Alex
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Add XGMI reset on init support to aldebaran and SOCs with GC v9.4.3.
>
> Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/aldebaran.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Drop delayed reset work handler as it is no longer used.
>
> Signed-off-by: Lijo Lazar
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 --
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 80 ---
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Use XGMI hive information to rely on resetting XGMI devices on
> initialization rather than using mgpu structure. mgpu structure may have
> other devices as well.
>
> Signed-off-by: Lijo Lazar
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
On Mon, Sep 2, 2024 at 3:53 AM Lijo Lazar wrote:
>
> Add a separate function to read badpage data during initialization.
> Reading bad pages will need hardware access and cannot be done during
> reset. Hence in cases where device needs a full reset during
> init itself, attempting to read will cau
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> In some cases, device needs to be reset before first use. Add handlers
> for doing device reset during driver init sequence.
>
> Signed-off-by: Lijo Lazar
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
> drivers/gpu/drm/amd/amdgpu/
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Move the reinitialization part after a reset to another function. No
> functional changes.
>
> Signed-off-by: Lijo Lazar
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 +
> drivers/gpu/drm/amd/amdgpu/amdgpu_
With the error Feifei mentioned fixed,
Reviewed-by: Alex Deucher
On Mon, Sep 2, 2024 at 4:13 AM Lijo Lazar wrote:
>
> Drop pending_reset flag in gmc block. Instead use init level to
> determine which type of init is preferred - in this case MINIMAL.
>
> Signed-off-by: Lijo Lazar
> ---
> driver
On Mon, Sep 9, 2024 at 4:57 PM Alex Deucher wrote:
>
> On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
> >
> > Add init levels to define the level to which device needs to be
> > initialized.
> >
> > Signed-off-by: Lijo Lazar
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu.h| 14 ++
>
On Mon, Sep 2, 2024 at 3:34 AM Lijo Lazar wrote:
>
> Add init levels to define the level to which device needs to be
> initialized.
>
> Signed-off-by: Lijo Lazar
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h| 14 ++
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 54
On Mon, Sep 9, 2024 at 4:18 PM Shashank Sharma wrote:
>
> From: Shashank Sharma
>
> This reverts commit 81af32520e7aaa337fe132f16c12ce54170187ea.
>
> This commit prevents a usermode queue client to get the shadow related
> information.
>
> Signed-off-by: Shashank Sharma
> ---
> drivers/gpu/drm/
[AMD Official Use Only - AMD Internal Distribution Only]
Acked-by: Leo Liu
> -Original Message-
> From: Lazar, Lijo
> Sent: September 6, 2024 4:46 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhang, Hawking ; Deucher, Alexander
> ; Liu, Leo ; Jian, Jane
> ; Lu, Victor Cheng Chi (Victor)
This patch adds userqueue suspend/resume functions at
core MES V11 IP level.
V2: use true/false for queue_active status (Christian)
added Christian's R-B
V3: reset/set queue status in mqd.create and mqd.destroy
Cc: Alex Deucher
Cc: Christian Koenig
Reviewed-by: Christian Koenig
Signed-off
From: Shashank Sharma
This reverts commit 81af32520e7aaa337fe132f16c12ce54170187ea.
This commit prevents a usermode queue client to get the shadow related
information.
Signed-off-by: Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 8 ++--
1 file changed, 2 insertions(+), 6 de
This patch adds support for userqueue resume. What it typically does is
this:
- adds a new delayed work for resuming all the queues.
- schedules this delayed work from the suspend work.
- validates the BOs and replaces the eviction fence before resuming all
the queues running under this instance
From: Arvind Yadav
This reverts commit 6be2ad4f0073c541146caa66c5ae936c955a8224.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 7823faa3dbaa..2e3c974a3340
From: Arvind Yadav
Current MES GFX mask prevents FW to enable oversubscription. This patch
does the following:
- Fixes the mask values and adds a description for the same
- Removes the central mask setup and makes it IP specific, as it would
be different when the number of pipes and queues are
This patch adds suspend support for gfx userqueues. It typically does
the following:
- adds an enable_signaling function for the eviction fence, so that it
can trigger the userqueue suspend,
- adds a delayed function for suspending the userqueues, to suspend all
the queues under this userq mana
From: Arvind Yadav
This patch adds input fences to VM_IOCTL for unmapping an object.
The kernel will unmap the BO only when the fence is signaled.
V2: Bug fix (Arvind)
V3: Bug fix (Arvind)
V4: Rename UAPI objects as per UAPI review (Marek)
Cc: Alex Deucher
Cc: Christian Koenig
Signed-off-by:
This patch:
- adds a kernel config option "CONFIG_DRM_AMD_USERQ_GFX"
- moves the usequeue initialization code for all IPs under
this flag
so that the userqueue works only when the config is enabled.
V9: Introduce this patch
V10: Call it CONFIG_DRM_AMDGPU_NAVI3X_USERQ instead of
CONFIG_DRM
This patch adds basic eviction fence framework for the gfx buffers.
The idea is to:
- One eviction fence is created per gfx process, at kms_open.
- This fence is attached to all the gem buffers created
by this process.
- This fence is detached to all the gem buffers at postclose_kms.
This framew
From: Arvind Yadav
This patch does necessary modifications to enable the SDMA
usermode queues using the existing userqueue infrastructure.
V9: introduced this patch in the series
V10: use header file instead of extern (Alex)
V11: rename drm_amdgpu_userq_mqd_sdma_gfx_v11 to
drm_amdgpu_userq
This patch updates the VM_IOCTL to allow userspace to synchronize
the mapping/unmapping of a BO in the page table.
The major changes are:
- it adds a drm_timeline object as an input parameter to the VM IOCTL.
- this object is used by the kernel to sync the update of the BO in
the page table duri
This patch enables GFX-v11 IP support in the usermode queue base
code. It typically:
- adds a GFX_v11 specific MQD structure
- sets IP functions to create and destroy MQDs
- sets MQD objects coming from userspace
V10: introduced this spearate patch for GFX V11 enabling (Alex).
V11: Addressed revie
This patch does the necessary changes required to
enable compute workload support using the existing
usermode queues infrastructure.
V9: Patch introduced
V10: Add custom IP specific mqd strcuture for compute (Alex)
V11: Rename drm_amdgpu_userq_mqd_compute_gfx_v11 to
drm_amdgpu_userq_mqd_comp
The userspace sends us the doorbell object and the relative doobell
index in the object to be used for the usermode queue, but the FW
expects the absolute doorbell index on the PCI BAR in the MQD. This
patch adds a function to convert this relative doorbell index to
absolute doorbell index.
V5: F
To support oversubscription, MES FW expects WPTR BOs to
be mapped into GART, before they are submitted to usermode
queues. This patch adds a function for the same.
V4: fix the wptr value before mapping lookup (Bas, Christian).
V5: Addressed review comments from Christian:
- Either pin object
This patch adds code to cleanup any leftover userqueues which
a user might have missed to destroy due to a crash or any other
programming error.
V7: Added Alex's R-B
V8: Rebase
V9: Rebase
V10: Rebase
Cc: Alex Deucher
Cc: Christian Koenig
Reviewed-by: Alex Deucher
Suggested-by: Bas Nieuwenhu
This patch adds new functions to map/unmap a usermode queue into
the FW, using the MES ring. As soon as this mapping is done, the
queue would be considered ready to accept the workload.
V1: Addressed review comments from Alex on the RFC patch series
- Map/Unmap should be IP specific.
V2:
The MES FW expects us to allocate at least one page as context
space to process gang and process related context data. This
patch creates a joint object for the same, and calculates GPU
space offsets of these spaces.
V1: Addressed review comments on RFC patch:
Alex: Make this function IP speci
A Memory queue descriptor (MQD) of a userqueue defines it in
the hw's context. As MQD format can vary between different
graphics IPs, we need gfx GEN specific handlers to create MQDs.
This patch:
- Adds a new file which will be used for MES based userqueue
functions targeting GFX and SDMA IP.
-
This patch introduces amdgpu_userqueue_object and its helper
functions to creates and destroy this object. The helper
functions creates/destroys a base amdgpu_bo, kmap/unmap it and
save the respective GPU and CPU addresses in the encapsulating
userqueue object.
These helpers will be used to create
This patch adds:
- A new IOCTL function to create and destroy
- A new structure to keep all the user queue data in one place.
- A function to generate unique index for the queue.
V1: Worked on review comments from RFC patch series:
- Alex: Keep a list of queues, instead of single queue per proce
This patch adds IP independent skeleton code for amdgpu
usermode queue. It contains:
- A new files with init functions of usermode queues.
- A queue context manager in driver private data.
V1: Worked on design review comments from RFC patch series:
(https://patchwork.freedesktop.org/series/112214/
From: Alex Deucher
This patch intorduces new UAPI/IOCTL for usermode graphics
queue. The userspace app will fill this structure and request
the graphics driver to add a graphics work queue for it. The
output of this UAPI is a queue id.
This UAPI maps the queue into GPU, so the graphics app can s
This patch series introduces base code of AMDGPU usermode queues for gfx
workloads. Usermode queues is a method of GPU workload submission into the
graphics hardware without any interaction with kernel/DRM schedulers. In
this method, a userspace graphics application can create its own workqueue
and
Am 09.09.24 um 18:02 schrieb Kim, Jonathan:
[Public]
-Original Message-
From: Christian König
Sent: Thursday, September 5, 2024 10:24 AM
To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org
Cc: Kuehling, Felix ; Deucher, Alexander
; Joshi, Mukul
Subject: Re: [PATCH] drm/amdkfd: fix vm-pa
[AMD Official Use Only - AMD Internal Distribution Only]
Should also probably fix
rsetore -> restore
as well
Kent
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Monday, September 9, 2024 1:56 PM
> To: Zhang, Jesse(Jie)
> Cc: amd-gfx@lists.freedesktop.org; D
On 2024-08-29 10:55, Xaver Hugl wrote:
> Hi,
>
> I have a WIP implementation of this for KWin at
> https://invent.kde.org/plasma/kwin/-/commits/work/zamundaaa/drm-colorop.
> It maps KWin's color pipeline to the drm one to get (primary plane
> only, for now) direct scanout of HDR content on SDR
On Sun, Sep 8, 2024 at 9:20 PM jesse.zh...@amd.com wrote:
>
> To avoid memory leaks, release q_extra_data when exiting the restore queue.
> v2: Correct the proto (Alex)
should be criu, not riu.
Alex
>
> Signed-off-by: Jesse Zhang
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
On Mon, Sep 9, 2024 at 7:37 AM Thomas Zimmermann wrote:
>
> Call drm_client_setup() to run the kernel's default client setup
> for DRM. Set fbdev_probe in struct drm_driver, so that the client
> setup can start the common fbdev client.
>
> Signed-off-by: Thomas Zimmermann
> Cc: Zack Rusin
> Cc:
On 2024-09-09 13:19, Alex Deucher wrote:
> Ping?
>
> Alex
>
> On Fri, Sep 6, 2024 at 12:43 PM Alex Deucher
> wrote:
>>
>> Per the comments, these are variable sized arrays.
>>
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3613
>> Signed-off-by: Alex Deucher
Reviewed-by: Harry Wen
On Mon, Sep 9, 2024 at 2:48 AM Ma Ke wrote:
>
> In dcn32_enable_phantom_plane, we should better check null pointer before
> accessing various structs.
>
> Cc: sta...@vger.kernel.org
> Fixes: 235c67634230 ("drm/amd/display: add DCN32/321 specific files for
> Display Core")
> Signed-off-by: Ma Ke
Ping?
Alex
On Fri, Sep 6, 2024 at 12:43 PM Alex Deucher wrote:
>
> Per the comments, these are variable sized arrays.
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3613
> Signed-off-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/include/atomfirmware.h | 4 ++--
> 1 file changed, 2
From: Tvrtko Ursulin
Christian suggested to rename the lock and improve the documentation of
what it protects. And to also re-order the structure members so all
protected by the lock are together in a block.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Alex Deucher
Cc: Luben Tuikov
From: Tvrtko Ursulin
Having removed one re-lock cycle on the entity->lock in a patch titled
"drm/sched: Optimise drm_sched_entity_push_job", with only a tiny bit
larger refactoring we can do the same optimisation on the rq->lock.
(Currently both drm_sched_rq_add_entity() and
drm_sched_rq_update_f
From: Tvrtko Ursulin
It does not seem there is a need to set the current entity in FIFO mode
since ot only serves as being a "cursor" in round-robin mode. Even if
scheduling mode is changed at runtime the change in behaviour is simply
to restart from the first entity, instead of continuing in RR
From: Tvrtko Ursulin
Entities run queue can change during drm_sched_entity_push_job() so make
sure to update the score consistently.
Signed-off-by: Tvrtko Ursulin
Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple
queues")
Cc: Nirmoy Das
Cc: Christian König
Cc: Luben
From: Tvrtko Ursulin
Without the locking amdgpu currently can race between
amdgpu_ctx_set_entity_priority() (via drm_sched_entity_modify_sched()) and
drm_sched_job_arm(), leading to the latter accesing potentially
inconsitent entity->sched_list and entity->num_sched_list pair.
v2:
* Improve com
From: Tvrtko Ursulin
Lets re-order the members to make it clear which are protected by the lock
and at the same time document it via kerneldoc.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Alex Deucher
Cc: Luben Tuikov
Cc: Matthew Brost
Cc: Philipp Stanner
---
include/drm/gpu_sch
From: Tvrtko Ursulin
In FIFO mode We can avoid dropping the lock only to immediately re-acquire
by adding a new drm_sched_rq_update_fifo_locked() helper.
Signed-off-by: Tvrtko Ursulin
Cc: Christian König
Cc: Alex Deucher
Cc: Luben Tuikov
Cc: Matthew Brost
Cc: Philipp Stanner
---
drivers/g
From: Tvrtko Ursulin
Since drm_sched_entity_modify_sched() can modify the entities run queue,
lets make sure to only dereference the pointer once so both adding and
waking up are guaranteed to be consistent.
Alternative of moving the spin_unlock to after the wake up would for now
be more problem
From: Tvrtko Ursulin
Re-spin of the series from two days ago with review feedback addressed and
some new patches added.
Changelog is in individual patches but essentially new patches are renames
and struct members re-ordering as discussed in v1, plus one more optimisation
when I noticed we can s
On 2024-09-09 13:11, Alex Deucher wrote:
> On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi
> wrote:
>>
>> On 9/8/24 09:35, Christopher Snowhill wrote:
>>
>>> On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote:
From: Tobias Jakobi
Hello,
this fixes a nasty race condition in
On Sun, Sep 8, 2024 at 7:23 AM Tobias Jakobi
wrote:
>
> On 9/8/24 09:35, Christopher Snowhill wrote:
>
> > On Mon Sep 2, 2024 at 2:40 AM PDT, tjakobi wrote:
> >> From: Tobias Jakobi
> >>
> >> Hello,
> >>
> >> this fixes a nasty race condition in the set_drr() callbacks for DCN10
> >> and DCN35 th
On Mon, Sep 9, 2024 at 5:54 AM wrote:
>
> From: Jiadong Zhu
>
> Implement sdma queue reset callback using mes_reset_queue_mmio.
> Extract sdma resume sequence from sdma_v6_0_gfx_resume for queue restarting.
Might make more sense to split this patch in two. One patch to split
out the per instanc
On Mon, Sep 9, 2024 at 5:54 AM wrote:
>
> From: Jiadong Zhu
>
> Reset sdma queue through mmio based on me_id and queue_id.
>
> Signed-off-by: Jiadong Zhu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 53 -
> 2 files
On Mon, Sep 9, 2024 at 8:23 AM Christian König wrote:
>
> Adding Leo as well.
>
> Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin:
> > From: Tvrtko Ursulin
> >
> > According to Christian the dynamic DRM priority override was only
> > interesting before the hardware priority (dona via
> > drm_sched_en
On Fri, Sep 06, 2024 at 07:06:14PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> In a recent conversation with Christian there was a thought that
> drm_sched_entity_modify_sched() should start using the entity->rq_lock to be
> safe against job submission and simultaneous priority change
[Public]
> -Original Message-
> From: Christian König
> Sent: Thursday, September 5, 2024 10:24 AM
> To: Kim, Jonathan ; amd-gfx@lists.freedesktop.org
> Cc: Kuehling, Felix ; Deucher, Alexander
> ; Joshi, Mukul
> Subject: Re: [PATCH] drm/amdkfd: fix vm-pasid lookup for multiple partition
On Mon, Sep 9, 2024 at 8:58 AM Liang, Prike wrote:
>
> [AMD Official Use Only - AMD Internal Distribution Only]
>
>
> Previously, the S3 process aborted before calling the noirq suspend, and this
> issue was successfully sorted by checking the suspend_complete flag. However,
> there are now some
Am 09.09.24 um 15:27 schrieb Tvrtko Ursulin:
On 09/09/2024 13:46, Philipp Stanner wrote:
On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote:
[SNIP]
That could also be a great opportunity for improving the lock
naming:
Well that comment made me laugh because I point out the same when
th
On Mon, 2024-09-09 at 14:27 +0100, Tvrtko Ursulin wrote:
>
> On 09/09/2024 13:46, Philipp Stanner wrote:
> > On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote:
> > >
> > > On 09/09/2024 13:18, Christian König wrote:
> > > > Am 09.09.24 um 14:13 schrieb Philipp Stanner:
> > > > > On Mon, 202
On 06/09/2024 19:12, Alex Deucher wrote:
On Wed, Sep 4, 2024 at 4:36 AM Tvrtko Ursulin wrote:
On 21/08/2024 21:47, Alex Deucher wrote:
On Tue, Aug 13, 2024 at 9:57 AM Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Currently it is not well defined what is drm-memory- compared to other
cate
> Date: Tue, 11 Apr 2023 10:52:48 +0200
>
> The address of a data structure member was determined before
> a corresponding null pointer check in the implementation of
> the function “amdgpu_ras_interrupt_dispatch”.
>
> Thus avoid the risk for undefined behaviour by moving the assignment
> for the v
On 09/09/2024 13:18, Christian König wrote:
Am 09.09.24 um 14:13 schrieb Philipp Stanner:
On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote:
Am 09.09.24 um 11:44 schrieb Philipp Stanner:
On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Without the locki
On 09/09/2024 09:47, Philipp Stanner wrote:
Hi,
On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
In a recent conversation with Christian there was a thought that
drm_sched_entity_modify_sched() should start using the entity-
rq_lock to be
safe against job subm
[AMD Official Use Only - AMD Internal Distribution Only]
Fixed typo in red
-Original Message-
From: amd-gfx On Behalf Of Zhang,
Hawking
Sent: Monday, September 9, 2024 20:22
To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org
Cc: Zhou1, Tao
Subject: RE: [PATCH] drm/amdgpu: disable RAS bad
[AMD Official Use Only - AMD Internal Distribution Only]
Previously, the S3 process aborted before calling the noirq suspend, and this
issue was successfully sorted by checking the suspend_complete flag. However,
there are now some S3 suspend cases, such as pm_test platform/core mode, which
abo
On Mon, 2024-09-09 at 13:37 +0100, Tvrtko Ursulin wrote:
>
> On 09/09/2024 13:18, Christian König wrote:
> > Am 09.09.24 um 14:13 schrieb Philipp Stanner:
> > > On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote:
> > > > Am 09.09.24 um 11:44 schrieb Philipp Stanner:
> > > > > On Fri, 2024-09
On 9/6/2024 8:06 PM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Entities run queue can change during drm_sched_entity_push_job() so make
> sure to update the score consistently.
>
> Signed-off-by: Tvrtko Ursulin
> Fixes: d41a39dda140 ("drm/scheduler: improve job distribution with multiple
Adding Leo as well.
Am 06.09.24 um 20:06 schrieb Tvrtko Ursulin:
From: Tvrtko Ursulin
According to Christian the dynamic DRM priority override was only
interesting before the hardware priority (dona via
drm_sched_entity_modify_sched()) existed. Furthermore, both
overrides also only work somewh
[AMD Official Use Only - AMD Internal Distribution Only]
connected_to_gpu is legacy design - I understand UMC IP version is also used so
it works. Checking is_app_apu flag is good enough at this stage.
It would be better to move the code change to amdgpu_ras_fs_init.
In addition, it's more accu
Am 09.09.24 um 14:13 schrieb Philipp Stanner:
On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote:
Am 09.09.24 um 11:44 schrieb Philipp Stanner:
On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Without the locking amdgpu currently can race
amdgpu_ctx_set_ent
On Mon, 2024-09-09 at 13:29 +0200, Christian König wrote:
> Am 09.09.24 um 11:44 schrieb Philipp Stanner:
> > On Fri, 2024-09-06 at 19:06 +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Without the locking amdgpu currently can race
> > > amdgpu_ctx_set_entity_priority() and dr
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Store instances of drm_fb_helper and struct omap_fbdev separately.
This will allow omapdrm to use the common fbdev client, which allocates
its own instance of struct drm_fb_helper.
There is at most one instance of each per DRM device, so both can be
referenced directly from the omap and DRM device
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
The nouveau driver specifies a preferred color mode depending on
the available video memory, with a default of 32. Adapt this
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
The hibmc driver specifies a preferred color mode of 32. As this
is the default if no format has been given, leave it out enti
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Rework fbdev probing to support fbdev_probe in struct drm_driver
and remove the old fb_probe callback. Provide an initializer macro
for struct drm_driver that sets the callback according to the kernel
configuration.
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbde
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: Rodrigo Siqueira
Cc: Melissa Wen
Cc: "Maíra Canal"
Cc: Haneen Mohammed
Acked-by: Jav
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: David Lechner
Acked-by: David Lechner
---
drivers/gpu/drm/tiny/st7735r.c | 4 +++-
1
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: Dave Airlie
Cc: Sean Paul
Cc: Thomas Zimmermann
Acked-by: Javier Martinez Canillas
-
Call drm_client_setup() to run the kernel's default client setup
for DRM. Set fbdev_probe in struct drm_driver, so that the client
setup can start the common fbdev client.
Signed-off-by: Thomas Zimmermann
Cc: Zack Rusin
Cc: Broadcom internal kernel review list
Acked-by: Javier Martinez Canillas
1 - 100 of 183 matches
Mail list logo
