Re: [PATCH 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-09-05 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20240905] [cannot apply to drm-xe/drm-xe-next linus/master v6.11-rc6] [If your patch is applied to the wrong git tree, kindly drop us a note. And

RE: [PATCH] drm/amd/pm: update the features set on smu v14.0.2/3

2024-09-05 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: Kenneth Feng Sent: Thursday, September 5, 2024 3:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wang, Yang(Kevin) ; Feng, Kenneth Subject: [PATCH] drm/amd/pm: upd

[PATCH] drm/amdkfd: Fix resource leak in kriu rsetore queue

2024-09-05 Thread jesse.zhang
From: "jesse.zh...@amd.com" To avoid memory leaks, release q_extra_data when exiting the restore queue. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager

RE: [PATCH] drm/amdgpu: update golden regs for gfx12

2024-09-05 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Min, Frank Sent: Thursday, September 5, 2024 23:23 To: amd-gfx@lists.freedesktop.org Cc: Gao, Likun ; Zhang, Hawking Subject: [PATCH] drm/amdgpu: update golden

Re: [PATCH 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-09-05 Thread kernel test robot
Hi Thomas, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20240905] [cannot apply to drm-xe/drm-xe-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.11-rc6] [If your patch is applied to

[PATCH 1/2] drm/amd/amdgpu: apply command submission parser for JPEG v2+

2024-09-05 Thread David (Ming Qiang) Wu
This patch extends the same cs parser from JPEG v4.0.3 to other JPEG versions (v2 and above). Rename to more common name as jpeg_v2_dec_ring_parse_cs() from jpeg_v4_0_3_dec_ring_parse_cs(). Signed-off-by: David (Ming Qiang) Wu --- drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 63 ++

[PATCH 2/2] drm/amd/amdgpu: apply command submission parser for JPEG v1

2024-09-05 Thread David (Ming Qiang) Wu
Similar to jpeg_v2_dec_ring_parse_cs() but it has different register ranges and a few other registers access. Signed-off-by: David (Ming Qiang) Wu --- drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 76 +- drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.h | 11 2 files changed, 86 ins

Re: [PATCH] drm/amd/pm: update the features set on smu v14.0.2/3

2024-09-05 Thread Alex Deucher
On Thu, Sep 5, 2024 at 3:40 AM Kenneth Feng wrote: > > update the features set on smu v14.0.2/3 > > Signed-off-by: Kenneth Feng Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 11 ++- > drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 9 +++

[pull] amdgpu drm-fixes-6.11

2024-09-05 Thread Alex Deucher
Hi Dave, Simona, Fixes for 6.11. The following changes since commit 431c1646e1f86b949fa3685efc50b660a364c2b6: Linux 6.11-rc6 (2024-09-01 19:46:02 +1200) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.11-2024-09-05 for you to fe

[PATCH 0/2] drm/ttm: Add an option to report graphics memory OOM

2024-09-05 Thread Thomas Hellström
Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether correc

[PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-05 Thread sikkamukul
From: Bob Zhou [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] Check return value and conduct null pointer handling to avoid null pointer dereference. Signed-off-by: Bob Zhou Reviewed-by: Tim Huang Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin Signed-off-by: Mukul Sik

Re: AMD drm patch workflow is broken for stable trees

2024-09-05 Thread Greg KH
On Tue, Aug 27, 2024 at 10:18:27AM -0400, Alex Deucher wrote: > On Sat, Aug 24, 2024 at 1:23 AM Greg KH wrote: > > > > On Fri, Aug 23, 2024 at 05:23:46PM -0400, Alex Deucher wrote: > > > On Thu, Aug 15, 2024 at 1:11 AM Greg KH > > > wrote: > > > > > > > > On Wed, Aug 14, 2024 at 05:30:08PM -0400

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-05 Thread Greg KH
On Tue, Sep 03, 2024 at 04:58:09AM +, sikkamukul wrote: > From: Bob Zhou > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > Check return value and conduct null pointer handling to avoid null pointer > dereference. > > Signed-off-by: Bob Zhou > Reviewed-by: Tim Huang > S

[PATCH] drm/amd/display: Fix debugfs dmub_fw_state read

2024-09-05 Thread Filip Hejsek
When the FW state is too large to fit in initial seq_file buffer, seq_write returns -1, which is subsequently returned from dmub_fw_state_show. This causes the read operation to fail. Return instead always 0 and let the seq_file handling retry the read with a larger buffer if the initial buffer ov

Re: [PATCH] drm/amdgpu: enable -Wformat-truncation

2024-09-05 Thread Jani Nikula
On Tue, 03 Sep 2024, Hamza Mahfooz wrote: > It is enabled by W=1 and amdgpu has a clean build with it enabled. So, > to make sure we block future instances of it from showing up on > our driver, enable it by default for the module. Would prefer enabling it by default across the subsystem [1]. BR

Re: [PATCH 1/2] Documentation/gpu: Document the situation with unqualified drm-memory-

2024-09-05 Thread Tvrtko Ursulin
On 21/08/2024 21:47, Alex Deucher wrote: On Tue, Aug 13, 2024 at 9:57 AM Tvrtko Ursulin wrote: From: Tvrtko Ursulin Currently it is not well defined what is drm-memory- compared to other categories. In practice the only driver which emits these keys is amdgpu and in them exposes the curre

[PATCH] drm/amdgpu/mes11: Indent an if statment

2024-09-05 Thread Dan Carpenter
Indent the "break" statement one more tab. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c index 0f055d1b1da6..ee91ff9e52a2

[INFO] bad desktop experience, external monitor attached nvidia-optimus-enhanced gpu

2024-09-05 Thread __- -__
Hi, This issue has a workaround. put into /etc/environment LIBGL_DRI3_DISABLE=1 Above envar force use of egl_dri2 defaults According to https://docs.mesa3d.org/egl.html Maybe it is a race condition with default MESA_LOADER. What is the relation between iris and egl_dri2 Both running is a

[PATCH 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

2024-09-05 Thread Thomas Hellström
The ttm_device_init funcition uses multiple bool arguments. That means readability in the caller becomes poor, and all callers need to change if yet another bool is added. Instead use a struct with multiple single-bit flags. This addresses both problems. Prefer it over using defines or enums with

Re: [PATCH v1] drm/ci: uprev IGT and deqp-runner

2024-09-05 Thread Helen Mae Koike Fornazier
On Thu, 05 Sep 2024 06:39:32 -0300 Vignesh Raman wrote --- > Uprev IGT to the latest version and deqp-runner > to v0.20.0. Also update expectation files. > > Signed-off-by: Vignesh Raman vignesh.ra...@collabora.com> > --- > > v1: > - Flaky test report will be sent to ma

[PATCH 2/2] drm/ttm: Add a device flag to propagate -ENOSPC on OOM

2024-09-05 Thread Thomas Hellström
Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether correc

Re: [PATCH v5.15-v5.10] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-09-05 Thread Alex Deucher
On Tue, Sep 3, 2024 at 5:53 AM sikkamukul wrote: > > From: Bob Zhou > > [ Upstream commit 50151b7f1c79a09117837eb95b76c2de76841dab ] > > Check return value and conduct null pointer handling to avoid null pointer > dereference. > > Signed-off-by: Bob Zhou > Reviewed-by: Tim Huang > Signed-off-b

[PATCH] drm/amdgpu: update golden regs for gfx12

2024-09-05 Thread Min, Frank
[AMD Official Use Only - AMD Internal Distribution Only] From: Frank Min update golden regs for gfx12 Signed-off-by: Frank Min --- drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v12_0.c

Re: [PATCH] drm/amdkfd: fix vm-pasid lookup for multiple partitions

2024-09-05 Thread Christian König
Am 19.08.24 um 19:59 schrieb Jonathan Kim: Currently multiple partitions will incorrectly overwrite the VM lookup table since the table is indexed by PASID and multiple partitions can register different VM objects on the same PASID. That's a rather bad idea. Why do we have the same PASID for di

Re: [PATCH] drm/amdgpu: Raise dma resv usage for created TLB fence

2024-09-05 Thread Christian König
Well that explanation doesn't seem to make much sense either. What do you mean with TLB flush is occurring prematurely? Regards, Christian. Am 05.09.24 um 14:38 schrieb Andjelkovic, Dejan: [AMD Official Use Only - AMD Internal Distribution Only] Hi there. We're running into a page fault iss

Re: [PATCH] drm/amdgpu: Raise dma resv usage for created TLB fence

2024-09-05 Thread Andjelkovic, Dejan
[AMD Official Use Only - AMD Internal Distribution Only] Hi there. We're running into a page fault issue that's very easily reproducible on a SRIOV environment when using SDMA for page table updates. Going through mapping logs and trace files, it seems TLB flush is occurring prematurely. Changi

Re: [PATCH 6/6] drm/amdgpu: Add few optimizations to userq fence driver

2024-09-05 Thread Christian König
Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: Add few optimizations to userq fence driver. v1:(Christian): - Remove unnecessary comments. - In drm_exec_init call give num_bo_handles as last parameter it would making allocation of the array more efficient - Handle return va

Re: [PATCH 5/6] drm/amdgpu: Remove the MES self test

2024-09-05 Thread Christian König
Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: Remove MES self test as this conflicts the userqueue fence interrupts. v2:(Christian) - remove the amdgpu_mes_self_test() function and any now unused code. Signed-off-by: Arunpravin Paneer Selvam Acked-by: Christian König --- dri

Re: [PATCH 3/6] drm/amdgpu: screen freeze and userq driver crash

2024-09-05 Thread Christian König
Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: Screen freeze and userq fence driver crash while playing Xonotic Signed-off-by: Arunpravin Paneer Selvam --- drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a

Re: [PATCH] drm/amdgpu: Raise dma resv usage for created TLB fence

2024-09-05 Thread Christian König
Am 05.09.24 um 10:58 schrieb Dejan Andjelkovic: When using SDMA for PT updates, a TLB fence hooked to a buffer objects dma resv object with usage declared as BOOKKEEP leaves a chance for TLB flush to occur prematurely. This will lead to a page fault. Raising the usage from BOOKKEEP to KERNEL remo

Re: [PATCH 4/6] drm/amdgpu: Enable userq fence interrupt support

2024-09-05 Thread Christian König
Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: Add support to handle the userqueue protected fence signal hardware interrupt. Create a xarray which maps the doorbell index to the fence driver address. This would help to retrieve the fence driver information when an userq fence interrupt

Re: [PATCH v1] drm/ci: uprev IGT and deqp-runner

2024-09-05 Thread Daniel Stone
Hi Vignesh, On Thu, 5 Sept 2024 at 10:41, Vignesh Raman wrote: > Uprev IGT to the latest version and deqp-runner > to v0.20.0. Also update expectation files. Thanks! This is: Reviewed-by: Daniel Stone

[PATCH v1] drm/ci: uprev IGT and deqp-runner

2024-09-05 Thread Vignesh Raman
Uprev IGT to the latest version and deqp-runner to v0.20.0. Also update expectation files. Signed-off-by: Vignesh Raman --- v1: - Flaky test report will be sent to maintainers after this patch series is reviewed. --- drivers/gpu/drm/ci/gitlab-ci.yml | 4 +- drivers/gpu/drm/ci/i

[PATCH] drm/amdkfd: clean up code for interrupt v10

2024-09-05 Thread jesse.zh...@amd.com
Variable hub_inst is unused. Related the commit "bde7ae79ca40": "drm/amdkfd: Drop poison hanlding from gfx v10" Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_pro

RE: [PATCH 00/10] Support XGMI reset on init

2024-09-05 Thread Xu, Feifei
[AMD Official Use Only - AMD Internal Distribution Only] Patch3~10: Reviewed-by: Feifei Xu -Original Message- From: amd-gfx On Behalf Of Lijo Lazar Sent: Monday, September 2, 2024 3:34 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander ; Koenig, Christian Su

[PATCH] drm/amdgpu: Raise dma resv usage for created TLB fence

2024-09-05 Thread Dejan Andjelkovic
When using SDMA for PT updates, a TLB fence hooked to a buffer objects dma resv object with usage declared as BOOKKEEP leaves a chance for TLB flush to occur prematurely. This will lead to a page fault. Raising the usage from BOOKKEEP to KERNEL removes this possibility. Signed-off-by: Dejan Andjel

Re: [PATCH 1/6] drm/amdgpu: Implement userqueue signal/wait IOCTL

2024-09-05 Thread Christian König
Am 30.08.24 um 20:43 schrieb Arunpravin Paneer Selvam: This patch introduces new IOCTL for userqueue secure semaphore. The signal IOCTL called from userspace application creates a drm syncobj and array of bo GEM handles and passed in as parameter to the driver to install the fence into it. The

Re: [PATCH] drm/amdgpu: Fix kdoc entry in 'amdgpu_vm_cpu_prepare'

2024-09-05 Thread Christian König
Am 04.09.24 um 09:32 schrieb Srinivasan Shanmugam: This commit updates described non-existent parameters 'resv' and 'sync_mode', and failed to describe the existing 'sync' parameter. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter or stru

Re: [PATCH v2] drm/amdgpu/: Add missing kdoc entry in amdgpu_vm_handle_fault function

2024-09-05 Thread Christian König
Am 28.08.24 um 05:09 schrieb Srinivasan Shanmugam: This commit adds a description for the 'ts' parameter in the amdgpu_vm_handle_fault function's comment block. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2781: warning: Function parameter or struct member 'ts' not descr

[PATCH] drm/amd/pm: update the features set on smu v14.0.2/3

2024-09-05 Thread Kenneth Feng
update the features set on smu v14.0.2/3 Signed-off-by: Kenneth Feng --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 11 ++- drivers/gpu/drm/amd/pm/swsmu/smu14/smu_v14_0_2_ppt.c | 9 + 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

RE: [PATCH] drm/amdgpu: update suspend status for aborting from deeper suspend

2024-09-05 Thread Liang, Prike
[AMD Official Use Only - AMD Internal Distribution Only] According to the ChromeOS team test, this patch can resolve the S3 suspend abort from deeper sleep, which occurs when suspension aborts after calling the noirq suspend and before executing the _S3 and turning off the power rail. Could thi