On Thu, Sep 5, 2024 at 4:06 AM Leo Li wrote:
>
> Can you delete ", new_cursor_state" on that line and try again? Seems to be a
> unused variable warning being elevated to an error.
>
Thanks, I applied both patches and can confirm that this solved the issue.
The first patch was definitely not enou
On 9/4/2024 6:57 PM, Srinivasan Shanmugam wrote:
> This commit modifies the initialization only if the cleaner shader
> object has been allocated. This is done by adding checks for
> adev->gfx.cleaner_shader_obj before calling
> amdgpu_gfx_cleaner_shader_init
>
> The changes are made in the gfx
Reviewed-by: Tom Chung
On 9/4/2024 3:43 PM, Srinivasan Shanmugam wrote:
Added a descriptor for the 'program_isharp_1dlut' parameter, which is a
flag used to determine whether to program the isharp 1D LUT.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_
On Wed, Sep 4, 2024 at 9:38 AM Srinivasan Shanmugam
wrote:
>
> This commit modifies the initialization only if the cleaner shader
> object has been allocated. This is done by adding checks for
> adev->gfx.cleaner_shader_obj before calling
> amdgpu_gfx_cleaner_shader_init
>
> The changes are made i
On Wed, Sep 4, 2024 at 8:37 PM Alex Deucher wrote:
>
> On Wed, Sep 4, 2024 at 9:53 AM Srinivasan Shanmugam
> wrote:
> >
> > This commit modifies the initialization only if the cleaner shader
> > object has been allocated. This is done by adding checks for
> > adev->gfx.cleaner_shader_obj before c
On Wed, Sep 4, 2024 at 9:53 AM Srinivasan Shanmugam
wrote:
>
> This commit modifies the initialization only if the cleaner shader
> object has been allocated. This is done by adding checks for
> adev->gfx.cleaner_shader_obj before calling
> amdgpu_gfx_cleaner_shader_init
>
> The changes are made i
On Wed, Sep 4, 2024 at 9:27 AM Srinivasan Shanmugam
wrote:
>
> This commit refactors the cleaner shader initialization process. The
> changes remove unnecessary checks for adev->gfx.enable_cleaner_shader in
> the amdgpu_gfx_cleaner_shader_sw_init,
> amdgpu_gfx_cleaner_shader_sw_fini, and amdgpu_gf
On 2024-09-04 18:21, Mikhail Gavrilov wrote:
On Wed, Sep 4, 2024 at 4:15 AM Leo Li wrote:
Hi Mike,
Super sorry for the ridiculous wait. Your first two emails slipped by my inbox,
which is really silly, given I'm first in the to field...
Thanks for bisecting and finding a free game to repro
On Wed, Sep 4, 2024 at 4:15 AM Leo Li wrote:
> Hi Mike,
>
> Super sorry for the ridiculous wait. Your first two emails slipped by my
> inbox,
> which is really silly, given I'm first in the to field...
>
> Thanks for bisecting and finding a free game to reproduce it on. I did not
> have
> luck r
Pushed to drm-misc-next, thanks!
On Sat, 2024-08-31 at 09:28 +0800, Li Zetao wrote:
> When it needs to get a value within a certain interval, using clamp()
> makes the code easier to understand than min(max()).
>
> Reviewed-by: Lyude Paul
> Signed-off-by: Li Zetao
> ---
> v1 -> v2: Change the p
On 2024-09-03 19:24, Ramesh Errabolu
wrote:
Enables users to update SVM's default granularity, used in
buffer migration and handling of recoverable page faults.
Param value is set in terms of log(numPages(buffer)),
e.g. 9 for a 2 MIB buffer
Signed-off-by: Ra
On 9/4/2024 8:08 PM, Philip Yang wrote:
>
> On 2024-09-04 04:04, Asher Song wrote:
>> In some APUs, the bo type of GART page table is ttm_bo_type_sg.
>> Those type BOs is released by bo->delayed_delete which is added in
>> ttm_device->wq, not released immediately.
>>
>> To make sure all the tt
On 2024-09-04 04:04, Asher Song wrote:
In some APUs, the bo type of GART page table is ttm_bo_type_sg.
Those type BOs is released by bo->delayed_delete which is added in ttm_device->wq, not released immediately.
To make sure all the ttm_resource is released before
This commit modifies the initialization only if the cleaner shader
object has been allocated. This is done by adding checks for
adev->gfx.cleaner_shader_obj before calling
amdgpu_gfx_cleaner_shader_init
The changes are made in the gfx_v9_4_3_sw_init, gfx_v9_4_3_sw_fini, and
gfx_v9_4_3_hw_init func
This commit modifies the initialization only if the cleaner shader
object has been allocated. This is done by adding checks for
adev->gfx.cleaner_shader_obj before calling
amdgpu_gfx_cleaner_shader_init
The changes are made in the gfx_v9_0_hw_init functions These functions
are responsible for init
This commit refactors the cleaner shader initialization process. The
changes remove unnecessary checks for adev->gfx.enable_cleaner_shader in
the amdgpu_gfx_cleaner_shader_sw_init,
amdgpu_gfx_cleaner_shader_sw_fini, and amdgpu_gfx_cleaner_shader_init
functions. These checks are now performed before
On 2024-09-02 05:06, Christian König
wrote:
Am
02.09.24 um 05:03 schrieb Lang Yu:
Fixes: 5a1c27951966 ("drm/amdgpu:
implement TLB flush fence")
Signed-off-by: Lang Yu
Ah yes, that exp
Am 02.09.24 um 09:34 schrieb Lijo Lazar:
There are case where a device needs to be reset first before it is fully
initialized. An example case is a driver reinstallation with a different version
of PSP TOS. In such a case, if a device supports reset in which PSP TOS is
unloaded, then driver needs
On Wed, Sep 4, 2024 at 6:03 AM jesse.zh...@amd.com wrote:
>
> Initialize the queue type before resetting the queue using mmio.
>
> Signed-off-by: Jesse Zhang
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers
It could be that the automated testing tools will run amok on that.
I need to ask Felix for details but I think the code for the CWSR trap
handlers were converted to C style comments as well because of that.
Christian.
Am 04.09.24 um 12:52 schrieb Deucher, Alexander:
[AMD Official Use Only
[AMD Official Use Only - AMD Internal Distribution Only]
I think you can drop this patch. This code is not compiled, it's just for
reference, and changing all of the comments will just make it harder to keep in
sync with the internal version.
Alex
From: SHANMU
Am 04.09.24 um 11:33 schrieb Srinivasan Shanmugam:
This commit updates the comment style in the cleaner shader code from
`//` to `/* ... */` to adhere to the Linux kernel coding style.
The comments describe the operation of the cleaner shader, which is used
to clean LDS, SGPRs, and VGPRs. The sh
[AMD Official Use Only - AMD Internal Distribution Only]
Comments inline.
Thanks,
Feifei
-Original Message-
From: amd-gfx On Behalf Of Lijo Lazar
Sent: Monday, September 2, 2024 3:34 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhang, Hawking ; Deucher, Alexander
; Koenig, Christian
Subje
Initialize the queue type before resetting the queue using mmio.
Signed-off-by: Jesse Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c
index f7d5d4f08a53..10b61
This commit updates the comment style in the cleaner shader code from
`//` to `/* ... */` to adhere to the Linux kernel coding style.
The comments describe the operation of the cleaner shader, which is used
to clean LDS, SGPRs, and VGPRs. The shader uses two kernels launched
separately to clean VG
On 9/4/2024 1:34 PM, Asher Song wrote:
> In some APUs, the bo type of GART page table is ttm_bo_type_sg.
> Those type BOs is released by bo->delayed_delete which is added in
> ttm_device->wq, not released immediately.
>
> To make sure all the ttm_resource is released before ttm_resource_manage
This commit updates the comment style in the cleaner shader code from
`//` to `/* ... */` to adhere to the Linux kernel coding style.
The comments describe the operation of the cleaner shader, which is used
to clean LDS, SGPRs, and VGPRs. The shader uses two kernels launched
separately to clean VG
Am 04.09.24 um 10:38 schrieb Srinivasan Shanmugam:
This commit replaces the use of amdgpu_job_submit_direct which submits
the job to the ring directly, with drm_sched_entity in the cleaner
shader job submission process. The change allows the GPU scheduler to
manage the cleaner shader job.
- The
This commit replaces the use of amdgpu_job_submit_direct which submits
the job to the ring directly, with drm_sched_entity in the cleaner
shader job submission process. The change allows the GPU scheduler to
manage the cleaner shader job.
- The job is then submitted to the GPU using the
drm_sche
Am 04.09.24 um 10:04 schrieb Asher Song:
In some APUs, the bo type of GART page table is ttm_bo_type_sg.
Those type BOs is released by bo->delayed_delete which is added in
ttm_device->wq, not released immediately.
To make sure all the ttm_resource is released before ttm_resource_manager is
fin
In some APUs, the bo type of GART page table is ttm_bo_type_sg.
Those type BOs is released by bo->delayed_delete which is added in
ttm_device->wq, not released immediately.
To make sure all the ttm_resource is released before ttm_resource_manager is
finilized, drain the workqueue in ttm_device.
[AMD Official Use Only - AMD Internal Distribution Only]
On Tuesday, September 3, 2024 9:29 PM wrote by Koenig, Christian
> Am 03.09.24 um 14:31 schrieb Asher Song:
> > In some APUs, the bo type of GART page table is ttm_bo_type_sg.
> > Those type BOs is released by bo->delayed_delete which is add
Am 04.09.24 um 09:12 schrieb Srinivasan Shanmugam:
This commit replaces the use of amdgpu_job_submit_direct which submits
the job to the ring directly, with drm_sched_entity in the cleaner
shader job submission process. The change allows the GPU scheduler to
manage the cleaner shader job.
- The
Added a descriptor for the 'program_isharp_1dlut' parameter, which is a
flag used to determine whether to program the isharp 1D LUT.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:963:
warning: Function parameter or struct member 'program_ishar
This commit updates described non-existent parameters 'resv' and
'sync_mode', and failed to describe the existing 'sync' parameter.
Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c:50: warning: Function parameter or
struct member 'sync' not described in 'amdgpu_vm_cpu_prep
This commit replaces the use of amdgpu_job_submit_direct which submits
the job to the ring directly, with drm_sched_entity in the cleaner
shader job submission process. The change allows the GPU scheduler to
manage the cleaner shader job.
- The job is then submitted to the GPU using the
drm_sche
36 matches
Mail list logo
