On 2024-08-07 04:36, Samuel Zhang wrote:
Ptrace access VRAM bo will first try sdma access in
amdgpu_ttm_access_memory_sdma(), if fails, it will fallback to mmio
access.
Since ptrace only access 8 bytes at a time and
amdgpu_ttm_access_memory_sdma() only allow PAGE_SIZE bytes access,
it returns
Maybe we can turn this check into a warnings if, and only if the
exp_hw_support module param is set. That way we don't water down the
checks on the production code path but allow experimental setups to run
without a seat belt.
Regards,
Felix
On 2024-08-09 01:39, Zhang, Yifan wrote:
[AMD O
From: LipArcanjo
All dce command_table_helper's shares a copy-pasted collection
of copy-pasted functions, which are: phy_id_to_atom,
clock_source_id_to_atom_phy_clk_src_id, and engine_bp_to_atom.
This patch removes the multiple copy-pasted by creating a
common command table and make the command_
We don't actually need to request that the compositor does a full
modeset to modify the panel power savings level, we can instead
just make a request to DMUB, to set the new level dynamically.
Cc: Harry Wentland
Cc: Leo Li
Cc: Mario Limonciello
Cc: Sebastian Wick
Signed-off-by: Hamza Mahfooz
On 8/8/24 4:06 PM, Melissa Wen wrote:
On 07/08/2024 04:55, Tom Chung wrote:
From: Rodrigo Siqueira
[why & how]
When the commit 9d84c7ef8a87 ("drm/amd/display: Correct cursor position
on horizontal mirror") was introduced, it used the wrong calculation for
the position copy for X. This com
I don't see anything wrong with it
Reviewed-by: Faith Ekstrand
However, I'm not an AMDGPU developer so you probably want someone who knows
the amdgpu sync stuff to review as well.
On Wed, Aug 7, 2024 at 8:09 PM Bas Nieuwenhuizen
wrote:
> For the rationale see the earlier RFC by Faith:
> https
On Wed, Aug 7, 2024 at 8:09 PM Bas Nieuwenhuizen
wrote:
> Per submission flag because:
>
> 1) Slightly simpler & more flexible than per context flag.
> 2) We'd need to extend the per-BO struct if we want to put
>it there.
> 3) Doing it per BO is annoying implementation wise as we
>disasso
[Public]
Reviewed-by: Lijo Lazar
Thanks,
Lijo
-Original Message-
From: Kim, Jonathan
Sent: Thursday, August 8, 2024 9:39 PM
To: amd-gfx@lists.freedesktop.org
Cc: Lazar, Lijo ; Kuehling, Felix ;
Kim, Jonathan ; Kim, Jonathan
Subject: [PATCH] drm/amdkfd: fix partition query when setting
On Fri, Aug 9, 2024 at 12:12 PM Kim, Jonathan wrote:
>
> [Public]
>
> > -Original Message-
> > From: Alex Deucher
> > Sent: Friday, August 9, 2024 11:55 AM
> > To: Kim, Jonathan
> > Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix
> > ; Deucher, Alexander
> >
> > Subject: Re: [PATCH]
[Public]
> -Original Message-
> From: Alex Deucher
> Sent: Friday, August 9, 2024 11:55 AM
> To: Kim, Jonathan
> Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix
> ; Deucher, Alexander
>
> Subject: Re: [PATCH] drm/amdkfd: fallback to pipe reset on queue reset fail
> for
> gfx9
>
> Ca
On Fri, Aug 2, 2024 at 12:38 PM Jonathan Kim wrote:
>
> If queue reset fails, tell the CP to reset the pipe.
> Since queues multiplex context per pipe and we've issues a device wide
> preemption prior to the hang, we can assume the hung pipe only has one
> queue to reset on pipe reset.
Is there a
[Public]
Ping on review.
Thanks,
Jon
> -Original Message-
> From: Kim, Jonathan
> Sent: Friday, August 2, 2024 12:38 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Kuehling, Felix ; Deucher, Alexander
> ; Kim, Jonathan ;
> Kim, Jonathan
> Subject: [PATCH] drm/amdkfd: fallback to pipe re
In aperture_remove_conflicting_pci_devices(), match the pci
device determine whether or not to call sysfb_disable(). This
fixes cases where the pimary device is not VGA compatible which
leads to the following problem:
1. A PCI device with a non-VGA class is the the boot display
2. That device is
On Wed, Aug 7, 2024 at 11:15 PM Victor Zhao wrote:
>
> on MI300/MI308 UBB products, when doing mode1 reset, since 1 gpu need to
> wait all 8 gpus finish mode1 reset and then do re-init. As observed,
> sometimes the gpu which triggered the reset need to wait 15s for all
> gpus to finish.
>
> If pol
Add gfx9 support of CP queue registers for all queues
to be used by devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 98 -
1 file changed, 95 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drive
Add support of gfx9_4_3 ipdump print so devcoredump
could trigger it to dump the captured registers
in devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
Add general registers of gfx9_4_3 in ipdump for
devcoredump support.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 133 +++-
1 file changed, 132 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/a
Add gfx9_4_3 print support of CP queue registers
for all queues to be used by devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.
Add gfx9_4_3 print support of CP queue registers
for all queues to be used by devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 42 +++--
1 file changed, 40 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.
Add gfx9 support of CP queue registers for all queues
to be used by devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 97 -
1 file changed, 94 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drive
*** BLURB HERE ***
Sunil Khatri (4):
drm/amdgpu: add gfx9_4_3 register support in ipdump
drm/amdgpu: add print support for gfx9_4_3 ipdump
drm/amdgpu: add cp queue registers for gfx9_4_3 ipdump
drm/amdgpu: add cp queue registers print for gfx9_4_3
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
Add general registers of gfx9_4_3 in ipdump for
devcoredump support.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 133 +++-
1 file changed, 132 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c
b/drivers/gpu/drm/a
Add support of gfx9_4_3 ipdump print so devcoredump
could trigger it to dump the captured registers
in devcoredump.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 24 +++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
Hi,
On 08/08/2024 07:38, Lin.Cao wrote:
If buddy manager have more than one roots and each root have sub-block
need to be free. When drm_buddy_fini called, the first loop of
force_merge will merge and free all of the sub block of first root,
which offset is 0x0 and size is biggest(more than have
Hi
Am 09.08.24 um 10:44 schrieb Daniel Vetter:
On Wed, Aug 07, 2024 at 10:41:33AM +0200, Thomas Zimmermann wrote:
Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from
their lastclose callbacks. Call it from the fbdev lastclose helper,
so that the driver functions can finally be
On Wed, Aug 07, 2024 at 10:41:40AM +0200, Thomas Zimmermann wrote:
> The output_poll_changed hook in struct drm_mode_config_funcs is
> unused. Remove it. The helper drm_client_dev_hotplug() implements
> the callback's functionality.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
On Wed, Aug 07, 2024 at 10:41:38AM +0200, Thomas Zimmermann wrote:
> The function is unused. Remove it.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vetter
Without the next patch to remove ->lastclose there's some confusion text
left in the DOC: section in drm_fb_helper.c, but no p
On Wed, Aug 07, 2024 at 10:41:37AM +0200, Thomas Zimmermann wrote:
> Replace the callto drm_fb_helper_output_poll_changed() with a call
> to drm_client_dev_hotplug(). It's equivalent in functionality, but
> use the DRM client infrastructure.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Dani
[Public]
> -Original Message-
> From: Lazar, Lijo
> Sent: Wednesday, August 7, 2024 12:17 PM
> To: amd-gfx@lists.freedesktop.org; brahma_sw_dev
>
> Cc: Zhang, Hawking ; Deucher, Alexander
> ; Kim, Jonathan ;
> Kasiviswanathan, Harish
> Subject: [PATCH] drm/amdkfd: Add node_id to locatio
On Wed, Aug 07, 2024 at 10:41:36AM +0200, Thomas Zimmermann wrote:
> The output_poll_changed hook was only necessary before in-kernel
> DRM clients existed, but is now obsolete. The client code handles
> display otplugging internally.
>
> Signed-off-by: Thomas Zimmermann
Reviewed-by: Daniel Vett
On Wed, Aug 07, 2024 at 10:41:33AM +0200, Thomas Zimmermann wrote:
> Amdgpu and nouveau call vga_switcheroo_process_delayed_switch() from
> their lastclose callbacks. Call it from the fbdev lastclose helper,
> so that the driver functions can finally be removed.
>
> The fbdev call is part of all l
This resolves the dereference null return value warning
reported by Coverity.
Signed-off-by: Tim Huang
---
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c
b/drivers/gpu/drm/am
This resolves the dereference null return value warning
reported by Coverity.
Signed-off-by: Tim Huang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
b/drivers/gpu/drm/amd/amdgpu/amd
33 matches
Mail list logo
