On 8/6/24 13:42, Sebastian Wick wrote:
From: Sebastian Wick
This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5.
The panel_power_savings sysfs entry can be used to change the displayed
colorimetry which breaks color managed setups.
The "do not break userspace" rule which was violated
The patches other than 4.0.3 are:
Reviewed-by: Alex Deucher
I think 4.0.3 needs the GET_INST() fix.
Alex
On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
>
> Add support for logging the registers in devcoredump
> buffer for vcn_v2_6.
>
> Signed-off-by: Sunil Khatri
> ---
> drivers/gpu/drm/a
On Tue, Aug 6, 2024 at 11:47 PM Khatri, Sunil wrote:
>
>
> On 8/7/2024 2:58 AM, Alex Deucher wrote:
>
> On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
>
> Add support of vcn ip dump in the devcoredump
> for vcn_v4_0_3.
>
> Signed-off-by: Sunil Khatri
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v
On 8/7/2024 2:58 AM, Alex Deucher wrote:
On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
Add support of vcn ip dump in the devcoredump
for vcn_v4_0_3.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 170 +++-
1 file changed, 169 insertions(+
On Tue, Aug 6, 2024 at 11:37 PM Khatri, Sunil wrote:
>
>
> On 8/7/2024 3:02 AM, Alex Deucher wrote:
> > On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
> >> Add support for logging the registers in devcoredump
> >> buffer for vcn_v4_0_3.
> >>
> >> Signed-off-by: Sunil Khatri
> >> ---
> >> d
On 8/7/2024 3:02 AM, Alex Deucher wrote:
On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
Add support for logging the registers in devcoredump
buffer for vcn_v4_0_3.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 34 -
1 file changed,
This commit adds a null check for the 'afb' variable in the
amdgpu_dm_update_cursor function. Previously, 'afb' was assumed to be
null at line 8388, but was used later in the code without a null check.
This could potentially lead to a null pointer dereference.
Changes since v1:
- Moved the null ch
This commit adds a null check for the 'afb' variable in the
amdgpu_dm_plane_handle_cursor_update function. Previously, 'afb' was
assumed to be null, but was used later in the code without a null check.
This could potentially lead to a null pointer dereference.
Changes since v1:
- Moved the null ch
On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
>
> Add support for logging the registers in devcoredump
> buffer for vcn_v4_0_3.
>
> Signed-off-by: Sunil Khatri
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 34 -
> 1 file changed, 33 insertions(+), 1 deletion(-)
>
On Tue, Aug 6, 2024 at 4:18 AM Sunil Khatri wrote:
>
> Add support of vcn ip dump in the devcoredump
> for vcn_v4_0_3.
>
> Signed-off-by: Sunil Khatri
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 170 +++-
> 1 file changed, 169 insertions(+), 1 deletion(-)
>
> diff --git
On Tue, Aug 6, 2024 at 4:35 PM Bas Nieuwenhuizen
wrote:
>
> Missing validation ...
>
> Checked libdrm and it clears all the structs, so we should be
> safe to just check everything.
>
> Signed-off-by: Bas Nieuwenhuizen
Applied. Thanks!
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 +
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Alex,
Previously we used packed and found out it didn't match with FW interface, and
the one without packed working as it matches with
FW interface, this sounds tricky though.
Thanks,
Ruijing
-Original Message-
From: Alex Deuc
Missing validation ...
Checked libdrm and it clears all the structs, so we should be
safe to just check everything.
Signed-off-by: Bas Nieuwenhuizen
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
b
On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu wrote:
>
> Because gpu_addr is updated in the calling routine
> (amdgpu_cs_patch_ibs()),it is removed in the callback.
>
> Use .patch_cs_in_place instead of .parse_cs for
> amdgpu_vce_ring_parse_cs_vm() as there is no need for keeping
> a tempo
sounds good - will fix them - thanks!
David
On 2024-08-06 16:09, Alex Deucher wrote:
On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu wrote:
Add JPEG IB command parser to ensure registers
in the command are within the JPEG IP block.
Signed-off-by: David (Ming Qiang) Wu
---
drivers/gp
On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu wrote:
>
> Add JPEG IB command parser to ensure registers
> in the command are within the JPEG IP block.
>
> Signed-off-by: David (Ming Qiang) Wu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0
On Tue, Aug 6, 2024 at 1:08 PM Alex Deucher wrote:
>
> On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu
> wrote:
> >
> > Add JPEG IB command parser to ensure registers
> > in the command are within the JPEG IP block.
> >
> > Signed-off-by: David (Ming Qiang) Wu
> > ---
> > drivers/gpu/drm
On Tue, Aug 6, 2024 at 3:38 PM yinjiyao wrote:
>
> kmd_fw_shared changed in VCN5
>
> Signed-off-by: Yinjie Yao
> Reviewed-by: Ruijing Dong
Acked-by: Alex Deucher
BTW, should these structures be marked as packed? I suspect they should?
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
kmd_fw_shared changed in VCN5
Signed-off-by: Yinjie Yao
Reviewed-by: Ruijing Dong
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
index f127eccf
From: Sebastian Wick
This reverts commit 63d0b87213a0ba241b3fcfba3fe7b0aed0cd1cc5.
The panel_power_savings sysfs entry can be used to change the displayed
colorimetry which breaks color managed setups.
The "do not break userspace" rule which was violated here is enough
reason to revert this com
From: Sebastian Wick
This reverts commit 76cb763e6ea62e838ccc8f7a1ea4246d690fccc9.
Reverting the panel_power_savings sysfs. See next commit.
Signed-off-by: Sebastian Wick
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 29 +++
1 file changed, 4 insertions(+), 25 deletions(
kmd_fw_shared changed in VCN5
Signed-off-by: Yinjie Yao
Reviewed-by: Ruijing Dong
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
index f127eccf
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Yinjie,
Please join the email group from
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
After signed up successfully, please resend this email with
Reviewed-by: Ruijing Dong
Thanks,
Ruijing
-Original Message-
From: Y
kmd_fw_shared changed in VCN5
Signed-off-by: Yinjie Yao
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h
index f127eccf59d7..2a1f3dbb14d3 100644
-
On 05/08/2024 10:11, Daniel Stone wrote:
Hi Vignesh,
On Tue, 30 Jul 2024 at 03:16, Vignesh Raman wrote:
Some ARM SOCs have a separate display controller and GPU, each with
different drivers. For mediatek mt8173, the GPU driver is powervr,
and the display driver is mediatek. In the case of m
[AMD Official Use Only - AMD Internal Distribution Only]
The series is:
Reviewed-by: Leo Liu
> -Original Message-
> From: amd-gfx On Behalf Of Alex
> Deucher
> Sent: Tuesday, August 6, 2024 1:03 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ;
> sta...@vger.kernel.org
>
On Tue, Aug 6, 2024 at 12:00 PM David (Ming Qiang) Wu wrote:
>
> Add JPEG IB command parser to ensure registers
> in the command are within the JPEG IP block.
>
> Signed-off-by: David (Ming Qiang) Wu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++
> drivers/gpu/drm/amd/amdgpu/jpeg_v4_0
This needs to be set as well if the IB uses atomics.
Signed-off-by: Alex Deucher
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c
b/drivers/gpu/drm/amd/amdgpu/
This needs to be set as well if the IB uses atomics.
Signed-off-by: Alex Deucher
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v2_0.c
b/drivers/gpu/drm/amd/amdgpu/jpeg
Because gpu_addr is updated in the calling routine
(amdgpu_cs_patch_ibs()),it is removed in the callback.
Use .patch_cs_in_place instead of .parse_cs for
amdgpu_vce_ring_parse_cs_vm() as there is no need for keeping
a temporary IB, therefore ib->sa_bo is NULL and amdgpu_ib_free()
is removed.
Sign
Add JPEG IB command parser to ensure registers
in the command are within the JPEG IP block.
Signed-off-by: David (Ming Qiang) Wu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 3 ++
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.c | 58 +++-
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_3.h
[AMD Official Use Only - AMD Internal Distribution Only]
Reviewed-by: Roman Li
> -Original Message-
> From: Mahfooz, Hamza
> Sent: Tuesday, August 6, 2024 10:18 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Wentland, Harry ; Li, Sun peng (Leo)
> ; Siqueira, Rodrigo ;
> Deucher, Alexander
[Public]
> -Original Message-
> From: Xiao, Jack
> Sent: Tuesday, July 23, 2024 4:28 AM
> To: amd-gfx@lists.freedesktop.org; Deucher, Alexander
> ; ckoenig.leichtzumer...@gmail.com
> Cc: Xiao, Jack
> Subject: [PATCH] drm/amdgpu/mes: refine for maximum packet execution
>
> Only allow API_
To be able to get to the lowest power state when suspending systems with
DCN3.5+, we must be in IPS before the display hardware is put into
D3cold. So, to ensure that the system always reaches the lowest power
state while suspending force systems that support IPS to enter idle
optimizations before
amdgpu can handle async flips on overlay planes, so allow it for atomic
async checks.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pla
Currently, DRM atomic uAPI allows only primary planes to be flipped
asynchronously. However, each driver might be able to perform async
flips in other different plane types. To enable drivers to set their own
restrictions on which type of plane they can or cannot flip, use the
existing atomic_async
Hi,
As per my previous patchsets, the goal of this work is to find a nice way to
allow amdgpu to perform async page flips in the overlay plane as well, not
only on the primary one. Currently, when using the atomic uAPI, this is the only
type of plane allowed to do async flips, and every driver acc
[Public]
Hi all,
This week this patchset was tested on the following systems:
* Lenovo ThinkBook T13s Gen4 with AMD Ryzen 5 6600U
* MSI Gaming X Trio RX 6800
* Gigabyte Gaming OC RX 7900 XTX
These systems were tested on the following display/connection types:
* eD
Stop waiting for the KIQ to return back when there is a reset pending.
It's quite likely that the KIQ will never response.
Signed-off-by: Koenig Christian
Suggested-by: Lazar Lijo
Tested-by: Victor Skvortsov
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 3 ++-
drivers/gpu/drm/amd/amdgpu/amdg
KIQ timeouts no longer seen.
This reverts commit b4d12cc00ad69e8a0dea2ece7202bacfd8b894fb.
Signed-off-by: Victor Skvortsov
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd
Flexible endpoints use DIGs from available inflexible endpoints,
so only the encoders of inflexible links need to be freed.
Otherwise, a double free issue may occur when unloading the
amdgpu module.
[ 279.190523] RIP: 0010:__slab_free+0x152/0x2f0
[ 279.190577] Call Trace:
[ 279.190580]
[ 279
Hi Yamato-san,
On 2024-08-06 04:43, Masatake YAMATO wrote:
> Though drmCommandWriteRead() is used in libdrm [1],
> DRM_IOCTL_AMDGPU_GEM_VA uses DRM_IOW for encoding.
>
> [1]
> https://gitlab.freedesktop.org/mesa/drm/-/blob/main/amdgpu/amdgpu_bo.c?ref_type=heads
AFAICT libdrm doesn't read fro
Though drmCommandWriteRead() is used in libdrm [1],
DRM_IOCTL_AMDGPU_GEM_VA uses DRM_IOW for encoding.
[1]
https://gitlab.freedesktop.org/mesa/drm/-/blob/main/amdgpu/amdgpu_bo.c?ref_type=heads
Signed-off-by: Masatake YAMATO
---
include/uapi/drm/amdgpu_drm.h | 2 +-
1 file changed, 1 insertion(
Add support for logging the registers in devcoredump
buffer for vcn_v1_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 34 ++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
b/drivers/gpu/drm
Add support for logging the registers in devcoredump
buffer for vcn_v5_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 34 -
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
b/drivers/gpu/d
Add support of vcn ip dump in the devcoredump
for vcn_v4_0_3.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 170 +++-
1 file changed, 169 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
b/drivers/gpu/drm/amd/amdg
Add support for logging the registers in devcoredump
buffer for vcn_v4_0_5.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 34 -
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
b/drivers/gpu
Add support of vcn ip dump in the devcoredump
for vcn_v4_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 169 +-
1 file changed, 168 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
b/drivers/gpu/drm/amd/amdgpu/v
Add support for logging the registers in devcoredump
buffer for vcn_v2_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 34 ++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
b/drivers/gpu/drm
Add support for logging the registers in devcoredump
buffer for vcn_v2_5.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 34 ++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm
Add support of vcn ip dump in the devcoredump
for vcn_v2_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 111 +-
1 file changed, 110 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c
b/drivers/gpu/drm/amd/amdgpu/v
Add support of vcn ip dump in the devcoredump
for vcn_v2_5.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 110 +-
1 file changed, 109 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/v
Add support of vcn ip dump in the devcoredump
for vcn_v1_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 95 ++-
1 file changed, 94 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
b/drivers/gpu/drm/amd/amdgpu/vc
Add support for logging the registers in devcoredump
buffer for vcn_v2_6.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c
i
Add support of vcn ip dump in the devcoredump
for vcn_v4_0_5.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c | 169 +++-
1 file changed, 168 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_5.c
b/drivers/gpu/drm/amd/amdg
VCN IP dump support for
a. 1.0
b. 2.0
c. 2.5
d. 2.6
e. 4.0
f. 4.0.3
g. 4.0.5
h. 5.0
Testing is done on VCN 3.x 4.x 5.x only as older version of VCN targets
are not available but it should work as the methodology to read and dump
value in devcoredump remains same. All the registers are validated
ag
Add support of vcn ip dump in the devcoredump
for vcn_v5_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 170 +++-
1 file changed, 169 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
b/drivers/gpu/drm/amd/amdgpu
Add support for logging the registers in devcoredump
buffer for vcn_v4_0_3.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c | 34 -
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0_3.c
b/drivers/gpu
Add support for logging the registers in devcoredump
buffer for vcn_v4_0.
Signed-off-by: Sunil Khatri
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 34 ++-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
b/drivers/gpu/drm
Hi
Am 05.08.24 um 21:00 schrieb Deucher, Alexander:
[Public]
-Original Message-
From: Thomas Zimmermann
Sent: Wednesday, July 31, 2024 8:17 AM
To: maarten.lankho...@linux.intel.com; mrip...@kernel.org;
airl...@gmail.com; dan...@ffwll.ch
Cc: amd-gfx@lists.freedesktop.org; dri-de...@lis
60 matches
Mail list logo
