Re: [PATCH] drm/radeon/r100: Handle unknown family in r100_cp_init_microcode()

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Tue, Jul 30, 2024 at 12:05 PM Geert Uytterhoeven wrote: > > With -Werror: > > In function ‘r100_cp_init_microcode’, > inlined from ‘r100_cp_init’ at drivers/gpu/drm/radeon/r100.c:1136:7: > include/linux/printk.h:465:44: error: ‘%s’ directive argument is null

Re: [PATCH] drm/amd: Use a constant format string for amdgpu_ucode_request

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Fri, Jul 19, 2024 at 6:35 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > Multiple files in amdgpu call amdgpu_ucode_request() with a fw_name > variable that the compiler cannot check for being a valid format string, > as seen by enabling the (default-disabled) -Wformat-

Re: [PATCH 0/3] drm/amd: some trivial fixes

2024-08-05 Thread Alex Deucher
Applied the series. Thanks! Alex On Sun, Aug 4, 2024 at 10:14 AM wrote: > > From: Tobias Jakobi > > Nothing serious here, just some bits I noticed when reading code. > > Tobias Jakobi (3): > drm/amd: Make amd_ip_funcs static for SDMA v5.0 > drm/amd: Make amd_ip_funcs static for SDMA v5.2 >

Re: [PATCH] check for mcbp

2024-08-05 Thread Alex Deucher
Acked-by: Alex Deucher On Sat, Aug 3, 2024 at 10:13 AM Dandapat, Soham wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > This is the fix for below > > we don’t need to call amdgpu_ring_mux_start_ib/ amdgpu_ring_mux_end_ib if > adev->gfx.mcbp is enable . > > we could retu

Re: [PATCH 1/2] Revert "drm/amdgpu: Extend KIQ reg polling wait for VF"

2024-08-05 Thread Alex Deucher
On Fri, Aug 2, 2024 at 2:27 PM Victor Skvortsov wrote: > > KIQ timeouts no longer seen. > > This reverts commit b4d12cc00ad69e8a0dea2ece7202bacfd8b894fb. MIssing your Signed-off-by. Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

Re: [PATCH] drm/amdgpu/uvd4: fix mask and shift definitions

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 31, 2024 at 3:20 AM Remington Brasga wrote: > > A few define's are listed twice with different, incorrect values. > This fix sets them appropriately. > > Signed-off-by: Remington Brasga > --- > The second UVD_LMI_CTRL__RFU_MASK is incorrect, so it was removed. It sh

Re: [PATCH][next] drm/amd/display: remove extraneous ; after statements

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Fri, Aug 2, 2024 at 8:00 AM Colin Ian King wrote: > > There are a several statements with two following semicolons, replace > these with just one semicolon. > > Signed-off-by: Colin Ian King > --- > .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 2 +- > ...

Re: [PATCH v3] drm/amd/amdgpu: Properly tune the size of struct

2024-08-05 Thread Alex Deucher
Applied. Thanks! On Wed, Jul 31, 2024 at 6:25 AM WangYuli wrote: > > The struct assertion is failed because sparse cannot parse > `#pragma pack(push, 1)` and `#pragma pack(pop)` correctly. > GCC's output is still 1-byte-aligned. No harm to memory layout. > > The error can be filtered out by spar

RE: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-05 Thread Deucher, Alexander
[Public] > -Original Message- > From: Thomas Zimmermann > Sent: Wednesday, July 31, 2024 8:17 AM > To: maarten.lankho...@linux.intel.com; mrip...@kernel.org; > airl...@gmail.com; dan...@ffwll.ch > Cc: amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; intel- > g...@lists.free

6.11/regression/bisected - after commit 1b04dcca4fb1, launching some RenPy games causes computer hang

2024-08-05 Thread Mikhail Gavrilov
Hi, After commit 1b04dcca4fb1, launching some RenPy games causes computer hang. After the hang, even Alt + sysrq + REISUB can't reboot the computer! And no trace in the kernel log! For demonstration, I'm going to use the game "Find the Orange Narwhal" because it is free and has 100% reproducivity f

Re: [PATCH] drm/amdgpu: Add DCC GFX12 flag to enable address alignment

2024-08-05 Thread Alex Deucher
On Mon, Aug 5, 2024 at 10:10 AM Arunpravin Paneer Selvam wrote: > > We require this flag AMDGPU_GEM_CREATE_GFX12_DCC or any other > kernel level GFX12 DCC flag to differentiate the DCC buffers and other > pinned display buffers(which has TTM_PL_FLAG_CONTIGUOUS enabled). > > If we use the TTM_PL_FL

Re: [PATCH v2 0/3] drm: backlight quirk infrastructure and lower minimum for Framework AMD 13

2024-08-05 Thread Hans de Goede
Hi Thomas, On 6/23/24 10:51 AM, Thomas Weißschuh wrote: > The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > is "12". This leads to a fairly bright minimum display backlight. > > Add a generic quirk infrastructure for backlight configuration to > override the settings prov

RE: [PATCH 6.10] drm/amd/display: Refactor function dm_dp_mst_is_port_support_mode()

2024-08-05 Thread Deucher, Alexander
[Public] > -Original Message- > From: Kevin Holm > Sent: Tuesday, July 30, 2024 2:54 PM > To: sta...@vger.kernel.org > Cc: regressi...@lists.linux.dev; amd-gfx@lists.freedesktop.org; ML dri-devel > ; LKML ; Lin, > Wayne ; Zuo, Jerry ; > Mohamed, Zaeem ; Wheeler, Daniel > ; Deucher, Alexan

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-05 Thread Alex Deucher
On Mon, Aug 5, 2024 at 3:34 AM Nikita Zhandarovich wrote: > > > > On 7/30/24 23:56, Christian König wrote: > > Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: > >> On 7/29/24 11:12, Christian König wrote: > >>> Am 29.07.24 um 20:04 schrieb Christian König: > Am 29.07.24 um 19:26 schrieb Nik

[PATCH] drm/amdgpu: Add DCC GFX12 flag to enable address alignment

2024-08-05 Thread Arunpravin Paneer Selvam
We require this flag AMDGPU_GEM_CREATE_GFX12_DCC or any other kernel level GFX12 DCC flag to differentiate the DCC buffers and other pinned display buffers(which has TTM_PL_FLAG_CONTIGUOUS enabled). If we use the TTM_PL_FLAG_CONTIGUOUS flag for DCC buffers, we may over allocate for all the pinned

Re: [PATCH v9 0/6] drm/ci: Add support for GPU and display testing

2024-08-05 Thread Daniel Stone
Hi Vignesh, On Tue, 30 Jul 2024 at 03:16, Vignesh Raman wrote: > Some ARM SOCs have a separate display controller and GPU, each with > different drivers. For mediatek mt8173, the GPU driver is powervr, > and the display driver is mediatek. In the case of mediatek mt8183, > the GPU driver is panfr

Re: [PATCH] drm/radeon/evergreen_cs: fix int overflow errors in cs track offsets

2024-08-05 Thread Nikita Zhandarovich
On 7/30/24 23:56, Christian König wrote: > Am 30.07.24 um 19:36 schrieb Nikita Zhandarovich: >> On 7/29/24 11:12, Christian König wrote: >>> Am 29.07.24 um 20:04 schrieb Christian König: Am 29.07.24 um 19:26 schrieb Nikita Zhandarovich: > Hi, > > On 7/29/24 02:23, Christian Köni

Re: [PATCH] drm/amdgpu: add dce6 drm_panic support

2024-08-05 Thread Jocelyn Falempe
On 02/08/2024 11:39, Christian König wrote: Am 02.08.24 um 09:17 schrieb Lu Yao: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- The patch can work properly on the TTY, but after st

[PATCH 2/3] drm/amd: Make amd_ip_funcs static for SDMA v5.2

2024-08-05 Thread tjakobi
From: Tobias Jakobi The struct can be static, as it is only used in this translation unit. Signed-off-by: Tobias Jakobi --- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_2.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm

AMD Radeon out of memory causes system instability.

2024-08-05 Thread James Lawrence
Apologies if I'm hitting the wrong mailing list. long time user, first time reporter and all that. recently my system has been suffering from instability with the graphics system. essentially some application on my system is causing oom for graphics memory. normally I'd just expect a hard crash

Re: [PATCH] drm/amdgpu: add dce6 drm_panic support

2024-08-05 Thread yaolu
在 2024/8/2 17:39, Christian König 写道: Am 02.08.24 um 09:17 schrieb Lu Yao: Add support for the drm_panic module, which displays a pretty user friendly message on the screen when a Linux kernel panic occurs. Signed-off-by: Lu Yao --- The patch can work properly on the TTY, but after start X,

[PATCH 1/3] drm/amd: Make amd_ip_funcs static for SDMA v5.0

2024-08-05 Thread tjakobi
From: Tobias Jakobi The struct can be static, as it is only used in this translation unit. Signed-off-by: Tobias Jakobi --- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/sdma_v5_0.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 0/3] drm/amd: some trivial fixes

2024-08-05 Thread tjakobi
From: Tobias Jakobi Nothing serious here, just some bits I noticed when reading code. Tobias Jakobi (3): drm/amd: Make amd_ip_funcs static for SDMA v5.0 drm/amd: Make amd_ip_funcs static for SDMA v5.2 drm/amdgpu/swsmu: fix SMU11 typos (memlk -> memclk) drivers/gpu/drm/amd/amdgpu/sdma_v5_

[PATCH 3/3] drm/amdgpu/swsmu: fix SMU11 typos (memlk -> memclk)

2024-08-05 Thread tjakobi
From: Tobias Jakobi No functional changes. Signed-off-by: Tobias Jakobi --- drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 4 ++-- drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/

Re: [PATCH] drm/amd/display: remove unneeded semicolon

2024-08-05 Thread David Tadokoro
> No functional modification involved. > > ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_shared.c:6463:166-167: > Unneeded semicolon. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9633 > Signed-off-by: Jiapeng Chong > --- > .../dis

Re: [PATCH v3 0/2] drm: minimum backlight overrides and implementation for amdgpu

2024-08-05 Thread Thomas Weißschuh
Hi, On 2024-08-01 10:52:55+, Hans de Goede wrote: > On 7/31/24 10:55 PM, Daniel Vetter wrote: > > On Wed, Jul 31, 2024 at 08:40:12PM +0300, Jani Nikula wrote: > >> On Wed, 31 Jul 2024, Thomas Weißschuh wrote: > >>> The value of "min_input_signal" returned from ATIF on a Framework AMD 13 > >>>

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-05 Thread Xaver Hugl
Am Do., 1. Aug. 2024 um 14:34 Uhr schrieb Jani Nikula : > > On Mon, 01 Jul 2024, Xaver Hugl wrote: > > Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl > > : > >> Merging can only happen once a real world userspace application has > >> implemented support for it. I'll try to do that sometime

[PATCH][next] drm/amd/display: remove extraneous ; after statements

2024-08-05 Thread Colin Ian King
There are a several statements with two following semicolons, replace these with just one semicolon. Signed-off-by: Colin Ian King --- .../drm/amd/display/dc/dml2/dml21/dml21_translation_helper.c | 2 +- .../dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c| 2 +- .../display/dc/dml2/d