RE: [PATCH] drm/amdgpu: remove RAS unused paramter 'err_addr'

2024-08-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Friday, August 2, 2024 10:19 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Zhou1, Tao ; Chai, Thomas Subject: [PA

RE: [PATCH] drm/amdgpu: remove RAS unused paramter 'err_addr'

2024-08-01 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Due to certain network issues, the same patch has been sent twice. Please ignore this one. Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Friday, August 2, 2024 10:18 AM To: amd-gfx@lists.freedes

[PATCH] drm/amdgpu: remove RAS unused paramter 'err_addr'

2024-08-01 Thread Yang Wang
- amdgpu_ras_error_statistic_ue_count() - amdgpu_ras_error_statistic_ce_count() - amdgpu_ras_error_statistic_de_count() The parameter 'err_addr' is no longer used since following patch. Fixes: efc4009da0dc ("drm/amdgpu: Remove unused code") Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgp

[PATCH] drm/amdgpu: remove RAS unused paramter 'err_addr'

2024-08-01 Thread Yang Wang
- amdgpu_ras_error_statistic_ue_count() - amdgpu_ras_error_statistic_ce_count() - amdgpu_ras_error_statistic_de_count() The parameter 'err_addr' is no longer used since following patch. Fixes: efc4009da0dc ("drm/amdgpu: Remove unused code") Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgp

Re: [PATCH 7/9] drm/panel: panel-sony-acx565akm: Use backlight power constants

2024-08-01 Thread Jessica Zhang
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Reviewed-by

Re: [PATCH 6/9] drm/panel: panel-samsung-s6e3ha2: Use backlight power constants

2024-08-01 Thread Jessica Zhang
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Reviewed-by

Re: [PATCH 5/9] drm/panel: panel-samsung-s6e63j0x03: Use backlight power constants

2024-08-01 Thread Jessica Zhang
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Reviewed-by

Re: [PATCH 4/9] drm/panel: panel-orisetech-otm8009a: Use backlight power constants

2024-08-01 Thread Jessica Zhang
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Neil Armstrong Cc: Jessica Zhang Reviewed-by

Re: [PATCH 3/9] drm/panel: panel-novatak-nt35510: Use backlight power constants

2024-08-01 Thread Jessica Zhang
On 7/31/2024 5:17 AM, Thomas Zimmermann wrote: Replace FB_BLANK_ constants with their counterparts from the backlight subsystem. The values are identical, so there's no change in functionality or semantics. Signed-off-by: Thomas Zimmermann Cc: Linus Walleij Cc: Neil Armstrong Cc: Jessica Z

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-01 Thread Marek Olšák
On Thu, Aug 1, 2024, 03:37 Christian König wrote: > Am 01.08.24 um 08:53 schrieb Marek Olšák: > > On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: > >> >> On 8/1/2024 8:49 AM, Marek Olšák wrote: >> >> + /* Header is at index 0, followed by num_nops - 1 NOP packet's >> */ >> >> + for (

Re: [PATCH 1/3] drm/amdgpu: Forward soft recovery errors to userspace

2024-08-01 Thread Friedrich Vock
Hi, I happened to come across an issue just now again where soft recovery fails to get reported to userspace properly, causing apps to submit hanging work in a loop (which ended up hanging the entire machine) - it seems like this patch never made it into amd-staging-drm-next. Given that it has a

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Jani Nikula
On Thu, 01 Aug 2024, Thomas Zimmermann wrote: > Hi > > Am 01.08.24 um 14:33 schrieb Jani Nikula: >> On Mon, 01 Jul 2024, Xaver Hugl wrote: >>> Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl >>> : Merging can only happen once a real world userspace application has implemented sup

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Thomas Zimmermann
Hi Am 01.08.24 um 14:33 schrieb Jani Nikula: On Mon, 01 Jul 2024, Xaver Hugl wrote: Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : Merging can only happen once a real world userspace application has implemented support for it. I'll try to do that sometime next week in KWin Here's th

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-08-01 Thread Jani Nikula
On Mon, 01 Jul 2024, Xaver Hugl wrote: > Am Do., 20. Juni 2024 um 22:22 Uhr schrieb Xaver Hugl : >> Merging can only happen once a real world userspace application has >> implemented support for it. I'll try to do that sometime next week in >> KWin > > Here's the promised implementation: > https:/

Re: [PATCH 2/9] drm/i915: Use backlight power constants

2024-08-01 Thread Jani Nikula
On Wed, 31 Jul 2024, Thomas Zimmermann wrote: > Hi > > Am 31.07.24 um 14:56 schrieb Jani Nikula: >> On Wed, 31 Jul 2024, Thomas Zimmermann wrote: >>> Replace FB_BLANK_ constants with their counterparts from the >>> backlight subsystem. The values are identical, so there's no >>> change in functio

Re: [PATCH V2 00/53] GC per queue reset

2024-08-01 Thread Christian König
Patches #1, #2 are Acked-by: Christian König . Patches #3, #4 and #5 are Reviewed-by: Christian König . To review the rest I really need to wrap my head around all the userqueue stuff again after my vacation. Regards, Christian. Am 25.07.24 um 17:00 schrieb Alex Deucher: This adds prelimi

RE: [PATCH 3/3] drm/amdgpu: report bad status in GPU recovery

2024-08-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, August 1, 2024 18:00 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 3/3] drm/amdgpu: report bad

RE: [PATCH 2/3] drm/amdgpu: update bad state check in GPU recovery

2024-08-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, August 1, 2024 18:00 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 2/3] drm/amdgpu: update bad

RE: [PATCH 1/3] drm/amdgpu: create function to check RAS RMA status

2024-08-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Thursday, August 1, 2024 18:00 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 1/3] drm/amdgpu: create func

[PATCH 2/3] drm/amdgpu: update bad state check in GPU recovery

2024-08-01 Thread Tao Zhou
Return RMA status without message print. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 96e525ab9a84..5d49f70

[PATCH 3/3] drm/amdgpu: report bad status in GPU recovery

2024-08-01 Thread Tao Zhou
Instead of printing GPU reset failed. v2: add check for reset_context->src. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amd

[PATCH 1/3] drm/amdgpu: create function to check RAS RMA status

2024-08-01 Thread Tao Zhou
In the convenience of calling it globally. Signed-off-by: Tao Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 22 -- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_umc.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v11_0_3.c | 2 +- 4 file

RE: [PATCH] drm/amdgpu: save the funcs of gfx software rings

2024-08-01 Thread Huang, Trigger
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Zhu, Jiadong > Sent: Thursday, August 1, 2024 3:58 PM > To: Huang, Trigger ; amd-gfx@lists.freedesktop.org > Cc: Huang, Trigger > Subject: RE: [PATCH] drm/amdgpu: save the funcs of gfx software rings >

RE: [PATCH] drm/amdgpu: save the funcs of gfx software rings

2024-08-01 Thread Zhu, Jiadong
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of > trigger.hu...@amd.com > Sent: Thursday, August 1, 2024 3:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Huang, Trigger > Subject: [PATCH] drm/amdgpu: save the funcs of gfx softwa

RE: [PATCH] drm/amdgpu: report bad status in GPU recovery

2024-08-01 Thread Zhang, Hawking
[AMD Official Use Only - AMD Internal Distribution Only] How about replace amdgpu_ras_eeprom_check_err_threshold with ras->is_rma and move amdgpu_ras_eeprom_check_err_threshold to end of gpu recovery as the change you made. In such case we don;'t need to add a paremter in the function just to d

Re: [PATCH] drm/amdgpu: optimize the padding with hw optimization

2024-08-01 Thread Christian König
Am 01.08.24 um 08:53 schrieb Marek Olšák: On Thu, Aug 1, 2024, 00:28 Khatri, Sunil wrote: On 8/1/2024 8:49 AM, Marek Olšák wrote: >> +       /* Header is at index 0, followed by num_nops - 1 NOP packet's */ >> +       for (i = 1; i < num_nop; i++) >> +               amdgpu_

[PATCH] drm/amdgpu: save the funcs of gfx software rings

2024-08-01 Thread Trigger.Huang
From: Trigger Huang Currently the funcs variable of a gfx software ring is not set. So if it is visited somewhere, it will lead to error logic being executed. For example, if we want to call some callbacks in funcs of a gfx software ring, like per ring reset, it will be failed due to funcs is NUL

[PATCH 3/4] drm/amdgpu: fix unchecked return value warning for amdgpu_atombios

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 35 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/

[PATCH 4/4] drm/amdgpu: check return for setting engine dram timings

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.h | 4 ++-- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 8 +--- 3 files changed, 11 ins

[PATCH 2/4] drm/amdgpu: fix unchecked return value warning for amdgpu_gfx

2024-08-01 Thread Tim Huang
This resolves the unchecded return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgp

[PATCH 1/4] drm/amd/pm: fix unchecked return value warning for vega10_hwmgr

2024-08-01 Thread Tim Huang
This resolves the unchecked return value warning reported by Coverity. Signed-off-by: Tim Huang --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/dr

RE: [PATCH] drm/amdgpu: report bad status in GPU recovery

2024-08-01 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] We need to perform gpu reset for HW and only make the reset flow failing from driver perspective. Tao > -Original Message- > From: Lazar, Lijo > Sent: Thursday, August 1, 2024 2:41 PM > To: Zhou1, Tao ; Zhang, Hawking > ; amd-gf