Re: [PATCH 1/2] amdgpu: add the amdgpu_vm ptr in the vm_bo_map/unmap events

[AMD Official Use Only - AMD Internal Distribution Only] Let's drop this patch: the amdgpu_vm_*_ptes events already contain all the info I need. Thanks, Pierre-Eric From: Christian König Sent: Monday, June 3, 2024 4:12 PM To: Pierre-Eric Pelloux-Prayer ; Koenig,

Re: [PATCH] drm/amdgpu: revert "take runtime pm reference when we attach a buffer"

Am 05.06.24 um 15:20 schrieb Alex Deucher: On Wed, Jun 5, 2024 at 8:32 AM Christian König wrote: This reverts commit b8c415e3bf989be1b749409951debe6b36f5c78c and commit 425285d39afddaf4a9dab36045b816af0cc3e400. Taking a runtime pm reference for DMA-buf is actually completely unnecessary. Whe

[PATCH v3 0/2] Add support for 'power saving policy' property

During the Display Next hackfest 2024 one of the topics discussed was the need for compositor to be able to relay intention to drivers that color fidelity is preferred over power savings. To accomplish this a new optional DRM property is being introduced called "power saving policy". This propert

[PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

When the `power_saving_policy` property is set to bit mask "Require color accuracy" ABM should be disabled immediately and any requests by sysfs to update will return an -EBUSY error. When the `power_saving_policy` property is set to bit mask "Require low latency" PSR should be disabled. When the

[PATCH v3 1/2] drm: Introduce 'power saving policy' drm property

The `power saving policy` DRM property is an optional property that can be added to a connector by a driver. This property is for compositors to indicate intent of policy of whether a driver can use power saving features that may compromise the experience intended by the compositor. Acked-by: Leo

[PATCH] drm/amdkfd: Extend gfx12 trap handler fix to gfx10/11

In commit 6d1878882d2d ("drm/amdkfd: gfx12 context save/restore trap handler fixes") the following fix was introduced but incorrectly restricted to gfx12. The same issue and a corresponding fix apply to gfx10 and gfx11. Do not overwrite TRAPSTS.{SAVECTX,HOST_TRAP} when restoring this register. Bot

[PATCH] drm/amdgpu: Indicate CU havest info to CP

To achieve full occupancy CP hardware needs to know if CUs in SE are symmetrically or asymmetrically harvested Signed-off-by: Harish Kasiviswanathan --- drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd

RE: [PATCH V2 2/2] drm/amd/display/dcn401: use pre-allocated temp structure for bounding box

[AMD Official Use Only - AMD Internal Distribution Only] Tested-by: George Zhang Thanks, George -Original Message- From: Deucher, Alexander Sent: Tuesday, June 4, 2024 4:26 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Mahfooz, Hamza ; Zhang, George ; Arnd Bergmann ;

Re: [PATCH V2 2/2] drm/amd/display/dcn401: use pre-allocated temp structure for bounding box

On Tue, Jun 4, 2024, at 22:26, Alex Deucher wrote: > Fixes: 669d6b078ed8 ("drm/amd/display: avoid large on-stack structures") > Suggested-by: Hamza Mahfooz > Signed-off-by: Alex Deucher > Cc: George Zhang > Cc: Arnd Bergmann Acked-by: Arnd Bergmann

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

On Tue, Jun 04, 2024 at 10:02:29AM +0800, kernel test robot wrote: > Hi Mario, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on drm-misc/drm-misc-next] > [also build test ERROR on drm/drm-next drm-exynos/exynos-drm-next > drm-intel/for-linux-next drm-intel/

[linux-next:master] BUILD REGRESSION 234cb065ad82915ff8d06ce01e01c3e640b674d2

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 234cb065ad82915ff8d06ce01e01c3e640b674d2 Add linux-next specific files for 20240605 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202406051521.mroqvr5l-...@intel.com https

Re: [PATCH V2 2/2] drm/amd/display/dcn401: use pre-allocated temp structure for bounding box

On 2024-06-04 16:26, Alex Deucher wrote: > This mirrors what the driver does for older DCN generations. > > Should fix: > [ 26.924055] BUG: sleeping function called from invalid context at > include/linux/sched/mm.h:306 > [ 26.924060] in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid:

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

On Wed, Jun 5, 2024 at 12:07 PM Harry Wentland wrote: > > > > On 2024-06-04 11:50, Alex Deucher wrote: > > This mirrors what the driver does for older DCN generations. > > > > Should fix: > > > > BUG: sleeping function called from invalid context at > > include/linux/sched/mm.h:306 > > in_atomic(

Re: [PATCH] drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update

On 2024-06-05 11:46, Srinivasan Shanmugam wrote: > This commit adds a null check for the 'afb' variable in the > amdgpu_dm_plane_handle_cursor_update function. Previously, 'afb' was > assumed to be null, but was used later in the code without a null check. > This could potentially lead to a null

[PATCH] drm/amd/display: Add NULL check for 'afb' before dereferencing in amdgpu_dm_plane_handle_cursor_update

This commit adds a null check for the 'afb' variable in the amdgpu_dm_plane_handle_cursor_update function. Previously, 'afb' was assumed to be null, but was used later in the code without a null check. This could potentially lead to a null pointer dereference. Fixes the below: drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

On 2024-06-04 11:50, Alex Deucher wrote: > This mirrors what the driver does for older DCN generations. > > Should fix: > > BUG: sleeping function called from invalid context at > include/linux/sched/mm.h:306 > in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 449, name: > kworker/u64:8

Re: [PATCH] drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor

On 2024-06-05 10:53, Srinivasan Shanmugam wrote: > This commit adds a null check for the 'afb' variable in the > amdgpu_dm_update_cursor function. Previously, 'afb' was assumed to be > null at line 8388, but was used later in the code without a null check. > This could potentially lead to a null

[PATCH] drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor

This commit adds a null check for the 'afb' variable in the amdgpu_dm_update_cursor function. Previously, 'afb' was assumed to be null at line 8388, but was used later in the code without a null check. This could potentially lead to a null pointer dereference. Fixes the below: drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/display: Simplify if conditions

Applied. Thanks! Alex On Tue, Jun 4, 2024 at 9:07 AM Thorsten Blum wrote: > > The if conditions !A || A && B can be simplified to !A || B. > > Fixes the following Coccinelle/coccicheck warnings reported by > excluded_middle.cocci: > > WARNING !A || A && B is equivalent to !A || B >

Re: [PATCH] drm/amdgpu: revert "take runtime pm reference when we attach a buffer"

On Wed, Jun 5, 2024 at 8:32 AM Christian König wrote: > > This reverts commit b8c415e3bf989be1b749409951debe6b36f5c78c and > commit 425285d39afddaf4a9dab36045b816af0cc3e400. > > Taking a runtime pm reference for DMA-buf is actually completely > unnecessary. > > When the buffer is in GTT it is stil

Re: [PATCH 2/3] drm/xe: drop redundant W=1 warnings from Makefile

On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmissing-prototypes are always > enab

Re: [PATCH] drm/amd/display: Increase frame-larger-than warning limit

On Mon, 03 Jun 2024 15:29:48 PDT (-0700), nat...@kernel.org wrote: Hi Palmer, On Thu, May 30, 2024 at 07:57:42AM -0700, Palmer Dabbelt wrote: From: Palmer Dabbelt I get a handful of build errors along the lines of linux/drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba

Re: [PATCH] drm/amd/display: use GFP_ATOMIC for bounding box

On Tue, Jun 4, 2024, at 16:22, Christian König wrote: > Am 04.06.24 um 15:50 schrieb Alex Deucher: >> This can be called in atomic context. Should fix: >> >> BUG: sleeping function called from invalid context at >> include/linux/sched/mm.h:306 >> in_atomic(): 1, irqs_disabled(): 0, non_block: 0,

Re: [PATCH 1/2][RFC] amdgpu: fix a race in kfd_mem_export_dmabuf()

On Tue, Jun 04, 2024 at 02:08:30PM -0400, Felix Kuehling wrote: > > +int drm_gem_prime_handle_to_fd(struct drm_device *dev, > > + struct drm_file *file_priv, uint32_t handle, > > + uint32_t flags, > > + int *prime_fd) > > +{

[PATCH v2 1/2][RFC] amdgpu: fix a race in kfd_mem_export_dmabuf()

[now without a descriptor leak; it really needs testing, though] Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into descriptor table, only to have it looked up by file descriptor and remove it from descriptor table is not just too convoluted - it's racy; another thread might ha

Re: [PATCH 2/2][RFC] amdkfd CRIU fixes

On Tue, Jun 04, 2024 at 02:16:00PM -0400, Felix Kuehling wrote: > > On 2024-06-03 22:14, Al Viro wrote: > > Instead of trying to use close_fd() on failure exits, just have > > criu_get_prime_handle() store the file reference without inserting > > it into descriptor table. > > > > Then, once the c

Re: [PATCH 3/3] drm/amdgpu: drop redundant W=1 warnings from Makefile

On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmissing-prototypes are always > enab

Re: [PATCH 1/2] drm/amd/display: use pre-allocated temp structure for bounding box

On Tue, Jun 4, 2024, at 20:06, Alex Deucher wrote: > This mirrors what the driver does for older DCN generations. > > Should fix: > > BUG: sleeping function called from invalid context at > include/linux/sched/mm.h:306 > in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 449, name: > kworker/

Re: [PATCH] kernel/resource: optimize find_next_iomem_res

On Thu, May 30, 2024 at 10:36:57PM -0700, Chia-I Wu wrote: > We can skip children resources when the parent resource does not cover > the range. > > This should help vmf_insert_* users on x86, such as several DRM drivers. > On my AMD Ryzen 5 7520C, when streaming data from cpu memory into amdgpu >

Re: [PATCH 1/3] drm/i915: drop redundant W=1 warnings from Makefile

On Thu, 23 May 2024, Jani Nikula wrote: > Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default > across the subsystem"), most of the extra warnings in the driver > Makefile are redundant. Remove them. > > Note that -Wmissing-declarations and -Wmissing-prototypes are always > enab

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

I sent a separate patch for DCN 401. On Wed, Jun 5, 2024 at 8:37 AM Pillai, Aurabindo wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > > Hi Alex, > > I'll a hunk for fixing DCN401 as well to this and resend it later today. > > > -- > > Regards, > Jay > _

RE: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility

[AMD Official Use Only - AMD Internal Distribution Only] Hi Chris, I have checked my inbox and did not see your email. Could you please resend it? Best Regards, Kevin -Original Message- From: Koenig, Christian Sent: Wednesday, June 5, 2024 7:21 PM To: Wang, Yang(Kevin) ; amd-gfx@lists.

[PATCH] drm/amdgpu: revert "take runtime pm reference when we attach a buffer"

This reverts commit b8c415e3bf989be1b749409951debe6b36f5c78c and commit 425285d39afddaf4a9dab36045b816af0cc3e400. Taking a runtime pm reference for DMA-buf is actually completely unnecessary. When the buffer is in GTT it is still accessible even when the GPU is powered down and when it is in VRAM

RE: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

[AMD Official Use Only - AMD Internal Distribution Only] Hi, Christian If you just want to know the status of MES , then this approach is ok . My original thinking is the driver might also need to know the status of the functionality it requires . ex . after call remove_queue , whether the CP

Re: [PATCH] Revert "drm/amd/display: avoid large on-stack structures"

[AMD Official Use Only - AMD Internal Distribution Only] Thanks for the heads up! -- Regards, Jay From: Mahfooz, Hamza Sent: Tuesday, June 4, 2024 1:50 PM To: Pillai, Aurabindo ; amd-gfx@lists.freedesktop.org Cc: a...@arndb.de ; Deucher, Alexander ; Wentland,

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

[AMD Official Use Only - AMD Internal Distribution Only] Hi Alex, I'll a hunk for fixing DCN401 as well to this and resend it later today. -- Regards, Jay From: amd-gfx on behalf of Zhang, George Sent: Tuesday, June 4, 2024 12:49 PM To: Deucher, Alexander ;

[PATCH AUTOSEL 6.1 13/14] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

From: Jesse Zhang [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent. Signed-off-by: Jesse Zhang Suggested-by: Christian König Reviewed-by: Christian König S

[PATCH AUTOSEL 6.6 17/18] Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"

From: Alex Deucher [ Upstream commit dd2b75fd9a79bf418e088656822af06fc253dbe3 ] This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8. Revert this commit as apparently the LLVM code to take advantage of this never landed. Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Cc: Feifei X

[PATCH AUTOSEL 6.6 16/18] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

From: Jesse Zhang [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent. Signed-off-by: Jesse Zhang Suggested-by: Christian König Reviewed-by: Christian König S

[PATCH AUTOSEL 6.6 15/18] drm/amdgpu: silence UBSAN warning

From: Alex Deucher [ Upstream commit 05d9e24ddb15160164ba6e917a88c00907dc2434 ] Convert a variable sized array from [1] to []. Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- 1 file changed, 1 inserti

Re: 6.10/bisected/regression - commits bc87d666c05 and 6d4279cb99ac cause appearing green flashing bar on top of screen on Radeon 6900XT and 120Hz

On Sun, May 26, 2024 at 7:06 PM Mikhail Gavrilov wrote: > > Hi, > Day before yesterday I replaced 7900XTX to 6900XT for got clear in > which kernel first time appeared warning message "DMA-API: amdgpu > :0f:00.0: cacheline tracking EEXIST, overlapping mappings aren't > supported". > The kernel

[PATCH AUTOSEL 6.8 17/18] Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"

From: Alex Deucher [ Upstream commit dd2b75fd9a79bf418e088656822af06fc253dbe3 ] This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8. Revert this commit as apparently the LLVM code to take advantage of this never landed. Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Cc: Feifei X

[PATCH AUTOSEL 6.8 16/18] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

From: Jesse Zhang [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent. Signed-off-by: Jesse Zhang Suggested-by: Christian König Reviewed-by: Christian König S

[PATCH AUTOSEL 6.8 15/18] drm/amdgpu: silence UBSAN warning

From: Alex Deucher [ Upstream commit 05d9e24ddb15160164ba6e917a88c00907dc2434 ] Convert a variable sized array from [1] to []. Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- 1 file changed, 1 inserti

[PATCH AUTOSEL 6.9 19/23] drm/amdgpu: silence UBSAN warning

From: Alex Deucher [ Upstream commit 05d9e24ddb15160164ba6e917a88c00907dc2434 ] Convert a variable sized array from [1] to []. Reviewed-by: Christian König Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/include/atomfirmware.h | 2 +- 1 file changed, 1 inserti

[PATCH AUTOSEL 6.9 21/23] Revert "drm/amdkfd: fix gfx_target_version for certain 11.0.3 devices"

From: Alex Deucher [ Upstream commit dd2b75fd9a79bf418e088656822af06fc253dbe3 ] This reverts commit 28ebbb4981cb1fad12e0b1227dbecc88810b1ee8. Revert this commit as apparently the LLVM code to take advantage of this never landed. Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher Cc: Feifei X

[PATCH AUTOSEL 6.9 20/23] drm/amdgpu: fix dereference null return value for the function amdgpu_vm_pt_parent

From: Jesse Zhang [ Upstream commit a0cf36546cc24ae1c95d72253c7795d4d2fc77aa ] The pointer parent may be NULLed by the function amdgpu_vm_pt_parent. To make the code more robust, check the pointer parent. Signed-off-by: Jesse Zhang Suggested-by: Christian König Reviewed-by: Christian König S

[PATCH AUTOSEL 6.9 03/23] drm/amdgpu: correct hbm field in boot status

From: Hawking Zhang [ Upstream commit ec58991054e899c9d86f7e3c8a96cb602d4b5938 ] hbm filed takes bit 13 and bit 14 in boot status. Signed-off-by: Hawking Zhang Reviewed-by: Tao Zhou Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 2 +- 1

[PATCH AUTOSEL 6.8 4/6] drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs

From: Lang Yu [ Upstream commit eb853413d02c8d9b27942429b261a9eef228f005 ] Small APUs(i.e., consumer, embedded products) usually have a small carveout device memory which can't satisfy most compute workloads memory allocation requirements. We can't even run a Basic MNIST Example with a default

[PATCH AUTOSEL 6.8 3/6] drm/amdkfd: handle duplicate BOs in reserve_bo_and_cond_vms

From: Lang Yu [ Upstream commit 2a705f3e49d20b59cd9e5cc3061b2d92ebe1e5f0 ] Observed on gfx8 ASIC where KFD_IOC_ALLOC_MEM_FLAGS_AQL_QUEUE_MEM is used. Two attachments use the same VM, root PD would be locked twice. [ 57.910418] Call Trace: [ 57.793726] ? reserve_bo_and_cond_vms+0x111/0x1c0

[PATCH AUTOSEL 6.9 4/6] drm/amdkfd: Let VRAM allocations go to GTT domain on small APUs

From: Lang Yu [ Upstream commit eb853413d02c8d9b27942429b261a9eef228f005 ] Small APUs(i.e., consumer, embedded products) usually have a small carveout device memory which can't satisfy most compute workloads memory allocation requirements. We can't even run a Basic MNIST Example with a default

[PATCH AUTOSEL 6.9 3/6] drm/amdkfd: handle duplicate BOs in reserve_bo_and_cond_vms

From: Lang Yu [ Upstream commit 2a705f3e49d20b59cd9e5cc3061b2d92ebe1e5f0 ] Observed on gfx8 ASIC where KFD_IOC_ALLOC_MEM_FLAGS_AQL_QUEUE_MEM is used. Two attachments use the same VM, root PD would be locked twice. [ 57.910418] Call Trace: [ 57.793726] ? reserve_bo_and_cond_vms+0x111/0x1c0

Re: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility

You haven't addressed any of my comments on patch #1. Regards, Christian. Am 05.06.24 um 11:33 schrieb Wang, Yang(Kevin): [AMD Official Use Only - AMD Internal Distribution Only] Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Monday, June 3

Page fault storms and IH ring overflow

Hi guys, just FYI: Alex published yesterday a bunch of new firmware files: https://gitlab.freedesktop.org/drm/firmware/-/commits/amd-staging One major issue which should be fixed by those is that page faults can no longer overflow the IH ring buffer on APUs and older dGPUs. Newer dGPU with

Re: [RFC PATCH v4 00/42] Color Pipeline API w/ VKMS

On 02/26, Harry Wentland wrote: > This is an RFC set for a color pipeline API, along with a sample > implementation in VKMS. All the key API bits are here. VKMS now > supports two named transfer function colorops and two matrix > colorops. We have IGT tests that check all four of these colorops > w

RE: [PATCH] drm/amdgpu: move some aca/mca init functions into ras_init() stage

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Wednesday, June 5, 2024 5:32 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > > Subject: [PATCH] drm/amdgpu: move some aca/mca

RE: [PATCH 00/18] Enhance amdgpu_firmware_request() to improve function flexibility

[AMD Official Use Only - AMD Internal Distribution Only] Ping... Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Yang Wang Sent: Monday, June 3, 2024 9:42 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Deucher, Alexander Subject: [PATCH 00/18] Enhance amdg

[PATCH] drm/amdgpu: move some aca/mca init functions into ras_init() stage

adjust the function position to better match aca/mca fini code in ras_fini(). Signed-off-by: Yang Wang --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 28 ++--- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gp

Re: [PATCH 1/2][RFC] amdgpu: fix a race in kfd_mem_export_dmabuf()

Am 04.06.24 um 20:08 schrieb Felix Kuehling: On 2024-06-03 22:13, Al Viro wrote: Using drm_gem_prime_handle_to_fd() to set dmabuf up and insert it into descriptor table, only to have it looked up by file descriptor and remove it from descriptor table is not just too convoluted - it's racy; anot

Re: [PATCH] drm/amdgpu: add reset source in various cases

Am 04.06.24 um 17:58 schrieb Eric Huang: To fullfill the reset event description. Suggested-by: Lijo Lazar Signed-off-by: Eric Huang Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 1 + drivers/gpu/drm/amd/a

Re: [PATCH] drm/amd/display: use pre-allocated temp structure for bounding box

Am 04.06.24 um 17:50 schrieb Alex Deucher: This mirrors what the driver does for older DCN generations. Should fix: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 449, name: kworker/u64:8 preempt_count:

Re: [PATCH] drm/amd/display: use GFP_ATOMIC for bounding box

Am 04.06.24 um 16:57 schrieb Arnd Bergmann: On Tue, Jun 4, 2024, at 16:22, Christian König wrote: Am 04.06.24 um 15:50 schrieb Alex Deucher: This can be called in atomic context. Should fix: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:306 in_atomic(): 1, ir

RE: [PATCH 1/12 V2] drm/amd/pm: remove dead code in si_convert_power_level_to_smc

[Public] This patch is, Reviewed-by: Tim Huang > -Original Message- > From: Jesse Zhang > Sent: Wednesday, June 5, 2024 4:34 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Huang, Tim ; Zhang, > Jesse(Jie) ; Zhang, Jesse(Jie) > > Subject: [PAT

RE: [PATCH 4/12 V2] drm/amdgpu: remove dead code in atom_get_src_int

[Public] This patch is, Reviewed-by: Tim Huang > -Original Message- > From: Jesse Zhang > Sent: Wednesday, June 5, 2024 4:34 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Huang, Tim ; Zhang, > Jesse(Jie) ; Zhang, Jesse(Jie) > > Subject: [PAT

[PATCH 4/12 V2] drm/amdgpu: remove dead code in atom_get_src_int

Since the range of align is 0~7, the expression is: align = (attr >> 3) & 7. In the case of ATOM_ARG_IMM, the code cannot reach the default case. So there is no need for "break". Signed-off-by: Jesse Zhang Suggested-by: Tim Huang --- drivers/gpu/drm/amd/amdgpu/atom.c | 8 1 file change

[PATCH 1/12 V2] drm/amd/pm: remove dead code in si_convert_power_level_to_smc

Since gmc_pg is false, setting mcFlags with SISLANDS_SMC_MC_PG_EN cannot be reach. Signed-off-by: Jesse Zhang Suggested-by: Tim Huang --- drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c b/drivers/gpu

Re: [PATCH] drm/amdgpu: Fix the BO release clear memory warning

Hi Christian, On 5/7/2024 8:21 PM, Christian König wrote: Am 06.05.24 um 15:48 schrieb Arunpravin Paneer Selvam: This happens when the amdgpu_bo_release_notify running before amdgpu_ttm_set_buffer_funcs_status set the buffer funcs to enabled. check the buffer funcs enablement before calling th

RE: [PATCH 5/5] drm/amdgpu: add ras fatal flag to distingush fatal error reset

[AMD Official Use Only - AMD Internal Distribution Only] Series is Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Friday, May 31, 2024 18:49 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 5/5] drm/amdgpu: add

Re: [PATCH v4 6/9] drm/amdgpu: call flush_gpu_tlb directly in gfxhub enable

Am 05.06.24 um 03:33 schrieb Yunxiang Li: Here since we are in reset and takes the reset_domain write side lock already. We can't use the flush tlb helper which tries to take the read side. Signed-off-by: Yunxiang Li Please add some code comments with a TODO that this needs more investigatio

RE: [PATCH 05/12] drm/amd/pm: remove dead code in navi10_emit_clk_levels and navi10_print_clk_levels

[Public] This patch is, Reviewed-by: Tim Huang > -Original Message- > From: Jesse Zhang > Sent: Monday, June 3, 2024 4:48 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Kuehling, Felix ; > Huang, Tim ; Zhang, Jesse(Jie) > ; Zhang, Jesse(Jie)

RE: [PATCH 2/5] drm/amdgpu: trigger mode1 reset for RAS RMA status

[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: Friday, May 31, 2024 18:49 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: [PATCH 2/5] drm/amdgpu: trigger mode1 r

RE: [PATCH 04/12] drm/amdgpu: remove dead code in atom_get_src_int

[AMD Official Use Only - AMD Internal Distribution Only] Hi Jesse, > -Original Message- > From: Jesse Zhang > Sent: Monday, June 3, 2024 4:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Kuehling, Felix ; > Huang, Tim ; Zhang, Jesse(Jie) > ; Zha

RE: [PATCH 01/12] drm/amd/pm: remove dead code in si_convert_power_level_to_smc

[Public] Hi Jesse, > -Original Message- > From: Jesse Zhang > Sent: Monday, June 3, 2024 4:46 PM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Koenig, Christian > ; Kuehling, Felix ; > Huang, Tim ; Zhang, Jesse(Jie) > ; Zhang, Jesse(Jie) > Subject: [PATCH 01/12] drm/amd