Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Limonciello, Mario
Also a direct acpi_lid_open() call seems a bit iffy. But I guess if someone needs this to work on non-ACPI system they get to figure out how to abstract it better. acpi_lid_open() does seem to return != 0 when ACPI is not supported, so at least it would err on the side of enabling everything.

[PATCH 8/8] drm/amdkfd: remove dead code in kfd_create_vcrat_image_gpu

2024-05-29 Thread Jesse Zhang
Since the value of avail_size is at least VCRAT_SIZE_FOR_GPU(16384), minus struct crat_header(40UL) and struct crat_subtype_compute(40UL) it cannot be less than 0. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drive

[PATCH 7/8] drm/amdkfd: Comment out the unused variable use_static in pm_map_queues_v9

2024-05-29 Thread Jesse Zhang
To fix the warning about unused value, comment out the variable use_static. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_packet_manager_v9.c b/drivers/gpu/drm/

[PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags

2024-05-29 Thread Jesse Zhang
The varible uncached set false, the condition uncached cannot be true. So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags

2024-05-29 Thread Jesse Zhang
The varible uncached set false, the condition uncached cannot be true. So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[PATCH 5/8] drm/amdkfd: fix the return for the function kfd_dbg_trap_set_flags

2024-05-29 Thread Jesse Zhang
If the rewind flag is set, it should return the final result of setting mes debug mode or refresh the run list. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c b/

[PATCH 4/8] amd/amdkfd:fix overflowed constant in the function svm_migrate_copy_to_ram

2024-05-29 Thread Jesse Zhang
If the svm migration copy memory gart fails or the dma mapping page fails for the first time. But the variable i is still 0, and executing i-- will overflow. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH 3/8] drm/amdkfd: fix overflow for the function criu_restore_bos

2024-05-29 Thread Jesse Zhang
When copying the information from the user fails, it will goto exit. But the variable i remains at 0, and do i-- will overflow. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd

[PATCH 2/8] drm/amdkfd: fix the kdf debugger issue

2024-05-29 Thread Jesse Zhang
the expression caps | HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED is always 1/true regardless of the values of its operand. Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 1/8] drm/amdgu: fix Unintentional integer overflow for mall size

2024-05-29 Thread Jesse Zhang
Potentially overflowing expression mall_size_per_umc * adev->gmc.num_umc with type unsigned int (32 bits, unsigned) is evaluated using 32-bit arithmetic,and then used in a context that expects an expression of type u64 (64 bits, unsigned). Signed-off-by: Jesse Zhang --- drivers/gpu/drm/amd/amd

[PATCH 3/3] drm/amd/amdgpu: Enable MMHUB prefetch for ISP v4.1.0 and 4.1.1

2024-05-29 Thread Yifan Zhang
From: Pratap Nirujogi Remove temporary WA to disable ISP prefetch as MMHUB SAW is initialized to support ISP HW access GART memory using the TLSi path with prefetch enabled. Signed-off-by: Pratap Nirujogi Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/isp_v4_1_0.c | 12

[PATCH 2/3] drm/amdgpu: disable lane0 L1TLB and enable lane1 L1TLB

2024-05-29 Thread Yifan Zhang
This patch to disable lane0 L1TLB and enable lane1 L1TLB. Signed-off-by: Yifan Zhang Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c b/drivers/gpu/drm/amd/amdgp

[PATCH 1/3] drm/amdgpu: init SAW registers for mmhub v3.3

2024-05-29 Thread Yifan Zhang
This patch to configure mmhub3.3 SAW registers Signed-off-by: Yifan Zhang Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 40 + 1 file changed, 40 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c b/drivers/gpu/drm/amd/amdg

RE: [PATCH v2 04/10] drm/amdgpu/kfd: remove is_hws_hang and is_resetting

2024-05-29 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] > One thing I could see going wrong is, that down_read_trylock(&dqm->dev- > >adev->reset_domain->sem) will not fail immediately when the reset is > scheduled. So there may be multipe attempts at HW access that detect an > error or time out,

Re: [PATCH v2 04/10] drm/amdgpu/kfd: remove is_hws_hang and is_resetting

2024-05-29 Thread Felix Kuehling
On 2024-05-28 13:23, Yunxiang Li wrote: > is_hws_hang and is_resetting serves pretty much the same purpose and > they all duplicates the work of the reset_domain lock, just check that > directly instead. This also eliminate a few bugs listed below and get > rid of dqm->ops.pre_reset. > > kfd_hw

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-29 Thread Jessica Zhang
On 5/28/2024 7:40 PM, Vignesh Raman wrote: Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since some jobs takes more than 1 hour to complete. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman Reviewed-by

Re: [PATCH v2] drm/amdkfd: Handle deallocated VPGRs in gfx11+ trap handler

2024-05-29 Thread Jay Cornwall
On 5/29/2024 16:07, Lancelot SIX wrote: On 29/05/2024 20:35, Jay Cornwall wrote: A wavefront may deallocate its VGPRs at the end of a program while waiting for memory transactions to complete. If it subsequently receives a context save exception it will be unable to save, since this requires VG

[PATCH] drm/radeon: Remove __counted_by from StateArray.states[]

2024-05-29 Thread Nathan Chancellor
ptable.h @@ -439,7 +439,7 @@ typedef struct _StateArray{ //how many states we have UCHAR ucNumEntries; -ATOM_PPLIB_STATE_V2 states[] __counted_by(ucNumEntries); +ATOM_PPLIB_STATE_V2 states[] /* __counted_by(ucNumEntries) */; }StateArray; --- base-commit: e64e8f7c178e5228e0b2d

Re: [PATCH v3 5/6] drm/ci: skip driver specific tests

2024-05-29 Thread Jessica Zhang
On 5/28/2024 7:40 PM, Vignesh Raman wrote: Skip driver specific tests and skip kms tests for panfrost driver since it is not a kms driver. Reviewed-by: Dmitry Baryshkov Signed-off-by: Vignesh Raman Reviewed-by: Jessica Zhang --- v2: - Skip xe tests for amdgpu and virtio. v3: -

Re: [PATCH v3 2/6] drm/ci: add farm variable

2024-05-29 Thread Jessica Zhang
On 5/28/2024 7:40 PM, Vignesh Raman wrote: Mesa uses structured logs for logging and debug purpose, https://mesa.pages.freedesktop.org/-/mesa/-/jobs/59165650/artifacts/results/job_detail.json Since drm-ci uses the mesa scripts, add the farm variable and update the device type for missing jobs

Re: [PATCH v3 1/6] drm/ci: uprev mesa version

2024-05-29 Thread Jessica Zhang
On 5/28/2024 7:40 PM, Vignesh Raman wrote: zlib.net is not allowing tarball download anymore and results in below error in kernel+rootfs_arm32 container build, urllib.error.HTTPError: HTTP Error 403: Forbidden urllib.error.HTTPError: HTTP Error 415: Unsupported Media Type Uprev mesa to latest

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 2:47 AM Wolfram Sang wrote: > > Hi Alex, > > On Thu, May 09, 2024 at 01:15:32PM -0400, Alex Deucher wrote: > > On Thu, May 9, 2024 at 8:02 AM Heiner Kallweit wrote: > > > > > > Support for I2C_CLASS_SPD is currently being removed from the kernel. > > > Only remaining step

Re: [PATCH v2] drm/amdkfd: Handle deallocated VPGRs in gfx11+ trap handler

2024-05-29 Thread Lancelot SIX
On 29/05/2024 20:35, Jay Cornwall wrote: A wavefront may deallocate its VGPRs at the end of a program while waiting for memory transactions to complete. If it subsequently receives a context save exception it will be unable to save, since this requires VGPRs. In this case the trap handler shou

[PATCH v2] drm/amdkfd: Handle deallocated VPGRs in gfx11+ trap handler

2024-05-29 Thread Jay Cornwall
A wavefront may deallocate its VGPRs at the end of a program while waiting for memory transactions to complete. If it subsequently receives a context save exception it will be unable to save, since this requires VGPRs. In this case the trap handler should terminate the wavefront. Fixes intermitten

Re: [PATCH v3 4/6] drm/ci: uprev IGT

2024-05-29 Thread Abhinav Kumar
On 5/29/2024 2:48 AM, Vignesh Raman wrote: Hi Dmitry, On 29/05/24 13:39, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 08:10:47AM +0530, Vignesh Raman wrote: test-list.txt and test-list-full.txt are not generated for cross-builds and they are required by drm-ci for testing arm32 targets.

RE: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

2024-05-29 Thread Wang, Yang(Kevin)
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Yang Wang Best Regards, Kevin -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, May 30, 2024 2:08 AM To: Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu/

Re: [PATCH] drm/amdgpu/soc24: use common nbio callback to set remap offset

2024-05-29 Thread Alex Deucher
Ping? On Wed, May 8, 2024 at 3:42 PM Alex Deucher wrote: > > This fixes HDP flushes on systems with non-4K pages. > > Signed-off-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/soc24.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/soc

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 06:39:21PM +0300, Ville Syrjälä wrote: > On Wed, May 29, 2024 at 09:45:55AM -0500, Mario Limonciello wrote: > > On 5/29/2024 09:14, Ville Syrjälä wrote: > > > On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > > >> If the lid on a laptop is closed when eDP

[linux-next:master] BUILD REGRESSION 9d99040b1bc8dbf385a8aa535e9efcdf94466e19

2024-05-29 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 9d99040b1bc8dbf385a8aa535e9efcdf94466e19 Add linux-next specific files for 20240529 Error/Warning ids grouped by kconfigs: gcc_recent_errors |-- alpha-allyesconfig | |-- drivers-gpu-drm-imx

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
If you don't hook into some lid notify event how is one supposed to get the display back to life after opening the lid? I guess in my mind it's a tangential to the "initial modeset". The DRM master can issue a modeset to enable the combination as desired. This code is run whenever there's

RE: [PATCH v1 1/3] drm/amdgpu: add gfx9 register support in ipdump

2024-05-29 Thread Khatri, Sunil
[AMD Official Use Only - AMD Internal Distribution Only] -Original Message- From: Alex Deucher Sent: Wednesday, May 29, 2024 7:16 PM To: Khatri, Sunil Cc: Deucher, Alexander ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH v1 1/3] drm/amdgpu: add gfx9 register sup

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Ville Syrjälä
On Wed, May 29, 2024 at 09:45:55AM -0500, Mario Limonciello wrote: > On 5/29/2024 09:14, Ville Syrjälä wrote: > > On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it remains enabled when the initial

Re: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Christian König
Am 29.05.24 um 16:48 schrieb Li, Yunxiang (Teddy): [AMD Official Use Only - AMD Internal Distribution Only] Yeah, I know. That's one of the reason I've pointed out on the patch adding that that this behavior is actually completely broken. If you run into issues with the MES because of this the

RE: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] > Yeah, I know. That's one of the reason I've pointed out on the patch adding > that that this behavior is actually completely broken. > > If you run into issues with the MES because of this then please suggest a > revert of that patch. I t

Re: [PATCH 1/4] [RESEND] drm/amd/display: dynamically allocate dml2_configuration_options structures

2024-05-29 Thread Alex Deucher
Applied the series. Thanks! Alex On Tue, May 28, 2024 at 7:52 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > This structure is too large to fit on a stack, as shown by the > newly introduced warnings from a recent code change: > > drivers/gpu/drm/amd/amdgpu/../display/dc/resource/dcn32/dc

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 09:14, Ville Syrjälä wrote: On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the initial framebuffer configuration is built. When creating the initial framebuffer confi

Re: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Christian König
Am 29.05.24 um 16:31 schrieb Li, Yunxiang (Teddy): [Public] The problem is that we don't force complete the non scheduler rings, e.g. MES, KIQ etc... Try to remove this check here from the loop in amdgpu_device_pre_asic_reset(): if (!amdgpu_ring_sched_ready(ring))

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Mario Limonciello
On 5/29/2024 08:55, Alex Deucher wrote: On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: On Wed, 29 May 2024, Alex Deucher wrote: On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: If the lid on a laptop is closed when eDP connectors are populated then it remains enabled when the

RE: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Li, Yunxiang (Teddy)
[Public] > The problem is that we don't force complete the non scheduler rings, e.g. MES, > KIQ etc... > > Try to remove this check here from the loop in > amdgpu_device_pre_asic_reset(): > > if (!amdgpu_ring_sched_ready(ring)) > continue; Ah, I see. Thou

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Ville Syrjälä
On Tue, May 28, 2024 at 04:03:19PM -0500, Mario Limonciello wrote: > If the lid on a laptop is closed when eDP connectors are populated > then it remains enabled when the initial framebuffer configuration > is built. > > When creating the initial framebuffer configuration detect the ACPI > lid sta

Re: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Christian König
Am 29.05.24 um 15:44 schrieb Li, Yunxiang (Teddy): [AMD Official Use Only - AMD Internal Distribution Only] I don't think trying to add some reset handling here makes sense in the first place. Part of the reset/recovery procedure is to signal all fence and that includes the one we are waiting

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 9:51 AM Jani Nikula wrote: > > On Wed, 29 May 2024, Alex Deucher wrote: > > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > > wrote: > >> > >> If the lid on a laptop is closed when eDP connectors are populated > >> then it remains enabled when the initial framebuffer

RE: [PATCH] MAINTAINERS: update email for Evan Quan

2024-05-29 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Wolfram Sang > Sent: Wednesday, May 29, 2024 7:46 AM > To: linux-ker...@vger.kernel.org > Cc: Wolfram Sang ; Evan Quan > ; amd-gfx@lists.freedesktop.org > Subject: [PATCH] MAINTAINERS: update email for Evan Quan > > The old emai

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Jani Nikula
On Wed, 29 May 2024, Alex Deucher wrote: > On Tue, May 28, 2024 at 5:03 PM Mario Limonciello > wrote: >> >> If the lid on a laptop is closed when eDP connectors are populated >> then it remains enabled when the initial framebuffer configuration >> is built. >> >> When creating the initial framebu

Re: [bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-05-29 Thread Alex Deucher
DId you also update mesa? There could be a UMD change that causes the page faults. Alex On Wed, May 29, 2024 at 3:37 AM Christian König wrote: > > Hi, > > when the issue is easy to reproduce I suggest to bisect the changes > between 6.9 and 6.10-rc1. > > On the other hand it's not unlikely that

Re: [PATCH v1 1/3] drm/amdgpu: add gfx9 register support in ipdump

2024-05-29 Thread Alex Deucher
On Wed, May 29, 2024 at 5:50 AM Sunil Khatri wrote: > > Add general registers of gfx9 in ipdump for > devcoredump support. > > Signed-off-by: Sunil Khatri > --- > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 124 +- > 1 file changed, 123 insertions(+), 1 deletion(-) > > diff -

RE: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Li, Yunxiang (Teddy)
[AMD Official Use Only - AMD Internal Distribution Only] > I don't think trying to add some reset handling here makes sense in the first > place. > Part of the reset/recovery procedure is to signal all fence and that includes > the one we are waiting for here. > So this wait should return immedi

Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during initialization

2024-05-29 Thread Alex Deucher
On Tue, May 28, 2024 at 5:03 PM Mario Limonciello wrote: > > If the lid on a laptop is closed when eDP connectors are populated > then it remains enabled when the initial framebuffer configuration > is built. > > When creating the initial framebuffer configuration detect the ACPI > lid status and

Re: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Christian König
Am 29.05.24 um 15:22 schrieb Li, Yunxiang (Teddy): [Public] It's perfectly possible that the reset has already started before we enter the function. Yeah, this could and does happen, but it just means we are back to the old behavior. I guess I could use "can I take the read side lock?" to te

[bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-05-29 Thread Wang Yunchen
Hello, After upgrading to Linux 6.10-rc1 (Mesa is left untouched) I identified a strange bug that could cause the GPU to crash and reset while playing videos online with VA-API. The screen would first start to jitter, then flicker once or twice, but the desktop session couldn't be brought back.

Re: [linux-next:master] BUILD REGRESSION 6dc544b66971c7f9909ff038b62149105272d26a

2024-05-29 Thread David Sterba
On Wed, May 29, 2024 at 02:19:47AM +0800, kernel test robot wrote: > tree/branch: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > branch HEAD: 6dc544b66971c7f9909ff038b62149105272d26a Add linux-next > specific files for 20240528 > > Error/Warning reports: > > htt

[PATCH] MAINTAINERS: update email for Evan Quan

2024-05-29 Thread Wolfram Sang
The old email address bounced. I found the newer one in recent git history, update MAINTAINERS accordingly. Cc: Evan Quan Signed-off-by: Wolfram Sang --- Against v6.10-rc1. Still needs ack from Evan Quan MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINE

[PATCH 0/2] Fix alignment in comment blocks

2024-05-29 Thread Bruno Rocha Levi
Hi! This patchset fixes two alignment issues in comment blocks throughout the codebase. These changes fix codestyle warnings reported from checkpatch and are intended to improve code readability. Thanks, Bruno Rocha Levi (2): drm/vkms: Fix misalignment in comment block drivers/gpu: Fix misal

[PATCH 2/2] drivers/gpu: Fix misalignment in comment block

2024-05-29 Thread Bruno Rocha Levi
This patch fixes a warning from checkpatch by ensuring the trailing */ is aligned with the rest of the *, improving readability. Co-developed-by: Lucas Antonio Signed-off-by: Lucas Antonio Signed-off-by: Bruno Rocha Levi --- drivers/gpu/drm/amd/acp/include/acp_gfx_if.h | 2 +- 1 file changed,

Re: [PATCH v4 3/3] drm/display: split DSC helpers from DP helpers

2024-05-29 Thread Marijn Suijten
On 2024-05-28 22:39:20, Dmitry Baryshkov wrote: > Currently the DRM DSC functions are selected by the > DRM_DISPLAY_DP_HELPER Kconfig symbol. This is not optimal, since the DSI > code (both panel and host drivers) end up selecting the seemingly > irrelevant DP helpers. Split the DSC code to be guar

Re: [PATCH v4 2/3] drm/panel/lg-sw43408: mark sw43408_backlight_ops as static

2024-05-29 Thread Marijn Suijten
On 2024-05-28 22:39:19, Dmitry Baryshkov wrote: > Fix sparse warning regarding symbol 'sw43408_backlight_ops' not being > declared. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202404200739.hbwzvohr-...@intel.com/ > Reviewed-by: Neil Armstrong > Fixes: 06

Re: [PATCH] drm/amd/pm: remove deprecated I2C_CLASS_SPD support from newly added SMU_14_0_2

2024-05-29 Thread Wolfram Sang
Hi Alex, On Thu, May 09, 2024 at 01:15:32PM -0400, Alex Deucher wrote: > On Thu, May 9, 2024 at 8:02 AM Heiner Kallweit wrote: > > > > Support for I2C_CLASS_SPD is currently being removed from the kernel. > > Only remaining step is to remove the definition of I2C_CLASS_SPD. > > Setting I2C_CLASS

Re: [PATCH v4 1/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER

2024-05-29 Thread Marijn Suijten
On 2024-05-28 22:39:18, Dmitry Baryshkov wrote: > This panel driver uses DSC PPS functions and as such depends on the > DRM_DISPLAY_DP_HELPER. Select this symbol to make required functions > available to the driver. > > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild

RE: [PATCH v2 03/10] drm/amdgpu: abort fence poll if reset is started

2024-05-29 Thread Li, Yunxiang (Teddy)
[Public] > It's perfectly possible that the reset has already started before we enter > the function. Yeah, this could and does happen, but it just means we are back to the old behavior. I guess I could use "can I take the read side lock?" to test if the function is called outside of reset or

Re: [PATCH] drm/amdgpu: drop MES 10.1 support

2024-05-29 Thread Christian König
Am 02.05.24 um 23:41 schrieb Alex Deucher: It was an enablement vehicle for MES 11 and was never productized. Remove it. Signed-off-by: Alex Deucher Acked-by: Christian König --- drivers/gpu/drm/amd/amdgpu/Makefile |1 - drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2

[PATCH v1 1/3] drm/amdgpu: add gfx9 register support in ipdump

2024-05-29 Thread Sunil Khatri
Add general registers of gfx9 in ipdump for devcoredump support. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 124 +- 1 file changed, 123 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amd

[PATCH v1 2/3] drm/amdgpu: add print support for gfx9 ipdump

2024-05-29 Thread Sunil Khatri
Add support of gfx9 ipdump print so devcoredump could trigger it to dump the captured registers in devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH v1 3/3] drm/amdgpu: add cp queue registers for gfx9 ipdump

2024-05-29 Thread Sunil Khatri
Add gfx9 support of CP queue registers for all queues to be used by devcoredump. Signed-off-by: Sunil Khatri --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 110 +- 1 file changed, 108 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/driver

[PATCH v1 0/3] gfx9 ipdump patches

2024-05-29 Thread Sunil Khatri
gfx9 ipdump patches Sunil Khatri (3): drm/amdgpu: add gfx9 register support in ipdump drm/amdgpu: add print support for gfx9 ipdump drm/amdgpu: add cp queue registers for gfx9 ipdump drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 248 +- 1 file changed, 246 insertions(+),

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-29 Thread Vignesh Raman
Hi Dmitry, On 29/05/24 13:30, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 08:10:49AM +0530, Vignesh Raman wrote: Now the testlist is used from IGT build, so update xfails with the new testlist. Set the timeout of all i915 jobs to 1h30m since some jobs takes more than 1 hour to complete. R

Re: [PATCH v3 4/6] drm/ci: uprev IGT

2024-05-29 Thread Vignesh Raman
Hi Dmitry, On 29/05/24 13:39, Dmitry Baryshkov wrote: On Wed, May 29, 2024 at 08:10:47AM +0530, Vignesh Raman wrote: test-list.txt and test-list-full.txt are not generated for cross-builds and they are required by drm-ci for testing arm32 targets. This is fixed in igt-gpu-tools. So uprev IGT to

Re: [PATCH 01/14] drm/amdgpu: add nbio set_reg_remap helper

2024-05-29 Thread Christian König
Acked-by: Christian König for the whole series. Am 06.05.24 um 20:45 schrieb Alex Deucher: Will be used to consolidate reg remap settings and fix HDP flushes on systems with non-4K pages. Reviewed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_nbio.h

Re: (subset) [PATCH v4 0/3] drm/panel: two fixes for lg-sw43408

2024-05-29 Thread Dmitry Baryshkov
On Tue, 28 May 2024 22:39:17 +0300, Dmitry Baryshkov wrote: > Fix two issues with the panel-lg-sw43408 driver reported by the kernel > test robot. > > Applied to drm-misc-fixes, thanks! [1/3] drm/panel/lg-sw43408: select CONFIG_DRM_DISPLAY_DP_HELPER commit: 33defcacd207196a6b35857087e6335

[PATCH] drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

2024-05-29 Thread Bob Zhou
Check return value and conduct null pointer handling to avoid null pointer dereference. Signed-off-by: Bob Zhou --- .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 38 +++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega1

Re: [PATCH v3 4/6] drm/ci: uprev IGT

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:47AM +0530, Vignesh Raman wrote: > test-list.txt and test-list-full.txt are not generated for > cross-builds and they are required by drm-ci for testing > arm32 targets. This is fixed in igt-gpu-tools. So uprev > IGT to include the commit which fixes this issue. Also >

Re: [PATCH v3 6/6] drm/ci: update xfails for the new testlist

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:49AM +0530, Vignesh Raman wrote: > Now the testlist is used from IGT build, so update > xfails with the new testlist. > > Set the timeout of all i915 jobs to 1h30m since some jobs > takes more than 1 hour to complete. > > Reviewed-by: Dmitry Baryshkov This had an e

Re: [PATCH v3 3/6] drm/ci: generate testlist from build

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:46AM +0530, Vignesh Raman wrote: > Stop vendoring the testlist into the kernel. Instead, use the > testlist from the IGT build to ensure we do not miss renamed > or newly added tests. > > Signed-off-by: Vignesh Raman > --- > > v2: > - Fix testlist generation for a

Re: [PATCH v3 2/6] drm/ci: add farm variable

2024-05-29 Thread Dmitry Baryshkov
On Wed, May 29, 2024 at 08:10:45AM +0530, Vignesh Raman wrote: > Mesa uses structured logs for logging and debug purpose, > https://mesa.pages.freedesktop.org/-/mesa/-/jobs/59165650/artifacts/results/job_detail.json > > Since drm-ci uses the mesa scripts, add the farm variable > and update the dev

Re: [bug report] drm/amdgpu: amdgpu crash on playing videos, linux 6.10-rc

2024-05-29 Thread Christian König
Hi, when the issue is easy to reproduce I suggest to bisect the changes between 6.9 and 6.10-rc1. On the other hand it's not unlikely that we have a known bug in -rc1 which will be fixed by -rc2. Anyway added Leo to the mail thread since he is the one responsible for the video decoding eng