RE: [PATCH] drm/amdgpu: trigger flr_work if reading pf2vf data failed

2024-03-16 Thread Skvortsov, Victor
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Lazar, > Lijo > Sent: Friday, March 15, 2024 6:47 AM > To: Luo, Zhigang ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Saye, Sashank > ; Chan, Hing Pong > Subject: Re: [PATCH] drm/amdgpu: trigger

[PATCH] drm/amdgpu: Fix truncation issues in smu_v13_0_init_microcode

2024-03-16 Thread Srinivasan Shanmugam
Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0.c: In function ‘smu_v13_0_init_microcode’: drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu13/smu_v13_0.c:108:52: warning: ‘%s’ directive output may be truncated writing up to 29 bytes into a region of size 23 [-Wform

[PATCH] drm/amd/display: delete unnecessary check in dcn35_set_long_vblank()

2024-03-16 Thread Dan Carpenter
"timing" is "&pipe_ctx[i]->stream->timing" where ->timing is not the first struct member of ->stream. So it's the address which points into the middle of a struct. It can't be NULL so delete the NULL check. Signed-off-by: Dan Carpenter --- drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.

Re: [bug report] drm/amdgpu: add ring buffer information in devcoredump

2024-03-16 Thread Dan Carpenter
The static checker is just complaining about NULL checking that doesn't make sense. It raises the question, can the pointer be NULL or not? Based on your comments and from reviewing the code, I do not think it can be NULL. Thus the correct thing is to remove the unnecessary NULL check. regards,

Re: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode

2024-03-16 Thread kernel test robot
md-display-Introduce-overlay-cursor-mode/20240316-011404 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20240315170959.165505-2-sunpeng.li%40amd.com patch subject: [PATCH 1/2] drm/amd/display: Introduce overlay cursor mode config: loongarch-defconf